René's URL Explorer Experiment


Title: Modified reserved word field names included in field masks. · Issue #227 · googleapis/python-api-core · GitHub

Open Graph Title: Modified reserved word field names included in field masks. · Issue #227 · googleapis/python-api-core

X Title: Modified reserved word field names included in field masks. · Issue #227 · googleapis/python-api-core

Description: I'm not sure whether this is an issue with this library, the generator or the field mask helper, but it seems to be incorrect behavior that's blocking for Ads users, unless there's a workaround or other solution I'm not aware of: Environ...

Open Graph Description: I'm not sure whether this is an issue with this library, the generator or the field mask helper, but it seems to be incorrect behavior that's blocking for Ads users, unless there's a workaround or ...

X Description: I'm not sure whether this is an issue with this library, the generator or the field mask helper, but it seems to be incorrect behavior that's blocking for Ads users, unless there's a wo...

Opengraph URL: https://github.com/googleapis/python-api-core/issues/227

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Modified reserved word field names included in field masks.","articleBody":"I'm not sure whether this is an issue with this library, the [`generator`](https://github.com/googleapis/gapic-generator-python) or the [`field mask helper`](https://github.com/googleapis/python-api-core/blob/master/google/api_core/protobuf_helpers.py#L290), but it seems to be incorrect behavior that's blocking for Ads users, unless there's a workaround or other solution I'm not aware of:\r\n\r\n#### Environment details\r\n\r\n  - Programming language: `Python`\r\n  - OS: `gLinux`\r\n  - Language runtime version: `3.7.0`\r\n  - Package version: `1.18.1`\r\n\r\n#### Steps to reproduce\r\n\r\nAssuming we have a protobuf definition like the following:\r\n\r\n```\r\nmessage HasType {\r\n  string type = 1;\r\n}\r\n```\r\n\r\nWe'll have a generated Python class similar to:\r\n\r\n```py\r\nclass HasType(proto.Message):\r\n    type_ = proto.Field(proto.STRING, number=1,)\r\n```\r\n\r\nWhere `type` has been modified to `type_`. \r\n\r\nNormally setting `type_` isn't a problem, the issue is that this modified field name gets leaked into field masks, which are revoked by the API because it doesn't match the protobuf definition. This prevents users from executing update requests where the `type` field on any object has been modified. \r\n\r\nHere's a short script to reproduce:\r\n\r\n```py\r\nfrom google.api_core import protobuf_helpers\r\nimport proto\r\n\r\nclass HasType(proto.Message):\r\n    type_ = proto.Field(proto.STRING, number=1,)\r\n\r\nht = HasType()\r\nht.type_ = \"has type\"\r\n\r\nfm = protobuf_helpers.field_mask(None, ht._pb)\r\n\r\nprint(fm.paths[0])\r\n# \u003e\u003e\u003e \"type_\"\r\n```\r\n","author":{"url":"https://github.com/BenRKarl","@type":"Person","name":"BenRKarl"},"datePublished":"2021-06-29T17:10:14.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/227/python-api-core/issues/227"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:fe4cf007-7e43-67b2-3568-68f35f173d43
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9E74:622FF:9B2867:DF7DD3:6A4E41F0
html-safe-nonced8aa007df180558c3500174443ca9d642092303728ff15bb6aecf5b745bf0973
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTc0OjYyMkZGOjlCMjg2NzpERjdERDM6NkE0RTQxRjAiLCJ2aXNpdG9yX2lkIjoiMzk5OTk4NDA5NDg3NjE1NjQwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb39ab61c72b5bab5d90dcc69a8663970d840f3ea1a7e936b816cd14fc4f58b3f
hovercard-subject-tagissue:944866748
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-api-core/227/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a62c8d109574afe92f77921e84fb9ed914103ae31991238f4facee3d6c9d371d/googleapis/python-api-core/issues/227
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a62c8d109574afe92f77921e84fb9ed914103ae31991238f4facee3d6c9d371d/googleapis/python-api-core/issues/227
og:image:altI'm not sure whether this is an issue with this library, the generator or the field mask helper, but it seems to be incorrect behavior that's blocking for Ads users, unless there's a workaround or ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBenRKarl
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-preview
go-importgithub.com/googleapis/python-api-core git https://github.com/googleapis/python-api-core.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992456
octolytics-dimension-repository_nwogoogleapis/python-api-core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992456
octolytics-dimension-repository_network_root_nwogoogleapis/python-api-core
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9fabff9b8b127e686a3ec86f91422e818056ca2c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-api-core/issues/227#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fissues%2F227
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fissues%2F227
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=googleapis%2Fpython-api-core
Reloadhttps://github.com/googleapis/python-api-core/issues/227
Reloadhttps://github.com/googleapis/python-api-core/issues/227
Reloadhttps://github.com/googleapis/python-api-core/issues/227
Please reload this pagehttps://github.com/googleapis/python-api-core/issues/227
googleapis https://github.com/googleapis
python-api-corehttps://github.com/googleapis/python-api-core
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Fork 97 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Star 144 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Code https://github.com/googleapis/python-api-core
Issues 0 https://github.com/googleapis/python-api-core/issues
Pull requests 0 https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality 0 https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
Code https://github.com/googleapis/python-api-core
Issues https://github.com/googleapis/python-api-core/issues
Pull requests https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
#228https://github.com/googleapis/python-api-core/pull/228
Modified reserved word field names included in field masks.https://github.com/googleapis/python-api-core/issues/227#top
#228https://github.com/googleapis/python-api-core/pull/228
https://github.com/busunkim96
priority: p2Moderately-important priority. Fix may not be included in next release.https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22priority%3A%20p2%22
type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
https://github.com/BenRKarl
BenRKarlhttps://github.com/BenRKarl
on Jun 29, 2021https://github.com/googleapis/python-api-core/issues/227#issue-944866748
generatorhttps://github.com/googleapis/gapic-generator-python
field mask helperhttps://github.com/googleapis/python-api-core/blob/master/google/api_core/protobuf_helpers.py#L290
busunkim96https://github.com/busunkim96
priority: p2Moderately-important priority. Fix may not be included in next release.https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22priority%3A%20p2%22
type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.