Title: client_options.from_dict should accept other mapping types · Issue #14 · googleapis/python-api-core · GitHub
Open Graph Title: client_options.from_dict should accept other mapping types · Issue #14 · googleapis/python-api-core
X Title: client_options.from_dict should accept other mapping types · Issue #14 · googleapis/python-api-core
Description: Raised by @plamut in googleapis/google-api-python-client#829. Is there a reason for accepting dicts only? Someone might prefer having the options stored in a different dict flavor, e.g. defaultdict, and accepting mappings in general woul...
Open Graph Description: Raised by @plamut in googleapis/google-api-python-client#829. Is there a reason for accepting dicts only? Someone might prefer having the options stored in a different dict flavor, e.g. defaultdict...
X Description: Raised by @plamut in googleapis/google-api-python-client#829. Is there a reason for accepting dicts only? Someone might prefer having the options stored in a different dict flavor, e.g. defaultdict...
Opengraph URL: https://github.com/googleapis/python-api-core/issues/14
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"client_options.from_dict should accept other mapping types","articleBody":"Raised by @plamut in https://github.com/googleapis/google-api-python-client/pull/829/.\r\n\r\n\u003e Is there a reason for accepting dicts only? Someone might prefer having the options stored in a different dict flavor, e.g. defaultdict, and accepting mappings in general would represent a usability improvement to them.\r\n\r\nDocumentation in this library needs to be updated. See https://googleapis.dev/python/google-api-core/latest/client_options.html \r\n\r\nClients should also be updated to accept mapping types:\r\n```\r\n if isinstance(client_options, six.moves.collections_abc.Mapping):\r\n```\r\n\r\ninstead of\r\n\r\n```\r\nif type(client_options) == dict:\r\n```","author":{"url":"https://github.com/busunkim96","@type":"Person","name":"busunkim96"},"datePublished":"2020-03-11T21:24:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/14/python-api-core/issues/14"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d501ea95-34a4-48bf-c7fe-e0bdd91a6083 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BAC0:8A2B5:314BA8F:4508AC4:6A4F7CE6 |
| html-safe-nonce | 16c277a0b0e78679a0d506397533944731f8883b2b342158db005ae394136205 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUMwOjhBMkI1OjMxNEJBOEY6NDUwOEFDNDo2QTRGN0NFNiIsInZpc2l0b3JfaWQiOiI2ODMyMjA0MzQwNDExNDI1MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 887876761715a57fb971f39871fa97a4b328e043dafe386c3eec24c7c8c42477 |
| hovercard-subject-tag | issue:579554081 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-api-core/14/issue_layout |
| twitter:image | https://opengraph.githubassets.com/eebc88497101691f8424d9aeb5799bdedd08194d15dc2af1358d8a232b339292/googleapis/python-api-core/issues/14 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/eebc88497101691f8424d9aeb5799bdedd08194d15dc2af1358d8a232b339292/googleapis/python-api-core/issues/14 |
| og:image:alt | Raised by @plamut in googleapis/google-api-python-client#829. Is there a reason for accepting dicts only? Someone might prefer having the options stored in a different dict flavor, e.g. defaultdict... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | busunkim96 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/python-api-core git https://github.com/googleapis/python-api-core.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 226992456 |
| octolytics-dimension-repository_nwo | googleapis/python-api-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 226992456 |
| octolytics-dimension-repository_network_root_nwo | googleapis/python-api-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width