Title: Cloud Pub/Sub API ignores FlowControlSettings in BatchingSettings · Issue #25 · googleapis/java-pubsub · GitHub
Open Graph Title: Cloud Pub/Sub API ignores FlowControlSettings in BatchingSettings · Issue #25 · googleapis/java-pubsub
X Title: Cloud Pub/Sub API ignores FlowControlSettings in BatchingSettings · Issue #25 · googleapis/java-pubsub
Description: Gax has introduced FlowControl settings in [1] (see setFlowControlSettings). This makes it seem like Flow Control is available in the APIs that support BatchSettings, such as Pub/Sub's Publisher [2]. There are two issues here: FlowContro...
Open Graph Description: Gax has introduced FlowControl settings in [1] (see setFlowControlSettings). This makes it seem like Flow Control is available in the APIs that support BatchSettings, such as Pub/Sub's Publisher [2...
X Description: Gax has introduced FlowControl settings in [1] (see setFlowControlSettings). This makes it seem like Flow Control is available in the APIs that support BatchSettings, such as Pub/Sub's Publishe...
Opengraph URL: https://github.com/googleapis/java-pubsub/issues/25
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Cloud Pub/Sub API ignores FlowControlSettings in BatchingSettings","articleBody":"Gax has introduced FlowControl settings in [1] (see setFlowControlSettings). This makes it seem like Flow Control is available in the APIs that support BatchSettings, such as Pub/Sub's Publisher [2]. There are two issues here:\r\n1. FlowControlSettings settings in GAX have no way of communicating to the user whether a particular client implements them. This is actually true of all batching settings. This is a recipe for confusion. \r\n2. In the particular case of Pub/Sub client, publisher flow control is a desirable feature in itself. We either need to decide to implement it and turn this bug into a feature request and offer explicit failure and documentation if we decided not to.\r\n\r\n\r\n[1] http://googleapis.github.io/gax-java/1.4.1/apidocs/com/google/api/gax/batching/BatchingSettings.Builder.html#setFlowControlSettings-com.google.api.gax.batching.FlowControlSettings-\r\n[2] https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java#L124\r\nThanks for stopping by to let us know something could be better!\r\n\r\n\r\n\r\n**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response.\r\n\r\nPlease run down the following list and make sure you've tried the usual \"quick fixes\":\r\n\r\n - Search the issues already opened: https://github.com/googleapis/google-cloud-java/issues\r\n - Check for answers on StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform\r\n\r\nIf you are still having issues, please be sure to include as much information as possible:\r\n\r\n#### Environment details\r\n\r\n1. Specify the API at the beginning of the title (for example, \"BigQuery: ...\")\r\n General, Core, and Other are also allowed as types\r\n2. OS type and version:\r\n3. Java version:\r\n4. google-cloud-java version(s):\r\n\r\n#### Steps to reproduce\r\n\r\n 1. ?\r\n 2. ? \r\n\r\n#### Code example\r\n\r\n```java\r\n// example\r\n```\r\n\r\n#### Stack trace\r\n```\r\nAny relevant stacktrace here.\r\n```\r\n\r\n#### External references such as API reference guides used\t\r\n\r\n- ?\t\r\n\r\n#### Any additional information below\t\r\n\r\n\r\nMaking sure to follow these steps will guarantee the quickest resolution possible.\r\n\r\nThanks!\r\n","author":{"url":"https://github.com/kir-titievsky","@type":"Person","name":"kir-titievsky"},"datePublished":"2019-08-29T18:23:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/25/java-pubsub/issues/25"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:aaa4bf6a-998c-4763-6009-f8f0d87f8b48 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C1F6:3D21AE:117BD22:17B94F6:6A4D6854 |
| html-safe-nonce | b1347727719d1a384375ba37efba921d50b1f57e867fdd48e67b4360d5cc75a5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUY2OjNEMjFBRToxMTdCRDIyOjE3Qjk0RjY6NkE0RDY4NTQiLCJ2aXNpdG9yX2lkIjoiMzQ5ODgxNTU3OTU2MDQzNzg0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | db9f95c067a3f1dcd44ec9f8c2f2734be9184e8b4cc31c0d1c16f363077728d1 |
| hovercard-subject-tag | issue:532899523 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/java-pubsub/25/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a11e3ed334ffd379c4e38edcc5e79fa977bbdf281ebf0a8cfa01a7ede6b19e7d/googleapis/java-pubsub/issues/25 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a11e3ed334ffd379c4e38edcc5e79fa977bbdf281ebf0a8cfa01a7ede6b19e7d/googleapis/java-pubsub/issues/25 |
| og:image:alt | Gax has introduced FlowControl settings in [1] (see setFlowControlSettings). This makes it seem like Flow Control is available in the APIs that support BatchSettings, such as Pub/Sub's Publisher [2... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kir-titievsky |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7db3950e3f59095e20a9789440c3dd554efc62d434882ead06ae05b5815605b9 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/java-pubsub git https://github.com/googleapis/java-pubsub.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 203461480 |
| octolytics-dimension-repository_nwo | googleapis/java-pubsub |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 203461480 |
| octolytics-dimension-repository_network_root_nwo | googleapis/java-pubsub |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cd8f6a71db61d6012a0cbb134be844fdbe9b8a45 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width