René's URL Explorer Experiment


Title: fix(pubsub): include request overhead when computing publish batch size overflow by plamut · Pull Request #9911 · googleapis/google-cloud-python · GitHub

Open Graph Title: fix(pubsub): include request overhead when computing publish batch size overflow by plamut · Pull Request #9911 · googleapis/google-cloud-python

X Title: fix(pubsub): include request overhead when computing publish batch size overflow by plamut · Pull Request #9911 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: Fixes #7108. This PR fixes the logic that computes the publish batch size overflow, taking the total request message size overhead into account. The improved logic prevents the server-side errors s...

X Description: Fixes #7108. This PR fixes the logic that computes the publish batch size overflow, taking the total request message size overhead into account. The improved logic prevents the server-side errors s...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/9911

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:72fa0608-4ecb-2548-9582-f091f6def592
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9710:3F3AF6:25E1C98:33A7836:6A504236
html-safe-nonce50da7f6ece06c4fbbe9fe61e61115e71f80e4d76abd840f01bc9c545b71a22da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzEwOjNGM0FGNjoyNUUxQzk4OjMzQTc4MzY6NkE1MDQyMzYiLCJ2aXNpdG9yX2lkIjoiMzkwMzIwMzYyNTQwNTUzMDY3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6591b23fe654b05aa2e335b2393cd19410841e9dd13e9f3e870ec7cb5d047f7a
hovercard-subject-tagpull_request:348588737
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/9911/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a3200ed728a8327db9fe2267dddcf205482bd45b4b957704a28150ad11bafe79/googleapis/google-cloud-python/pull/9911
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a3200ed728a8327db9fe2267dddcf205482bd45b4b957704a28150ad11bafe79/googleapis/google-cloud-python/pull/9911
og:image:altFixes #7108. This PR fixes the logic that computes the publish batch size overflow, taking the total request message size overhead into account. The improved logic prevents the server-side errors s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameplamut
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released90666eaf032b7eb8975a378efe38e37f4ebb96c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/9911#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9911
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9911
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9911
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9911
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9911
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 444 https://github.com/googleapis/google-cloud-python/issues
Pull requests 136 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
plamuthttps://github.com/plamut
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
plamut:iss-7108https://github.com/plamut/google-cloud-python/tree/iss-7108
Conversationhttps://github.com/googleapis/google-cloud-python/pull/9911
Commits5 (5)https://github.com/googleapis/google-cloud-python/pull/9911/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/9911/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/9911/files
fix(pubsub): include request overhead when computing publish batch size overflowhttps://github.com/googleapis/google-cloud-python/pull/9911#top
plamuthttps://github.com/plamut
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
plamut:iss-7108https://github.com/plamut/google-cloud-python/tree/iss-7108
https://github.com/plamut
plamuthttps://github.com/plamut
Dec 3, 2019https://github.com/googleapis/google-cloud-python/pull/9911#issue-532313265
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
#7108https://github.com/googleapis/google-cloud-python/issues/7108
bug/issuehttps://github.com/googleapis/google-cloud-python/issues
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
plamuthttps://github.com/plamut
December 3, 2019 11:15https://github.com/googleapis/google-cloud-python/pull/9911#commits-pushed-550b0c6
https://github.com/plamut
Clarify the description of BatchSettings.max_byteshttps://github.com/googleapis/google-cloud-python/pull/9911/commits/550b0c60e9a04a2dee860f44472826378d136b87
550b0c6https://github.com/googleapis/google-cloud-python/pull/9911/commits/550b0c60e9a04a2dee860f44472826378d136b87
https://github.com/plamut
Include overhead in batch overflow calculationhttps://github.com/googleapis/google-cloud-python/pull/9911/commits/20001935c78671cc6eabaca7c355343c2e99d6d7
2000193https://github.com/googleapis/google-cloud-python/pull/9911/commits/20001935c78671cc6eabaca7c355343c2e99d6d7
@reludhttps://github.com/relud
https://github.com/plamut
plamuthttps://github.com/plamut
api: pubsub https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
Dec 3, 2019https://github.com/googleapis/google-cloud-python/pull/9911#event-2851919181
https://github.com/plamut
plamuthttps://github.com/plamut
pradnhttps://github.com/pradn
December 3, 2019 22:35https://github.com/googleapis/google-cloud-python/pull/9911#event-2851919185
https://github.com/plamut
plamuthttps://github.com/plamut
anguillanneufhttps://github.com/anguillanneuf
code ownerhttps://github.com/googleapis/google-cloud-python/blob/38d8f2b8bdbfdb27dc84b4f3d4ed4998d4cf52e5/.github/CODEOWNERS#L45
December 3, 2019 22:35https://github.com/googleapis/google-cloud-python/pull/9911#event-2851919189
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 3, 2019https://github.com/googleapis/google-cloud-python/pull/9911#event-2851919420
https://github.com/software-dov
software-dovhttps://github.com/software-dov
Dec 3, 2019 https://github.com/googleapis/google-cloud-python/pull/9911#pullrequestreview-326497666
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9911/files/20001935c78671cc6eabaca7c355343c2e99d6d7
pubsub/google/cloud/pubsub_v1/publisher/_batch/thread.pyhttps://github.com/googleapis/google-cloud-python/pull/9911/files/20001935c78671cc6eabaca7c355343c2e99d6d7#diff-c53fd9034c37005c33a50371364c6b0a69fcb240e34a842f170d8b554755c6ba
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
https://github.com/plamut
Access settings inside Batch in a consistent way.https://github.com/googleapis/google-cloud-python/pull/9911/commits/843a10abcfe7a7c39900deedc1900faafe1078e5
843a10ahttps://github.com/googleapis/google-cloud-python/pull/9911/commits/843a10abcfe7a7c39900deedc1900faafe1078e5
https://github.com/software-dov
software-dovhttps://github.com/software-dov
Dec 3, 2019 https://github.com/googleapis/google-cloud-python/pull/9911#pullrequestreview-326499009
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9911/files/20001935c78671cc6eabaca7c355343c2e99d6d7
pubsub/tests/system.pyhttps://github.com/googleapis/google-cloud-python/pull/9911/files/20001935c78671cc6eabaca7c355343c2e99d6d7#diff-883c08da996624b35f0bb3ba108f8745a3b9caa97bcc28b4ab91f1d9009a6c4b
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
pubsub/tests/unit/pubsub_v1/publisher/batch/test_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/9911/files/20001935c78671cc6eabaca7c355343c2e99d6d7#diff-0684fc98d538990f173a3618d05ccb73ea91dbeab4143d59bcb182374787fb64
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
pubsub/tests/unit/pubsub_v1/publisher/batch/test_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/9911/files/20001935c78671cc6eabaca7c355343c2e99d6d7#diff-0684fc98d538990f173a3618d05ccb73ea91dbeab4143d59bcb182374787fb64
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
pubsub/google/cloud/pubsub_v1/publisher/_batch/thread.pyhttps://github.com/googleapis/google-cloud-python/pull/9911/files/20001935c78671cc6eabaca7c355343c2e99d6d7#diff-c53fd9034c37005c33a50371364c6b0a69fcb240e34a842f170d8b554755c6ba
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
pubsub/tests/unit/pubsub_v1/publisher/batch/test_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/9911/files/20001935c78671cc6eabaca7c355343c2e99d6d7#diff-0684fc98d538990f173a3618d05ccb73ea91dbeab4143d59bcb182374787fb64
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
pubsub/tests/unit/pubsub_v1/publisher/batch/test_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/9911/files/20001935c78671cc6eabaca7c355343c2e99d6d7#diff-0684fc98d538990f173a3618d05ccb73ea91dbeab4143d59bcb182374787fb64
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
https://github.com/plamut
Cleanup and refactor a few code snippetshttps://github.com/googleapis/google-cloud-python/pull/9911/commits/289935ebb011904038c0a109b954ec8fbb3b5795
289935ehttps://github.com/googleapis/google-cloud-python/pull/9911/commits/289935ebb011904038c0a109b954ec8fbb3b5795
https://github.com/plamut
plamuthttps://github.com/plamut
software-dovhttps://github.com/software-dov
December 4, 2019 08:56https://github.com/googleapis/google-cloud-python/pull/9911#event-2853135749
https://github.com/software-dov
software-dovhttps://github.com/software-dov
Dec 4, 2019 https://github.com/googleapis/google-cloud-python/pull/9911#pullrequestreview-327223457
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9911/files/289935ebb011904038c0a109b954ec8fbb3b5795
software-dovhttps://github.com/software-dov
https://github.com/googleapis/google-cloud-python/pull/9911#pullrequestreview-327223457
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
https://github.com/plamut
Raise more specific error if message too largehttps://github.com/googleapis/google-cloud-python/pull/9911/commits/d4509ec8e96d7c233d27b4e96751758350811ed4
d4509echttps://github.com/googleapis/google-cloud-python/pull/9911/commits/d4509ec8e96d7c233d27b4e96751758350811ed4
https://github.com/plamut
plamuthttps://github.com/plamut
Dec 4, 2019https://github.com/googleapis/google-cloud-python/pull/9911#issuecomment-561897781
@software-dovhttps://github.com/software-dov
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
https://github.com/plamut
plamuthttps://github.com/plamut
software-dovhttps://github.com/software-dov
December 4, 2019 23:51https://github.com/googleapis/google-cloud-python/pull/9911#event-2855973773
https://github.com/software-dov
software-dovhttps://github.com/software-dov
Dec 4, 2019 https://github.com/googleapis/google-cloud-python/pull/9911#pullrequestreview-327232981
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9911/files/d4509ec8e96d7c233d27b4e96751758350811ed4
software-dovhttps://github.com/software-dov
https://github.com/googleapis/google-cloud-python/pull/9911#pullrequestreview-327232981
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
https://github.com/plamut
plamuthttps://github.com/plamut
0699ba6https://github.com/googleapis/google-cloud-python/commit/0699ba616f26199db1a0828e0285012c97b7a96c
Dec 5, 2019https://github.com/googleapis/google-cloud-python/pull/9911#event-2856723808
https://github.com/plamut
plamuthttps://github.com/plamut
December 5, 2019 07:05https://github.com/googleapis/google-cloud-python/pull/9911#event-2856723984
chore(bigquery): bump copyright year to 2020, tweak docstring formatting (via synth) #10225 https://github.com/googleapis/google-cloud-python/pull/10225
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator. #10256 https://github.com/googleapis/google-cloud-python/pull/10256
[CHANGE ME] Re-generated datastore to pick up changes in the API or client library generator. #10261 https://github.com/googleapis/google-cloud-python/pull/10261
partheahttps://github.com/parthea
Mar 2, 2026 https://github.com/googleapis/google-cloud-python/pull/9911#ref-commit-806fdd1
https://github.com/plamut
fix(pubsub): include request overhead when computing publish batch si…https://github.com/googleapis/google-cloud-python/commit/806fdd13d076dbf70293ce96eb117079663219af
806fdd1https://github.com/googleapis/google-cloud-python/commit/806fdd13d076dbf70293ce96eb117079663219af
#9911https://github.com/googleapis/google-cloud-python/pull/9911
@reludhttps://github.com/relud
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9911
https://github.com/pradn
pradn https://github.com/pradn
https://github.com/anguillanneuf
anguillanneuf https://github.com/anguillanneuf
https://github.com/software-dov
software-dov https://github.com/software-dov
https://github.com/googleapis/google-cloud-python/pull/9911/files/d4509ec8e96d7c233d27b4e96751758350811ed4
api: pubsub https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
PubSub: check batch max bytes against request byte size https://github.com/googleapis/google-cloud-python/issues/7108
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9911
https://github.com/plamut
https://github.com/software-dov
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.