| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cf4ccb06-b503-4ee0-6009-8805ba7c7119 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8EBA:25305:B68EE9:105E279:6A4E4835 |
| html-safe-nonce | be1078c74a6383d95cc4f9a370f1c9d8bf978d7c6e7d60ab897a45c1369ef6b0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUJBOjI1MzA1OkI2OEVFOToxMDVFMjc5OjZBNEU0ODM1IiwidmlzaXRvcl9pZCI6IjE0NTEzNzcwNDQzMjc2NDcyODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 22934e10756d8a084a04c2b8d2936d7339ea09f834ab6b6d1b0a3e5ce41436c1 |
| hovercard-subject-tag | pull_request:345979421 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/9894/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/776d91f1d20614848ed47a5c530527cd14d39bfd079a6dea068eba4ce882af82/googleapis/google-cloud-python/pull/9894 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/776d91f1d20614848ed47a5c530527cd14d39bfd079a6dea068eba4ce882af82/googleapis/google-cloud-python/pull/9894 |
| og:image:alt | Fixes #9790.
This PR fixes the client leaking open sockets by adding a close() method to the client for cleaning up after itself. It also fixes a similar leak in IPython magics - even if bqstorage ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | plamut |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 16316451 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16316451 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e8506f6d0538364886e3f0153c154c410965e70d |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/googleapis/google-cloud-python/pull/9894#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9894 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9894 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python |
| Reload | https://github.com/googleapis/google-cloud-python/pull/9894 |
| Reload | https://github.com/googleapis/google-cloud-python/pull/9894 |
| Reload | https://github.com/googleapis/google-cloud-python/pull/9894 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
|
googleapis
| https://github.com/googleapis |
| google-cloud-python | https://github.com/googleapis/google-cloud-python |
|
Notifications
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python |
|
Fork
1.7k
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python |
|
Star
5.3k
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python |
|
Code
| https://github.com/googleapis/google-cloud-python |
|
Issues
439
| https://github.com/googleapis/google-cloud-python/issues |
|
Pull requests
138
| https://github.com/googleapis/google-cloud-python/pulls |
|
Discussions
| https://github.com/googleapis/google-cloud-python/discussions |
|
Actions
| https://github.com/googleapis/google-cloud-python/actions |
|
Projects
| https://github.com/googleapis/google-cloud-python/projects |
|
Security and quality
0
| https://github.com/googleapis/google-cloud-python/security |
|
Insights
| https://github.com/googleapis/google-cloud-python/pulse |
|
Code
| https://github.com/googleapis/google-cloud-python |
|
Issues
| https://github.com/googleapis/google-cloud-python/issues |
|
Pull requests
| https://github.com/googleapis/google-cloud-python/pulls |
|
Discussions
| https://github.com/googleapis/google-cloud-python/discussions |
|
Actions
| https://github.com/googleapis/google-cloud-python/actions |
|
Projects
| https://github.com/googleapis/google-cloud-python/projects |
|
Security and quality
| https://github.com/googleapis/google-cloud-python/security |
|
Insights
| https://github.com/googleapis/google-cloud-python/pulse |
| tswast | https://github.com/tswast |
| googleapis:master | https://github.com/googleapis/google-cloud-python/tree/master |
| plamut:iss-9790 | https://github.com/plamut/google-cloud-python/tree/iss-9790 |
| Conversation | https://github.com/googleapis/google-cloud-python/pull/9894 |
| Commits5 (5) | https://github.com/googleapis/google-cloud-python/pull/9894/commits |
| Checks | https://github.com/googleapis/google-cloud-python/pull/9894/checks |
| Files changed | https://github.com/googleapis/google-cloud-python/pull/9894/files |
| fix(bigquery): add close() method to client for releasing open sockets | https://github.com/googleapis/google-cloud-python/pull/9894#top |
| tswast | https://github.com/tswast |
| googleapis:master | https://github.com/googleapis/google-cloud-python/tree/master |
| plamut:iss-9790 | https://github.com/plamut/google-cloud-python/tree/iss-9790 |
|
| https://github.com/plamut |
| plamut | https://github.com/plamut |
| Nov 26, 2019 | https://github.com/googleapis/google-cloud-python/pull/9894#issue-529025395 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
| #9790 | https://github.com/googleapis/google-cloud-python/issues/9790 |
| bug/issue | https://github.com/googleapis/google-cloud-python/issues |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
| plamut | https://github.com/plamut |
| November 26, 2019 21:38 | https://github.com/googleapis/google-cloud-python/pull/9894#commits-pushed-a4c271f |
|
| https://github.com/plamut |
| Add psutil as an extra test dependency | https://github.com/googleapis/google-cloud-python/pull/9894/commits/a4c271f263dc41e0fb4aa5fb90f554bdc6d5cd5c |
| a4c271f | https://github.com/googleapis/google-cloud-python/pull/9894/commits/a4c271f263dc41e0fb4aa5fb90f554bdc6d5cd5c |
|
| https://github.com/plamut |
| Add close() method to Client | https://github.com/googleapis/google-cloud-python/pull/9894/commits/d27618c70ef6ed18a3e51033bf037ef4c36f6bf2 |
| d27618c | https://github.com/googleapis/google-cloud-python/pull/9894/commits/d27618c70ef6ed18a3e51033bf037ef4c36f6bf2 |
|
| https://github.com/plamut |
| Fix open sockets leak in IPython magics | https://github.com/googleapis/google-cloud-python/pull/9894/commits/ae63a4fd4929880daf92c3e09bcdc51ea91b171e |
| ae63a4f | https://github.com/googleapis/google-cloud-python/pull/9894/commits/ae63a4fd4929880daf92c3e09bcdc51ea91b171e |
| https://github.com/plamut |
| plamut | https://github.com/plamut |
|
api: bigquery
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20bigquery%22 |
| Nov 26, 2019 | https://github.com/googleapis/google-cloud-python/pull/9894#event-2833787008 |
| https://github.com/plamut |
| plamut | https://github.com/plamut |
| tswast | https://github.com/tswast |
| November 26, 2019 23:22 | https://github.com/googleapis/google-cloud-python/pull/9894#event-2833787017 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Nov 26, 2019 | https://github.com/googleapis/google-cloud-python/pull/9894#event-2833787151 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Nov 27, 2019
| https://github.com/googleapis/google-cloud-python/pull/9894#pullrequestreview-323362129 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/9894/files/ae63a4fd4929880daf92c3e09bcdc51ea91b171e |
| tswast | https://github.com/tswast |
| https://github.com/googleapis/google-cloud-python/pull/9894#pullrequestreview-323362129 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
| bigquery/google/cloud/bigquery/magics.py | https://github.com/googleapis/google-cloud-python/pull/9894/files/ae63a4fd4929880daf92c3e09bcdc51ea91b171e#diff-41efeb2e5ae176043828217206c5ef0c115ff9d77b6917083816dc3440881dc8 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
| bigquery/setup.py | https://github.com/googleapis/google-cloud-python/pull/9894/files/ae63a4fd4929880daf92c3e09bcdc51ea91b171e#diff-dd1adf60dfafa0b5df028f631e13cfdce438d5ab7cbe50e5665cb3b90461b7b4 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
| plamut | https://github.com/plamut |
| November 27, 2019 13:29 | https://github.com/googleapis/google-cloud-python/pull/9894#commits-pushed-827a4cf |
|
| https://github.com/plamut |
| Move psutil test dependency to noxfile | https://github.com/googleapis/google-cloud-python/pull/9894/commits/827a4cf260818e0b0faf0b69f5aeca0036fcfc39 |
| 827a4cf | https://github.com/googleapis/google-cloud-python/pull/9894/commits/827a4cf260818e0b0faf0b69f5aeca0036fcfc39 |
|
| https://github.com/plamut |
| Wrap entire cell magic into try-finally block | https://github.com/googleapis/google-cloud-python/pull/9894/commits/7dff06f221f74c44694298b859409c41f1bb3ff2 |
| 7dff06f | https://github.com/googleapis/google-cloud-python/pull/9894/commits/7dff06f221f74c44694298b859409c41f1bb3ff2 |
| https://github.com/plamut |
| plamut | https://github.com/plamut |
|
Nov 27, 2019
| https://github.com/googleapis/google-cloud-python/pull/9894#pullrequestreview-323659409 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/9894/files/7dff06f221f74c44694298b859409c41f1bb3ff2 |
| bigquery/noxfile.py | https://github.com/googleapis/google-cloud-python/pull/9894/files/7dff06f221f74c44694298b859409c41f1bb3ff2#diff-08788e38d69ad0190bcdcd9ab7177e56bc04d685a37a9f3d38e7f0f3f8504580 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
| https://github.com/plamut |
| plamut | https://github.com/plamut |
| tswast | https://github.com/tswast |
| November 27, 2019 13:36 | https://github.com/googleapis/google-cloud-python/pull/9894#event-2835663599 |
| https://github.com/plamut |
| plamut | https://github.com/plamut |
| Nov 27, 2019 | https://github.com/googleapis/google-cloud-python/pull/9894#issuecomment-559259581 |
| @tswast | https://github.com/tswast |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Nov 27, 2019
| https://github.com/googleapis/google-cloud-python/pull/9894#pullrequestreview-323962858 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/9894/files/7dff06f221f74c44694298b859409c41f1bb3ff2 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
| Nov 27, 2019 | https://github.com/googleapis/google-cloud-python/pull/9894#issuecomment-559263863 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
| 9360057 | https://github.com/googleapis/google-cloud-python/commit/93600571c88d31c94d5080af35541d27b0021443 |
| Nov 27, 2019 | https://github.com/googleapis/google-cloud-python/pull/9894#event-2837112617 |
| https://github.com/plamut |
| plamut | https://github.com/plamut |
| November 27, 2019 22:14 | https://github.com/googleapis/google-cloud-python/pull/9894#event-2837149539 |
|
chore(bigquery): bump copyright year to 2020, tweak docstring formatting (via synth)
#10225
| https://github.com/googleapis/google-cloud-python/pull/10225 |
|
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
| https://github.com/googleapis/google-cloud-python/pull/10256 |
|
[CHANGE ME] Re-generated datastore to pick up changes in the API or client library generator.
#10261
| https://github.com/googleapis/google-cloud-python/pull/10261 |
| https://github.com/busunkim96 |
| busunkim96 | https://github.com/busunkim96 |
|
Mar 24, 2020
| https://github.com/googleapis/google-cloud-python/pull/9894#ref-pullrequest-586610632 |
|
fix: don't use threads for gRPC AuthMetadataPlugin, reverts #390
googleapis/google-auth-library-python#467
| https://github.com/googleapis/google-auth-library-python/pull/467 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Aug 18, 2020
| https://github.com/googleapis/google-cloud-python/pull/9894#ref-issue-681064292 |
|
Feature Request: allow clients to act as context manager and add close() method to cleanup resources
googleapis/gapic-generator-python#575
| https://github.com/googleapis/gapic-generator-python/issues/575 |
| https://github.co/hiddenchars |
| https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9894 |
|
| https://github.com/tswast |
|
tswast
| https://github.com/tswast |
|
| https://github.com/googleapis/google-cloud-python/pull/9894/files/7dff06f221f74c44694298b859409c41f1bb3ff2 |
|
api: bigquery
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20bigquery%22 |
|
cla: yes
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
BigQuery: resource leaks in client and %%bigquery magics
| https://github.com/googleapis/google-cloud-python/issues/9790 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/9894 |
|
| https://github.com/plamut |
|
| https://github.com/tswast |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |