René's URL Explorer Experiment


Title: fix(firestore): simplify 'Collection.add', avoid spurious API call by tseaver · Pull Request #9634 · googleapis/google-cloud-python · GitHub

Open Graph Title: fix(firestore): simplify 'Collection.add', avoid spurious API call by tseaver · Pull Request #9634 · googleapis/google-cloud-python

X Title: fix(firestore): simplify 'Collection.add', avoid spurious API call by tseaver · Pull Request #9634 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: /cc @samtstern Closes #9629

X Description: /cc @samtstern Closes #9629

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/9634

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d75fce07-6f53-943d-c66f-27840bc95f51
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDA2:4C357:18A547B:221BC0F:6A4EBDB4
html-safe-nonce4c3b561b3e26b97b44ec2e66ba30797d3db05495dfed6d0633bb47adf9c32d18
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREEyOjRDMzU3OjE4QTU0N0I6MjIxQkMwRjo2QTRFQkRCNCIsInZpc2l0b3JfaWQiOiI2ODgxMjM3NzQ4NjQ2MzczNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1be0d31f8120422204bd52b47601dcbc54ad9831bde2b2c2b2d528635df29d10
hovercard-subject-tagpull_request:338184429
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/9634/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3f49c41fe5a7e6df9178f0641f993ab281ffb925f08b242e800855d420b4486f/googleapis/google-cloud-python/pull/9634
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3f49c41fe5a7e6df9178f0641f993ab281ffb925f08b242e800855d420b4486f/googleapis/google-cloud-python/pull/9634
og:image:alt/cc @samtstern Closes #9629
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametseaver
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/9634#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9634
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9634
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9634
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9634
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9634
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9634
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 441 https://github.com/googleapis/google-cloud-python/issues
Pull requests 140 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
tseaverhttps://github.com/tseaver
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
Conversationhttps://github.com/googleapis/google-cloud-python/pull/9634
Commits1 (1)https://github.com/googleapis/google-cloud-python/pull/9634/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/9634/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/9634/files
fix(firestore): simplify 'Collection.add', avoid spurious API callhttps://github.com/googleapis/google-cloud-python/pull/9634#top
tseaverhttps://github.com/tseaver
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Nov 7, 2019https://github.com/googleapis/google-cloud-python/pull/9634#issue-519443050
@samtsternhttps://github.com/samtstern
#9629https://github.com/googleapis/google-cloud-python/issues/9629
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9634
https://github.com/tseaver
fix(firestore): simplify 'Collection.add', avoid spurious API callhttps://github.com/googleapis/google-cloud-python/pull/9634/commits/ae3fd53a070cd8320ca032181d4e3db961a177ac
ae3fd53https://github.com/googleapis/google-cloud-python/pull/9634/commits/ae3fd53a070cd8320ca032181d4e3db961a177ac
#9629https://github.com/googleapis/google-cloud-python/issues/9629
https://github.com/tseaver
tseaverhttps://github.com/tseaver
api: firestore https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20firestore%22
Nov 7, 2019https://github.com/googleapis/google-cloud-python/pull/9634#event-2780421654
https://github.com/tseaver
tseaverhttps://github.com/tseaver
BenWhiteheadhttps://github.com/BenWhitehead
November 7, 2019 18:40https://github.com/googleapis/google-cloud-python/pull/9634#event-2780421669
https://github.com/tseaver
tseaverhttps://github.com/tseaver
crwilcoxhttps://github.com/crwilcox
frankynhttps://github.com/frankyn
code ownershttps://github.com/googleapis/google-cloud-python/blob/8c83b5290b7f7eaef5edc8f02ff8cab5a95ce3b9/.github/CODEOWNERS#L20
November 7, 2019 18:40https://github.com/googleapis/google-cloud-python/pull/9634#event-2780421672
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 7, 2019https://github.com/googleapis/google-cloud-python/pull/9634#event-2780421874
https://github.com/samtstern
samtsternhttps://github.com/samtstern
Nov 7, 2019 https://github.com/googleapis/google-cloud-python/pull/9634#pullrequestreview-313593378
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9634/files/ae3fd53a070cd8320ca032181d4e3db961a177ac
https://github.com/BenWhitehead
BenWhiteheadhttps://github.com/BenWhitehead
Nov 7, 2019 https://github.com/googleapis/google-cloud-python/pull/9634#pullrequestreview-313597491
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9634/files/ae3fd53a070cd8320ca032181d4e3db961a177ac
https://github.com/tseaver
tseaverhttps://github.com/tseaver
5621e9chttps://github.com/googleapis/google-cloud-python/commit/5621e9c1735abf636575e3a1a04005bda587cb56
Nov 7, 2019https://github.com/googleapis/google-cloud-python/pull/9634#event-2780667354
https://github.com/tseaver
tseaverhttps://github.com/tseaver
November 7, 2019 20:03https://github.com/googleapis/google-cloud-python/pull/9634#event-2780667647
https://github.com/samtstern
samtsternhttps://github.com/samtstern
Nov 7, 2019 https://github.com/googleapis/google-cloud-python/pull/9634#ref-issue-512614743
onUpdate (and onCreate) function triggered when document is written for the first time firebase/firebase-functions#574 https://github.com/firebase/firebase-functions/issues/574
https://github.com/yoshi-automation
yoshi-automationhttps://github.com/yoshi-automation
Jan 29, 2020 https://github.com/googleapis/google-cloud-python/pull/9634#ref-pullrequest-556855852
chore(bigquery): bump copyright year to 2020, tweak docstring formatting (via synth) #10225 https://github.com/googleapis/google-cloud-python/pull/10225
partheahttps://github.com/parthea
Nov 24, 2025 https://github.com/googleapis/google-cloud-python/pull/9634#ref-commit-ac0c96b
https://github.com/tseaver
fix(firestore): simplify 'Collection.add', avoid spurious API call (https://github.com/googleapis/google-cloud-python/commit/ac0c96b063a9a3b4dd3073fcc1be2d79a8acdc36
#…https://github.com/googleapis/google-cloud-python/pull/9634
ac0c96bhttps://github.com/googleapis/google-cloud-python/commit/ac0c96b063a9a3b4dd3073fcc1be2d79a8acdc36
…9634https://github.com/googleapis/google-cloud-python/pull/9634
#9629https://github.com/googleapis/google-cloud-python/issues/9629
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9634
https://github.com/crwilcox
crwilcox https://github.com/crwilcox
https://github.com/frankyn
frankyn https://github.com/frankyn
https://github.com/BenWhitehead
BenWhitehead https://github.com/BenWhitehead
https://github.com/googleapis/google-cloud-python/pull/9634/files/ae3fd53a070cd8320ca032181d4e3db961a177ac
https://github.com/samtstern
samtstern https://github.com/samtstern
https://github.com/googleapis/google-cloud-python/pull/9634/files/ae3fd53a070cd8320ca032181d4e3db961a177ac
api: firestore https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20firestore%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Firestore: Incorrect implementation of collection.add() https://github.com/googleapis/google-cloud-python/issues/9629
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9634
https://github.com/tseaver
https://github.com/BenWhitehead
https://github.com/samtstern
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.