René's URL Explorer Experiment


Title: fix(pubsub): fix messages delivered multiple times despite a long ACK deadline by plamut · Pull Request #9525 · googleapis/google-cloud-python · GitHub

Open Graph Title: fix(pubsub): fix messages delivered multiple times despite a long ACK deadline by plamut · Pull Request #9525 · googleapis/google-cloud-python

X Title: fix(pubsub): fix messages delivered multiple times despite a long ACK deadline by plamut · Pull Request #9525 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: Fixes #9252. This PR addresses the problem with some of the messages being re-delivered too early, because their acknowledge deadline is set to short, and is not properly extended. The issue was so...

X Description: Fixes #9252. This PR addresses the problem with some of the messages being re-delivered too early, because their acknowledge deadline is set to short, and is not properly extended. The issue was so...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/9525

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cee8bd77-2201-51d0-deb8-2892245d0403
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD34A:710E:B9BAD4:10CB953:6A4E4844
html-safe-nonceca5dd1db01a10f9e9459452fc3093966b58d3554e23e67f3bac3b2b74ef7ccc1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzRBOjcxMEU6QjlCQUQ0OjEwQ0I5NTM6NkE0RTQ4NDQiLCJ2aXNpdG9yX2lkIjoiMjgyMzA2ODA2Mzk4MDQ3MjM4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3bf7e840f192b0c7b7bbe738f95985257e82d58f6be15e9c469ec50132af0981
hovercard-subject-tagpull_request:331586758
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/9525/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5aeebe9e30c734b4166b7a8b8689d9fd8e421a0328176bd195d2b293f1714af7/googleapis/google-cloud-python/pull/9525
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5aeebe9e30c734b4166b7a8b8689d9fd8e421a0328176bd195d2b293f1714af7/googleapis/google-cloud-python/pull/9525
og:image:altFixes #9252. This PR addresses the problem with some of the messages being re-delivered too early, because their acknowledge deadline is set to short, and is not properly extended. The issue was so...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameplamut
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8506f6d0538364886e3f0153c154c410965e70d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/9525#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9525
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9525
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9525
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9525
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9525
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 439 https://github.com/googleapis/google-cloud-python/issues
Pull requests 138 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
plamuthttps://github.com/plamut
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
plamut:iss-9252-bhttps://github.com/plamut/google-cloud-python/tree/iss-9252-b
Conversationhttps://github.com/googleapis/google-cloud-python/pull/9525
Commits4 (4)https://github.com/googleapis/google-cloud-python/pull/9525/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/9525/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/9525/files
fix(pubsub): fix messages delivered multiple times despite a long ACK deadlinehttps://github.com/googleapis/google-cloud-python/pull/9525#top
plamuthttps://github.com/plamut
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
plamut:iss-9252-bhttps://github.com/plamut/google-cloud-python/tree/iss-9252-b
https://github.com/plamut
plamuthttps://github.com/plamut
Oct 23, 2019https://github.com/googleapis/google-cloud-python/pull/9525#issue-511377496
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
#9252https://github.com/googleapis/google-cloud-python/issues/9252
original fixhttps://github.com/googleapis/google-cloud-python/pull/9268
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/plamut
plamuthttps://github.com/plamut
api: pubsub https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
Oct 23, 2019https://github.com/googleapis/google-cloud-python/pull/9525#event-2737380485
https://github.com/plamut
plamuthttps://github.com/plamut
anguillanneufhttps://github.com/anguillanneuf
pradnhttps://github.com/pradn
code ownershttps://github.com/googleapis/google-cloud-python/blob/409838642664f25e24cb98a02933b99e06ebdab1/.github/CODEOWNERS#L45
October 23, 2019 14:50https://github.com/googleapis/google-cloud-python/pull/9525#event-2737380495
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 23, 2019https://github.com/googleapis/google-cloud-python/pull/9525#event-2737380822
plamuthttps://github.com/plamut
November 11, 2019 12:35https://github.com/googleapis/google-cloud-python/pull/9525#commits-pushed-de45c3e
https://github.com/plamut
fix(pubsub): lease-manage all received messageshttps://github.com/googleapis/google-cloud-python/pull/9525/commits/de45c3ecbb35516a0b5ad27531378e266984857e
de45c3ehttps://github.com/googleapis/google-cloud-python/pull/9525/commits/de45c3ecbb35516a0b5ad27531378e266984857e
https://github.com/plamut
Exclude on hold messages from load calculationhttps://github.com/googleapis/google-cloud-python/pull/9525/commits/b65873b3221da32deac4262a8c1d3084f0fbe105
b65873bhttps://github.com/googleapis/google-cloud-python/pull/9525/commits/b65873b3221da32deac4262a8c1d3084f0fbe105
https://github.com/plamut
Add warning if internal bytes count is negativehttps://github.com/googleapis/google-cloud-python/pull/9525/commits/a0cf284ecb9f895a6a45b6800c6685677a3c638d
a0cf284https://github.com/googleapis/google-cloud-python/pull/9525/commits/a0cf284ecb9f895a6a45b6800c6685677a3c638d
https://github.com/plamut
Use histogram to set default stream ACK deadlinehttps://github.com/googleapis/google-cloud-python/pull/9525/commits/79adfa4d9d05e6955b403b3afedb65a0e4c097be
79adfa4https://github.com/googleapis/google-cloud-python/pull/9525/commits/79adfa4d9d05e6955b403b3afedb65a0e4c097be
https://github.com/plamut
plamuthttps://github.com/plamut
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/b0a605ee258adc0455c547ead8229e72bfb72eb6..79adfa4d9d05e6955b403b3afedb65a0e4c097be
b0a605ehttps://github.com/googleapis/google-cloud-python/commit/b0a605ee258adc0455c547ead8229e72bfb72eb6
79adfa4https://github.com/googleapis/google-cloud-python/commit/79adfa4d9d05e6955b403b3afedb65a0e4c097be
Compare https://github.com/googleapis/google-cloud-python/compare/b0a605ee258adc0455c547ead8229e72bfb72eb6..79adfa4d9d05e6955b403b3afedb65a0e4c097be
November 11, 2019 10:43https://github.com/googleapis/google-cloud-python/pull/9525#event-2787472774
https://github.com/plamut
plamuthttps://github.com/plamut
kokoro:force-run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Nov 11, 2019https://github.com/googleapis/google-cloud-python/pull/9525#event-2787560519
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:force-run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Nov 11, 2019https://github.com/googleapis/google-cloud-python/pull/9525#event-2787561473
https://github.com/pellard1016
pellard1016https://github.com/pellard1016
Nov 20, 2019https://github.com/googleapis/google-cloud-python/pull/9525#issuecomment-556223984
https://user-images.githubusercontent.com/42385705/69267311-e26ec200-0b9a-11ea-9c17-d60cfc9673a9.jpg
https://user-images.githubusercontent.com/42385705/69267323-e7337600-0b9a-11ea-9d6e-00e1ad01070f.jpg
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/plamut
plamuthttps://github.com/plamut
Nov 20, 2019https://github.com/googleapis/google-cloud-python/pull/9525#issuecomment-556362201
@pellard1016https://github.com/pellard1016
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/pellard1016
pellard1016https://github.com/pellard1016
Nov 20, 2019https://github.com/googleapis/google-cloud-python/pull/9525#issuecomment-556376781
…https://github.com/googleapis/google-cloud-python/pull/9525
@pellard1016https://github.com/pellard1016
https://github.com/pellard1016https://github.com/pellard1016
#9525https://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/notifications/unsubscribe-auth/AKDMCKORZTQGJ5J2K6NCIBTQUWNWJANCNFSM4JECX5MAhttps://github.com/notifications/unsubscribe-auth/AKDMCKORZTQGJ5J2K6NCIBTQUWNWJANCNFSM4JECX5MA
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/pradn
pradnhttps://github.com/pradn
Nov 22, 2019 https://github.com/googleapis/google-cloud-python/pull/9525#pullrequestreview-321327594
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9525/files/79adfa4d9d05e6955b403b3afedb65a0e4c097be
pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.pyhttps://github.com/googleapis/google-cloud-python/pull/9525/files/79adfa4d9d05e6955b403b3afedb65a0e4c097be#diff-170ff47601080f0548be1136d0d38e40da61c92a09ee1ef39d5fe55ed9a053a5
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/pradn
pradnhttps://github.com/pradn
Nov 22, 2019 https://github.com/googleapis/google-cloud-python/pull/9525#pullrequestreview-321328548
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9525/files/79adfa4d9d05e6955b403b3afedb65a0e4c097be
pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.pyhttps://github.com/googleapis/google-cloud-python/pull/9525/files/79adfa4d9d05e6955b403b3afedb65a0e4c097be#diff-170ff47601080f0548be1136d0d38e40da61c92a09ee1ef39d5fe55ed9a053a5
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/pradn
pradnhttps://github.com/pradn
Nov 22, 2019 https://github.com/googleapis/google-cloud-python/pull/9525#pullrequestreview-321328974
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9525/files/79adfa4d9d05e6955b403b3afedb65a0e4c097be
pradnhttps://github.com/pradn
https://github.com/googleapis/google-cloud-python/pull/9525#pullrequestreview-321328974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/plamut
plamuthttps://github.com/plamut
pradnhttps://github.com/pradn
November 22, 2019 16:51https://github.com/googleapis/google-cloud-python/pull/9525#event-2823899136
https://github.com/googleapis
googleapishttps://github.com/googleapis
plamuthttps://github.com/plamut
Nov 22, 2019https://github.com/googleapis/google-cloud-python/pull/9525#event-2824408920
https://github.com/pradn
pradnhttps://github.com/pradn
Nov 22, 2019 https://github.com/googleapis/google-cloud-python/pull/9525#pullrequestreview-321781532
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9525/files/79adfa4d9d05e6955b403b3afedb65a0e4c097be
https://github.com/plamut
plamuthttps://github.com/plamut
d4c440bhttps://github.com/googleapis/google-cloud-python/commit/d4c440b185eeefa130499b0a6df1658b295c798f
Nov 22, 2019https://github.com/googleapis/google-cloud-python/pull/9525#event-2824474886
https://github.com/plamut
plamuthttps://github.com/plamut
November 22, 2019 20:21https://github.com/googleapis/google-cloud-python/pull/9525#event-2824475116
https://github.com/jawlitkp
jawlitkphttps://github.com/jawlitkp
Dec 23, 2019https://github.com/googleapis/google-cloud-python/pull/9525#issuecomment-568587606
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/plamut
plamuthttps://github.com/plamut
Jan 9, 2020https://github.com/googleapis/google-cloud-python/pull/9525#issuecomment-572533077
@jawlitkphttps://github.com/jawlitkp
PubSub v1.1.0https://github.com/googleapis/google-cloud-python/releases/tag/pubsub-1.1.0
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
chore(bigquery): bump copyright year to 2020, tweak docstring formatting (via synth) #10225 https://github.com/googleapis/google-cloud-python/pull/10225
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator. #10256 https://github.com/googleapis/google-cloud-python/pull/10256
[CHANGE ME] Re-generated datastore to pick up changes in the API or client library generator. #10261 https://github.com/googleapis/google-cloud-python/pull/10261
partheahttps://github.com/parthea
Mar 2, 2026 https://github.com/googleapis/google-cloud-python/pull/9525#ref-commit-817cc2a
https://github.com/plamut
fix(pubsub): fix messages delivered multiple times despite a long ACK…https://github.com/googleapis/google-cloud-python/commit/817cc2a1d196170cc5f738a4a001a97d99536025
817cc2ahttps://github.com/googleapis/google-cloud-python/commit/817cc2a1d196170cc5f738a4a001a97d99536025
#9525https://github.com/googleapis/google-cloud-python/pull/9525
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9525
https://github.com/pradn
pradn https://github.com/pradn
https://github.com/googleapis/google-cloud-python/pull/9525/files/79adfa4d9d05e6955b403b3afedb65a0e4c097be
https://github.com/anguillanneuf
anguillanneuf https://github.com/anguillanneuf
api: pubsub https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Pub/Sub: buffered messages delivered multiple times ignoring acknowledgment deadline https://github.com/googleapis/google-cloud-python/issues/9252
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9525
https://github.com/plamut
https://github.com/pellard1016
https://github.com/jawlitkp
https://github.com/pradn
https://github.com/googlebot
https://github.com/yoshi-kokoro
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.