René's URL Explorer Experiment


Title: feat(pubsub): add stop method by IlyaFaer · Pull Request #9365 · googleapis/google-cloud-python · GitHub

Open Graph Title: feat(pubsub): add stop method by IlyaFaer · Pull Request #9365 · googleapis/google-cloud-python

X Title: feat(pubsub): add stop method by IlyaFaer · Pull Request #9365 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: Add stop() method, which sends all outstanding messages and waits until all futures resolved. Similar features in Go and Java. Closes #4913 Closes #6883

X Description: Add stop() method, which sends all outstanding messages and waits until all futures resolved. Similar features in Go and Java. Closes #4913 Closes #6883

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/9365

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c4228aec-6946-03d4-d4a9-e5fe1185a537
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB116:645E3:30F851:47EA35:6A4E044E
html-safe-nonced0f236dd39e2d3b4d8b15657e6a609ae35105b110c2d9e4f721994d75ed68038
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTE2OjY0NUUzOjMwRjg1MTo0N0VBMzU6NkE0RTA0NEUiLCJ2aXNpdG9yX2lkIjoiODYzMTU3OTA4MjAxNjgxODI1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6b683d8dc384dc40307dbe861fe8b559b56b3320587850375547e7dbdde5f6b8
hovercard-subject-tagpull_request:323147921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/9365/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/268ee791956f380ff876707aad536aa07afb6d46a2bf71902551261ec778e4ba/googleapis/google-cloud-python/pull/9365
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/268ee791956f380ff876707aad536aa07afb6d46a2bf71902551261ec778e4ba/googleapis/google-cloud-python/pull/9365
og:image:altAdd stop() method, which sends all outstanding messages and waits until all futures resolved. Similar features in Go and Java. Closes #4913 Closes #6883
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameIlyaFaer
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release52bde38e24398476f8eb1e0760c81346c6a00812
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/9365#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9365
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9365
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9365
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9365
Reloadhttps://github.com/googleapis/google-cloud-python/pull/9365
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 439 https://github.com/googleapis/google-cloud-python/issues
Pull requests 138 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
pradnhttps://github.com/pradn
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
MaxxleLLC:pubsub_wait_methodhttps://github.com/MaxxleLLC/google-cloud-python/tree/pubsub_wait_method
Conversationhttps://github.com/googleapis/google-cloud-python/pull/9365
Commits15 (15)https://github.com/googleapis/google-cloud-python/pull/9365/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/9365/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/9365/files
feat(pubsub): add stop methodhttps://github.com/googleapis/google-cloud-python/pull/9365#top
pradnhttps://github.com/pradn
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
MaxxleLLC:pubsub_wait_methodhttps://github.com/MaxxleLLC/google-cloud-python/tree/pubsub_wait_method
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
Oct 1, 2019https://github.com/googleapis/google-cloud-python/pull/9365#issue-500742538
Gohttps://github.com/googleapis/google-cloud-go/blob/bdcd41efeb09c795b4c380d194b2a7a19f945176/pubsub/topic.go#L414-L426
Javahttps://github.com/googleapis/google-cloud-java/blob/bec495ff9106f863098b0089c51cd6a21ca9f6b2/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java#L492-L507
#4913https://github.com/googleapis/google-cloud-python/issues/4913
#6883https://github.com/googleapis/google-cloud-python/issues/6883
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
feat(pubsub): add stop methodhttps://github.com/googleapis/google-cloud-python/pull/9365/commits/dad43aa135141b2a23784c35306041e2d1489f93
dad43aahttps://github.com/googleapis/google-cloud-python/pull/9365/commits/dad43aa135141b2a23784c35306041e2d1489f93
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
api: pubsub https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
Oct 1, 2019https://github.com/googleapis/google-cloud-python/pull/9365#event-2676112353
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 1, 2019https://github.com/googleapis/google-cloud-python/pull/9365#event-2676112483
feat(pubsub): add unit-test for stop methodhttps://github.com/googleapis/google-cloud-python/pull/9365/commits/ec7677c5d5d4164ce35336e6f742bbebae324f89
ec7677chttps://github.com/googleapis/google-cloud-python/pull/9365/commits/ec7677c5d5d4164ce35336e6f742bbebae324f89
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
kokoro:force-run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Oct 1, 2019https://github.com/googleapis/google-cloud-python/pull/9365#event-2676203358
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:force-run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Oct 1, 2019https://github.com/googleapis/google-cloud-python/pull/9365#event-2676203710
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
Oct 1, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-295478434
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/ec7677c5d5d4164ce35336e6f742bbebae324f89
pubsub/google/cloud/pubsub_v1/publisher/client.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/ec7677c5d5d4164ce35336e6f742bbebae324f89#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
Oct 1, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-295478771
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/ec7677c5d5d4164ce35336e6f742bbebae324f89
pubsub/google/cloud/pubsub_v1/futures.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/ec7677c5d5d4164ce35336e6f742bbebae324f89#diff-2627c05e33f425837092d6c438f9969f7cfd51899ca937c6f9e8c220265b62ed
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
anguillanneufhttps://github.com/anguillanneuf
kamalaboulhosnhttps://github.com/kamalaboulhosn
lukesneeringerhttps://github.com/lukesneeringer
October 1, 2019 09:38https://github.com/googleapis/google-cloud-python/pull/9365#event-2676334715
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
October 1, 2019 09:38https://github.com/googleapis/google-cloud-python/pull/9365#event-2676335003
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
plamuthttps://github.com/plamut
code ownerhttps://github.com/googleapis/google-cloud-python/blob/63b70d4ba70ee97216a7f3323335a1d1fed442cb/.github/CODEOWNERS#L41
October 1, 2019 09:38https://github.com/googleapis/google-cloud-python/pull/9365#event-2676335011
https://github.com/pradn
pradnhttps://github.com/pradn
October 2, 2019 16:31https://github.com/googleapis/google-cloud-python/pull/9365#event-2681253955
https://github.com/googleapis
googleapishttps://github.com/googleapis
tseaverhttps://github.com/tseaver
Oct 4, 2019https://github.com/googleapis/google-cloud-python/pull/9365#event-2686862658
https://github.com/pradn
pradnhttps://github.com/pradn
Oct 18, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-304131391
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/ec7677c5d5d4164ce35336e6f742bbebae324f89
pubsub/google/cloud/pubsub_v1/publisher/_batch/thread.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/ec7677c5d5d4164ce35336e6f742bbebae324f89#diff-c53fd9034c37005c33a50371364c6b0a69fcb240e34a842f170d8b554755c6ba
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
Add comment for _futures. Change wait() conditions.https://github.com/googleapis/google-cloud-python/pull/9365/commits/93b5ec8cb02e8e2d1c7d934aa27963212fead446
93b5ec8https://github.com/googleapis/google-cloud-python/pull/9365/commits/93b5ec8cb02e8e2d1c7d934aa27963212fead446
https://github.com/pradn
pradnhttps://github.com/pradn
Oct 23, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-305986277
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/93b5ec8cb02e8e2d1c7d934aa27963212fead446
pubsub/google/cloud/pubsub_v1/publisher/_batch/thread.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/ec7677c5d5d4164ce35336e6f742bbebae324f89..93b5ec8cb02e8e2d1c7d934aa27963212fead446#diff-c53fd9034c37005c33a50371364c6b0a69fcb240e34a842f170d8b554755c6ba
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
October 23, 2019 18:36https://github.com/googleapis/google-cloud-python/pull/9365#commits-pushed-a0d82e6
Move attribute commenthttps://github.com/googleapis/google-cloud-python/pull/9365/commits/a0d82e67d04dfc7c6b9add12939936c1f35e14ea
a0d82e6https://github.com/googleapis/google-cloud-python/pull/9365/commits/a0d82e67d04dfc7c6b9add12939936c1f35e14ea
Make stop() method non-blocking.https://github.com/googleapis/google-cloud-python/pull/9365/commits/210abf0b4cf93f00fd3c2eb2993f474a4221d414
210abf0https://github.com/googleapis/google-cloud-python/pull/9365/commits/210abf0b4cf93f00fd3c2eb2993f474a4221d414
Add one more assert for stop() method.https://github.com/googleapis/google-cloud-python/pull/9365/commits/99bfc2608afccdc0a71c0ce43139f09876d51603
99bfc26https://github.com/googleapis/google-cloud-python/pull/9365/commits/99bfc2608afccdc0a71c0ce43139f09876d51603
https://github.com/pradn
pradnhttps://github.com/pradn
Oct 25, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-307203175
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/99bfc2608afccdc0a71c0ce43139f09876d51603
pubsub/google/cloud/pubsub_v1/publisher/client.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/93b5ec8cb02e8e2d1c7d934aa27963212fead446..99bfc2608afccdc0a71c0ce43139f09876d51603#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/pradn
pradnhttps://github.com/pradn
Oct 25, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-307204551
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/99bfc2608afccdc0a71c0ce43139f09876d51603
pradnhttps://github.com/pradn
https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-307204551
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
October 25, 2019 16:41https://github.com/googleapis/google-cloud-python/pull/9365#commits-pushed-3216d84
Fix comment.https://github.com/googleapis/google-cloud-python/pull/9365/commits/3216d849da9a0461c71f2a338cc142eda950ab1a
https://github.com/googleapis/google-cloud-python/commit/3216d849da9a0461c71f2a338cc142eda950ab1a#comments
3216d84https://github.com/googleapis/google-cloud-python/pull/9365/commits/3216d849da9a0461c71f2a338cc142eda950ab1a
Comment fix.https://github.com/googleapis/google-cloud-python/pull/9365/commits/94d30237ed12f569f2c4729d06f3f028f4a1f34c
94d3023https://github.com/googleapis/google-cloud-python/pull/9365/commits/94d30237ed12f569f2c4729d06f3f028f4a1f34c
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
Oct 25, 2019https://github.com/googleapis/google-cloud-python/pull/9365#issuecomment-546379097
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/pradn
pradnhttps://github.com/pradn
Oct 25, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-307270801
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/94d30237ed12f569f2c4729d06f3f028f4a1f34c
pubsub/google/cloud/pubsub_v1/publisher/client.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/94d30237ed12f569f2c4729d06f3f028f4a1f34c#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
Add stopping lock.https://github.com/googleapis/google-cloud-python/pull/9365/commits/3f5333350e4370ac697d4495362dec0e2fefb292
3f53333https://github.com/googleapis/google-cloud-python/pull/9365/commits/3f5333350e4370ac697d4495362dec0e2fefb292
https://github.com/pradn
pradnhttps://github.com/pradn
Oct 28, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-308098580
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/3f5333350e4370ac697d4495362dec0e2fefb292
pubsub/google/cloud/pubsub_v1/publisher/client.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/3f5333350e4370ac697d4495362dec0e2fefb292#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
Spelling mistake fix.https://github.com/googleapis/google-cloud-python/pull/9365/commits/b63c17693d73b0efc7a12bbff1e4b362d58d3d9d
b63c176https://github.com/googleapis/google-cloud-python/pull/9365/commits/b63c17693d73b0efc7a12bbff1e4b362d58d3d9d
https://github.com/pradn
pradnhttps://github.com/pradn
Nov 1, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-310609556
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/b63c17693d73b0efc7a12bbff1e4b362d58d3d9d
pubsub/google/cloud/pubsub_v1/publisher/client.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/b63c17693d73b0efc7a12bbff1e4b362d58d3d9d#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
November 4, 2019 15:10https://github.com/googleapis/google-cloud-python/pull/9365#commits-pushed-3ef412c
Preventing race conditions while stopping publisher.https://github.com/googleapis/google-cloud-python/pull/9365/commits/3ef412cd146567162e6d1570f1c114c8994ca01f
3ef412chttps://github.com/googleapis/google-cloud-python/pull/9365/commits/3ef412cd146567162e6d1570f1c114c8994ca01f
Fix test.https://github.com/googleapis/google-cloud-python/pull/9365/commits/b1d515d8b65736df46afa0477d47c9ee98d40fcc
b1d515dhttps://github.com/googleapis/google-cloud-python/pull/9365/commits/b1d515d8b65736df46afa0477d47c9ee98d40fcc
Lock method stop() completely.https://github.com/googleapis/google-cloud-python/pull/9365/commits/25344673d0cc5a8ee86d16827231bc9403e534db
2534467https://github.com/googleapis/google-cloud-python/pull/9365/commits/25344673d0cc5a8ee86d16827231bc9403e534db
https://github.com/pradn
pradnhttps://github.com/pradn
Nov 6, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-312609995
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/25344673d0cc5a8ee86d16827231bc9403e534db
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
Nov 7, 2019https://github.com/googleapis/google-cloud-python/pull/9365#issuecomment-551048416
@pradnhttps://github.com/pradn
@kamalaboulhosnhttps://github.com/kamalaboulhosn
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/plamut
plamuthttps://github.com/plamut
Nov 7, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-313482468
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/25344673d0cc5a8ee86d16827231bc9403e534db
plamuthttps://github.com/plamut
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-313482468
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pradnhttps://github.com/pradn
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
pubsub/google/cloud/pubsub_v1/publisher/client.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/25344673d0cc5a8ee86d16827231bc9403e534db#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
pubsub/google/cloud/pubsub_v1/publisher/client.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/25344673d0cc5a8ee86d16827231bc9403e534db#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/kamalaboulhosn
kamalaboulhosnhttps://github.com/kamalaboulhosn
Nov 7, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-313494213
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/25344673d0cc5a8ee86d16827231bc9403e534db
https://github.com/kamalaboulhosn
kamalaboulhosnhttps://github.com/kamalaboulhosn
Nov 7, 2019https://github.com/googleapis/google-cloud-python/pull/9365#issuecomment-551171798
@pradnhttps://github.com/pradn
@kamalaboulhosnhttps://github.com/kamalaboulhosn
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
Small refactor.https://github.com/googleapis/google-cloud-python/pull/9365/commits/45a6bf890de245bbef0aa14522e96b3db6d27eb4
45a6bf8https://github.com/googleapis/google-cloud-python/pull/9365/commits/45a6bf890de245bbef0aa14522e96b3db6d27eb4
https://github.com/plamut
plamuthttps://github.com/plamut
Nov 7, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-313503876
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/45a6bf890de245bbef0aa14522e96b3db6d27eb4
pubsub/google/cloud/pubsub_v1/publisher/client.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/files/45a6bf890de245bbef0aa14522e96b3db6d27eb4#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/plamut
Update pubsub/google/cloud/pubsub_v1/publisher/client.pyhttps://github.com/googleapis/google-cloud-python/pull/9365/commits/ba01ec190a062502065e48278daf12514e6d296e
ba01ec1https://github.com/googleapis/google-cloud-python/pull/9365/commits/ba01ec190a062502065e48278daf12514e6d296e
https://github.com/plamut
plamuthttps://github.com/plamut
Nov 7, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-313505265
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/9365/files/ba01ec190a062502065e48278daf12514e6d296e
plamuthttps://github.com/plamut
https://github.com/googleapis/google-cloud-python/pull/9365#pullrequestreview-313505265
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/pradn
pradnhttps://github.com/pradn
anguillanneufhttps://github.com/anguillanneuf
lukesneeringerhttps://github.com/lukesneeringer
November 7, 2019 18:05https://github.com/googleapis/google-cloud-python/pull/9365#event-2780317880
https://github.com/pradn
pradnhttps://github.com/pradn
1e7c0a6https://github.com/googleapis/google-cloud-python/commit/1e7c0a6f95407266fbe1df56dc1ea57ee3bdd12c
Nov 7, 2019https://github.com/googleapis/google-cloud-python/pull/9365#event-2780319612
https://github.com/plamut
plamuthttps://github.com/plamut
Dec 2, 2019 https://github.com/googleapis/google-cloud-python/pull/9365#ref-issue-531266218
PubSub: Force push a batch of messages #9906 https://github.com/googleapis/google-cloud-python/issues/9906
https://github.com/yoshi-automation
yoshi-automationhttps://github.com/yoshi-automation
Jan 29, 2020 https://github.com/googleapis/google-cloud-python/pull/9365#ref-pullrequest-556855852
chore(bigquery): bump copyright year to 2020, tweak docstring formatting (via synth) #10225 https://github.com/googleapis/google-cloud-python/pull/10225
partheahttps://github.com/parthea
Mar 2, 2026 https://github.com/googleapis/google-cloud-python/pull/9365#ref-commit-bd92594
https://github.com/pradn
feat(pubsub): add stop method (https://github.com/googleapis/google-cloud-python/commit/bd92594e4acea0f2c0d7d9693a06cd91e84bbfc1
#9365https://github.com/googleapis/google-cloud-python/pull/9365
)https://github.com/googleapis/google-cloud-python/commit/bd92594e4acea0f2c0d7d9693a06cd91e84bbfc1
bd92594https://github.com/googleapis/google-cloud-python/commit/bd92594e4acea0f2c0d7d9693a06cd91e84bbfc1
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F9365
https://github.com/pradn
pradn https://github.com/pradn
https://github.com/googleapis/google-cloud-python/pull/9365/files/25344673d0cc5a8ee86d16827231bc9403e534db
https://github.com/tseaver
tseaver https://github.com/tseaver
https://github.com/googleapis/google-cloud-python/pull/9365/files/ec7677c5d5d4164ce35336e6f742bbebae324f89
https://github.com/plamut
plamut https://github.com/plamut
https://github.com/googleapis/google-cloud-python/pull/9365/files/ba01ec190a062502065e48278daf12514e6d296e
https://github.com/kamalaboulhosn
kamalaboulhosn https://github.com/kamalaboulhosn
https://github.com/googleapis/google-cloud-python/pull/9365/files/25344673d0cc5a8ee86d16827231bc9403e534db
api: pubsub https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Pubsub: How to flush unsent messages on program exit? https://github.com/googleapis/google-cloud-python/issues/6883
Pubsub API should provide a way to synchronize a set of operations https://github.com/googleapis/google-cloud-python/issues/4913
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/9365
https://github.com/IlyaFaer
https://github.com/kamalaboulhosn
https://github.com/tseaver
https://github.com/pradn
https://github.com/plamut
https://github.com/googlebot
https://github.com/yoshi-kokoro
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.