| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d4a99b07-1ca0-0f7d-f69c-80813e189971 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB7E:1E70:1931FC5:229CD1F:6A4F026A |
| html-safe-nonce | ec45f229c9ccc766c8011ecdf291dd1d1d2ed0187894b249df68903ef88b7215 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjdFOjFFNzA6MTkzMUZDNToyMjlDRDFGOjZBNEYwMjZBIiwidmlzaXRvcl9pZCI6IjIxODI5ODg2MDI1MjYzMzU1OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 51b346480c45d8cb6dd028e6a84f96448211ba619d170722e7361d8b5d1f8686 |
| hovercard-subject-tag | pull_request:294210783 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/8604/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6aa43937142a1a807fd5d0130a74163881959fbdfaa3e7b8d82328d7db83e806/googleapis/google-cloud-python/pull/8604 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6aa43937142a1a807fd5d0130a74163881959fbdfaa3e7b8d82328d7db83e806/googleapis/google-cloud-python/pull/8604 |
| og:image:alt | Moved Bucket.create() implementation into Client.create_bucket()
Towards: #7762 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | IlyaFaer |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 16316451 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16316451 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/googleapis/google-cloud-python/pull/8604#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F8604 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F8604 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python |
| Reload | https://github.com/googleapis/google-cloud-python/pull/8604 |
| Reload | https://github.com/googleapis/google-cloud-python/pull/8604 |
| Reload | https://github.com/googleapis/google-cloud-python/pull/8604 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
|
googleapis
| https://github.com/googleapis |
| google-cloud-python | https://github.com/googleapis/google-cloud-python |
|
Notifications
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python |
|
Fork
1.7k
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python |
|
Star
5.3k
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python |
|
Code
| https://github.com/googleapis/google-cloud-python |
|
Issues
441
| https://github.com/googleapis/google-cloud-python/issues |
|
Pull requests
140
| https://github.com/googleapis/google-cloud-python/pulls |
|
Discussions
| https://github.com/googleapis/google-cloud-python/discussions |
|
Actions
| https://github.com/googleapis/google-cloud-python/actions |
|
Projects
| https://github.com/googleapis/google-cloud-python/projects |
|
Security and quality
0
| https://github.com/googleapis/google-cloud-python/security |
|
Insights
| https://github.com/googleapis/google-cloud-python/pulse |
|
Code
| https://github.com/googleapis/google-cloud-python |
|
Issues
| https://github.com/googleapis/google-cloud-python/issues |
|
Pull requests
| https://github.com/googleapis/google-cloud-python/pulls |
|
Discussions
| https://github.com/googleapis/google-cloud-python/discussions |
|
Actions
| https://github.com/googleapis/google-cloud-python/actions |
|
Projects
| https://github.com/googleapis/google-cloud-python/projects |
|
Security and quality
| https://github.com/googleapis/google-cloud-python/security |
|
Insights
| https://github.com/googleapis/google-cloud-python/pulse |
| IlyaFaer | https://github.com/IlyaFaer |
| googleapis:master | https://github.com/googleapis/google-cloud-python/tree/master |
| MaxxleLLC:redesign_client_create_bucket_7762 | https://github.com/MaxxleLLC/google-cloud-python/tree/redesign_client_create_bucket_7762 |
| Conversation | https://github.com/googleapis/google-cloud-python/pull/8604 |
| Commits23 (23) | https://github.com/googleapis/google-cloud-python/pull/8604/commits |
| Checks | https://github.com/googleapis/google-cloud-python/pull/8604/checks |
| Files changed | https://github.com/googleapis/google-cloud-python/pull/8604/files |
| refactor(storage): move 'create_bucket' implementation from 'Bucket' to 'Client' | https://github.com/googleapis/google-cloud-python/pull/8604#top |
| IlyaFaer | https://github.com/IlyaFaer |
| googleapis:master | https://github.com/googleapis/google-cloud-python/tree/master |
| MaxxleLLC:redesign_client_create_bucket_7762 | https://github.com/MaxxleLLC/google-cloud-python/tree/redesign_client_create_bucket_7762 |
|
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| Jul 3, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#issue-463804397 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| July 3, 2019 14:14 | https://github.com/googleapis/google-cloud-python/pull/8604#commits-pushed-feccf18 |
| Storage: client redesign proposal | https://github.com/googleapis/google-cloud-python/pull/8604/commits/feccf18b2cfcd7af8d7299c482e8750308d95a34 |
| feccf18 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/feccf18b2cfcd7af8d7299c482e8750308d95a34 |
| Merge branch 'client_redesign_create_bucket_7762' into redesign_clien… | https://github.com/googleapis/google-cloud-python/pull/8604/commits/f9e692466d26c8579cc519fb28c06da6cbbe95da |
| f9e6924 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/f9e692466d26c8579cc519fb28c06da6cbbe95da |
| Delete unittest.main | https://github.com/googleapis/google-cloud-python/pull/8604/commits/1f57249683329bfad2e75b8064303db7184263a9 |
| 1f57249 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/1f57249683329bfad2e75b8064303db7184263a9 |
| Delete unnecessary import | https://github.com/googleapis/google-cloud-python/pull/8604/commits/b9146a40914a5156f65d4195ba5d540672ff8399 |
| b9146a4 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/b9146a40914a5156f65d4195ba5d540672ff8399 |
| Cosmetic changes | https://github.com/googleapis/google-cloud-python/pull/8604/commits/be8166c6bd562ebfe884aa3d36c2277a408793d4 |
| be8166c | https://github.com/googleapis/google-cloud-python/pull/8604/commits/be8166c6bd562ebfe884aa3d36c2277a408793d4 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jul 3, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2457896858 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
|
Jul 3, 2019
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-257552863 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/8604/files/be8166c6bd562ebfe884aa3d36c2277a408793d4 |
| storage/google/cloud/storage/bucket.py | https://github.com/googleapis/google-cloud-python/pull/8604/files/be8166c6bd562ebfe884aa3d36c2277a408793d4#diff-2d811c9045d2669401c72c141a826352d75d15551e39a33f00494a6acf531e5b |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
|
Jul 3, 2019
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-257554050 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/8604/files/be8166c6bd562ebfe884aa3d36c2277a408793d4 |
| storage/tests/unit/test_bucket.py | https://github.com/googleapis/google-cloud-python/pull/8604/files/be8166c6bd562ebfe884aa3d36c2277a408793d4#diff-6f846271dd0482312c7bfd1acb67fc9dbb49fd85f9defbbed636a015c801f84a |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| Merge branch 'master' into redesign_client_create_bucket_7762 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/c9ec3e9fa0909bb096662c8be16d4942e3b1b092 |
| c9ec3e9 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/c9ec3e9fa0909bb096662c8be16d4942e3b1b092 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| July 3, 2019 15:15 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2457940940 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| crwilcox | https://github.com/crwilcox |
| frankyn | https://github.com/frankyn |
| tseaver | https://github.com/tseaver |
| code owners | https://github.com/googleapis/google-cloud-python/blob/c2df95b299917fb7843f40e8ea932267255f0376/.github/CODEOWNERS#L17 |
| July 3, 2019 15:15 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2457940963 |
| https://github.com/tseaver |
| tseaver | https://github.com/tseaver |
|
api: storage
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20storage%22 |
| Jul 3, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2458499018 |
| https://github.com/AVaksman |
| AVaksman | https://github.com/AVaksman |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Jul 4, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2460834924 |
| https://github.com/yoshi-kokoro |
| yoshi-kokoro | https://github.com/yoshi-kokoro |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Jul 4, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2460837927 |
| July 5, 2019 10:29 | https://github.com/googleapis/google-cloud-python/pull/8604#commits-pushed-d1bafa1 |
| Merge branch 'master' into redesign_client_create_bucket_7762 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/d1bafa14b5e5c4b2262bf1ec9c0bedc162c34c5e |
| d1bafa1 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/d1bafa14b5e5c4b2262bf1ec9c0bedc162c34c5e |
| Merge branch 'redesign_client_create_bucket_7762' of | https://github.com/googleapis/google-cloud-python/pull/8604/commits/8c21c5aca019afe3b3cd186ec7d815f888ffefc8 |
| https://github.c… | https://github.com/q-logic/google-cloud-python |
| 8c21c5a | https://github.com/googleapis/google-cloud-python/pull/8604/commits/8c21c5aca019afe3b3cd186ec7d815f888ffefc8 |
| …om/q-logic/google-cloud-python | https://github.com/q-logic/google-cloud-python |
| https://github.com/crwilcox |
| crwilcox | https://github.com/crwilcox |
| frankyn | https://github.com/frankyn |
| Jul 8, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2466693830 |
| https://github.com/sduskis |
| sduskis | https://github.com/sduskis |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Jul 9, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2470115351 |
| https://github.com/yoshi-kokoro |
| yoshi-kokoro | https://github.com/yoshi-kokoro |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Jul 9, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2470121557 |
| Merge branch 'master' into redesign_client_create_bucket_7762 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/8d31e55ebd853707f9a2ba953942bae1a272393c |
| 8d31e55 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/8d31e55ebd853707f9a2ba953942bae1a272393c |
| https://github.com/tseaver |
| tseaver | https://github.com/tseaver |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Jul 10, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2473459492 |
| https://github.com/yoshi-kokoro |
| yoshi-kokoro | https://github.com/yoshi-kokoro |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Jul 10, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2473463625 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| Jul 26, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2512575495 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| tswast | https://github.com/tswast |
| August 1, 2019 11:10 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2526166338 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Aug 7, 2019
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-272283571 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/8604/files/8d31e55ebd853707f9a2ba953942bae1a272393c |
| storage/google/cloud/storage/bucket.py | https://github.com/googleapis/google-cloud-python/pull/8604/files/be8166c6bd562ebfe884aa3d36c2277a408793d4#diff-2d811c9045d2669401c72c141a826352d75d15551e39a33f00494a6acf531e5b |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| storage/tests/unit/test_bucket.py | https://github.com/googleapis/google-cloud-python/pull/8604/files/8d31e55ebd853707f9a2ba953942bae1a272393c#diff-6f846271dd0482312c7bfd1acb67fc9dbb49fd85f9defbbed636a015c801f84a |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| August 8, 2019 12:38 | https://github.com/googleapis/google-cloud-python/pull/8604#commits-pushed-1c50d4c |
| Merge branch 'master' into redesign_client_create_bucket_7762 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/1c50d4cc4f3ea10ad678c7af286be00b8c6088ab |
| 1c50d4c | https://github.com/googleapis/google-cloud-python/pull/8604/commits/1c50d4cc4f3ea10ad678c7af286be00b8c6088ab |
| Delete public property for bucket properties and mocks in bucket test… | https://github.com/googleapis/google-cloud-python/pull/8604/commits/09d0c6f9144a4945522e133447e20935e501a180 |
| 09d0c6f | https://github.com/googleapis/google-cloud-python/pull/8604/commits/09d0c6f9144a4945522e133447e20935e501a180 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| tswast | https://github.com/tswast |
| September 9, 2019 08:16 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2617776364 |
| Merge branch 'master' into redesign_client_create_bucket_7762 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/b8e091f88c3f085dccfc466d072de9a82065e79f |
| b8e091f | https://github.com/googleapis/google-cloud-python/pull/8604/commits/b8e091f88c3f085dccfc466d072de9a82065e79f |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| Oct 28, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2747878731 |
| October 28, 2019 13:38 | https://github.com/googleapis/google-cloud-python/pull/8604#commits-pushed-5a31265 |
| Updated PRed changes to actualize them with changes from | https://github.com/googleapis/google-cloud-python/pull/8604/commits/5a31265644dacdbfdcc4257f000142ea957864cc |
| a79d98d | https://github.com/MaxxleLLC/google-cloud-python/commit/a79d98de3e9d6890c4e98d33cecae2f80550fdfd |
| 5a31265 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/5a31265644dacdbfdcc4257f000142ea957864cc |
| Black reformat | https://github.com/googleapis/google-cloud-python/pull/8604/commits/e4f94da28787b7289b16003e481c961cc8b43ab8 |
| e4f94da | https://github.com/googleapis/google-cloud-python/pull/8604/commits/e4f94da28787b7289b16003e481c961cc8b43ab8 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Oct 29, 2019
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-308891203 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/8604/files/e4f94da28787b7289b16003e481c961cc8b43ab8 |
| tswast | https://github.com/tswast |
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-308891203 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @crwilcox | https://github.com/crwilcox |
| @frankyn | https://github.com/frankyn |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| https://github.com/frankyn |
| frankyn | https://github.com/frankyn |
| Oct 30, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#issuecomment-548150785 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| https://github.com/frankyn |
| frankyn | https://github.com/frankyn |
|
Nov 1, 2019
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-310235993 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/8604/files/e4f94da28787b7289b16003e481c961cc8b43ab8 |
| frankyn | https://github.com/frankyn |
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-310235993 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| storage/google/cloud/storage/client.py | https://github.com/googleapis/google-cloud-python/pull/8604/files/e4f94da28787b7289b16003e481c961cc8b43ab8#diff-cb2a027afc737f9c8a732f9bc5adb52ee0a0afe94fe2b68a9322d145fde43a3a |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| storage/google/cloud/storage/client.py | https://github.com/googleapis/google-cloud-python/pull/8604/files/e4f94da28787b7289b16003e481c961cc8b43ab8#diff-cb2a027afc737f9c8a732f9bc5adb52ee0a0afe94fe2b68a9322d145fde43a3a |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| November 1, 2019 14:06 | https://github.com/googleapis/google-cloud-python/pull/8604#commits-pushed-e96d05c |
| Add user_project param into Client.create_bucket() method. | https://github.com/googleapis/google-cloud-python/pull/8604/commits/e96d05ca7709d8f8e3be958f73f32a51fbd5d689 |
| e96d05c | https://github.com/googleapis/google-cloud-python/pull/8604/commits/e96d05ca7709d8f8e3be958f73f32a51fbd5d689 |
| Fix comment. | https://github.com/googleapis/google-cloud-python/pull/8604/commits/35427fbd037bd639870096b40b50c846f6aacfe4 |
| 35427fb | https://github.com/googleapis/google-cloud-python/pull/8604/commits/35427fbd037bd639870096b40b50c846f6aacfe4 |
| https://github.com/frankyn |
| frankyn | https://github.com/frankyn |
|
Nov 1, 2019
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-310661624 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/8604/files/35427fbd037bd639870096b40b50c846f6aacfe4 |
| frankyn | https://github.com/frankyn |
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-310661624 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://cloud.google.com/storage/docs/json_api/v1/buckets/insert | https://cloud.google.com/storage/docs/json_api/v1/buckets/insert |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| storage/google/cloud/storage/client.py | https://github.com/googleapis/google-cloud-python/pull/8604/files/35427fbd037bd639870096b40b50c846f6aacfe4#diff-cb2a027afc737f9c8a732f9bc5adb52ee0a0afe94fe2b68a9322d145fde43a3a |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| November 4, 2019 11:02 | https://github.com/googleapis/google-cloud-python/pull/8604#commits-pushed-608d7ac |
| Merge branch 'master' of | https://github.com/googleapis/google-cloud-python/pull/8604/commits/608d7ac1b85b279a9618d00af22812af2467f73d |
| https://github.com/q-logic/google-cloud-python | https://github.com/q-logic/google-cloud-python |
| … | https://github.com/googleapis/google-cloud-python/pull/8604/commits/608d7ac1b85b279a9618d00af22812af2467f73d |
| 608d7ac | https://github.com/googleapis/google-cloud-python/pull/8604/commits/608d7ac1b85b279a9618d00af22812af2467f73d |
| Merge branch 'redesign_client_create_bucket_7762' of | https://github.com/googleapis/google-cloud-python/pull/8604/commits/db2c0ae9295a5e3e66ed2366996fbaf2c6662cf3 |
| https://github.c… | https://github.com/q-logic/google-cloud-python |
| db2c0ae | https://github.com/googleapis/google-cloud-python/pull/8604/commits/db2c0ae9295a5e3e66ed2366996fbaf2c6662cf3 |
| …om/q-logic/google-cloud-python | https://github.com/q-logic/google-cloud-python |
| Create bucket should support user_project. | https://github.com/googleapis/google-cloud-python/pull/8604/commits/8000ce6056381dd114ae3daee8368ed1c651c168 |
| 8000ce6 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/8000ce6056381dd114ae3daee8368ed1c651c168 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Nov 4, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2766932057 |
| https://github.com/yoshi-kokoro |
| yoshi-kokoro | https://github.com/yoshi-kokoro |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Nov 4, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2766938975 |
| Test for user_project query parameter. | https://github.com/googleapis/google-cloud-python/pull/8604/commits/e206be2b5dada7565b1a4f6a6354d492e39dd47a |
| e206be2 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/e206be2b5dada7565b1a4f6a6354d492e39dd47a |
| https://github.com/frankyn |
| frankyn | https://github.com/frankyn |
|
Nov 5, 2019
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-311451537 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/8604/files/e206be2b5dada7565b1a4f6a6354d492e39dd47a |
| frankyn | https://github.com/frankyn |
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-311451537 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @IlyaFaer | https://github.com/IlyaFaer |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| https://github.com/frankyn |
| frankyn | https://github.com/frankyn |
| Nov 5, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#issuecomment-549618165 |
| google-cloud-python/storage/tests/unit/test_bucket.py | https://github.com/googleapis/google-cloud-python/blob/e206be2b5dada7565b1a4f6a6354d492e39dd47a/storage/tests/unit/test_bucket.py#L610-L819 |
| e206be2 | https://github.com/googleapis/google-cloud-python/commit/e206be2b5dada7565b1a4f6a6354d492e39dd47a |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| November 5, 2019 12:48 | https://github.com/googleapis/google-cloud-python/pull/8604#commits-pushed-2cd2321 |
| Merge branch 'master' into redesign_client_create_bucket_7762 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/2cd23213ccca10b603143d0826bdf541ccb5160a |
| 2cd2321 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/2cd23213ccca10b603143d0826bdf541ccb5160a |
| Copy tests from bucket test to client. | https://github.com/googleapis/google-cloud-python/pull/8604/commits/675e11d54b6805d838dfc97545ac83e1d3296719 |
| 675e11d | https://github.com/googleapis/google-cloud-python/pull/8604/commits/675e11d54b6805d838dfc97545ac83e1d3296719 |
| Revert "Copy tests from bucket test to client." | https://github.com/googleapis/google-cloud-python/pull/8604/commits/2530133a4bb74330ea5d14f25bfe0a2dda0adfed |
| 2530133 | https://github.com/googleapis/google-cloud-python/pull/8604/commits/2530133a4bb74330ea5d14f25bfe0a2dda0adfed |
| 675e11d | https://github.com/MaxxleLLC/google-cloud-python/commit/675e11d54b6805d838dfc97545ac83e1d3296719 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Nov 5, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2771160733 |
| https://github.com/yoshi-kokoro |
| yoshi-kokoro | https://github.com/yoshi-kokoro |
|
kokoro:force-run
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run |
| Nov 5, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2771161965 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| Nov 5, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#issuecomment-549805962 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| @frankyn | https://github.com/frankyn |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| https://github.com/frankyn |
| frankyn | https://github.com/frankyn |
|
Nov 8, 2019
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-313722140 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/8604/files/2530133a4bb74330ea5d14f25bfe0a2dda0adfed |
| frankyn | https://github.com/frankyn |
| https://github.com/googleapis/google-cloud-python/pull/8604#pullrequestreview-313722140 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| Nov 8, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#issuecomment-551428612 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
| https://github.com/IlyaFaer |
| IlyaFaer | https://github.com/IlyaFaer |
| 332c8ff | https://github.com/googleapis/google-cloud-python/commit/332c8ff62cc663ca1a88517038e1c988cc35ebc4 |
| Nov 8, 2019 | https://github.com/googleapis/google-cloud-python/pull/8604#event-2782053362 |
| https://github.com/yoshi-automation |
| yoshi-automation | https://github.com/yoshi-automation |
|
Jan 29, 2020
| https://github.com/googleapis/google-cloud-python/pull/8604#ref-pullrequest-556855852 |
|
chore(bigquery): bump copyright year to 2020, tweak docstring formatting (via synth)
#10225
| https://github.com/googleapis/google-cloud-python/pull/10225 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Jan 31, 2020
| https://github.com/googleapis/google-cloud-python/pull/8604#ref-issue-558430799 |
|
Proposal: move API-methods to client
googleapis/python-storage#38
| https://github.com/googleapis/python-storage/issues/38 |
| parthea | https://github.com/parthea |
|
Mar 9, 2026
| https://github.com/googleapis/google-cloud-python/pull/8604#ref-commit-01a5311 |
| refactor(storage): move 'create_bucket' implementation from 'Bucket' … | https://github.com/googleapis/google-cloud-python/commit/01a5311d9964dca5bdd77f686e12e5be8fc35179 |
| 01a5311 | https://github.com/googleapis/google-cloud-python/commit/01a5311d9964dca5bdd77f686e12e5be8fc35179 |
| #8604 | https://github.com/googleapis/google-cloud-python/pull/8604 |
| https://github.co/hiddenchars |
| https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F8604 |
|
| https://github.com/tswast |
|
tswast
| https://github.com/tswast |
|
| https://github.com/googleapis/google-cloud-python/pull/8604/files/e4f94da28787b7289b16003e481c961cc8b43ab8 |
|
| https://github.com/crwilcox |
|
crwilcox
| https://github.com/crwilcox |
|
| https://github.com/tseaver |
|
tseaver
| https://github.com/tseaver |
|
| https://github.com/frankyn |
|
frankyn
| https://github.com/frankyn |
|
| https://github.com/googleapis/google-cloud-python/pull/8604/files/2530133a4bb74330ea5d14f25bfe0a2dda0adfed |
|
| https://github.com/frankyn |
|
frankyn
| https://github.com/frankyn |
|
api: storage
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20storage%22 |
|
cla: yes
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/8604 |
|
| https://github.com/IlyaFaer |
|
| https://github.com/tseaver |
|
| https://github.com/frankyn |
|
| https://github.com/tswast |
|
| https://github.com/sduskis |
|
| https://github.com/googlebot |
|
| https://github.com/AVaksman |
|
| https://github.com/yoshi-kokoro |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |