René's URL Explorer Experiment


Title: Don't check 'exclude_from_indexes' for empty lists. by tseaver · Pull Request #4915 · googleapis/google-cloud-python · GitHub

Open Graph Title: Don't check 'exclude_from_indexes' for empty lists. by tseaver · Pull Request #4915 · googleapis/google-cloud-python

X Title: Don't check 'exclude_from_indexes' for empty lists. by tseaver · Pull Request #4915 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: Closes #3152. Adds a breaking unit test for the bug in the first commit, and fixes it in the second commit. Supersedes PRs #3767 and #4778

X Description: Closes #3152. Adds a breaking unit test for the bug in the first commit, and fixes it in the second commit. Supersedes PRs #3767 and #4778

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/4915

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8e8a0e49-6429-01b8-a173-845ad508a044
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F62:633B1:43CD26:605E1B:6A4E6E28
html-safe-nonce9a59b8b9f841011bb267d663d1fa95c7386791946a49f05a396e9870193afa48
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjYyOjYzM0IxOjQzQ0QyNjo2MDVFMUI6NkE0RTZFMjgiLCJ2aXNpdG9yX2lkIjoiODk4OTU5MzAxMzA1MjE0MTA5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc6691ff7f8d17b45fce10758ff0f6e2b38097d2756d49f6d8b19e81953be86a7
hovercard-subject-tagpull_request:170856624
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/4915/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cb85e4a57edfae2678f0117fd274220db6829f8eb4ac38f3212c43b0645b18c2/googleapis/google-cloud-python/pull/4915
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cb85e4a57edfae2678f0117fd274220db6829f8eb4ac38f3212c43b0645b18c2/googleapis/google-cloud-python/pull/4915
og:image:altCloses #3152. Adds a breaking unit test for the bug in the first commit, and fixes it in the second commit. Supersedes PRs #3767 and #4778
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametseaver
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/4915#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4915
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4915
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/4915
Reloadhttps://github.com/googleapis/google-cloud-python/pull/4915
Reloadhttps://github.com/googleapis/google-cloud-python/pull/4915
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4915
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 440 https://github.com/googleapis/google-cloud-python/issues
Pull requests 142 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
tseaverhttps://github.com/tseaver
masterhttps://github.com/googleapis/google-cloud-python/tree/master
3152-datastore-empty_arrayshttps://github.com/googleapis/google-cloud-python/tree/3152-datastore-empty_arrays
Conversationhttps://github.com/googleapis/google-cloud-python/pull/4915
Commits2 (2)https://github.com/googleapis/google-cloud-python/pull/4915/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/4915/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/4915/files
Don't check 'exclude_from_indexes' for empty lists.https://github.com/googleapis/google-cloud-python/pull/4915#top
tseaverhttps://github.com/tseaver
masterhttps://github.com/googleapis/google-cloud-python/tree/master
3152-datastore-empty_arrayshttps://github.com/googleapis/google-cloud-python/tree/3152-datastore-empty_arrays
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Feb 22, 2018https://github.com/googleapis/google-cloud-python/pull/4915#issue-299495930
#3152https://github.com/googleapis/google-cloud-python/issues/3152
#3767https://github.com/googleapis/google-cloud-python/pull/3767
#4778https://github.com/googleapis/google-cloud-python/pull/4778
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4915
tseaverhttps://github.com/tseaver
February 22, 2018 15:21https://github.com/googleapis/google-cloud-python/pull/4915#commits-pushed-f885008
https://github.com/tseaver
Add unit test which actually exerciseshttps://github.com/googleapis/google-cloud-python/pull/4915/commits/f885008bdcc2a5fc6387262a1c3d955364a0a029
#3152https://github.com/googleapis/google-cloud-python/issues/3152
.https://github.com/googleapis/google-cloud-python/pull/4915/commits/f885008bdcc2a5fc6387262a1c3d955364a0a029
f885008https://github.com/googleapis/google-cloud-python/pull/4915/commits/f885008bdcc2a5fc6387262a1c3d955364a0a029
https://github.com/tseaver
Don't check 'exclude_from_indexes' for empty lists.https://github.com/googleapis/google-cloud-python/pull/4915/commits/3585264ff3a23ecd6005bdca860872972a9ca74a
3585264https://github.com/googleapis/google-cloud-python/pull/4915/commits/3585264ff3a23ecd6005bdca860872972a9ca74a
#3152https://github.com/googleapis/google-cloud-python/issues/3152
https://github.com/tseaver
tseaverhttps://github.com/tseaver
type: bug https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
api: datastore https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20datastore%22
Feb 22, 2018https://github.com/googleapis/google-cloud-python/pull/4915#event-1487807885
https://github.com/tseaver
tseaverhttps://github.com/tseaver
chemelnucfinhttps://github.com/chemelnucfin
lukesneeringerhttps://github.com/lukesneeringer
theacodeshttps://github.com/theacodes
February 22, 2018 20:25https://github.com/googleapis/google-cloud-python/pull/4915#event-1487807895
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Feb 22, 2018https://github.com/googleapis/google-cloud-python/pull/4915#event-1487807949
Datastore: Allow empty lists in protobuf array value #4778 https://github.com/googleapis/google-cloud-python/pull/4778
Allow empty indexed arrays. #3767 https://github.com/googleapis/google-cloud-python/pull/3767
https://github.com/theacodes
theacodeshttps://github.com/theacodes
Feb 22, 2018 https://github.com/googleapis/google-cloud-python/pull/4915#pullrequestreview-98717198
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/4915/files/3585264ff3a23ecd6005bdca860872972a9ca74a
https://github.com/lukesneeringer
lukesneeringerhttps://github.com/lukesneeringer
Feb 22, 2018 https://github.com/googleapis/google-cloud-python/pull/4915#pullrequestreview-98717259
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/4915/files/3585264ff3a23ecd6005bdca860872972a9ca74a
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
Feb 22, 2018 https://github.com/googleapis/google-cloud-python/pull/4915#pullrequestreview-98727220
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/4915/files/3585264ff3a23ecd6005bdca860872972a9ca74a
https://github.com/tseaver
tseaverhttps://github.com/tseaver
d171166https://github.com/googleapis/google-cloud-python/commit/d171166ae0f4a2362e2a68fe4df7760353e9853a
Feb 22, 2018https://github.com/googleapis/google-cloud-python/pull/4915#event-1487895892
https://github.com/tseaver
tseaverhttps://github.com/tseaver
February 22, 2018 21:15https://github.com/googleapis/google-cloud-python/pull/4915#event-1487896105
partheahttps://github.com/parthea
Nov 24, 2025 https://github.com/googleapis/google-cloud-python/pull/4915#ref-commit-a67525a
https://github.com/tseaver
Don't check 'exclude_from_indexes' for empty lists. (https://github.com/googleapis/google-cloud-python/commit/a67525a20e6bc9884af2c73dcb19f6939e4b5739
#4915https://github.com/googleapis/google-cloud-python/pull/4915
)https://github.com/googleapis/google-cloud-python/commit/a67525a20e6bc9884af2c73dcb19f6939e4b5739
a67525ahttps://github.com/googleapis/google-cloud-python/commit/a67525a20e6bc9884af2c73dcb19f6939e4b5739
#3152https://github.com/googleapis/google-cloud-python/issues/3152
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4915
https://github.com/lukesneeringer
lukesneeringer https://github.com/lukesneeringer
https://github.com/googleapis/google-cloud-python/pull/4915/files/3585264ff3a23ecd6005bdca860872972a9ca74a
https://github.com/theacodes
theacodes https://github.com/theacodes
https://github.com/googleapis/google-cloud-python/pull/4915/files/3585264ff3a23ecd6005bdca860872972a9ca74a
https://github.com/chemelnucfin
chemelnucfin https://github.com/chemelnucfin
https://github.com/googleapis/google-cloud-python/pull/4915/files/3585264ff3a23ecd6005bdca860872972a9ca74a
api: datastore https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20datastore%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
type: bug https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
ValueError: For an array_value, subvalues must either all be indexed or all excluded from indexes. https://github.com/googleapis/google-cloud-python/issues/3152
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4915
https://github.com/tseaver
https://github.com/lukesneeringer
https://github.com/theacodes
https://github.com/chemelnucfin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.