René's URL Explorer Experiment


Title: Datastore: Allow empty lists in protobuf array value by chemelnucfin · Pull Request #4778 · googleapis/google-cloud-python · GitHub

Open Graph Title: Datastore: Allow empty lists in protobuf array value by chemelnucfin · Pull Request #4778 · googleapis/google-cloud-python

X Title: Datastore: Allow empty lists in protobuf array value by chemelnucfin · Pull Request #4778 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: Fixes #3152. @lukesneeringer This was your fix, so I believe you should be able to get me an LGTM soon right? :) @dhermes I would like to ask that you are ok with it since I mostly referred to you...

X Description: Fixes #3152. @lukesneeringer This was your fix, so I believe you should be able to get me an LGTM soon right? :) @dhermes I would like to ask that you are ok with it since I mostly referred to you...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/4778

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:138248c6-ea89-7ce8-3d9f-a458d8bd3022
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9C8:5105D:DC8F56:133DE57:6A4E8EF2
html-safe-noncefb0882fcb6646694fe35c876655b6c5e92f93d220940bf790427891ca164cb37
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUM4OjUxMDVEOkRDOEY1NjoxMzNERTU3OjZBNEU4RUYyIiwidmlzaXRvcl9pZCI6IjcxMjgwOTg2ODMxMDMzODMyODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb77272081fe528949016631e81bf5b287b7927d0a1bea3d1be9aaabc723bf58e
hovercard-subject-tagpull_request:164709632
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/4778/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/368a3785c844967afc4ff1a1ee2ced6e21c3c6982304507528c6460c0dae39a1/googleapis/google-cloud-python/pull/4778
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/368a3785c844967afc4ff1a1ee2ced6e21c3c6982304507528c6460c0dae39a1/googleapis/google-cloud-python/pull/4778
og:image:altFixes #3152. @lukesneeringer This was your fix, so I believe you should be able to get me an LGTM soon right? :) @dhermes I would like to ask that you are ok with it since I mostly referred to you...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechemelnucfin
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/4778#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4778
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4778
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/4778
Reloadhttps://github.com/googleapis/google-cloud-python/pull/4778
Reloadhttps://github.com/googleapis/google-cloud-python/pull/4778
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 441 https://github.com/googleapis/google-cloud-python/issues
Pull requests 139 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
chemelnucfinhttps://github.com/chemelnucfin
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
chemelnucfin:datastore-issue-3152https://github.com/chemelnucfin/google-cloud-python/tree/datastore-issue-3152
Conversationhttps://github.com/googleapis/google-cloud-python/pull/4778
Commits2 (2)https://github.com/googleapis/google-cloud-python/pull/4778/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/4778/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/4778/files
Datastore: Allow empty lists in protobuf array valuehttps://github.com/googleapis/google-cloud-python/pull/4778#top
chemelnucfinhttps://github.com/chemelnucfin
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
chemelnucfin:datastore-issue-3152https://github.com/chemelnucfin/google-cloud-python/tree/datastore-issue-3152
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
Jan 23, 2018https://github.com/googleapis/google-cloud-python/pull/4778#issue-291019469
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
#3152https://github.com/googleapis/google-cloud-python/issues/3152
@lukesneeringerhttps://github.com/lukesneeringer
@dhermeshttps://github.com/dhermes
@tseaverhttps://github.com/tseaver
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
type: bug https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
api: datastore https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20datastore%22
Jan 23, 2018https://github.com/googleapis/google-cloud-python/pull/4778#event-1438397787
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
lukesneeringerhttps://github.com/lukesneeringer
tseaverhttps://github.com/tseaver
dhermeshttps://github.com/dhermes
chemelnucfinhttps://github.com/chemelnucfin
Jan 23, 2018https://github.com/googleapis/google-cloud-python/pull/4778#event-1438397792
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
lukesneeringerhttps://github.com/lukesneeringer
code ownerhttps://github.com/googleapis/google-cloud-python/blob/7641d046cd44578180b15af8d17fea6d0e71311a/.github/CODEOWNERS#L6
January 23, 2018 22:39https://github.com/googleapis/google-cloud-python/pull/4778#event-1438397805
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jan 23, 2018https://github.com/googleapis/google-cloud-python/pull/4778#event-1438397835
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/06c749ecdefc62b707e9e4e1b48d517a51aad84b..ba5739693e115c7bc3f1eb3c8758f93e2f69678c
06c749ehttps://github.com/googleapis/google-cloud-python/commit/06c749ecdefc62b707e9e4e1b48d517a51aad84b
ba57396https://github.com/googleapis/google-cloud-python/commit/ba5739693e115c7bc3f1eb3c8758f93e2f69678c
Compare https://github.com/googleapis/google-cloud-python/compare/06c749ecdefc62b707e9e4e1b48d517a51aad84b..ba5739693e115c7bc3f1eb3c8758f93e2f69678c
January 23, 2018 23:11https://github.com/googleapis/google-cloud-python/pull/4778#event-1438445295
https://github.com/chemelnucfin
Datastore: Allow empty lists in protobuf array valuehttps://github.com/googleapis/google-cloud-python/pull/4778/commits/53c06dc4ec9ab386c7aebf97865a4f9c5d144b75
53c06dchttps://github.com/googleapis/google-cloud-python/pull/4778/commits/53c06dc4ec9ab386c7aebf97865a4f9c5d144b75
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/ba5739693e115c7bc3f1eb3c8758f93e2f69678c..53c06dc4ec9ab386c7aebf97865a4f9c5d144b75
ba57396https://github.com/googleapis/google-cloud-python/commit/ba5739693e115c7bc3f1eb3c8758f93e2f69678c
53c06dchttps://github.com/googleapis/google-cloud-python/commit/53c06dc4ec9ab386c7aebf97865a4f9c5d144b75
Compare https://github.com/googleapis/google-cloud-python/compare/ba5739693e115c7bc3f1eb3c8758f93e2f69678c..53c06dc4ec9ab386c7aebf97865a4f9c5d144b75
January 23, 2018 23:18https://github.com/googleapis/google-cloud-python/pull/4778#event-1438454609
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Jan 23, 2018 https://github.com/googleapis/google-cloud-python/pull/4778#pullrequestreview-91023632
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/4778/files/53c06dc4ec9ab386c7aebf97865a4f9c5d144b75
datastore/tests/unit/test_helpers.pyhttps://github.com/googleapis/google-cloud-python/pull/4778/files/53c06dc4ec9ab386c7aebf97865a4f9c5d144b75#diff-b8da53d61ad4f170684a88dd03c487f82b50b4893924883e5434d5d8d167d634
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4778
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4778
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4778
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
Jan 24, 2018https://github.com/googleapis/google-cloud-python/pull/4778#issuecomment-359975581
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
Jan 26, 2018https://github.com/googleapis/google-cloud-python/pull/4778#issuecomment-360852727
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
@lukesneeringerhttps://github.com/lukesneeringer
@tseaverhttps://github.com/tseaver
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
Jan 26, 2018https://github.com/googleapis/google-cloud-python/pull/4778#issuecomment-360855433
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/291660333a9d5aa1b14fefe0d9fc4f21ff5ef3bf..a0fe60dee927a4e2c3feefa8bb1f09a8af0dd786
2916603https://github.com/googleapis/google-cloud-python/commit/291660333a9d5aa1b14fefe0d9fc4f21ff5ef3bf
a0fe60dhttps://github.com/googleapis/google-cloud-python/commit/a0fe60dee927a4e2c3feefa8bb1f09a8af0dd786
Compare https://github.com/googleapis/google-cloud-python/compare/291660333a9d5aa1b14fefe0d9fc4f21ff5ef3bf..a0fe60dee927a4e2c3feefa8bb1f09a8af0dd786
January 26, 2018 18:02https://github.com/googleapis/google-cloud-python/pull/4778#event-1444074100
https://github.com/chemelnucfin
Review Changeshttps://github.com/googleapis/google-cloud-python/pull/4778/commits/d6c6b9be73b72f9d7cddf46d1d2e71fd9f236b58
d6c6b9bhttps://github.com/googleapis/google-cloud-python/pull/4778/commits/d6c6b9be73b72f9d7cddf46d1d2e71fd9f236b58
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/a0fe60dee927a4e2c3feefa8bb1f09a8af0dd786..d6c6b9be73b72f9d7cddf46d1d2e71fd9f236b58
a0fe60dhttps://github.com/googleapis/google-cloud-python/commit/a0fe60dee927a4e2c3feefa8bb1f09a8af0dd786
d6c6b9bhttps://github.com/googleapis/google-cloud-python/commit/d6c6b9be73b72f9d7cddf46d1d2e71fd9f236b58
Compare https://github.com/googleapis/google-cloud-python/compare/a0fe60dee927a4e2c3feefa8bb1f09a8af0dd786..d6c6b9be73b72f9d7cddf46d1d2e71fd9f236b58
January 26, 2018 18:03https://github.com/googleapis/google-cloud-python/pull/4778#event-1444075568
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
Jan 26, 2018https://github.com/googleapis/google-cloud-python/pull/4778#issuecomment-360859082
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
Feb 8, 2018https://github.com/googleapis/google-cloud-python/pull/4778#issuecomment-363958803
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
https://github.com/chemelnucfin
chemelnucfinhttps://github.com/chemelnucfin
Feb 8, 2018https://github.com/googleapis/google-cloud-python/pull/4778#event-1463584211
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Feb 22, 2018 https://github.com/googleapis/google-cloud-python/pull/4778#ref-pullrequest-299495930
Don't check 'exclude_from_indexes' for empty lists. #4915 https://github.com/googleapis/google-cloud-python/pull/4915
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Feb 22, 2018https://github.com/googleapis/google-cloud-python/pull/4778#issuecomment-367810681
#4915https://github.com/googleapis/google-cloud-python/pull/4915
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
https://github.com/theacodes
theacodeshttps://github.com/theacodes
dhermeshttps://github.com/dhermes
Sep 28, 2018https://github.com/googleapis/google-cloud-python/pull/4778#event-1873932528
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4778
https://github.com/lukesneeringer
lukesneeringer https://github.com/lukesneeringer
https://github.com/tseaver
tseaver https://github.com/tseaver
https://github.com/googleapis/google-cloud-python/pull/4778/files/53c06dc4ec9ab386c7aebf97865a4f9c5d144b75
https://github.com/lukesneeringer
lukesneeringer https://github.com/lukesneeringer
https://github.com/tseaver
tseaver https://github.com/tseaver
https://github.com/chemelnucfin
chemelnucfin https://github.com/chemelnucfin
api: datastore https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20datastore%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
type: bug https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
ValueError: For an array_value, subvalues must either all be indexed or all excluded from indexes. https://github.com/googleapis/google-cloud-python/issues/3152
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4778
https://github.com/chemelnucfin
https://github.com/tseaver
https://github.com/lukesneeringer
https://github.com/dhermes
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.