René's URL Explorer Experiment


Title: Retry whole batch of deletes on 429. by tseaver · Pull Request #4032 · googleapis/google-cloud-python · GitHub

Open Graph Title: Retry whole batch of deletes on 429. by tseaver · Pull Request #4032 · googleapis/google-cloud-python

X Title: Retry whole batch of deletes on 429. by tseaver · Pull Request #4032 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: Because Bucket.delete inside a batch context manager is deferred, we cannot retry it directly. We also need to check for bucket existence, as the bucket may have been deleted successfully in the p...

X Description: Because Bucket.delete inside a batch context manager is deferred, we cannot retry it directly. We also need to check for bucket existence, as the bucket may have been deleted successfully in the p...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/4032

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:eb48431b-4bed-eee7-a91e-a56320e67a0e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF40:ACE33:136F457:1A76EEA:6A4D710D
html-safe-nonce833428e7fd5cf9a2b8d4020b77ecf187b73bd711c2e1bb0f1fb4401498e9ca9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjQwOkFDRTMzOjEzNkY0NTc6MUE3NkVFQTo2QTRENzEwRCIsInZpc2l0b3JfaWQiOiI3MTk5NzA1OTA2ODcwNTc5NDY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac590212d48c23d6527b18ce23348690c4cba25fe272a79441f7a1a8924ff1d3e7
hovercard-subject-tagpull_request:142641158
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/4032/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8b750dbbb3f3a378bf7d52985fc467580ca8513a1ac0e8f9b3ed95fd7258d554/googleapis/google-cloud-python/pull/4032
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8b750dbbb3f3a378bf7d52985fc467580ca8513a1ac0e8f9b3ed95fd7258d554/googleapis/google-cloud-python/pull/4032
og:image:altBecause Bucket.delete inside a batch context manager is deferred, we cannot retry it directly. We also need to check for bucket existence, as the bucket may have been deleted successfully in the p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametseaver
hostnamegithub.com
expected-hostnamegithub.com
Nonec78260c7b3f4ac4b0356c8208537f05406a3a2d46a9ec3f735b372dcc519c39e
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release399fff412f48461d435721c009efc17ea44be72f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/4032#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4032
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4032
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/4032
Reloadhttps://github.com/googleapis/google-cloud-python/pull/4032
Reloadhttps://github.com/googleapis/google-cloud-python/pull/4032
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4032
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 439 https://github.com/googleapis/google-cloud-python/issues
Pull requests 129 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
tseaverhttps://github.com/tseaver
masterhttps://github.com/googleapis/google-cloud-python/tree/master
3761-storage-flaky-systest-cleanuphttps://github.com/googleapis/google-cloud-python/tree/3761-storage-flaky-systest-cleanup
Conversationhttps://github.com/googleapis/google-cloud-python/pull/4032
Commits1 (1)https://github.com/googleapis/google-cloud-python/pull/4032/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/4032/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/4032/files
Retry whole batch of deletes on 429.https://github.com/googleapis/google-cloud-python/pull/4032#top
tseaverhttps://github.com/tseaver
masterhttps://github.com/googleapis/google-cloud-python/tree/master
3761-storage-flaky-systest-cleanuphttps://github.com/googleapis/google-cloud-python/tree/3761-storage-flaky-systest-cleanup
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Sep 22, 2017https://github.com/googleapis/google-cloud-python/pull/4032#issue-259898858
#3761https://github.com/googleapis/google-cloud-python/issues/3761
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4032
https://github.com/tseaver
tseaverhttps://github.com/tseaver
api: storage https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20storage%22
flaky https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Aflaky
Sep 22, 2017https://github.com/googleapis/google-cloud-python/pull/4032#event-1261744381
https://github.com/tseaver
tseaverhttps://github.com/tseaver
dhermeshttps://github.com/dhermes
lukesneeringerhttps://github.com/lukesneeringer
September 22, 2017 18:26https://github.com/googleapis/google-cloud-python/pull/4032#event-1261744388
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Sep 22, 2017https://github.com/googleapis/google-cloud-python/pull/4032#event-1261744432
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Sep 22, 2017https://github.com/googleapis/google-cloud-python/pull/4032#issuecomment-331538126
#4035https://github.com/googleapis/google-cloud-python/issues/4035
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4032
https://github.com/tseaver
Retry whole batch of deletes on 429.https://github.com/googleapis/google-cloud-python/pull/4032/commits/bccc5bce25ed037112234348fc8658ef31f59207
bccc5bchttps://github.com/googleapis/google-cloud-python/pull/4032/commits/bccc5bce25ed037112234348fc8658ef31f59207
#3761https://github.com/googleapis/google-cloud-python/issues/3761
https://github.com/tseaver
tseaverhttps://github.com/tseaver
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/aadbe77b138a14353243a8d4ad33e71cdc608e0c..bccc5bce25ed037112234348fc8658ef31f59207
aadbe77https://github.com/googleapis/google-cloud-python/commit/aadbe77b138a14353243a8d4ad33e71cdc608e0c
bccc5bchttps://github.com/googleapis/google-cloud-python/commit/bccc5bce25ed037112234348fc8658ef31f59207
Compare https://github.com/googleapis/google-cloud-python/compare/aadbe77b138a14353243a8d4ad33e71cdc608e0c..bccc5bce25ed037112234348fc8658ef31f59207
September 25, 2017 15:28https://github.com/googleapis/google-cloud-python/pull/4032#event-1263951722
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Sep 25, 2017https://github.com/googleapis/google-cloud-python/pull/4032#issuecomment-331918234
#4050https://github.com/googleapis/google-cloud-python/pull/4050
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4032
https://github.com/lukesneeringer
lukesneeringerhttps://github.com/lukesneeringer
Sep 25, 2017 https://github.com/googleapis/google-cloud-python/pull/4032#pullrequestreview-65048608
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/4032/files/bccc5bce25ed037112234348fc8658ef31f59207
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Sep 25, 2017https://github.com/googleapis/google-cloud-python/pull/4032#issuecomment-332032204
@tseaverhttps://github.com/tseaver
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4032
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Oct 2, 2017 https://github.com/googleapis/google-cloud-python/pull/4032#ref-pullrequest-262211247
Remove use of batch when cleaning up buckets. #4102 https://github.com/googleapis/google-cloud-python/pull/4102
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Oct 2, 2017https://github.com/googleapis/google-cloud-python/pull/4032#issuecomment-333650431
#4102https://github.com/googleapis/google-cloud-python/pull/4102
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4032
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Oct 2, 2017https://github.com/googleapis/google-cloud-python/pull/4032#event-1274773017
https://github.com/tseaver
tseaverhttps://github.com/tseaver
October 2, 2017 20:11https://github.com/googleapis/google-cloud-python/pull/4032#event-1274773136
tseaverhttps://github.com/tseaver
Oct 2, 2017 https://github.com/googleapis/google-cloud-python/pull/4032#ref-commit-776ed95
https://github.com/tseaver
Remove use of batch when cleaning up buckets. (https://github.com/googleapis/google-cloud-python/commit/776ed95a4e7557dd6f974fc60f06b202406fd378
#4102https://github.com/googleapis/google-cloud-python/pull/4102
)https://github.com/googleapis/google-cloud-python/commit/776ed95a4e7557dd6f974fc60f06b202406fd378
776ed95https://github.com/googleapis/google-cloud-python/commit/776ed95a4e7557dd6f974fc60f06b202406fd378
#4032 (comment)https://github.com/googleapis/google-cloud-python/pull/4032#issuecomment-332032204
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Nov 2, 2017 https://github.com/googleapis/google-cloud-python/pull/4032#ref-issue-248823898
Storage flaky 429 in system tests #3761 https://github.com/googleapis/google-cloud-python/issues/3761
crwilcoxhttps://github.com/crwilcox
Jan 31, 2020 https://github.com/googleapis/google-cloud-python/pull/4032#ref-commit-01d9898
https://github.com/tseaver
Remove use of batch when cleaning up buckets. (#4102)https://github.com/googleapis/python-storage/commit/01d9898b0cce9133310f7bf017009697124eda40
01d9898https://github.com/googleapis/python-storage/commit/01d9898b0cce9133310f7bf017009697124eda40
googleapis/google-cloud-python#4032 (comment)https://github.com/googleapis/google-cloud-python/pull/4032#issuecomment-332032204
cojencohttps://github.com/cojenco
Oct 13, 2021 https://github.com/googleapis/google-cloud-python/pull/4032#ref-commit-f94fb0d
https://github.com/tseaver
https://github.com/cojenco
Remove use of batch when cleaning up buckets. (#4102)https://github.com/cojenco/python-storage/commit/f94fb0db723ac74bc404abaa5492def88595d204
f94fb0dhttps://github.com/cojenco/python-storage/commit/f94fb0db723ac74bc404abaa5492def88595d204
googleapis/google-cloud-python#4032 (comment)https://github.com/googleapis/google-cloud-python/pull/4032#issuecomment-332032204
cojencohttps://github.com/cojenco
Oct 13, 2021 https://github.com/googleapis/google-cloud-python/pull/4032#ref-commit-45cbc46
https://github.com/tseaver
https://github.com/cojenco
Remove use of batch when cleaning up buckets. (#4102)https://github.com/cojenco/python-storage/commit/45cbc46bc06034c55b6a97c9fc02f83bf139262f
45cbc46https://github.com/cojenco/python-storage/commit/45cbc46bc06034c55b6a97c9fc02f83bf139262f
googleapis/google-cloud-python#4032 (comment)https://github.com/googleapis/google-cloud-python/pull/4032#issuecomment-332032204
partheahttps://github.com/parthea
Mar 9, 2026 https://github.com/googleapis/google-cloud-python/pull/4032#ref-commit-503b69a
https://github.com/tseaver
Remove use of batch when cleaning up buckets. (https://github.com/googleapis/google-cloud-python/commit/503b69aa220eccdd3c1f7c87e06782a7e3a284ef
#4102https://github.com/googleapis/google-cloud-python/pull/4102
)https://github.com/googleapis/google-cloud-python/commit/503b69aa220eccdd3c1f7c87e06782a7e3a284ef
503b69ahttps://github.com/googleapis/google-cloud-python/commit/503b69aa220eccdd3c1f7c87e06782a7e3a284ef
#4032 (comment)https://github.com/googleapis/google-cloud-python/pull/4032#issuecomment-332032204
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F4032
https://github.com/dhermes
dhermes https://github.com/dhermes
https://github.com/lukesneeringer
lukesneeringer https://github.com/lukesneeringer
https://github.com/googleapis/google-cloud-python/pull/4032/files/bccc5bce25ed037112234348fc8658ef31f59207
api: storage https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20storage%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/4032
https://github.com/tseaver
https://github.com/dhermes
https://github.com/lukesneeringer
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.