| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:11dc264c-263e-a7d0-b596-313ebf9d0aaf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB20:3D53F4:24584:3053D:6A4D7F73 |
| html-safe-nonce | 27e81c4347628c872c05698aa804dd458d8e38df03d8accc46d79363796b089c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjIwOjNENTNGNDoyNDU4NDozMDUzRDo2QTREN0Y3MyIsInZpc2l0b3JfaWQiOiI4OTQwNDY2MzE4MTI2OTcyNzg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ece24199d964a1a5bceb01575f227f2a20182773be90753baeefeae83dda7eb6 |
| hovercard-subject-tag | pull_request:123515698 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/3463/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/91b8b3d7072bf8c2cedd3ff25c5a5999f27828aaef61235569970687bc5c1c77/googleapis/google-cloud-python/pull/3463 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/91b8b3d7072bf8c2cedd3ff25c5a5999f27828aaef61235569970687bc5c1c77/googleapis/google-cloud-python/pull/3463 |
| og:image:alt | @jonparrott @dhermes
This is what I assert to be a mostly complete publisher for Pub/Sub (minus error checking, which is a pretty big caveat, and tests, which is also a pretty big caveat). I would ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lukesneeringer |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae |
| turbo-cache-control | no-cache |
| go-import | github.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 16316451 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16316451 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6702a58b419a792226bd21ef0fb1bcb318bbcaa3 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/googleapis/google-cloud-python/pull/3463#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python |
| Reload | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Reload | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Reload | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
|
googleapis
| https://github.com/googleapis |
| google-cloud-python | https://github.com/googleapis/google-cloud-python |
|
Notifications
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python |
|
Fork
1.7k
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python |
|
Star
5.3k
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python |
|
Code
| https://github.com/googleapis/google-cloud-python |
|
Issues
439
| https://github.com/googleapis/google-cloud-python/issues |
|
Pull requests
129
| https://github.com/googleapis/google-cloud-python/pulls |
|
Discussions
| https://github.com/googleapis/google-cloud-python/discussions |
|
Actions
| https://github.com/googleapis/google-cloud-python/actions |
|
Projects
| https://github.com/googleapis/google-cloud-python/projects |
|
Security and quality
0
| https://github.com/googleapis/google-cloud-python/security |
|
Insights
| https://github.com/googleapis/google-cloud-python/pulse |
|
Code
| https://github.com/googleapis/google-cloud-python |
|
Issues
| https://github.com/googleapis/google-cloud-python/issues |
|
Pull requests
| https://github.com/googleapis/google-cloud-python/pulls |
|
Discussions
| https://github.com/googleapis/google-cloud-python/discussions |
|
Actions
| https://github.com/googleapis/google-cloud-python/actions |
|
Projects
| https://github.com/googleapis/google-cloud-python/projects |
|
Security and quality
| https://github.com/googleapis/google-cloud-python/security |
|
Insights
| https://github.com/googleapis/google-cloud-python/pulse |
| lukesneeringer | https://github.com/lukesneeringer |
| pubsub | https://github.com/googleapis/google-cloud-python/tree/pubsub |
| pubsub-publisher | https://github.com/googleapis/google-cloud-python/tree/pubsub-publisher |
| Conversation | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Commits44 (44) | https://github.com/googleapis/google-cloud-python/pull/3463/commits |
| Checks | https://github.com/googleapis/google-cloud-python/pull/3463/checks |
| Files changed | https://github.com/googleapis/google-cloud-python/pull/3463/files |
| PubSub Publisher | https://github.com/googleapis/google-cloud-python/pull/3463#top |
| lukesneeringer | https://github.com/lukesneeringer |
| pubsub | https://github.com/googleapis/google-cloud-python/tree/pubsub |
| pubsub-publisher | https://github.com/googleapis/google-cloud-python/tree/pubsub-publisher |
|
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
| Jun 1, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#issue-232901971 |
| @jonparrott | https://github.com/jonparrott |
| @dhermes | https://github.com/dhermes |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| May 25, 2017 07:03 | https://github.com/googleapis/google-cloud-python/pull/3463#commits-pushed-f784121 |
| [WIP] Getting started on Pub/Sub. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/f784121f2ffa06255d7469f68f6c49051d9313d2 |
| f784121 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/f784121f2ffa06255d7469f68f6c49051d9313d2 |
| stuff | https://github.com/googleapis/google-cloud-python/pull/3463/commits/c8a9fd678bd7a9ebbea2b1bd0e65cdf30160ce94 |
| c8a9fd6 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/c8a9fd678bd7a9ebbea2b1bd0e65cdf30160ce94 |
| WIP | https://github.com/googleapis/google-cloud-python/pull/3463/commits/9b09b8fbb0c4b7cc60ff5b26d093fcb00bd5416a |
| 9b09b8f | https://github.com/googleapis/google-cloud-python/pull/3463/commits/9b09b8fbb0c4b7cc60ff5b26d093fcb00bd5416a |
|
| https://github.com/lukesneeringer |
| wip | https://github.com/googleapis/google-cloud-python/pull/3463/commits/8f0832e78405fc79bb2ae867dffdf3a525a95878 |
| 8f0832e | https://github.com/googleapis/google-cloud-python/pull/3463/commits/8f0832e78405fc79bb2ae867dffdf3a525a95878 |
| WIP | https://github.com/googleapis/google-cloud-python/pull/3463/commits/02d7658794dde11098a0d95e6e9ba54aac14c375 |
| 02d7658 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/02d7658794dde11098a0d95e6e9ba54aac14c375 |
| Merge branch 'pubsub' of github.com:GoogleCloudPlatform/google-cloud-… | https://github.com/googleapis/google-cloud-python/pull/3463/commits/3a3ebe99c09977843657c4a282c2bed3159a3d56 |
| 3a3ebe9 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/3a3ebe99c09977843657c4a282c2bed3159a3d56 |
| WIP, fixing bugs. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/503d11f8efa0f7f90a277925d2295e22f1e289e9 |
| 503d11f | https://github.com/googleapis/google-cloud-python/pull/3463/commits/503d11f8efa0f7f90a277925d2295e22f1e289e9 |
| WIP | https://github.com/googleapis/google-cloud-python/pull/3463/commits/3b21b9353fb023d9041e697ef815e729512d72d5 |
| 3b21b93 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/3b21b9353fb023d9041e697ef815e729512d72d5 |
| wip | https://github.com/googleapis/google-cloud-python/pull/3463/commits/1e879a1e8df4fbcbe94c665f4fa9888edf2c9217 |
| 1e879a1 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/1e879a1e8df4fbcbe94c665f4fa9888edf2c9217 |
| wip | https://github.com/googleapis/google-cloud-python/pull/3463/commits/4bf05527681aac2883cb7f2c1b98852efa6647e9 |
| 4bf0552 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/4bf05527681aac2883cb7f2c1b98852efa6647e9 |
| wip | https://github.com/googleapis/google-cloud-python/pull/3463/commits/c6dc098edc1953e6fca84eb70f880da535383ce2 |
| c6dc098 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/c6dc098edc1953e6fca84eb70f880da535383ce2 |
| wip | https://github.com/googleapis/google-cloud-python/pull/3463/commits/13821a77c6524a675c8555faeece7af524157654 |
| 13821a7 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/13821a77c6524a675c8555faeece7af524157654 |
| wip | https://github.com/googleapis/google-cloud-python/pull/3463/commits/c2d7af86460ba59daf3d8a0b1f025c1ce8b78459 |
| c2d7af8 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/c2d7af86460ba59daf3d8a0b1f025c1ce8b78459 |
| Merge branch 'public-master' into pubsub | https://github.com/googleapis/google-cloud-python/pull/3463/commits/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| 4c0bf84 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
|
api: pubsub
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22 |
|
priority: p1
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22priority%3A%20p1%22 |
|
do not merge
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22 |
| Jun 1, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#event-1106175576 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
| Jun 1, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#event-1106175587 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
| dhermes | https://github.com/dhermes |
| theacodes | https://github.com/theacodes |
| June 1, 2017 14:40 | https://github.com/googleapis/google-cloud-python/pull/3463#event-1106175591 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jun 1, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#event-1106176006 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
|
Jun 1, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-41530779 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
|
Jun 1, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-41531148 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
|
Jun 1, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-41532383 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| pubsub/google/cloud/pubsub_v1/publisher/exceptions.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-4175136ad962931af10025c77d06631ecc58647edc83f505b398645e081c3c19 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
|
Jun 1, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-41532751 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| pubsub/google/cloud/pubsub_v1/publisher/future.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-d52667560e21446c128634a8f52056481b4f03d148e33b0f8a16702b051bf63e |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
|
Jun 1, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-41532871 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| pubsub/google/cloud/pubsub_v1/retry.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-b8aa1307402d77407ec6e8c213edfe0ede79e74d8cd907971df8ed0d831bfafa |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
|
Jun 1, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-41532966 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| pubsub/google/cloud/pubsub_v1/subscriber.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-c2fba99a74373136b1e5674338c0cfd60095157023f3b53b527bd8f157ea77d1 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/theacodes |
| theacodes | https://github.com/theacodes |
|
Jun 1, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-41572901 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| pubsub/google/cloud/pubsub_v1/__init__.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-9f87c86bc9ff750f7fa1acc26b22d2d016e378806e1ce421aa0aa6d4eb619810 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/future.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-d52667560e21446c128634a8f52056481b4f03d148e33b0f8a16702b051bf63e |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/dhermes |
| dhermes | https://github.com/dhermes |
|
Jun 1, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-41611670 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52 |
| pubsub/google/cloud/pubsub_v1/_gapic.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1a76a296475b3aa57715ace4e0ca541aea55d29bd2b3316e6be0b16934992f93 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-1bf1747007e186b70b1e66382ed56a2c44dbf4c79b61feb635fffd332c0a6c88 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/client.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/client.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/future.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52#diff-d52667560e21446c128634a8f52056481b4f03d148e33b0f8a16702b051bf63e |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Merge branch 'pubsub' into pubsub-publisher | https://github.com/googleapis/google-cloud-python/pull/3463/commits/783e9dd991d0513e05cb86110ab549de1dbf78d5 |
| 783e9dd | https://github.com/googleapis/google-cloud-python/pull/3463/commits/783e9dd991d0513e05cb86110ab549de1dbf78d5 |
| August 21, 2017 11:25 | https://github.com/googleapis/google-cloud-python/pull/3463#commits-pushed-356749a |
| Improve the max latency thread comments. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/356749a3ae414d3d93f719edff35136b4954b693 |
| 356749a | https://github.com/googleapis/google-cloud-python/pull/3463/commits/356749a3ae414d3d93f719edff35136b4954b693 |
| Collapse property docstrings. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/8242c9de3ae7b932a9d271450f621fac73fd5b2e |
| 8242c9d | https://github.com/googleapis/google-cloud-python/pull/3463/commits/8242c9de3ae7b932a9d271450f621fac73fd5b2e |
| More | https://github.com/googleapis/google-cloud-python/pull/3463/commits/db87dab3de63e967bd8cb81c36691fa920c9ef2d |
| @jonparrott | https://github.com/jonparrott |
| feedback. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/db87dab3de63e967bd8cb81c36691fa920c9ef2d |
| db87dab | https://github.com/googleapis/google-cloud-python/pull/3463/commits/db87dab3de63e967bd8cb81c36691fa920c9ef2d |
| Remove the client as a public item in the base batch. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/58072b8eab2b1ceb120ee4689b348820448b6322 |
| 58072b8 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/58072b8eab2b1ceb120ee4689b348820448b6322 |
| Remove the rejection batch. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/8f6748857e21dbd6f961210259a52e0a4f10913b |
| 8f67488 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/8f6748857e21dbd6f961210259a52e0a4f10913b |
| Lock batch acquisition. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/a86d9b72547c67df3f942f62504a16bee7cad670 |
| a86d9b7 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/a86d9b72547c67df3f942f62504a16bee7cad670 |
| Alter exception superclass. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/df18615c26ba61b5c7dff6915971fb27ebaae06f |
| df18615 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/df18615c26ba61b5c7dff6915971fb27ebaae06f |
| Inherit from google.api.core.future.Future. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/5f0549b02da28f55e681c7471d6a1d4c44b1ce05 |
| 5f0549b | https://github.com/googleapis/google-cloud-python/pull/3463/commits/5f0549b02da28f55e681c7471d6a1d4c44b1ce05 |
| Move to | https://github.com/googleapis/google-cloud-python/pull/3463/commits/101d9ca9c73db80f29c63745fa79975122234f3e |
| @jonparrott | https://github.com/jonparrott |
| 's Future interface. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/101d9ca9c73db80f29c63745fa79975122234f3e |
| 101d9ca | https://github.com/googleapis/google-cloud-python/pull/3463/commits/101d9ca9c73db80f29c63745fa79975122234f3e |
| Move Future off into its own module. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/e6e58bb45e680cd6b8c1a3a1e035e389c524f72a |
| e6e58bb | https://github.com/googleapis/google-cloud-python/pull/3463/commits/e6e58bb45e680cd6b8c1a3a1e035e389c524f72a |
| Add is not None. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/9fd490c819f1060d9814d4610b67901087b3d9d6 |
| 9fd490c | https://github.com/googleapis/google-cloud-python/pull/3463/commits/9fd490c819f1060d9814d4610b67901087b3d9d6 |
| https://github.com/theacodes |
| theacodes | https://github.com/theacodes |
|
Aug 22, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-57832915 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/9fd490c819f1060d9814d4610b67901087b3d9d6 |
| theacodes | https://github.com/theacodes |
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-57832915 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch/base.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/9a6b7cba8c7d7f1515709afc096851064e891dbd#diff-97b7be9aeafd13453c8423726aeffba043a72134ea557b316e9b8ecb9125b484 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch/base.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/1a53c3767aec30df1c6483aeec8d1b5d063f4f32#diff-97b7be9aeafd13453c8423726aeffba043a72134ea557b316e9b8ecb9125b484 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch/base.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/9fd490c819f1060d9814d4610b67901087b3d9d6#diff-97b7be9aeafd13453c8423726aeffba043a72134ea557b316e9b8ecb9125b484 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch/thread.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/9fd490c819f1060d9814d4610b67901087b3d9d6#diff-bc19f0a9fa85ba987ac37ca90ff132859130bdf88cdf01f41bea957d9694280a |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/batch/thread.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/9a6b7cba8c7d7f1515709afc096851064e891dbd#diff-bc19f0a9fa85ba987ac37ca90ff132859130bdf88cdf01f41bea957d9694280a |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/client.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/9fd490c819f1060d9814d4610b67901087b3d9d6#diff-d5cbcf0b8d5fcc9e0cb72d127515c73e97d32c5e48fba23ef8a13cec70474d97 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/exceptions.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/9fd490c819f1060d9814d4610b67901087b3d9d6#diff-4175136ad962931af10025c77d06631ecc58647edc83f505b398645e081c3c19 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/futures.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/9fd490c819f1060d9814d4610b67901087b3d9d6#diff-84a8c45fb65a219409ddfd8c65ea841945ec84e66c709bb7f6d89c96f18d4f59 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/publisher/futures.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/9fd490c819f1060d9814d4610b67901087b3d9d6#diff-84a8c45fb65a219409ddfd8c65ea841945ec84e66c709bb7f6d89c96f18d4f59 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| pubsub/google/cloud/pubsub_v1/types.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/9a6b7cba8c7d7f1515709afc096851064e891dbd#diff-2cfbf7a874c69240d6b0d1886a70ad251b61bceeaf008af18560d667589400dc |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| August 22, 2017 10:31 | https://github.com/googleapis/google-cloud-python/pull/3463#commits-pushed-469400e |
| Feedback. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/469400edd5b12d1e33c6df53656001e3fdd02d88 |
| 469400e | https://github.com/googleapis/google-cloud-python/pull/3463/commits/469400edd5b12d1e33c6df53656001e3fdd02d88 |
| #3463 (comment) | https://github.com/googleapis/google-cloud-python/pull/3463#discussion_r134532103 |
| Use concurrent.futures.TimeoutError where possible. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/31c0c81cb89c2b9ae51072a9d272be2fa61c57a8 |
| 31c0c81 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/31c0c81cb89c2b9ae51072a9d272be2fa61c57a8 |
| Add a lock on commit to ensure no duplication. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/04ac2782694b6b4ee16b394bf8ad50da373616e9 |
| 04ac278 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/04ac2782694b6b4ee16b394bf8ad50da373616e9 |
| Move to an Event. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/37ee9086337589a90f1c922d5a1218eb342a600b |
| 37ee908 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/37ee9086337589a90f1c922d5a1218eb342a600b |
| Make _names private. | https://github.com/googleapis/google-cloud-python/pull/3463/commits/12d44be6806a13e76a5ab41c4ea7f74681fe31f0 |
| 12d44be | https://github.com/googleapis/google-cloud-python/pull/3463/commits/12d44be6806a13e76a5ab41c4ea7f74681fe31f0 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
| Aug 22, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#issuecomment-324139349 |
| @jonparrott | https://github.com/jonparrott |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/theacodes |
| theacodes | https://github.com/theacodes |
| Aug 22, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#issuecomment-324139996 |
| @jonparrott | https://github.com/jonparrott |
| I answered | https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3463/files/9fd490c819f1060d9814d4610b67901087b3d9d6#r134548120 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
| Aug 22, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#issuecomment-324176700 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
| Aug 22, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#issuecomment-324176746 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/theacodes |
| theacodes | https://github.com/theacodes |
| Aug 22, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#issuecomment-324178289 |
| https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3463/files#r134590605 | https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3463/files#r134590605 |
| https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3463/files#r134535130 | https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3463/files#r134535130 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/theacodes |
| theacodes | https://github.com/theacodes |
|
Aug 22, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-57938526 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/12d44be6806a13e76a5ab41c4ea7f74681fe31f0 |
|
| https://github.com/lukesneeringer |
| Pubsub subscriber ( | https://github.com/googleapis/google-cloud-python/pull/3463/commits/6fe13095c6c66ae65a5be2e78593e8e2dd56fe53 |
| #3637 | https://github.com/googleapis/google-cloud-python/pull/3637 |
| ) | https://github.com/googleapis/google-cloud-python/pull/3463/commits/6fe13095c6c66ae65a5be2e78593e8e2dd56fe53 |
| 6fe1309 | https://github.com/googleapis/google-cloud-python/pull/3463/commits/6fe13095c6c66ae65a5be2e78593e8e2dd56fe53 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
| Aug 24, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#issuecomment-324525293 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
| 6bf3359 | https://github.com/googleapis/google-cloud-python/commit/6bf3359df49288ba96e89eec7e3684d2be110be4 |
| Aug 24, 2017 | https://github.com/googleapis/google-cloud-python/pull/3463#event-1219017362 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
| August 24, 2017 03:49 | https://github.com/googleapis/google-cloud-python/pull/3463#event-1219017393 |
| https://github.com/lukesneeringer |
| lukesneeringer | https://github.com/lukesneeringer |
|
Aug 24, 2017
| https://github.com/googleapis/google-cloud-python/pull/3463#ref-pullrequest-252479736 |
|
Pub/Sub API Redesign
#3859
| https://github.com/googleapis/google-cloud-python/pull/3859 |
| https://github.com/plamut |
| plamut | https://github.com/plamut |
|
Dec 22, 2021
| https://github.com/googleapis/google-cloud-python/pull/3463#pullrequestreview-838522442 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-python/pull/3463/files/6fe13095c6c66ae65a5be2e78593e8e2dd56fe53 |
| pubsub/google/cloud/pubsub_v1/_gapic.py | https://github.com/googleapis/google-cloud-python/pull/3463/files/6fe13095c6c66ae65a5be2e78593e8e2dd56fe53#diff-1a76a296475b3aa57715ace4e0ca541aea55d29bd2b3316e6be0b16934992f93 |
| plamut | https://github.com/plamut |
| Dec 22, 2021 | https://github.com/googleapis/google-cloud-python/pull/3463#discussion_r773935086 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @lukesneeringer | https://github.com/lukesneeringer |
| @theacodes | https://github.com/theacodes |
| @dhermes | https://github.com/dhermes |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
| parthea | https://github.com/parthea |
|
Oct 21, 2023
| https://github.com/googleapis/google-cloud-python/pull/3463#ref-commit-417789f |
|
| https://github.com/renovate-bot |
|
| https://github.com/busunkim96 |
| chore(deps): update dependency cryptography to v2.9.1 [( | https://github.com/googleapis/google-cloud-python/commit/417789fc7001c55704bac820fbf9ced06b98592f |
| #3463 | https://github.com/googleapis/google-cloud-python/pull/3463 |
| )]( | https://github.com/googleapis/google-cloud-python/commit/417789fc7001c55704bac820fbf9ced06b98592f |
| Googl… | https://github.com/GoogleCloudPlatform/python-docs-samples/pull/3463 |
| 417789f | https://github.com/googleapis/google-cloud-python/commit/417789fc7001c55704bac820fbf9ced06b98592f |
| …eCloudPlatform/python-docs-samples#3463 | https://github.com/GoogleCloudPlatform/python-docs-samples/pull/3463 |
| https://github.co/hiddenchars |
| https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3463 |
|
| https://github.com/dhermes |
|
dhermes
| https://github.com/dhermes |
|
| https://github.com/googleapis/google-cloud-python/pull/3463/files/4c0bf846debf1d03c7d033cb8444996921a69a52 |
|
| https://github.com/plamut |
|
plamut
| https://github.com/plamut |
|
| https://github.com/googleapis/google-cloud-python/pull/3463/files/6fe13095c6c66ae65a5be2e78593e8e2dd56fe53 |
|
| https://github.com/mdietz94 |
|
mdietz94
| https://github.com/mdietz94 |
|
| https://github.com/googleapis/google-cloud-python/pull/3463/files/1a53c3767aec30df1c6483aeec8d1b5d063f4f32 |
|
| https://github.com/tbkneeland |
|
tbkneeland
| https://github.com/tbkneeland |
|
| https://github.com/googleapis/google-cloud-python/pull/3463/files/1a53c3767aec30df1c6483aeec8d1b5d063f4f32 |
|
| https://github.com/theacodes |
|
theacodes
| https://github.com/theacodes |
|
| https://github.com/googleapis/google-cloud-python/pull/3463/files/12d44be6806a13e76a5ab41c4ea7f74681fe31f0 |
|
| https://github.com/lukesneeringer |
|
lukesneeringer
| https://github.com/lukesneeringer |
|
api: pubsub
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22 |
|
cla: yes
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
do not merge
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22 |
|
priority: p1
| https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22priority%3A%20p1%22 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/3463 |
|
| https://github.com/lukesneeringer |
|
| https://github.com/tseaver |
|
| https://github.com/theacodes |
|
| https://github.com/dhermes |
|
| https://github.com/plamut |
|
| https://github.com/mdietz94 |
|
| https://github.com/tbkneeland |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |