René's URL Explorer Experiment


Title: Overhaul logging background thread transport by theacodes · Pull Request #3407 · googleapis/google-cloud-python · GitHub

Open Graph Title: Overhaul logging background thread transport by theacodes · Pull Request #3407 · googleapis/google-cloud-python

X Title: Overhaul logging background thread transport by theacodes · Pull Request #3407 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/3407

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bfa57755-7588-bf69-512d-a3b9cbfc6ac3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD32:C5A49:55CDAE:74921B:6A4DCBF5
html-safe-nonce4cb7b480c2659daf7df885cf77836593a7751a87616c9d6bb6ed1ba4943db08e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDMyOkM1QTQ5OjU1Q0RBRTo3NDkyMUI6NkE0RENCRjUiLCJ2aXNpdG9yX2lkIjoiNDk1NDU1MTQzNDA4OTQ1MDQ4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca741ca84611252f86bec14c6e012280649e6f7500cb4eb010d8b6a11119a1f93
hovercard-subject-tagpull_request:120247439
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/3407/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/586963e32089c23d19ba6e6474f8ada44376a44a01a9a076a46176a52a2c4373/googleapis/google-cloud-python/pull/3407
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/586963e32089c23d19ba6e6474f8ada44376a44a01a9a076a46176a52a2c4373/googleapis/google-cloud-python/pull/3407
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametheacodes
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/3407#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/3407
Reloadhttps://github.com/googleapis/google-cloud-python/pull/3407
Reloadhttps://github.com/googleapis/google-cloud-python/pull/3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 439 https://github.com/googleapis/google-cloud-python/issues
Pull requests 131 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
theacodeshttps://github.com/theacodes
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
theacodes:new-background-threadhttps://github.com/theacodes/google-cloud-python/tree/new-background-thread
Conversationhttps://github.com/googleapis/google-cloud-python/pull/3407
Commits6 (6)https://github.com/googleapis/google-cloud-python/pull/3407/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/3407/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/3407/files
Overhaul logging background thread transporthttps://github.com/googleapis/google-cloud-python/pull/3407#top
theacodeshttps://github.com/theacodes
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
theacodes:new-background-threadhttps://github.com/theacodes/google-cloud-python/tree/new-background-thread
https://github.com/theacodes
theacodeshttps://github.com/theacodes
May 12, 2017https://github.com/googleapis/google-cloud-python/pull/3407#issue-228185944
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Overhaul logging background thread transporthttps://github.com/googleapis/google-cloud-python/pull/3407/commits/8d4a07d506279a3834acde8cdcd1b0736a4b5c65
8d4a07dhttps://github.com/googleapis/google-cloud-python/pull/3407/commits/8d4a07d506279a3834acde8cdcd1b0736a4b5c65
https://github.com/theacodes
theacodeshttps://github.com/theacodes
api: logging https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22
May 12, 2017https://github.com/googleapis/google-cloud-python/pull/3407#event-1079375148
https://github.com/theacodes
theacodeshttps://github.com/theacodes
dhermeshttps://github.com/dhermes
lukesneeringerhttps://github.com/lukesneeringer
waprinhttps://github.com/waprin
May 12, 2017 04:36https://github.com/googleapis/google-cloud-python/pull/3407#event-1079375153
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 12, 2017https://github.com/googleapis/google-cloud-python/pull/3407#event-1079375182
May 11, 2017 21:38https://github.com/googleapis/google-cloud-python/pull/3407#commits-pushed-3c94f68
Remove stray printhttps://github.com/googleapis/google-cloud-python/pull/3407/commits/3c94f68170025d51ef9228eda1ae0f085a2c9166
3c94f68https://github.com/googleapis/google-cloud-python/pull/3407/commits/3c94f68170025d51ef9228eda1ae0f085a2c9166
Remove now-unused importhttps://github.com/googleapis/google-cloud-python/pull/3407/commits/3462c13dbe6f3792681bfce721495c07074f91c5
3462c13https://github.com/googleapis/google-cloud-python/pull/3407/commits/3462c13dbe6f3792681bfce721495c07074f91c5
https://github.com/duggelz
duggelzhttps://github.com/duggelz
May 12, 2017 https://github.com/googleapis/google-cloud-python/pull/3407#pullrequestreview-37891169
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/3407/files/3462c13dbe6f3792681bfce721495c07074f91c5
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/3462c13dbe6f3792681bfce721495c07074f91c5#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
https://github.com/duggelz
duggelzhttps://github.com/duggelz
May 12, 2017 https://github.com/googleapis/google-cloud-python/pull/3407#pullrequestreview-37891369
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/3407/files/3462c13dbe6f3792681bfce721495c07074f91c5
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/3462c13dbe6f3792681bfce721495c07074f91c5#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
https://github.com/duggelz
duggelzhttps://github.com/duggelz
May 12, 2017 https://github.com/googleapis/google-cloud-python/pull/3407#pullrequestreview-37891800
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/3407/files/3462c13dbe6f3792681bfce721495c07074f91c5
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/3462c13dbe6f3792681bfce721495c07074f91c5#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Address dgreiman's commentshttps://github.com/googleapis/google-cloud-python/pull/3407/commits/40626e30d14faaf4636b1d86ba51ee808940a5b1
40626e3https://github.com/googleapis/google-cloud-python/pull/3407/commits/40626e30d14faaf4636b1d86ba51ee808940a5b1
https://github.com/dhermes
dhermeshttps://github.com/dhermes
May 12, 2017 https://github.com/googleapis/google-cloud-python/pull/3407#pullrequestreview-37903005
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1
logging/google/cloud/logging/handlers/handlers.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-8f959a8a16c5196845a683ee3cd32410e4a95ef4d0bc6db6a61587105168645a
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Address dhermes reviewhttps://github.com/googleapis/google-cloud-python/pull/3407/commits/b373f5eb140a3d818b8fe6d58684d71ce46d3265
b373f5ehttps://github.com/googleapis/google-cloud-python/pull/3407/commits/b373f5eb140a3d818b8fe6d58684d71ce46d3265
https://github.com/theacodes
theacodeshttps://github.com/theacodes
May 12, 2017 https://github.com/googleapis/google-cloud-python/pull/3407#pullrequestreview-37919686
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1
theacodeshttps://github.com/theacodes
https://github.com/googleapis/google-cloud-python/pull/3407#pullrequestreview-37919686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@dhermeshttps://github.com/dhermes
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/handlers.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-8f959a8a16c5196845a683ee3cd32410e4a95ef4d0bc6db6a61587105168645a
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
https://github.com/waprin
waprinhttps://github.com/waprin
May 12, 2017https://github.com/googleapis/google-cloud-python/pull/3407#issuecomment-301168324
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
https://github.com/theacodes
theacodeshttps://github.com/theacodes
May 12, 2017https://github.com/googleapis/google-cloud-python/pull/3407#issuecomment-301171121
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
https://github.com/dhermes
dhermeshttps://github.com/dhermes
May 12, 2017 https://github.com/googleapis/google-cloud-python/pull/3407#pullrequestreview-37931183
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/3407/files/b373f5eb140a3d818b8fe6d58684d71ce46d3265
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1..b373f5eb140a3d818b8fe6d58684d71ce46d3265#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1..b373f5eb140a3d818b8fe6d58684d71ce46d3265#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1..b373f5eb140a3d818b8fe6d58684d71ce46d3265#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1..b373f5eb140a3d818b8fe6d58684d71ce46d3265#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/google/cloud/logging/handlers/transports/background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1..b373f5eb140a3d818b8fe6d58684d71ce46d3265#diff-efecafa3a6fe5371373d304a5152a6a9ce422c2743b516df157c46c95c5db51e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
logging/tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/google-cloud-python/pull/3407/files/40626e30d14faaf4636b1d86ba51ee808940a5b1..b373f5eb140a3d818b8fe6d58684d71ce46d3265#diff-72a0bd366af5a026f9b3b2bfbdd440a61bdcb83b323f66d264837ab3ada10f63
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
Address dhermes review round 2https://github.com/googleapis/google-cloud-python/pull/3407/commits/b73ecf4dffdf4a15604105954f47f690c857f9d0
b73ecf4https://github.com/googleapis/google-cloud-python/pull/3407/commits/b73ecf4dffdf4a15604105954f47f690c857f9d0
https://github.com/dhermes
dhermeshttps://github.com/dhermes
May 12, 2017https://github.com/googleapis/google-cloud-python/pull/3407#issuecomment-301178316
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
https://github.com/theacodes
theacodeshttps://github.com/theacodes
a623929https://github.com/googleapis/google-cloud-python/commit/a623929ce3c2ff762752fa3f06599c8f58476697
May 12, 2017https://github.com/googleapis/google-cloud-python/pull/3407#event-1080615688
https://github.com/theacodes
theacodeshttps://github.com/theacodes
May 12, 2017 20:30https://github.com/googleapis/google-cloud-python/pull/3407#event-1080615747
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Jun 26, 2017 https://github.com/googleapis/google-cloud-python/pull/3407#ref-pullrequest-238596759
Prep logging-1.1.0 release. #3528 https://github.com/googleapis/google-cloud-python/pull/3528
https://github.com/waprin
waprinhttps://github.com/waprin
Jan 5, 2018 https://github.com/googleapis/google-cloud-python/pull/3407#ref-issue-271235608
Failed to submit logs #4346 https://github.com/googleapis/google-cloud-python/issues/4346
partheahttps://github.com/parthea
Nov 24, 2025 https://github.com/googleapis/google-cloud-python/pull/3407#ref-commit-ae57a13
Overhaul logging background thread transport (https://github.com/googleapis/google-cloud-python/commit/ae57a13b649531fb40ca29bc0e44f40bea4e617d
#3407https://github.com/googleapis/google-cloud-python/pull/3407
)https://github.com/googleapis/google-cloud-python/commit/ae57a13b649531fb40ca29bc0e44f40bea4e617d
ae57a13https://github.com/googleapis/google-cloud-python/commit/ae57a13b649531fb40ca29bc0e44f40bea4e617d
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3407
https://github.com/lukesneeringer
lukesneeringer https://github.com/lukesneeringer
https://github.com/waprin
waprin https://github.com/waprin
https://github.com/dhermes
dhermes https://github.com/dhermes
https://github.com/googleapis/google-cloud-python/pull/3407/files/b373f5eb140a3d818b8fe6d58684d71ce46d3265
https://github.com/duggelz
duggelz https://github.com/duggelz
https://github.com/googleapis/google-cloud-python/pull/3407/files/3462c13dbe6f3792681bfce721495c07074f91c5
api: logging https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3407
https://github.com/theacodes
https://github.com/waprin
https://github.com/dhermes
https://github.com/duggelz
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.