René's URL Explorer Experiment


Title: Drop usage of overly broad mock.Mock() in tests. by dhermes · Pull Request #3063 · googleapis/google-cloud-python · GitHub

Open Graph Title: Drop usage of overly broad mock.Mock() in tests. by dhermes · Pull Request #3063 · googleapis/google-cloud-python

X Title: Drop usage of overly broad mock.Mock() in tests. by dhermes · Pull Request #3063 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: @lukesneeringer @tseaver any ideas on an easy "lint"-like check that will scream if people create a Mock() without a spec? SIDEBAR: The error reporting unit tests are in a very bad state....

X Description: @lukesneeringer @tseaver any ideas on an easy "lint"-like check that will scream if people create a Mock() without a spec? SIDEBAR: The error reporting unit tests are in a very ba...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/3063

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e8127f6a-f414-2721-de0d-2774163fb8f2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA012:9FE98:3D50ED:578F8B:6A4E6D8C
html-safe-noncec44f449faeb11960f5d47a256d50506a0130624a836373a6d205b4b27e342f61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDEyOjlGRTk4OjNENTBFRDo1NzhGOEI6NkE0RTZEOEMiLCJ2aXNpdG9yX2lkIjoiMjA1OTQzMzAzMjA1NDM2OTY3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ee2b59470589bb3368b47b84410f3a946d87fdde881505d65aea813e481cbde
hovercard-subject-tagpull_request:107722090
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/3063/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3735228b8b90249e48662141e32fe71b96b5fefb2dd5dbd0458db363c6861578/googleapis/google-cloud-python/pull/3063
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3735228b8b90249e48662141e32fe71b96b5fefb2dd5dbd0458db363c6861578/googleapis/google-cloud-python/pull/3063
og:image:alt@lukesneeringer @tseaver any ideas on an easy "lint"-like check that will scream if people create a Mock() without a spec? SIDEBAR: The error reporting unit tests are in a very bad state....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedhermes
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/3063#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3063
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3063
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/3063
Reloadhttps://github.com/googleapis/google-cloud-python/pull/3063
Reloadhttps://github.com/googleapis/google-cloud-python/pull/3063
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 440 https://github.com/googleapis/google-cloud-python/issues
Pull requests 142 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
dhermeshttps://github.com/dhermes
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
dhermes:make-mocks-less-broadhttps://github.com/dhermes/google-cloud-python/tree/make-mocks-less-broad
Conversationhttps://github.com/googleapis/google-cloud-python/pull/3063
Commits3 (3)https://github.com/googleapis/google-cloud-python/pull/3063/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/3063/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/3063/files
Drop usage of overly broad mock.Mock() in tests.https://github.com/googleapis/google-cloud-python/pull/3063#top
dhermeshttps://github.com/dhermes
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
dhermes:make-mocks-less-broadhttps://github.com/dhermes/google-cloud-python/tree/make-mocks-less-broad
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Feb 23, 2017https://github.com/googleapis/google-cloud-python/pull/3063#issue-209896689
@lukesneeringerhttps://github.com/lukesneeringer
@tseaverhttps://github.com/tseaver
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
https://github.com/dhermes
dhermeshttps://github.com/dhermes
api: clouderrorreporting https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20clouderrorreporting%22
api: logging https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22
api: vision https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20vision%22
hygiene https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Ahygiene
Feb 23, 2017https://github.com/googleapis/google-cloud-python/pull/3063#event-975164889
https://github.com/dhermes
dhermeshttps://github.com/dhermes
lukesneeringerhttps://github.com/lukesneeringer
daspecsterhttps://github.com/daspecster
tseaverhttps://github.com/tseaver
Feb 23, 2017https://github.com/googleapis/google-cloud-python/pull/3063#event-975164904
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Feb 23, 2017https://github.com/googleapis/google-cloud-python/pull/3063#event-975164947
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Feb 23, 2017 https://github.com/googleapis/google-cloud-python/pull/3063#pullrequestreview-23598991
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/3063/files
error_reporting/google/cloud/error_reporting/_gax.pyhttps://github.com/googleapis/google-cloud-python/pull/3063/files#diff-c8f48e64ba35126c55f4a4386ec2c90b8af44c4ba53dd5783d388720c38c7e57
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3063
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
https://github.com/daspecster
daspecsterhttps://github.com/daspecster
Feb 23, 2017https://github.com/googleapis/google-cloud-python/pull/3063#issuecomment-282138457
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Feb 23, 2017https://github.com/googleapis/google-cloud-python/pull/3063#issuecomment-282139808
@daspecsterhttps://github.com/daspecster
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Feb 26, 2017 https://github.com/googleapis/google-cloud-python/pull/3063#ref-pullrequest-210335888
Passing along client instead of project when creating error API. #3075 https://github.com/googleapis/google-cloud-python/pull/3075
https://github.com/waprin
waprinhttps://github.com/waprin
Feb 27, 2017https://github.com/googleapis/google-cloud-python/pull/3063#issuecomment-282806375
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
dhermeshttps://github.com/dhermes
March 1, 2017 15:26https://github.com/googleapis/google-cloud-python/pull/3063#commits-pushed-80ec376
https://github.com/dhermes
Removing mock.Mock() in error reporting.https://github.com/googleapis/google-cloud-python/pull/3063/commits/80ec376ef1b193331b4c2c32cc2a79bc151e742f
80ec376https://github.com/googleapis/google-cloud-python/pull/3063/commits/80ec376ef1b193331b4c2c32cc2a79bc151e742f
googleapis#3057https://github.com/googleapis/google-cloud-python/pull/3057
https://github.com/dhermes
Removing overly broad mock.Mock() in logging.https://github.com/googleapis/google-cloud-python/pull/3063/commits/09ae157f187946b54fd006a7361c0b28de6fc65a
09ae157https://github.com/googleapis/google-cloud-python/pull/3063/commits/09ae157f187946b54fd006a7361c0b28de6fc65a
https://github.com/dhermes
Removing overly broad mock.Mock() in vision.https://github.com/googleapis/google-cloud-python/pull/3063/commits/c8e8a49b041f07d5adcd746bef76e430ffafc468
c8e8a49https://github.com/googleapis/google-cloud-python/pull/3063/commits/c8e8a49b041f07d5adcd746bef76e430ffafc468
https://github.com/dhermes
dhermeshttps://github.com/dhermes
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/f4c9830c7dae2a678d4b015014ecf94d988d9e0f..c8e8a49b041f07d5adcd746bef76e430ffafc468
f4c9830https://github.com/googleapis/google-cloud-python/commit/f4c9830c7dae2a678d4b015014ecf94d988d9e0f
c8e8a49https://github.com/googleapis/google-cloud-python/commit/c8e8a49b041f07d5adcd746bef76e430ffafc468
Compare https://github.com/googleapis/google-cloud-python/compare/f4c9830c7dae2a678d4b015014ecf94d988d9e0f..c8e8a49b041f07d5adcd746bef76e430ffafc468
March 1, 2017 23:26https://github.com/googleapis/google-cloud-python/pull/3063#event-982796673
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Mar 1, 2017https://github.com/googleapis/google-cloud-python/pull/3063#issuecomment-283511410
https://cloud.githubusercontent.com/assets/520669/23486906/a26eb2a4-fe97-11e6-96a4-5e4bb4f68bf7.png
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
https://github.com/dhermes
dhermeshttps://github.com/dhermes
17ac87fhttps://github.com/googleapis/google-cloud-python/commit/17ac87f0104a01141e2770035e85c78499e10022
Mar 1, 2017https://github.com/googleapis/google-cloud-python/pull/3063#event-982828351
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Mar 1, 2017https://github.com/googleapis/google-cloud-python/pull/3063#issuecomment-283511539
@daspecsterhttps://github.com/daspecster
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
https://github.com/dhermes
dhermeshttps://github.com/dhermes
March 1, 2017 23:57https://github.com/googleapis/google-cloud-python/pull/3063#event-982829018
https://github.com/lukesneeringer
lukesneeringerhttps://github.com/lukesneeringer
Mar 2, 2017https://github.com/googleapis/google-cloud-python/pull/3063#issuecomment-283799285
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
richkadelhttps://github.com/richkadel
May 6, 2017 https://github.com/googleapis/google-cloud-python/pull/3063#ref-commit-770a821
https://github.com/dhermes
Merge pull requesthttps://github.com/richkadel/google-cloud-python/commit/770a8217124de090271c082c48c7d220feaf4018
googleapis#3063https://github.com/googleapis/google-cloud-python/pull/3063
from dhermes/make-mocks-less-broadhttps://github.com/richkadel/google-cloud-python/commit/770a8217124de090271c082c48c7d220feaf4018
770a821https://github.com/richkadel/google-cloud-python/commit/770a8217124de090271c082c48c7d220feaf4018
https://github.com/theacodes
theacodeshttps://github.com/theacodes
daspecsterhttps://github.com/daspecster
Sep 28, 2018https://github.com/googleapis/google-cloud-python/pull/3063#event-1873929208
partheahttps://github.com/parthea
Oct 21, 2023 https://github.com/googleapis/google-cloud-python/pull/3063#ref-commit-c3b1796
https://github.com/renovate-bot
https://github.com/busunkim96
chore(deps): update dependency google-cloud-asset to v0.8.0 [(https://github.com/googleapis/google-cloud-python/commit/c3b17961916b16e0ed81cd4c082f9f1b79a347a4
#3063https://github.com/googleapis/google-cloud-python/pull/3063
)](https://github.com/googleapis/google-cloud-python/commit/c3b17961916b16e0ed81cd4c082f9f1b79a347a4
G…https://github.com/GoogleCloudPlatform/python-docs-samples/pull/3063
c3b1796https://github.com/googleapis/google-cloud-python/commit/c3b17961916b16e0ed81cd4c082f9f1b79a347a4
…oogleCloudPlatform/python-docs-samples#3063https://github.com/GoogleCloudPlatform/python-docs-samples/pull/3063
partheahttps://github.com/parthea
Oct 21, 2023 https://github.com/googleapis/google-cloud-python/pull/3063#ref-commit-1fc849a
https://github.com/dhermes
Merge pull requesthttps://github.com/googleapis/google-cloud-python/commit/1fc849a9181763a8cb85be16e3bdf73152fbde2f
#3063https://github.com/googleapis/google-cloud-python/pull/3063
from dhermes/make-mocks-less-broadhttps://github.com/googleapis/google-cloud-python/commit/1fc849a9181763a8cb85be16e3bdf73152fbde2f
1fc849ahttps://github.com/googleapis/google-cloud-python/commit/1fc849a9181763a8cb85be16e3bdf73152fbde2f
partheahttps://github.com/parthea
Nov 24, 2025 https://github.com/googleapis/google-cloud-python/pull/3063#ref-commit-a45634c
https://github.com/dhermes
Merge pull requesthttps://github.com/googleapis/google-cloud-python/commit/a45634c776b9a25feee9f687bb51f34bdc412303
#3063https://github.com/googleapis/google-cloud-python/pull/3063
from dhermes/make-mocks-less-broadhttps://github.com/googleapis/google-cloud-python/commit/a45634c776b9a25feee9f687bb51f34bdc412303
a45634chttps://github.com/googleapis/google-cloud-python/commit/a45634c776b9a25feee9f687bb51f34bdc412303
partheahttps://github.com/parthea
Nov 24, 2025 https://github.com/googleapis/google-cloud-python/pull/3063#ref-commit-e5ec020
https://github.com/dhermes
Merge pull requesthttps://github.com/googleapis/google-cloud-python/commit/e5ec020e51c892b30dd17a3f9a3a6fa94fe86609
#3063https://github.com/googleapis/google-cloud-python/pull/3063
from dhermes/make-mocks-less-broadhttps://github.com/googleapis/google-cloud-python/commit/e5ec020e51c892b30dd17a3f9a3a6fa94fe86609
e5ec020https://github.com/googleapis/google-cloud-python/commit/e5ec020e51c892b30dd17a3f9a3a6fa94fe86609
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F3063
https://github.com/lukesneeringer
lukesneeringer https://github.com/lukesneeringer
https://github.com/tseaver
tseaver https://github.com/tseaver
api: clouderrorreporting https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20clouderrorreporting%22
api: logging https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22
api: vision https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20vision%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/3063
https://github.com/dhermes
https://github.com/daspecster
https://github.com/waprin
https://github.com/lukesneeringer
https://github.com/tseaver
https://github.com/danoscarmike
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.