René's URL Explorer Experiment


Title: Use MessageToDict in logging._gax by dhermes · Pull Request #2600 · googleapis/google-cloud-python · GitHub

Open Graph Title: Use MessageToDict in logging._gax by dhermes · Pull Request #2600 · googleapis/google-cloud-python

X Title: Use MessageToDict in logging._gax by dhermes · Pull Request #2600 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: This allows removal of lots of custom conversion code. I noticed this when doing #2589.

X Description: This allows removal of lots of custom conversion code. I noticed this when doing #2589.

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/2600

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1060bd54-d2ef-034e-4eb8-8e8f06e9478d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id947A:F391:23982C:33BA6C:6A4DFF6E
html-safe-nonce520764419f5f74dfc2171e515dfddbe47ed65202366725631b9f29d42e089948
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDdBOkYzOTE6MjM5ODJDOjMzQkE2Qzo2QTRERkY2RSIsInZpc2l0b3JfaWQiOiI1NzkxODYwMDcxNTYzMzk0OTI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd10bbf242fe48f0a6ec5b2148c7ac8f02fdc6a2faecf5081bc5b5017dd034510
hovercard-subject-tagpull_request:90734704
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/2600/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/53ac01ebd9680be63fb1a679ce2185b331c4e57f52f84982fe27045833bb1261/googleapis/google-cloud-python/pull/2600
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/53ac01ebd9680be63fb1a679ce2185b331c4e57f52f84982fe27045833bb1261/googleapis/google-cloud-python/pull/2600
og:image:altThis allows removal of lots of custom conversion code. I noticed this when doing #2589.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedhermes
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release52bde38e24398476f8eb1e0760c81346c6a00812
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/2600#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2600
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2600
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/2600
Reloadhttps://github.com/googleapis/google-cloud-python/pull/2600
Reloadhttps://github.com/googleapis/google-cloud-python/pull/2600
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 439 https://github.com/googleapis/google-cloud-python/issues
Pull requests 132 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
dhermeshttps://github.com/dhermes
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
dhermes:gax-logging-use-messagetodicthttps://github.com/dhermes/google-cloud-python/tree/gax-logging-use-messagetodict
Conversationhttps://github.com/googleapis/google-cloud-python/pull/2600
Commits3 (3)https://github.com/googleapis/google-cloud-python/pull/2600/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/2600/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/2600/files
Use MessageToDict in logging._gaxhttps://github.com/googleapis/google-cloud-python/pull/2600#top
dhermeshttps://github.com/dhermes
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
dhermes:gax-logging-use-messagetodicthttps://github.com/dhermes/google-cloud-python/tree/gax-logging-use-messagetodict
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Oct 25, 2016https://github.com/googleapis/google-cloud-python/pull/2600#issue-185012189
#2589https://github.com/googleapis/google-cloud-python/pull/2589
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
dhermeshttps://github.com/dhermes
October 24, 2016 20:28https://github.com/googleapis/google-cloud-python/pull/2600#commits-pushed-b73c806
https://github.com/dhermes
Using MessageToDict/ParseDict in logging._gax.https://github.com/googleapis/google-cloud-python/pull/2600/commits/b73c80623e6c698b01f931529c5c18a09dac7216
b73c806https://github.com/googleapis/google-cloud-python/pull/2600/commits/b73c80623e6c698b01f931529c5c18a09dac7216
https://github.com/dhermes
Removing all thin wrappers around MessageToDict in logging.https://github.com/googleapis/google-cloud-python/pull/2600/commits/1d048723ad53ffdde810f5bbac3dd0b881cd978e
1d04872https://github.com/googleapis/google-cloud-python/pull/2600/commits/1d048723ad53ffdde810f5bbac3dd0b881cd978e
https://github.com/dhermes
Removing un-needed PB mocks in GAX logging unit tests.https://github.com/googleapis/google-cloud-python/pull/2600/commits/cf3431f8d4181e1d21f40c5ba594d52ebcfa7aa2
cf3431fhttps://github.com/googleapis/google-cloud-python/pull/2600/commits/cf3431f8d4181e1d21f40c5ba594d52ebcfa7aa2
https://github.com/dhermes
dhermeshttps://github.com/dhermes
api: logging https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22
Oct 25, 2016https://github.com/googleapis/google-cloud-python/pull/2600#event-834859597
https://github.com/dhermes
dhermeshttps://github.com/dhermes
daspecsterhttps://github.com/daspecster
tseaverhttps://github.com/tseaver
theacodeshttps://github.com/theacodes
Oct 25, 2016https://github.com/googleapis/google-cloud-python/pull/2600#event-834859598
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 25, 2016https://github.com/googleapis/google-cloud-python/pull/2600#event-834859606
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Oct 25, 2016https://github.com/googleapis/google-cloud-python/pull/2600#issuecomment-255932028
@tseaverhttps://github.com/tseaver
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
https://github.com/daspecster
daspecsterhttps://github.com/daspecster
Oct 25, 2016https://github.com/googleapis/google-cloud-python/pull/2600#issuecomment-256025165
MessageToDicthttps://github.com/google/protobuf/blob/58580da37357941d502805be3ae520441be77728/python/google/protobuf/json_format.py#L112
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Oct 25, 2016 https://github.com/googleapis/google-cloud-python/pull/2600#pullrequestreview-5666611
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/2600/files/cf3431f8d4181e1d21f40c5ba594d52ebcfa7aa2
logging/google/cloud/logging/_gax.pyhttps://github.com/googleapis/google-cloud-python/pull/2600/files/cf3431f8d4181e1d21f40c5ba594d52ebcfa7aa2#diff-9c8365362ad60d621fee4c2cdbe682760d0a4988800fe15dc89baa00e2372b2e
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2600
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2600
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
logging/unit_tests/test__gax.pyhttps://github.com/googleapis/google-cloud-python/pull/2600/files/cf3431f8d4181e1d21f40c5ba594d52ebcfa7aa2#diff-130f5409dd655f158a3c04b434711b954d8eb300572c8f7a76dceda3f95c8b04
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2600
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Oct 25, 2016https://github.com/googleapis/google-cloud-python/pull/2600#issuecomment-256105469
@tseaverhttps://github.com/tseaver
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Oct 25, 2016https://github.com/googleapis/google-cloud-python/pull/2600#issuecomment-256126053
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
https://github.com/dhermes
dhermeshttps://github.com/dhermes
25f4475https://github.com/googleapis/google-cloud-python/commit/25f4475914c3998f6d1939ad8e8612c95d176438
Oct 25, 2016https://github.com/googleapis/google-cloud-python/pull/2600#event-835936559
https://github.com/dhermes
dhermeshttps://github.com/dhermes
October 25, 2016 18:34https://github.com/googleapis/google-cloud-python/pull/2600#event-835936610
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Nov 14, 2016 https://github.com/googleapis/google-cloud-python/pull/2600#ref-pullrequest-189221427
Upgrading core to version to 0.21.0. #2733 https://github.com/googleapis/google-cloud-python/pull/2733
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Mar 31, 2017 https://github.com/googleapis/google-cloud-python/pull/2600#ref-issue-187139936
New 'MessageToDict' implementation breaks with unknown entry types #2674 https://github.com/googleapis/google-cloud-python/issues/2674
richkadelhttps://github.com/richkadel
May 6, 2017 https://github.com/googleapis/google-cloud-python/pull/2600#ref-commit-209babe
https://github.com/dhermes
Merge pull requesthttps://github.com/richkadel/google-cloud-python/commit/209babe3a50ade6633f1ab5573f60fd752757671
googleapis#2600https://github.com/googleapis/google-cloud-python/pull/2600
from dhermes/gax-logging-use-messa…https://github.com/richkadel/google-cloud-python/commit/209babe3a50ade6633f1ab5573f60fd752757671
209babehttps://github.com/richkadel/google-cloud-python/commit/209babe3a50ade6633f1ab5573f60fd752757671
https://github.com/theacodes
theacodeshttps://github.com/theacodes
daspecsterhttps://github.com/daspecster
Sep 28, 2018https://github.com/googleapis/google-cloud-python/pull/2600#event-1873927987
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2600
https://github.com/tseaver
tseaver https://github.com/tseaver
https://github.com/googleapis/google-cloud-python/pull/2600/files/cf3431f8d4181e1d21f40c5ba594d52ebcfa7aa2
https://github.com/tseaver
tseaver https://github.com/tseaver
https://github.com/theacodes
theacodes https://github.com/theacodes
api: logging https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2600
https://github.com/dhermes
https://github.com/daspecster
https://github.com/tseaver
https://github.com/theacodes
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.