René's URL Explorer Experiment


Title: Refactor datastore connection: move behavior into API objects by dhermes · Pull Request #2287 · googleapis/google-cloud-python · GitHub

Open Graph Title: Refactor datastore connection: move behavior into API objects by dhermes · Pull Request #2287 · googleapis/google-cloud-python

X Title: Refactor datastore connection: move behavior into API objects by dhermes · Pull Request #2287 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: @tseaver This is what we discussed in #2230. LMKWYT. This way we can just ditch google.cloud.client.Client (for _ClientFactoryMixin) and remove the connection module. Right now, the only real logic...

X Description: @tseaver This is what we discussed in #2230. LMKWYT. This way we can just ditch google.cloud.client.Client (for _ClientFactoryMixin) and remove the connection module. Right now, the only real logic...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/2287

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3afe74ab-e623-ca79-7b96-41f91b3200e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6AA:12115C:193720:244623:6A55E1E9
html-safe-nonced5617b343c5dad7b6eb859362b482ea6b9e5cfdb3cedc0cc2e6f773dc19d32df
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkFBOjEyMTE1QzoxOTM3MjA6MjQ0NjIzOjZBNTVFMUU5IiwidmlzaXRvcl9pZCI6IjY0NTYyNTg4MDYwNzkxNTI2MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac609b9168b9517cfdf5bfa8b58eb5e144c52bdacc057663bf661ecd90bd9cd4dd
hovercard-subject-tagpull_request:84697077
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/2287/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8b22ab550745e4a3f2816a384ee20f389a0e2b156d7bd50ffbe4bc4fde43717d/googleapis/google-cloud-python/pull/2287
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8b22ab550745e4a3f2816a384ee20f389a0e2b156d7bd50ffbe4bc4fde43717d/googleapis/google-cloud-python/pull/2287
og:image:alt@tseaver This is what we discussed in #2230. LMKWYT. This way we can just ditch google.cloud.client.Client (for _ClientFactoryMixin) and remove the connection module. Right now, the only real logic...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedhermes
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3725c7f9b2a6e3a27ef57c5aed13428c0f65e045
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/2287#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2287
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2287
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/2287
Reloadhttps://github.com/googleapis/google-cloud-python/pull/2287
Reloadhttps://github.com/googleapis/google-cloud-python/pull/2287
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2287
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 444 https://github.com/googleapis/google-cloud-python/issues
Pull requests 137 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
dhermeshttps://github.com/dhermes
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
dhermes:refactor-ds-cnxnhttps://github.com/dhermes/google-cloud-python/tree/refactor-ds-cnxn
Conversationhttps://github.com/googleapis/google-cloud-python/pull/2287
Commits9 (9)https://github.com/googleapis/google-cloud-python/pull/2287/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/2287/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/2287/files
Refactor datastore connection: move behavior into API objectshttps://github.com/googleapis/google-cloud-python/pull/2287#top
dhermeshttps://github.com/dhermes
googleapis:masterhttps://github.com/googleapis/google-cloud-python/tree/master
dhermes:refactor-ds-cnxnhttps://github.com/dhermes/google-cloud-python/tree/refactor-ds-cnxn
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Sep 9, 2016https://github.com/googleapis/google-cloud-python/pull/2287#issue-176077591
@tseaverhttps://github.com/tseaver
#2230https://github.com/googleapis/google-cloud-python/issues/2230
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2287
dhermeshttps://github.com/dhermes
September 9, 2016 09:56https://github.com/googleapis/google-cloud-python/pull/2287#commits-pushed-3c718c3
https://github.com/dhermes
Moving _DatastoreAPI implementations into dedicated module.https://github.com/googleapis/google-cloud-python/pull/2287/commits/3c718c3a16a0f944923ea25bad474d44f88bab08
3c718c3https://github.com/googleapis/google-cloud-python/pull/2287/commits/3c718c3a16a0f944923ea25bad474d44f88bab08
https://github.com/dhermes
Peeling off build_api_url method from datastore connection.https://github.com/googleapis/google-cloud-python/pull/2287/commits/eebd9d28cd4dd1a17b7ed216091425d8b877ab5c
eebd9d2https://github.com/googleapis/google-cloud-python/pull/2287/commits/eebd9d28cd4dd1a17b7ed216091425d8b877ab5c
https://github.com/dhermes
Moving datastore connection lookup into a base API class.https://github.com/googleapis/google-cloud-python/pull/2287/commits/98b1327aad09f9b85e70bef8cce59b154b1eb609
98b1327https://github.com/googleapis/google-cloud-python/pull/2287/commits/98b1327aad09f9b85e70bef8cce59b154b1eb609
https://github.com/dhermes
Moving datastore connection run_query into base API class.https://github.com/googleapis/google-cloud-python/pull/2287/commits/e7f7aa4f8075666487ca793f9d87d983e1b0b4be
e7f7aa4https://github.com/googleapis/google-cloud-python/pull/2287/commits/e7f7aa4f8075666487ca793f9d87d983e1b0b4be
https://github.com/dhermes
Moving datastore connection begin_transaction into base API class.https://github.com/googleapis/google-cloud-python/pull/2287/commits/3c172f2fc3c8e7928e4108a54fab0e5ce05383b8
3c172f2https://github.com/googleapis/google-cloud-python/pull/2287/commits/3c172f2fc3c8e7928e4108a54fab0e5ce05383b8
https://github.com/dhermes
Moving datastore connection commit into base API class.https://github.com/googleapis/google-cloud-python/pull/2287/commits/8367a3dd6131471170408b5bd2380b1ea90348d8
8367a3dhttps://github.com/googleapis/google-cloud-python/pull/2287/commits/8367a3dd6131471170408b5bd2380b1ea90348d8
https://github.com/dhermes
Moving datastore connection rollback into base API class.https://github.com/googleapis/google-cloud-python/pull/2287/commits/b17829f60651160366847d42ee93f38430724654
b17829fhttps://github.com/googleapis/google-cloud-python/pull/2287/commits/b17829f60651160366847d42ee93f38430724654
https://github.com/dhermes
Moving datastore connection allocate_ids into base API class.https://github.com/googleapis/google-cloud-python/pull/2287/commits/4329b0007eedd58ff86a4699f7d29ebe58fc1f8f
4329b00https://github.com/googleapis/google-cloud-python/pull/2287/commits/4329b0007eedd58ff86a4699f7d29ebe58fc1f8f
https://github.com/dhermes
Removing superfluous properties of datastore connection.https://github.com/googleapis/google-cloud-python/pull/2287/commits/500ae929a6e747edea7b3ac2bbf500087784f8cb
500ae92https://github.com/googleapis/google-cloud-python/pull/2287/commits/500ae929a6e747edea7b3ac2bbf500087784f8cb
https://github.com/dhermes
dhermeshttps://github.com/dhermes
api: datastore https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20datastore%22
hygiene https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Ahygiene
do not merge https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22
Sep 9, 2016https://github.com/googleapis/google-cloud-python/pull/2287#event-784341798
https://github.com/dhermes
dhermeshttps://github.com/dhermes
tseaverhttps://github.com/tseaver
Sep 9, 2016https://github.com/googleapis/google-cloud-python/pull/2287#event-784341803
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Sep 9, 2016https://github.com/googleapis/google-cloud-python/pull/2287#event-784341829
tseaverhttps://github.com/tseaver
Sep 9, 2016 https://github.com/googleapis/google-cloud-python/pull/2287#discussion-diff-78236638
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/2287/files/3c718c3a16a0f944923ea25bad474d44f88bab08..eebd9d28cd4dd1a17b7ed216091425d8b877ab5c#diff-ca9b0afff587eb1bda59f60fde58bfeb3260803b7d75f119aa90ab27ba8c6732
google/cloud/datastore/_api.pyhttps://github.com/googleapis/google-cloud-python/pull/2287/files#diff-ca9b0afff587eb1bda59f60fde58bfeb3260803b7d75f119aa90ab27ba8c6732
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2287
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2287
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2287
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2287
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Sep 9, 2016https://github.com/googleapis/google-cloud-python/pull/2287#issuecomment-246019319
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2287
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Sep 12, 2016https://github.com/googleapis/google-cloud-python/pull/2287#issuecomment-246480074
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2287
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Sep 12, 2016https://github.com/googleapis/google-cloud-python/pull/2287#issuecomment-246497599
@tseaverhttps://github.com/tseaver
#2230https://github.com/googleapis/google-cloud-python/issues/2230
#2221https://github.com/googleapis/google-cloud-python/issues/2221
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2287
https://github.com/lukesneeringer
lukesneeringerhttps://github.com/lukesneeringer
priority: p2 https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22priority%3A%20p2%22
Apr 19, 2017https://github.com/googleapis/google-cloud-python/pull/2287#event-1049088175
https://github.com/dhermes
dhermeshttps://github.com/dhermes
Jun 6, 2017https://github.com/googleapis/google-cloud-python/pull/2287#event-1112192947
https://github.com/dhermes
dhermeshttps://github.com/dhermes
June 6, 2017 17:10https://github.com/googleapis/google-cloud-python/pull/2287#event-1112193052
partheahttps://github.com/parthea
Apr 1, 2026 https://github.com/googleapis/google-cloud-python/pull/2287#ref-commit-38d7052
https://github.com/shuoweil
Fix: Anywidget Table Pagination for Small DataFrames & Improve Displa… (https://github.com/googleapis/google-cloud-python/commit/38d7052e3def0105797f1d599cae0060e694c615
38d7052https://github.com/googleapis/google-cloud-python/commit/38d7052e3def0105797f1d599cae0060e694c615
#2287https://github.com/googleapis/google-cloud-python/pull/2287
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F2287
https://github.com/tseaver
tseaver https://github.com/tseaver
api: datastore https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20datastore%22
cla: yes https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
do not merge https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22
priority: p2 https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22priority%3A%20p2%22
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/2287
https://github.com/dhermes
https://github.com/tseaver
https://github.com/lukesneeringer
https://github.com/danoscarmike
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.