René's URL Explorer Experiment


Title: fix(auth): verify workload cert and key match, retrying mid-rotation reads by nbayati · Pull Request #19043 · googleapis/google-cloud-python · GitHub

Open Graph Title: fix(auth): verify workload cert and key match, retrying mid-rotation reads by nbayati · Pull Request #19043 · googleapis/google-cloud-python

X Title: fix(auth): verify workload cert and key match, retrying mid-rotation reads by nbayati · Pull Request #19043 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: When the workload certificate and private key are separate files, re-read both (up to 3 attempts, 100ms apart) if the private key does not match the leaf certificate's public key, and raise Cli...

X Description: When the workload certificate and private key are separate files, re-read both (up to 3 attempts, 100ms apart) if the private key does not match the leaf certificate's public key, and raise...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/19043

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:18cf5200-5dd0-77a5-959e-28b14fce2ca1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DE4:3E5952:286650:38FD0F:6AFE1C23
html-safe-nonce5cfb972a39eced8f4b55714932947ea6b0a4fec65e5e384feda2eb399c7624ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REU0OjNFNTk1MjoyODY2NTA6MzhGRDBGOjZBRkUxQzIzIiwidmlzaXRvcl9pZCI6IjM3NDIyNzc4MjI2NTA4NDk2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacae2735707a8295c54efb98d395e57cd6562aa928fc1a2a0ee61e1a21a3d8e442
hovercard-subject-tagpull_request:5252298218
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/19043/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3bebe0b223a480da03e06457f248ff84c0774b7c55620eab0f674bfc482182d4/googleapis/google-cloud-python/pull/19043
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3bebe0b223a480da03e06457f248ff84c0774b7c55620eab0f674bfc482182d4/googleapis/google-cloud-python/pull/19043
og:image:altWhen the workload certificate and private key are separate files, re-read both (up to 3 attempts, 100ms apart) if the private key does not match the leaf certificate's public key, and raise Cli...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenbayati
hostnamegithub.com
expected-hostnamegithub.com
Noned0525ab1464526bf4532a5551aa348cf100dff75ef808a96fc67a08b1d946aa9
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefef3993a71fa20f7be8e167132fbf9619bc66e12
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/19043#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F19043
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F19043
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/19043
Reloadhttps://github.com/googleapis/google-cloud-python/pull/19043
Reloadhttps://github.com/googleapis/google-cloud-python/pull/19043
googleapishttps://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Codehttps://github.com/googleapis/google-cloud-python
Issues449 (449)https://github.com/googleapis/google-cloud-python/issues
Pull requests199 (199)https://github.com/googleapis/google-cloud-python/pulls
Discussionshttps://github.com/googleapis/google-cloud-python/discussions
Actionshttps://github.com/googleapis/google-cloud-python/actions
Projectshttps://github.com/googleapis/google-cloud-python/projects
Security and qualityhttps://github.com/googleapis/google-cloud-python/security
Insightshttps://github.com/googleapis/google-cloud-python/insights
https://github.com/googleapis/google-cloud-python
nbayatihttps://github.com/nbayati
mainhttps://github.com/googleapis/google-cloud-python/tree/main
cert_key_mismatch_retryhttps://github.com/googleapis/google-cloud-python/tree/cert_key_mismatch_retry
Conversationhttps://github.com/googleapis/google-cloud-python/pull/19043
Commits8 (8)https://github.com/googleapis/google-cloud-python/pull/19043/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/19043/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/19043/files
fix(auth): verify workload cert and key match, retrying mid-rotation readshttps://github.com/googleapis/google-cloud-python/pull/19043#top
nbayatihttps://github.com/nbayati
mainhttps://github.com/googleapis/google-cloud-python/tree/main
cert_key_mismatch_retryhttps://github.com/googleapis/google-cloud-python/tree/cert_key_mismatch_retry
https://github.com/nbayati
nbayatihttps://github.com/nbayati
Nov 11, 2026https://github.com/googleapis/google-cloud-python/pull/19043#issue-6319859386
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
https://github.com/nbayati
fix(auth): verify workload cert and key match, retrying mid-rotation …https://github.com/googleapis/google-cloud-python/pull/19043/commits/e0c26de970191f865eed5d54a27c12f8b238fb0a
e0c26dehttps://github.com/googleapis/google-cloud-python/pull/19043/commits/e0c26de970191f865eed5d54a27c12f8b238fb0a
https://github.com/nbayati
nbayatihttps://github.com/nbayati
code ownershttps://github.com/googleapis/google-cloud-python/blob/5a2b34ecf0d7799784c03a6fb094795d170dccdb/.github/CODEOWNERS#L34
November 11, 2026 01:51https://github.com/googleapis/google-cloud-python/pull/19043#event-35751204047
https://github.com/nbayati
nbayatihttps://github.com/nbayati
Nov 11, 2026 https://github.com/googleapis/google-cloud-python/pull/19043#ref-pullrequest-6114345571
feat(auth): add _MtlsCertManager for mTLS client certificate rotation #18925 https://github.com/googleapis/google-cloud-python/pull/18925
https://github.com/apps/gemini-code-assist
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Nov 11, 2026 https://github.com/googleapis/google-cloud-python/pull/19043#pullrequestreview-5852587016
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/19043/files/e0c26de970191f865eed5d54a27c12f8b238fb0a
gemini-code-assisthttps://github.com/apps/gemini-code-assist
https://github.com/googleapis/google-cloud-python/pull/19043#pullrequestreview-5852587016
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
https://github.com/nbayati
nbayatihttps://github.com/nbayati
macastelazhttps://github.com/macastelaz
November 11, 2026 01:52https://github.com/googleapis/google-cloud-python/pull/19043#event-35751300531
https://github.com/macastelaz
macastelazhttps://github.com/macastelaz
Nov 11, 2026 https://github.com/googleapis/google-cloud-python/pull/19043#pullrequestreview-5862276020
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/19043/files/e0c26de970191f865eed5d54a27c12f8b238fb0a
macastelazhttps://github.com/macastelaz
https://github.com/googleapis/google-cloud-python/pull/19043#pullrequestreview-5862276020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
packages/google-auth/google/auth/transport/_mtls_helper.pyhttps://github.com/googleapis/google-cloud-python/pull/19043/files/e0c26de970191f865eed5d54a27c12f8b238fb0a#diff-26913a611328abd817b36ce2e9d7fedc4131ba0c15c5ce6e5285194730ec46c3
macastelazhttps://github.com/macastelaz
Nov 11, 2026https://github.com/googleapis/google-cloud-python/pull/19043#discussion_r4540702596
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
nbayatihttps://github.com/nbayati
Nov 17, 2026https://github.com/googleapis/google-cloud-python/pull/19043#discussion_r4594033516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
packages/google-auth/google/auth/transport/_mtls_helper.pyhttps://github.com/googleapis/google-cloud-python/pull/19043/files/e0c26de970191f865eed5d54a27c12f8b238fb0a#diff-26913a611328abd817b36ce2e9d7fedc4131ba0c15c5ce6e5285194730ec46c3
macastelazhttps://github.com/macastelaz
Nov 11, 2026https://github.com/googleapis/google-cloud-python/pull/19043#discussion_r4540717556
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
nbayatihttps://github.com/nbayati
Nov 17, 2026https://github.com/googleapis/google-cloud-python/pull/19043#discussion_r4594034728
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
packages/google-auth/tests/transport/test__mtls_helper.pyhttps://github.com/googleapis/google-cloud-python/pull/19043/files/e0c26de970191f865eed5d54a27c12f8b238fb0a#diff-4555e744885b62a3af3e2e7203eb85870b0f21a86c7b0e65407e6e2e3db9c41a
macastelazhttps://github.com/macastelaz
Nov 11, 2026https://github.com/googleapis/google-cloud-python/pull/19043#discussion_r4540729173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
nbayatihttps://github.com/nbayati
Nov 17, 2026https://github.com/googleapis/google-cloud-python/pull/19043#discussion_r4594035393
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
packages/google-auth/google/auth/transport/_mtls_helper.pyhttps://github.com/googleapis/google-cloud-python/pull/19043/files/e0c26de970191f865eed5d54a27c12f8b238fb0a#diff-26913a611328abd817b36ce2e9d7fedc4131ba0c15c5ce6e5285194730ec46c3
macastelazhttps://github.com/macastelaz
Nov 11, 2026https://github.com/googleapis/google-cloud-python/pull/19043#discussion_r4540789570
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
nbayatihttps://github.com/nbayati
Nov 17, 2026https://github.com/googleapis/google-cloud-python/pull/19043#discussion_r4594036209
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
nbayatihttps://github.com/nbayati
November 15, 2026 01:50https://github.com/googleapis/google-cloud-python/pull/19043#commits-pushed-9ecc655
https://github.com/nbayati
fix(auth): skip RSA private key validation during cert-key match checkhttps://github.com/googleapis/google-cloud-python/pull/19043/commits/9ecc655eff9859e12cedef551a501bcb34b312e9
9ecc655https://github.com/googleapis/google-cloud-python/pull/19043/commits/9ecc655eff9859e12cedef551a501bcb34b312e9
https://github.com/nbayati
fix(auth): retry transient file read and PEM errors during cert-key loadhttps://github.com/googleapis/google-cloud-python/pull/19043/commits/37620f387af85efaad441b46a0520f4831478819
37620f3https://github.com/googleapis/google-cloud-python/pull/19043/commits/37620f387af85efaad441b46a0520f4831478819
https://github.com/nbayati
test(auth): cover cert catching up during mid-rotation retryhttps://github.com/googleapis/google-cloud-python/pull/19043/commits/9a53c3980eb968e838fcb5070f30bcd045518eeb
9a53c39https://github.com/googleapis/google-cloud-python/pull/19043/commits/9a53c3980eb968e838fcb5070f30bcd045518eeb
https://github.com/nbayati
fix(auth): catch x509.InvalidVersion when checking cert-key matchhttps://github.com/googleapis/google-cloud-python/pull/19043/commits/b79e78d64fcb294427100d2a37cb6931008cdbc4
b79e78dhttps://github.com/googleapis/google-cloud-python/pull/19043/commits/b79e78d64fcb294427100d2a37cb6931008cdbc4
https://github.com/nbayati
test(auth): cover persistent cert-key mismatch on 401 reload pathhttps://github.com/googleapis/google-cloud-python/pull/19043/commits/c1373a57e8d0b7984fe2de432966aff5d776cc3c
c1373a5https://github.com/googleapis/google-cloud-python/pull/19043/commits/c1373a57e8d0b7984fe2de432966aff5d776cc3c
https://github.com/nbayati
Merge remote-tracking branch 'upstream/main' into cert_key_mismatch_r…https://github.com/googleapis/google-cloud-python/pull/19043/commits/fcff5269b6f454aa1762d9675047197fd44af7a9
fcff526https://github.com/googleapis/google-cloud-python/pull/19043/commits/fcff5269b6f454aa1762d9675047197fd44af7a9
https://github.com/nbayati
test(auth): patch requests logger instead of caplog on 401 mismatch testhttps://github.com/googleapis/google-cloud-python/pull/19043/commits/9f6a0ef5315475f9985484ba5d47fe34d9d58355
9f6a0efhttps://github.com/googleapis/google-cloud-python/pull/19043/commits/9f6a0ef5315475f9985484ba5d47fe34d9d58355
https://github.com/nbayati
nbayatihttps://github.com/nbayati
daniel-sanchehttps://github.com/daniel-sanche
macastelazhttps://github.com/macastelaz
November 17, 2026 01:25https://github.com/googleapis/google-cloud-python/pull/19043#event-36349759404
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F19043
https://github.com/macastelaz
macastelaz https://github.com/macastelaz
https://github.com/daniel-sanche
daniel-sanche https://github.com/daniel-sanche
https://github.com/apps/gemini-code-assist
gemini-code-assist[bot] https://github.com/apps/gemini-code-assist
https://github.com/googleapis/google-cloud-python/pull/19043/files/e0c26de970191f865eed5d54a27c12f8b238fb0a
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/19043
https://github.com/nbayati
https://github.com/macastelaz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.