René's URL Explorer Experiment


Title: fix(auth): parse hostname for mTLS and PSC endpoint certificate rotation (#18147) by attharva-24 · Pull Request #18201 · googleapis/google-cloud-python · GitHub

Open Graph Title: fix(auth): parse hostname for mTLS and PSC endpoint certificate rotation (#18147) by attharva-24 · Pull Request #18201 · googleapis/google-cloud-python

X Title: fix(auth): parse hostname for mTLS and PSC endpoint certificate rotation (#18147) by attharva-24 · Pull Request #18201 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: Relands #18153 with all review feedback addressed, full test coverage, and live manual verification against Google Cloud mTLS endpoints. Fixes #18147 Changes Replaced naive any(prefix in url for p...

X Description: Relands #18153 with all review feedback addressed, full test coverage, and live manual verification against Google Cloud mTLS endpoints. Fixes #18147 Changes Replaced naive any(prefix in url for p...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/18201

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1e97405b-29cf-e220-16af-d3aff076bf5e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC5C2:39CCAA:4D4744:65B1A6:6AFE66B7
html-safe-noncecebcca32617e77da07ec8e426faa29c0096983f15cb2d172e23897295208e1a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUMyOjM5Q0NBQTo0RDQ3NDQ6NjVCMUE2OjZBRkU2NkI3IiwidmlzaXRvcl9pZCI6Ijc2ODA3NjcwNTYwNjAyNDU2ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1b8af8ba0958fe760007fe4cd2c9b9d4acef3b51f56c8e9775ab34baa49549bd
hovercard-subject-tagpull_request:4335977560
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/18201/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f9d50bef969a2849ffb12e38b2339eeeb4ca02a7a07b3478c09bc915dfadb72f/googleapis/google-cloud-python/pull/18201
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f9d50bef969a2849ffb12e38b2339eeeb4ca02a7a07b3478c09bc915dfadb72f/googleapis/google-cloud-python/pull/18201
og:image:altRelands #18153 with all review feedback addressed, full test coverage, and live manual verification against Google Cloud mTLS endpoints. Fixes #18147 Changes Replaced naive any(prefix in url for p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameattharva-24
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/18201#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F18201
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F18201
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/18201
Reloadhttps://github.com/googleapis/google-cloud-python/pull/18201
Reloadhttps://github.com/googleapis/google-cloud-python/pull/18201
googleapishttps://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Codehttps://github.com/googleapis/google-cloud-python
Issues450 (450)https://github.com/googleapis/google-cloud-python/issues
Pull requests200 (200)https://github.com/googleapis/google-cloud-python/pulls
Discussionshttps://github.com/googleapis/google-cloud-python/discussions
Actionshttps://github.com/googleapis/google-cloud-python/actions
Projectshttps://github.com/googleapis/google-cloud-python/projects
Security and qualityhttps://github.com/googleapis/google-cloud-python/security
Insightshttps://github.com/googleapis/google-cloud-python/insights
https://github.com/googleapis/google-cloud-python
partheahttps://github.com/parthea
googleapis:mainhttps://github.com/googleapis/google-cloud-python/tree/main
attharva-24:fix-mtls-url-checkhttps://github.com/attharva-24/google-cloud-python/tree/fix-mtls-url-check
Conversationhttps://github.com/googleapis/google-cloud-python/pull/18201
Commits6 (6)https://github.com/googleapis/google-cloud-python/pull/18201/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/18201/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/18201/files
fix(auth): parse hostname for mTLS and PSC endpoint certificate rotation (#18147)https://github.com/googleapis/google-cloud-python/pull/18201#top
partheahttps://github.com/parthea
googleapis:mainhttps://github.com/googleapis/google-cloud-python/tree/main
attharva-24:fix-mtls-url-checkhttps://github.com/attharva-24/google-cloud-python/tree/fix-mtls-url-check
https://github.com/attharva-24
attharva-24https://github.com/attharva-24
Aug 21, 2026https://github.com/googleapis/google-cloud-python/pull/18201#issue-5219070908
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18201
#18153https://github.com/googleapis/google-cloud-python/pull/18153
#18147https://github.com/googleapis/google-cloud-python/issues/18147
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18201
attharva-24https://github.com/attharva-24
August 21, 2026 20:31https://github.com/googleapis/google-cloud-python/pull/18201#commits-pushed-9019e4e
https://github.com/attharva-24
fix(auth): parse hostname for mTLS and PSC endpoint certificate rotat…https://github.com/googleapis/google-cloud-python/pull/18201/commits/9019e4e9a994b7f4238cdd5e64f376f4fbae6ad1
9019e4ehttps://github.com/googleapis/google-cloud-python/pull/18201/commits/9019e4e9a994b7f4238cdd5e64f376f4fbae6ad1
googleapis#18147https://github.com/googleapis/google-cloud-python/issues/18147
googleapis#18147https://github.com/googleapis/google-cloud-python/issues/18147
googleapis#17928https://github.com/googleapis/google-cloud-python/pull/17928
https://github.com/attharva-24
fix(auth): strip trailing root dot in hostname for FQDNshttps://github.com/googleapis/google-cloud-python/pull/18201/commits/98a018ab46babd2dca10c030699c0aa2be218e4f
98a018ahttps://github.com/googleapis/google-cloud-python/pull/18201/commits/98a018ab46babd2dca10c030699c0aa2be218e4f
https://github.com/attharva-24
test(auth): add test cases for explicit port numbers, queries, and fr…https://github.com/googleapis/google-cloud-python/pull/18201/commits/6a43e28f75c26910eec809568120b924181f45f6
6a43e28https://github.com/googleapis/google-cloud-python/pull/18201/commits/6a43e28f75c26910eec809568120b924181f45f6
https://github.com/attharva-24
fix(auth): support bare PSC domain and add IPv6 unit testshttps://github.com/googleapis/google-cloud-python/pull/18201/commits/bcb6665b67029a7b7a54ec6f484490cea084c43c
bcb6665https://github.com/googleapis/google-cloud-python/pull/18201/commits/bcb6665b67029a7b7a54ec6f484490cea084c43c
https://github.com/attharva-24
style(auth): replace Any with object in is_mtls_endpoint type annotat…https://github.com/googleapis/google-cloud-python/pull/18201/commits/eea53a4017e7f39b6d3b479ce4d260975a4237e1
eea53a4https://github.com/googleapis/google-cloud-python/pull/18201/commits/eea53a4017e7f39b6d3b479ce4d260975a4237e1
https://github.com/attharva-24
test(auth): simplify transport rotation tests to single mTLS/non-mTLS…https://github.com/googleapis/google-cloud-python/pull/18201/commits/c2f7a70cae1b6a7a84b8ca68578da74dc595803f
c2f7a70https://github.com/googleapis/google-cloud-python/pull/18201/commits/c2f7a70cae1b6a7a84b8ca68578da74dc595803f
https://github.com/attharva-24
attharva-24https://github.com/attharva-24
code ownershttps://github.com/googleapis/google-cloud-python/blob/b4d97179f151d5ff37e6c7dbbd190a84c7d936a9/.github/CODEOWNERS#L34
August 21, 2026 23:53https://github.com/googleapis/google-cloud-python/pull/18201#event-29833311454
https://github.com/apps/gemini-code-assist
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Aug 21, 2026 https://github.com/googleapis/google-cloud-python/pull/18201#pullrequestreview-4998271200
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/18201/files/c2f7a70cae1b6a7a84b8ca68578da74dc595803f
gemini-code-assisthttps://github.com/apps/gemini-code-assist
https://github.com/googleapis/google-cloud-python/pull/18201#pullrequestreview-4998271200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18201
https://github.com/attharva-24
attharva-24https://github.com/attharva-24
Aug 21, 2026https://github.com/googleapis/google-cloud-python/pull/18201#event-29833397852
https://github.com/attharva-24
attharva-24https://github.com/attharva-24
macastelazhttps://github.com/macastelaz
partheahttps://github.com/parthea
viacheslav-rostovtsevhttps://github.com/viacheslav-rostovtsev
August 21, 2026 23:57https://github.com/googleapis/google-cloud-python/pull/18201#event-29833408145
https://github.com/attharva-24
attharva-24https://github.com/attharva-24
Aug 25, 2026https://github.com/googleapis/google-cloud-python/pull/18201#issuecomment-5414390870
@partheahttps://github.com/parthea
@viacheslav-rostovtsevhttps://github.com/viacheslav-rostovtsev
@macastelazhttps://github.com/macastelaz
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18201
https://github.com/parthea
partheahttps://github.com/parthea
partheahttps://github.com/parthea
attharva-24https://github.com/attharva-24
Aug 26, 2026https://github.com/googleapis/google-cloud-python/pull/18201#event-30062517360
https://github.com/parthea
partheahttps://github.com/parthea
Sep 3, 2026 https://github.com/googleapis/google-cloud-python/pull/18201#pullrequestreview-5104286558
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/18201/files/c2f7a70cae1b6a7a84b8ca68578da74dc595803f
https://github.com/parthea
partheahttps://github.com/parthea
b18bb4chttps://github.com/googleapis/google-cloud-python/commit/b18bb4cb749d2dd10d0e2f7d8505460d305e54fc
Sep 3, 2026https://github.com/googleapis/google-cloud-python/pull/18201#event-30501571996
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18201
https://github.com/apps/release-please
release-pleasehttps://github.com/apps/release-please
Sep 3, 2026 https://github.com/googleapis/google-cloud-python/pull/18201#ref-pullrequest-5338952998
chore: release main #18276 https://github.com/googleapis/google-cloud-python/pull/18276
partheahttps://github.com/parthea
Sep 4, 2026 https://github.com/googleapis/google-cloud-python/pull/18201#ref-commit-036f734
https://github.com/apps/release-please
chore: release main (https://github.com/googleapis/google-cloud-python/commit/036f734e43e17f7fdab238f7cc653f5f98e45131
#18276https://github.com/googleapis/google-cloud-python/pull/18276
)https://github.com/googleapis/google-cloud-python/commit/036f734e43e17f7fdab238f7cc653f5f98e45131
036f734https://github.com/googleapis/google-cloud-python/commit/036f734e43e17f7fdab238f7cc653f5f98e45131
google-auth-v2.57.0...google-auth-v2.57.1https://github.com/googleapis/google-cloud-python/compare/google-auth-v2.57.0...google-auth-v2.57.1
#18147https://github.com/googleapis/google-cloud-python/issues/18147
#18147https://github.com/googleapis/google-cloud-python/issues/18147
#18201https://github.com/googleapis/google-cloud-python/pull/18201
#18201https://github.com/googleapis/google-cloud-python/pull/18201
b18bb4chttps://github.com/googleapis/google-cloud-python/commit/b18bb4cb749d2dd10d0e2f7d8505460d305e54fc
b18bb4chttps://github.com/googleapis/google-cloud-python/commit/b18bb4cb749d2dd10d0e2f7d8505460d305e54fc
google-cloud-biglake-hive-v0.3.3...google-cloud-biglake-hive-v0.3.4https://github.com/googleapis/google-cloud-python/compare/google-cloud-biglake-hive-v0.3.3...google-cloud-biglake-hive-v0.3.4
#18282https://github.com/googleapis/google-cloud-python/pull/18282
#18282https://github.com/googleapis/google-cloud-python/pull/18282
ffa6e54https://github.com/googleapis/google-cloud-python/commit/ffa6e542ae1a09a43761a63aa5f8e872c90e708e
ffa6e54https://github.com/googleapis/google-cloud-python/commit/ffa6e542ae1a09a43761a63aa5f8e872c90e708e
google-cloud-compute-v1beta-v0.12.3...google-cloud-compute-v1beta-v0.12.4https://github.com/googleapis/google-cloud-python/compare/google-cloud-compute-v1beta-v0.12.3...google-cloud-compute-v1beta-v0.12.4
#18282https://github.com/googleapis/google-cloud-python/pull/18282
#18282https://github.com/googleapis/google-cloud-python/pull/18282
ffa6e54https://github.com/googleapis/google-cloud-python/commit/ffa6e542ae1a09a43761a63aa5f8e872c90e708e
ffa6e54https://github.com/googleapis/google-cloud-python/commit/ffa6e542ae1a09a43761a63aa5f8e872c90e708e
https://github.com/googleapis/release-pleasehttps://github.com/googleapis/release-please
https://github.com/googleapis/release-please#release-pleasehttps://github.com/googleapis/release-please#release-please
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F18201
https://github.com/parthea
parthea https://github.com/parthea
https://github.com/googleapis/google-cloud-python/pull/18201/files/c2f7a70cae1b6a7a84b8ca68578da74dc595803f
https://github.com/macastelaz
macastelaz https://github.com/macastelaz
https://github.com/viacheslav-rostovtsev
viacheslav-rostovtsev https://github.com/viacheslav-rostovtsev
https://github.com/apps/gemini-code-assist
gemini-code-assist[bot] https://github.com/apps/gemini-code-assist
https://github.com/googleapis/google-cloud-python/pull/18201/files/c2f7a70cae1b6a7a84b8ca68578da74dc595803f
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18201
https://github.com/parthea
parthea https://github.com/parthea
Fix(auth): incorrect mTLS endpoint detection causes false positive cert rotations and breaks PSC endpoints https://github.com/googleapis/google-cloud-python/issues/18147
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18201
https://github.com/attharva-24
https://github.com/parthea
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.