| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6957ddf0-7f28-a0d4-aa14-56ff7037eebf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D27E:3DC1BA:18127F:220DF9:6AFDF2D9 |
| html-safe-nonce | 0002fa23a82e3a2a544456cbdbc5d3702d9c7d8f4431246c8885de88064ef3bc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjdFOjNEQzFCQToxODEyN0Y6MjIwREY5OjZBRkRGMkQ5IiwidmlzaXRvcl9pZCI6Ijc2NTYwNzUyNDE4MzA4NzE3NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f932491ef1d98b193009581ae7c5f92b66e3b5de4b2475e1922ba644ebf92db6 |
| hovercard-subject-tag | pull_request:4331650990 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/googleapis/google-cloud-python/pull/18188/files |
| twitter:image | https://avatars.githubusercontent.com/u/7291104?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7291104?s=400&v=4 |
| og:image:alt | Problem
Client libraries currently lack built-in support for OpenTelemetry tracing interceptors. We need a flexible, explicit mechanism to inject these interceptors into the transport pipeline with... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | dd812ec581ecac95855f5ec917ef9827506c39a9da1443f43ddb4179a46471eb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 16316451 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16316451 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-python |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 32ac708bac264dafdc28e10ff49b4d137f0c34a7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/googleapis/google-cloud-python/pull/18188/changes#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F18188%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F18188%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python |
| Reload | https://github.com/googleapis/google-cloud-python/pull/18188/changes |
| Reload | https://github.com/googleapis/google-cloud-python/pull/18188/changes |
| Reload | https://github.com/googleapis/google-cloud-python/pull/18188/changes |
| googleapis | https://github.com/googleapis |
| google-cloud-python | https://github.com/googleapis/google-cloud-python |
| Code | https://github.com/googleapis/google-cloud-python |
| Issues448 (448) | https://github.com/googleapis/google-cloud-python/issues |
| Pull requests199 (199) | https://github.com/googleapis/google-cloud-python/pulls |
| Discussions | https://github.com/googleapis/google-cloud-python/discussions |
| Actions | https://github.com/googleapis/google-cloud-python/actions |
| Projects | https://github.com/googleapis/google-cloud-python/projects |
| Security and quality | https://github.com/googleapis/google-cloud-python/security |
| Insights | https://github.com/googleapis/google-cloud-python/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2Fnew%2Fchoose |
| chalmerlowe | https://github.com/chalmerlowe |
| main | https://github.com/googleapis/google-cloud-python/tree/main |
| feat/otel-tracing-transport-logic | https://github.com/googleapis/google-cloud-python/tree/feat/otel-tracing-transport-logic |
|
Conversation
35
| https://github.com/googleapis/google-cloud-python/pull/18188 |
|
Commits
12
| https://github.com/googleapis/google-cloud-python/pull/18188/commits |
|
Checks
42
| https://github.com/googleapis/google-cloud-python/pull/18188/checks |
|
Files changed
| https://github.com/googleapis/google-cloud-python/pull/18188/files |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/18188/changes |
|
experiment(secretmanager): wire OpenTelemetry gRPC interceptor for T4 network spans (C)
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#top |
|
Show all changes
12 commits
| https://github.com/googleapis/google-cloud-python/pull/18188/files |
|
bd4f6f2
feat(secretmanager): integrate eager channel creation and interceptor…
chalmerlowe Aug 27, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/bd4f6f26f40172dcf869b3826ea35523883ac80e |
|
a83da6c
docs(secretmanager): add descriptive docstrings to OTel and transport…
chalmerlowe Aug 27, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/a83da6c62425191d5fa41f602c6e5185dbc40a94 |
|
50f8e02
feat(secretmanager): pass lazy partial channel factory when OTel trac…
chalmerlowe Aug 28, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/50f8e02d4dc79c105c5778489432fae8ea0de050 |
|
5f447a9
feat(secretmanager): adopt get_otel_channel_wrapper and apply_channel…
chalmerlowe Aug 31, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/5f447a99e2f03088d9c112031e4645788c1efafd |
|
c8bb8b0
feat(secretmanager): rename channel wrapper terminology to interceptor
chalmerlowe Sep 1, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/c8bb8b02da952ca6d91adf89fe112bbe4706dcb9 |
|
5854306
style(secretmanager): sort imports and restore service_account
chalmerlowe Sep 2, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/585430632c475a24a751068c4154a86cadcd494f |
|
885393d
feat(secretmanager): guard _observability import and update intercept…
chalmerlowe Sep 3, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/885393decdd23977542e857591b2860552793330 |
|
f929240
fix(secretmanager): resolve ClientInterceptor type definition and tes…
chalmerlowe Sep 3, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/f929240a8497425548a4becbbe3edc250bf09073 |
|
69bbf22
fix(secretmanager): provide explicit anonymous credentials for transp…
chalmerlowe Sep 4, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/69bbf2275a1a3764fafbfddc375589c9feecc7f8 |
|
e6db97f
style(secretmanager): sort and format import blocks according to ruff…
chalmerlowe Sep 4, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/e6db97f4164e347d0962bd6583b5af1d741b8bc3 |
|
7104ded
test(secretmanager): align OTel transport unit tests with GAPIC gener…
chalmerlowe Sep 4, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/7104ded293215b711b9a2a74ce0410a3e6580890 |
|
e9aade6
refactor(secretmanager): resolve interceptors before initializing tra…
chalmerlowe Sep 4, 2026
| https://github.com/googleapis/google-cloud-python/pull/18188/commits/e9aade6370f941f7f51dd43b40f8acbe6f8e14d1 |
|
Clear filters
| https://github.com/googleapis/google-cloud-python/pull/18188/files |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/18188/changes |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/18188/changes |
|
client.py
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78 |
|
grpc.py
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
test_secret_manager_service.py
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57 |
|
| https://github.com/googleapis/google-cloud-python/blob/main/.github/CODEOWNERS#L29 |
| ...ud-secret-manager/google/cloud/secretmanager_v1/services/secret_manager_service/client.py | https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78 |
|
View file
| https://github.com/googleapis/google-cloud-python/blob/e9aade6370f941f7f51dd43b40f8acbe6f8e14d1/packages/google-cloud-secret-manager/google/cloud/secretmanager_v1/services/secret_manager_service/client.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/googleapis/google-cloud-python/pull/18188/{{ revealButtonHref }} |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78 |
|
| https://github.com/googleapis/google-cloud-python/blob/main/.github/CODEOWNERS#L29 |
| ...-manager/google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc.py | https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
View file
| https://github.com/googleapis/google-cloud-python/blob/e9aade6370f941f7f51dd43b40f8acbe6f8e14d1/packages/google-cloud-secret-manager/google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/googleapis/google-cloud-python/pull/18188/{{ revealButtonHref }} |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073 |
|
| https://github.com/googleapis/google-cloud-python/blob/main/.github/CODEOWNERS#L29 |
| ...gle-cloud-secret-manager/tests/unit/gapic/secretmanager_v1/test_secret_manager_service.py | https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57 |
|
View file
| https://github.com/googleapis/google-cloud-python/blob/e9aade6370f941f7f51dd43b40f8acbe6f8e14d1/packages/google-cloud-secret-manager/tests/unit/gapic/secretmanager_v1/test_secret_manager_service.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/googleapis/google-cloud-python/pull/18188/{{ revealButtonHref }} |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57 |
|
| https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57 |
| Please reload this page | https://github.com/googleapis/google-cloud-python/pull/18188/changes |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |