René's URL Explorer Experiment


Title: experiment(secretmanager): wire OpenTelemetry gRPC interceptor for T4 network spans (C) by chalmerlowe · Pull Request #18188 · googleapis/google-cloud-python · GitHub

Open Graph Title: experiment(secretmanager): wire OpenTelemetry gRPC interceptor for T4 network spans (C) by chalmerlowe · Pull Request #18188 · googleapis/google-cloud-python

X Title: experiment(secretmanager): wire OpenTelemetry gRPC interceptor for T4 network spans (C) by chalmerlowe · Pull Request #18188 · googleapis/google-cloud-python

Description: Problem Client libraries currently lack built-in support for OpenTelemetry tracing interceptors. We need a flexible, explicit mechanism to inject these interceptors into the transport pipeline without tying the core low-level helpers too tightly to specific observability features. NoteThis PR is NOT intended to be merged. It is a proof-of-concept intended to inform the design and implementation of changes that need to be made in the GAPIC Generator templates. Approval of this PR is necessary to fully roll out a parallel PR with GAPIC generator template changes. Solution This PR implements explicit interceptor injection in the SecretManagerServiceClient and its gRPC transport. All changes are aligned, as close as possible, with the style and capabilities of the GAPIC generator. Updated SecretManagerServiceClient with simulated "generated" to resolve OpenTelemetry interceptors using google-api-core helpers and explicitly pass them to the transport. Added simulated "generated" unit tests to verify that interceptors are correctly injected and applied. Notes to Reviewers Async Deferred: As per the design plan, Async gRPC updates are deferred to a separate PR to keep this implementation small and clean. Stacked PRs: This work builds on the foundational helpers introduced in the google-api-core. Explicit Injection: This demonstrates the "active orchestrator" role of the generated client, delegating resolution to core helpers but explicitly controlling the pipeline.

Open Graph Description: Problem Client libraries currently lack built-in support for OpenTelemetry tracing interceptors. We need a flexible, explicit mechanism to inject these interceptors into the transport pipeline with...

X Description: Problem Client libraries currently lack built-in support for OpenTelemetry tracing interceptors. We need a flexible, explicit mechanism to inject these interceptors into the transport pipeline with...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/18188

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6957ddf0-7f28-a0d4-aa14-56ff7037eebf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD27E:3DC1BA:18127F:220DF9:6AFDF2D9
html-safe-nonce0002fa23a82e3a2a544456cbdbc5d3702d9c7d8f4431246c8885de88064ef3bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjdFOjNEQzFCQToxODEyN0Y6MjIwREY5OjZBRkRGMkQ5IiwidmlzaXRvcl9pZCI6Ijc2NTYwNzUyNDE4MzA4NzE3NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf932491ef1d98b193009581ae7c5f92b66e3b5de4b2475e1922ba644ebf92db6
hovercard-subject-tagpull_request:4331650990
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/googleapis/google-cloud-python/pull/18188/files
twitter:imagehttps://avatars.githubusercontent.com/u/7291104?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7291104?s=400&v=4
og:image:altProblem Client libraries currently lack built-in support for OpenTelemetry tracing interceptors. We need a flexible, explicit mechanism to inject these interceptors into the transport pipeline with...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedd812ec581ecac95855f5ec917ef9827506c39a9da1443f43ddb4179a46471eb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32ac708bac264dafdc28e10ff49b4d137f0c34a7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/18188/changes#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F18188%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F18188%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/18188/changes
Reloadhttps://github.com/googleapis/google-cloud-python/pull/18188/changes
Reloadhttps://github.com/googleapis/google-cloud-python/pull/18188/changes
googleapishttps://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Codehttps://github.com/googleapis/google-cloud-python
Issues448 (448)https://github.com/googleapis/google-cloud-python/issues
Pull requests199 (199)https://github.com/googleapis/google-cloud-python/pulls
Discussionshttps://github.com/googleapis/google-cloud-python/discussions
Actionshttps://github.com/googleapis/google-cloud-python/actions
Projectshttps://github.com/googleapis/google-cloud-python/projects
Security and qualityhttps://github.com/googleapis/google-cloud-python/security
Insightshttps://github.com/googleapis/google-cloud-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2Fnew%2Fchoose
chalmerlowehttps://github.com/chalmerlowe
mainhttps://github.com/googleapis/google-cloud-python/tree/main
feat/otel-tracing-transport-logichttps://github.com/googleapis/google-cloud-python/tree/feat/otel-tracing-transport-logic
Conversation 35 https://github.com/googleapis/google-cloud-python/pull/18188
Commits 12 https://github.com/googleapis/google-cloud-python/pull/18188/commits
Checks 42 https://github.com/googleapis/google-cloud-python/pull/18188/checks
Files changed https://github.com/googleapis/google-cloud-python/pull/18188/files
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18188/changes
experiment(secretmanager): wire OpenTelemetry gRPC interceptor for T4 network spans (C) https://github.com/googleapis/google-cloud-python/pull/18188/changes#top
Show all changes 12 commits https://github.com/googleapis/google-cloud-python/pull/18188/files
bd4f6f2 feat(secretmanager): integrate eager channel creation and interceptor… chalmerlowe Aug 27, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/bd4f6f26f40172dcf869b3826ea35523883ac80e
a83da6c docs(secretmanager): add descriptive docstrings to OTel and transport… chalmerlowe Aug 27, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/a83da6c62425191d5fa41f602c6e5185dbc40a94
50f8e02 feat(secretmanager): pass lazy partial channel factory when OTel trac… chalmerlowe Aug 28, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/50f8e02d4dc79c105c5778489432fae8ea0de050
5f447a9 feat(secretmanager): adopt get_otel_channel_wrapper and apply_channel… chalmerlowe Aug 31, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/5f447a99e2f03088d9c112031e4645788c1efafd
c8bb8b0 feat(secretmanager): rename channel wrapper terminology to interceptor chalmerlowe Sep 1, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/c8bb8b02da952ca6d91adf89fe112bbe4706dcb9
5854306 style(secretmanager): sort imports and restore service_account chalmerlowe Sep 2, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/585430632c475a24a751068c4154a86cadcd494f
885393d feat(secretmanager): guard _observability import and update intercept… chalmerlowe Sep 3, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/885393decdd23977542e857591b2860552793330
f929240 fix(secretmanager): resolve ClientInterceptor type definition and tes… chalmerlowe Sep 3, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/f929240a8497425548a4becbbe3edc250bf09073
69bbf22 fix(secretmanager): provide explicit anonymous credentials for transp… chalmerlowe Sep 4, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/69bbf2275a1a3764fafbfddc375589c9feecc7f8
e6db97f style(secretmanager): sort and format import blocks according to ruff… chalmerlowe Sep 4, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/e6db97f4164e347d0962bd6583b5af1d741b8bc3
7104ded test(secretmanager): align OTel transport unit tests with GAPIC gener… chalmerlowe Sep 4, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/7104ded293215b711b9a2a74ce0410a3e6580890
e9aade6 refactor(secretmanager): resolve interceptors before initializing tra… chalmerlowe Sep 4, 2026 https://github.com/googleapis/google-cloud-python/pull/18188/commits/e9aade6370f941f7f51dd43b40f8acbe6f8e14d1
Clear filters https://github.com/googleapis/google-cloud-python/pull/18188/files
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18188/changes
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18188/changes
client.py https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78
grpc.py https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
test_secret_manager_service.py https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57
https://github.com/googleapis/google-cloud-python/blob/main/.github/CODEOWNERS#L29
...ud-secret-manager/google/cloud/secretmanager_v1/services/secret_manager_service/client.pyhttps://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78
View file https://github.com/googleapis/google-cloud-python/blob/e9aade6370f941f7f51dd43b40f8acbe6f8e14d1/packages/google-cloud-secret-manager/google/cloud/secretmanager_v1/services/secret_manager_service/client.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/18188/{{ revealButtonHref }}
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-827463716eb34936bdf2446979f2be08587cd35a0a45b887c8eda3aea0b93c78
https://github.com/googleapis/google-cloud-python/blob/main/.github/CODEOWNERS#L29
...-manager/google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc.pyhttps://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
View file https://github.com/googleapis/google-cloud-python/blob/e9aade6370f941f7f51dd43b40f8acbe6f8e14d1/packages/google-cloud-secret-manager/google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/18188/{{ revealButtonHref }}
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-864b7c8841b318c788f168f3f94af25db58457845f9598154330d17324ff8073
https://github.com/googleapis/google-cloud-python/blob/main/.github/CODEOWNERS#L29
...gle-cloud-secret-manager/tests/unit/gapic/secretmanager_v1/test_secret_manager_service.pyhttps://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57
View file https://github.com/googleapis/google-cloud-python/blob/e9aade6370f941f7f51dd43b40f8acbe6f8e14d1/packages/google-cloud-secret-manager/tests/unit/gapic/secretmanager_v1/test_secret_manager_service.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/18188/{{ revealButtonHref }}
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57
https://github.com/googleapis/google-cloud-python/pull/18188/changes#diff-6593d8272d35b266884e1dddaa3d3d0c81096de097d37aa34c4bf13cced61e57
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/18188/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.