René's URL Explorer Experiment


Title: fix(sqlalchemy-spanner): handle TOKENLIST and unknown column types in introspection by waiho-gumloop · Pull Request #16622 · googleapis/google-cloud-python · GitHub

Open Graph Title: fix(sqlalchemy-spanner): handle TOKENLIST and unknown column types in introspection by waiho-gumloop · Pull Request #16622 · googleapis/google-cloud-python

X Title: fix(sqlalchemy-spanner): handle TOKENLIST and unknown column types in introspection by waiho-gumloop · Pull Request #16622 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: Description SpannerDialect._designate_type() crashes with KeyError: 'TOKENLIST' when introspecting tables that have TOKENLIST columns (introduced by Spanner full-text search). Root cause _...

X Description: Description SpannerDialect._designate_type() crashes with KeyError: 'TOKENLIST' when introspecting tables that have TOKENLIST columns (introduced by Spanner full-text search). Root ...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/16622

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9764ccac-2c18-1139-08be-2b08fe9322fa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD6B4:284E8F:12BBAE:1A74DE:6AFDF18C
html-safe-nonce815ad1695684994cbdb28d4398cdfd8351a1afb7d7a3bcbb7478981f75201582
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkI0OjI4NEU4RjoxMkJCQUU6MUE3NERFOjZBRkRGMThDIiwidmlzaXRvcl9pZCI6IjE1MjM4OTA3ODEwODM3OTE3NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3cf664389bce03b9241bc043c0c1f0c5c41df1a80b551946282a7fabc7aa9ce7
hovercard-subject-tagpull_request:3520824261
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/16622/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/727e2577dd4105bd3b88b25dba9e1b0dcaffb0ee4529e36fc8889999dff118bd/googleapis/google-cloud-python/pull/16622
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/727e2577dd4105bd3b88b25dba9e1b0dcaffb0ee4529e36fc8889999dff118bd/googleapis/google-cloud-python/pull/16622
og:image:altDescription SpannerDialect._designate_type() crashes with KeyError: 'TOKENLIST' when introspecting tables that have TOKENLIST columns (introduced by Spanner full-text search). Root cause _...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaiho-gumloop
hostnamegithub.com
expected-hostnamegithub.com
Nonedd812ec581ecac95855f5ec917ef9827506c39a9da1443f43ddb4179a46471eb
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32ac708bac264dafdc28e10ff49b4d137f0c34a7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/16622#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F16622
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F16622
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/16622
Reloadhttps://github.com/googleapis/google-cloud-python/pull/16622
Reloadhttps://github.com/googleapis/google-cloud-python/pull/16622
googleapishttps://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Codehttps://github.com/googleapis/google-cloud-python
Issues448 (448)https://github.com/googleapis/google-cloud-python/issues
Pull requests199 (199)https://github.com/googleapis/google-cloud-python/pulls
Discussionshttps://github.com/googleapis/google-cloud-python/discussions
Actionshttps://github.com/googleapis/google-cloud-python/actions
Projectshttps://github.com/googleapis/google-cloud-python/projects
Security and qualityhttps://github.com/googleapis/google-cloud-python/security
Insightshttps://github.com/googleapis/google-cloud-python/insights
https://github.com/googleapis/google-cloud-python
waiho-gumloophttps://github.com/waiho-gumloop
googleapis:mainhttps://github.com/googleapis/google-cloud-python/tree/main
waiho-gumloop:fix/sqlalchemy-spanner-tokenlist-typehttps://github.com/waiho-gumloop/google-cloud-python/tree/fix/sqlalchemy-spanner-tokenlist-type
Conversationhttps://github.com/googleapis/google-cloud-python/pull/16622
Commits2 (2)https://github.com/googleapis/google-cloud-python/pull/16622/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/16622/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/16622/files
fix(sqlalchemy-spanner): handle TOKENLIST and unknown column types in introspectionhttps://github.com/googleapis/google-cloud-python/pull/16622#top
waiho-gumloophttps://github.com/waiho-gumloop
googleapis:mainhttps://github.com/googleapis/google-cloud-python/tree/main
waiho-gumloop:fix/sqlalchemy-spanner-tokenlist-typehttps://github.com/waiho-gumloop/google-cloud-python/tree/fix/sqlalchemy-spanner-tokenlist-type
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
Apr 13, 2026https://github.com/googleapis/google-cloud-python/pull/16622#issue-4251069131
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
Spanner full-text searchhttps://cloud.google.com/spanner/docs/full-text-search
spanner: parse TOKENLIST data type failed. google-cloud-go#10651https://github.com/googleapis/google-cloud-go/issues/10651
feat(spanner/spansql): Add support for tokenlist and create search index google-cloud-go#11522https://github.com/googleapis/google-cloud-go/pull/11522
UUID PRhttps://github.com/googleapis/google-cloud-go/pull/14117
#16621https://github.com/googleapis/google-cloud-python/issues/16621
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
code ownerhttps://github.com/googleapis/google-cloud-python/blob/705e23d8698b25b1bee5c21c0c1416c91cb5145d/.github/CODEOWNERS#L46
April 13, 2026 03:33https://github.com/googleapis/google-cloud-python/pull/16622#event-24431078239
https://github.com/apps/gemini-code-assist
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Apr 13, 2026 https://github.com/googleapis/google-cloud-python/pull/16622#pullrequestreview-4096255771
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/16622/files
gemini-code-assisthttps://github.com/apps/gemini-code-assist
https://github.com/googleapis/google-cloud-python/pull/16622#pullrequestreview-4096255771
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
packages/sqlalchemy-spanner/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.pyhttps://github.com/googleapis/google-cloud-python/pull/16622/files#diff-508f50cf5266862609db5f2f9ef2114711676868c715443eeda54d927c2afecd
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Apr 13, 2026https://github.com/googleapis/google-cloud-python/pull/16622#discussion_r3070743649
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/f9141739e81c5065c5f99ee945037104c1ba6def9f166570e17368344f990bdd/68747470733a2f2f7777772e677374617469632e636f6d2f636f64657265766965776167656e742f686967682d7072696f726974792e737667
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/83bf00a2090fdcbfa25b0f891a0572cbc682b130..01c17c5f618e64f7bcb0e002c9e4d32f62f72352
83bf00ahttps://github.com/googleapis/google-cloud-python/commit/83bf00a2090fdcbfa25b0f891a0572cbc682b130
01c17c5https://github.com/googleapis/google-cloud-python/commit/01c17c5f618e64f7bcb0e002c9e4d32f62f72352
Compare https://github.com/googleapis/google-cloud-python/compare/83bf00a2090fdcbfa25b0f891a0572cbc682b130..01c17c5f618e64f7bcb0e002c9e4d32f62f72352
April 13, 2026 04:19https://github.com/googleapis/google-cloud-python/pull/16622#event-24431848392
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
Apr 13, 2026 https://github.com/googleapis/google-cloud-python/pull/16622#ref-issue-4251021090
sqlalchemy-spanner: _designate_type crashes with KeyError on TOKENLIST columns #16621 https://github.com/googleapis/google-cloud-python/issues/16621
https://github.com/waiho-gumloop
fix(sqlalchemy-spanner): add TOKENLIST type and unknown type fallback…https://github.com/googleapis/google-cloud-python/pull/16622/commits/c2f5788b2f5fd347cdfdd8d58a2b64d73677a9bf
c2f5788https://github.com/googleapis/google-cloud-python/pull/16622/commits/c2f5788b2f5fd347cdfdd8d58a2b64d73677a9bf
googleapis/google-cloud-go#11522https://github.com/googleapis/google-cloud-go/pull/11522
googleapis#16621https://github.com/googleapis/google-cloud-python/issues/16621
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/736e0013980aa4b0042b062249eda6f0c08d1da5..c2f5788b2f5fd347cdfdd8d58a2b64d73677a9bf
736e001https://github.com/googleapis/google-cloud-python/commit/736e0013980aa4b0042b062249eda6f0c08d1da5
c2f5788https://github.com/googleapis/google-cloud-python/commit/c2f5788b2f5fd347cdfdd8d58a2b64d73677a9bf
Compare https://github.com/googleapis/google-cloud-python/compare/736e0013980aa4b0042b062249eda6f0c08d1da5..c2f5788b2f5fd347cdfdd8d58a2b64d73677a9bf
April 13, 2026 06:11https://github.com/googleapis/google-cloud-python/pull/16622#event-24434014422
https://github.com/parthea
partheahttps://github.com/parthea
kokoro:force-run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
kokoro:run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Arun
May 1, 2026https://github.com/googleapis/google-cloud-python/pull/16622#event-25076597583
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Arun
kokoro:force-run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
May 1, 2026https://github.com/googleapis/google-cloud-python/pull/16622#event-25076610646
https://github.com/parthea
partheahttps://github.com/parthea
olavloitehttps://github.com/olavloite
May 1, 2026https://github.com/googleapis/google-cloud-python/pull/16622#event-25076620374
https://github.com/parthea
partheahttps://github.com/parthea
May 1, 2026https://github.com/googleapis/google-cloud-python/pull/16622#issuecomment-4360512641
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
https://github.com/parthea
partheahttps://github.com/parthea
May 1, 2026 16:57https://github.com/googleapis/google-cloud-python/pull/16622#event-25076629270
https://github.com/parthea
partheahttps://github.com/parthea
kokoro:force-run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
kokoro:run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Arun
May 1, 2026https://github.com/googleapis/google-cloud-python/pull/16622#event-25080537348
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Arun
kokoro:force-run https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
May 1, 2026https://github.com/googleapis/google-cloud-python/pull/16622#event-25080554959
https://github.com/waiho-gumloop
fix(sqlalchemy-spanner): instantiate types from _type_map and fix bla…https://github.com/googleapis/google-cloud-python/pull/16622/commits/c39dec65ac5ca1f8e593099af3ab68aa2a039862
c39dec6https://github.com/googleapis/google-cloud-python/pull/16622/commits/c39dec65ac5ca1f8e593099af3ab68aa2a039862
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
force-pushedhttps://github.com/googleapis/google-cloud-python/compare/7d16be36ee0c03785d3b5bc1c87ff5f9b0ce7aed..c39dec65ac5ca1f8e593099af3ab68aa2a039862
7d16be3https://github.com/googleapis/google-cloud-python/commit/7d16be36ee0c03785d3b5bc1c87ff5f9b0ce7aed
c39dec6https://github.com/googleapis/google-cloud-python/commit/c39dec65ac5ca1f8e593099af3ab68aa2a039862
Compare https://github.com/googleapis/google-cloud-python/compare/7d16be36ee0c03785d3b5bc1c87ff5f9b0ce7aed..c39dec65ac5ca1f8e593099af3ab68aa2a039862
May 1, 2026 21:58https://github.com/googleapis/google-cloud-python/pull/16622#event-25083942195
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
May 4, 2026 17:46https://github.com/googleapis/google-cloud-python/pull/16622#event-25143795154
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
May 4, 2026https://github.com/googleapis/google-cloud-python/pull/16622#issuecomment-4373309743
@partheahttps://github.com/parthea
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
https://github.com/sakthivelmanii
sakthivelmaniihttps://github.com/sakthivelmanii
sinhasubhamhttps://github.com/sinhasubham
June 17, 2026 09:21https://github.com/googleapis/google-cloud-python/pull/16622#event-26851954532
https://github.com/sinhasubham
sinhasubhamhttps://github.com/sinhasubham
Jun 18, 2026 https://github.com/googleapis/google-cloud-python/pull/16622#pullrequestreview-4523917287
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/16622/files/c39dec65ac5ca1f8e593099af3ab68aa2a039862
https://github.com/parthea
partheahttps://github.com/parthea
Aug 17, 2026https://github.com/googleapis/google-cloud-python/pull/16622#issuecomment-5318068681
#17911https://github.com/googleapis/google-cloud-python/pull/17911
#16622 (comment)https://github.com/googleapis/google-cloud-python/pull/16622#issue-4251069131
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
https://github.com/parthea
partheahttps://github.com/parthea
August 17, 2026 17:11https://github.com/googleapis/google-cloud-python/pull/16622#event-29571645377
[sqlalchemy-spanner]: _designate_type() raises KeyError on unrecognized Spanner column types instead of falling back to NullType #18839 https://github.com/googleapis/google-cloud-python/issues/18839
fix(sqlalchemy-spanner): reflect vector columns and unrecognized column types #18844 https://github.com/googleapis/google-cloud-python/pull/18844
https://github.com/rocksnow1942
rocksnow1942https://github.com/rocksnow1942
Oct 24, 2026https://github.com/googleapis/google-cloud-python/pull/16622#issuecomment-6382130992
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
@waiho-gumloophttps://github.com/waiho-gumloop
#18844https://github.com/googleapis/google-cloud-python/pull/18844
#18839https://github.com/googleapis/google-cloud-python/issues/18839
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F16622
https://github.com/sinhasubham
sinhasubham https://github.com/sinhasubham
https://github.com/googleapis/google-cloud-python/pull/16622/files/c39dec65ac5ca1f8e593099af3ab68aa2a039862
https://github.com/apps/gemini-code-assist
gemini-code-assist[bot] https://github.com/apps/gemini-code-assist
https://github.com/googleapis/google-cloud-python/pull/16622/files/83bf00a2090fdcbfa25b0f891a0572cbc682b130
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
https://github.com/olavloite
olavloite https://github.com/olavloite
sqlalchemy-spanner: _designate_type crashes with KeyError on TOKENLIST columns https://github.com/googleapis/google-cloud-python/issues/16621
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16622
https://github.com/waiho-gumloop
https://github.com/parthea
https://github.com/rocksnow1942
https://github.com/sinhasubham
https://github.com/olavloite
https://github.com/yoshi-kokoro
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.