René's URL Explorer Experiment


Title: fix: remove redundant MetricsCapture from trace_call by waiho-gumloop · Pull Request #16495 · googleapis/google-cloud-python · GitHub

Open Graph Title: fix: remove redundant MetricsCapture from trace_call by waiho-gumloop · Pull Request #16495 · googleapis/google-cloud-python

X Title: fix: remove redundant MetricsCapture from trace_call by waiho-gumloop · Pull Request #16495 · googleapis/google-cloud-python

Description: Google Cloud Client Libraries for Python. Contribute to googleapis/google-cloud-python development by creating an account on GitHub.

Open Graph Description: Summary trace_call() wraps every Spanner operation with a bare MetricsCapture() that creates a MetricsTracer without project_id or instance_id. Since every caller of trace_call already provides its...

X Description: Summary trace_call() wraps every Spanner operation with a bare MetricsCapture() that creates a MetricsTracer without project_id or instance_id. Since every caller of trace_call already provides its...

Opengraph URL: https://github.com/googleapis/google-cloud-python/pull/16495

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:038d1f1f-ae43-bec4-8ae8-4f75630ac90f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA56A:3BEF12:61B7E7:8F680F:6A4E0FDF
html-safe-noncee995837b07914e90b2ad586b914de55ee842e5e9d1b2b311dcd1958ae5bacb19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTZBOjNCRUYxMjo2MUI3RTc6OEY2ODBGOjZBNEUwRkRGIiwidmlzaXRvcl9pZCI6IjcyMzI5NDk5NTc2MzU2NDUxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8d4cc859e8fbb0ea77d787e56c72d6d4ff3798550496d711a0711d4af05d3b9b
hovercard-subject-tagpull_request:3474576361
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-python/16495/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ae4a042ef1b65a7e5b3257cf85380a86374d7f858063388c2f74253ee62723a2/googleapis/google-cloud-python/pull/16495
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ae4a042ef1b65a7e5b3257cf85380a86374d7f858063388c2f74253ee62723a2/googleapis/google-cloud-python/pull/16495
og:image:altSummary trace_call() wraps every Spanner operation with a bare MetricsCapture() that creates a MetricsTracer without project_id or instance_id. Since every caller of trace_call already provides its...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaiho-gumloop
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release51470c353b8a1f52a88d3e3cc2014b17ab8cc1ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/pull/16495#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F16495
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F16495
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/pull/16495
Reloadhttps://github.com/googleapis/google-cloud-python/pull/16495
Reloadhttps://github.com/googleapis/google-cloud-python/pull/16495
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16495
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 439 https://github.com/googleapis/google-cloud-python/issues
Pull requests 138 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
waiho-gumloophttps://github.com/waiho-gumloop
googleapis:mainhttps://github.com/googleapis/google-cloud-python/tree/main
waiho-gumloop:fix/remove-redundant-metrics-capturehttps://github.com/waiho-gumloop/google-cloud-python/tree/fix/remove-redundant-metrics-capture
Conversationhttps://github.com/googleapis/google-cloud-python/pull/16495
Commits1 (1)https://github.com/googleapis/google-cloud-python/pull/16495/commits
Checkshttps://github.com/googleapis/google-cloud-python/pull/16495/checks
Files changedhttps://github.com/googleapis/google-cloud-python/pull/16495/files
fix: remove redundant MetricsCapture from trace_callhttps://github.com/googleapis/google-cloud-python/pull/16495#top
waiho-gumloophttps://github.com/waiho-gumloop
googleapis:mainhttps://github.com/googleapis/google-cloud-python/tree/main
waiho-gumloop:fix/remove-redundant-metrics-capturehttps://github.com/waiho-gumloop/google-cloud-python/tree/fix/remove-redundant-metrics-capture
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
Apr 1, 2026https://github.com/googleapis/google-cloud-python/pull/16495#issue-4183143536
feat: Add Attempt, Operation and GFE Metrics python-spanner#1302https://github.com/googleapis/python-spanner/pull/1302
feat: implement native asyncio support via Cross-Sync python-spanner#1509https://github.com/googleapis/python-spanner/pull/1509
#16173https://github.com/googleapis/google-cloud-python/issues/16173
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16495
https://github.com/waiho-gumloop
fix: remove redundant MetricsCapture from trace_callhttps://github.com/googleapis/google-cloud-python/pull/16495/commits/195f0b0f7a18a151f8e1f17d9d1e1574cb5fa8aa
195f0b0https://github.com/googleapis/google-cloud-python/pull/16495/commits/195f0b0f7a18a151f8e1f17d9d1e1574cb5fa8aa
googleapis#16173https://github.com/googleapis/google-cloud-python/issues/16173
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
code ownershttps://github.com/googleapis/google-cloud-python/blob/14abfd57d486a393bb6227284aacdc7ec4c548b2/.github/CODEOWNERS#L5
April 1, 2026 00:11https://github.com/googleapis/google-cloud-python/pull/16495#event-24093347572
https://github.com/apps/gemini-code-assist
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Apr 1, 2026 https://github.com/googleapis/google-cloud-python/pull/16495#pullrequestreview-4040961199
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/16495/files/195f0b0f7a18a151f8e1f17d9d1e1574cb5fa8aa
gemini-code-assisthttps://github.com/apps/gemini-code-assist
https://github.com/googleapis/google-cloud-python/pull/16495#pullrequestreview-4040961199
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16495
https://github.com/waiho-gumloop
waiho-gumloophttps://github.com/waiho-gumloop
Apr 1, 2026 https://github.com/googleapis/google-cloud-python/pull/16495#ref-issue-4138663309
Redundant MetricsCapture in trace_call produces orphan metrics with incomplete resource labels #16173 https://github.com/googleapis/google-cloud-python/issues/16173
https://github.com/Eric-Jalal
Eric-Jalalhttps://github.com/Eric-Jalal
Apr 30, 2026 https://github.com/googleapis/google-cloud-python/pull/16495#pullrequestreview-4204013172
View reviewed changes https://github.com/googleapis/google-cloud-python/pull/16495/files/195f0b0f7a18a151f8e1f17d9d1e1574cb5fa8aa
https://github.com/Eric-Jalal
Eric-Jalalhttps://github.com/Eric-Jalal
Apr 30, 2026https://github.com/googleapis/google-cloud-python/pull/16495#issuecomment-4351299413
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16495
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16495
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fpull%2F16495
https://github.com/apps/gemini-code-assist
gemini-code-assist[bot] https://github.com/apps/gemini-code-assist
https://github.com/googleapis/google-cloud-python/pull/16495/files/195f0b0f7a18a151f8e1f17d9d1e1574cb5fa8aa
https://github.com/Eric-Jalal
Eric-Jalal https://github.com/Eric-Jalal
https://github.com/googleapis/google-cloud-python/pull/16495/files/195f0b0f7a18a151f8e1f17d9d1e1574cb5fa8aa
Redundant MetricsCapture in trace_call produces orphan metrics with incomplete resource labels https://github.com/googleapis/google-cloud-python/issues/16173
Please reload this pagehttps://github.com/googleapis/google-cloud-python/pull/16495
https://github.com/waiho-gumloop
https://github.com/Eric-Jalal
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.