René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Storage: Blob.delete returns self.bucket.delete_blob but delete_blob returns nothing","articleBody":"## Description\r\n\r\nIn this function docs returns part says returns `The blob that was just deleted.` but actually `self.bucket.delete_blob` didn't return anything and `rtype` also not `Blob` but `None`.\r\n\r\nI'm not sure the fault is that `Blob.delete` return unnecessary or `Bucket.delete_blob` didn't return after `blob` api_request.\r\n\r\n## Blob\r\n\r\n\u003chttps://github.com/googleapis/google-cloud-python/blob/master/storage/google/cloud/storage/blob.py#L548\u003e\r\n\r\n```python\r\n    def delete(self, client=None):\r\n        \"\"\"Deletes a blob from Cloud Storage.\r\n        If :attr:`user_project` is set on the bucket, bills the API request\r\n        to that project.\r\n        :type client: :class:`~google.cloud.storage.client.Client` or\r\n                      ``NoneType``\r\n        :param client: Optional. The client to use.  If not passed, falls back\r\n                       to the ``client`` stored on the blob's bucket.\r\n        :rtype: :class:`Blob`\r\n        :returns: The blob that was just deleted.\r\n        :raises: :class:`google.cloud.exceptions.NotFound`\r\n                 (propagated from\r\n                 :meth:`google.cloud.storage.bucket.Bucket.delete_blob`).\r\n        \"\"\"\r\n        return self.bucket.delete_blob(\r\n            self.name, client=client, generation=self.generation\r\n        )\r\n```\r\n\r\n## Bucket\r\n\r\n\u003chttps://github.com/googleapis/google-cloud-python/blob/master/storage/google/cloud/storage/bucket.py#L1055\u003e\r\n\r\n```python\r\n    def delete_blob(self, blob_name, client=None, generation=None):\r\n        \"\"\"Deletes a blob from the current bucket.\r\n        If the blob isn't found (backend 404), raises a\r\n        :class:`google.cloud.exceptions.NotFound`.\r\n        For example:\r\n        .. literalinclude:: snippets.py\r\n          :start-after: [START delete_blob]\r\n          :end-before: [END delete_blob]\r\n        If :attr:`user_project` is set, bills the API request to that project.\r\n        :type blob_name: str\r\n        :param blob_name: A blob name to delete.\r\n        :type client: :class:`~google.cloud.storage.client.Client` or\r\n                      ``NoneType``\r\n        :param client: Optional. The client to use.  If not passed, falls back\r\n                       to the ``client`` stored on the current bucket.\r\n        :type generation: long\r\n        :param generation: Optional. If present, permanently deletes a specific\r\n                           revision of this object.\r\n        :raises: :class:`google.cloud.exceptions.NotFound` (to suppress\r\n                 the exception, call ``delete_blobs``, passing a no-op\r\n                 ``on_error`` callback, e.g.:\r\n        .. literalinclude:: snippets.py\r\n            :start-after: [START delete_blobs]\r\n            :end-before: [END delete_blobs]\r\n        \"\"\"\r\n        client = self._require_client(client)\r\n        blob = Blob(blob_name, bucket=self, generation=generation)\r\n\r\n        # We intentionally pass `_target_object=None` since a DELETE\r\n        # request has no response value (whether in a standard request or\r\n        # in a batch request).\r\n        client._connection.api_request(\r\n            method=\"DELETE\",\r\n            path=blob.path,\r\n            query_params=blob._query_params,\r\n            _target_object=None,\r\n        )\r\n````\r\n","author":{"url":"https://github.com/sheiun","@type":"Person","name":"sheiun"},"datePublished":"2019-12-17T09:36:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/9985/google-cloud-python/issues/9985"}