René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"_PropertyMixin.patch() does not work as expected in a batch","articleBody":"One big takeaway is that `connection` should not be bound to `Blob` and `Bucket` (#728).\n\n---\n\nIf the `Bucket` does not explicitly have the `batch` set as it's connection, the request happens outside the batch:\n\n``` python\n\u003e\u003e\u003e from gcloud import storage\n\u003e\u003e\u003e from gcloud.storage.batch import Batch\n\u003e\u003e\u003e storage._PROJECT_ENV_VAR_NAME = 'GCLOUD_TESTS_PROJECT_ID'\n\u003e\u003e\u003e storage.set_defaults()\n\u003e\u003e\u003e bucket_name = 'dsmlmsldfsacjnajdnkewee'\n\u003e\u003e\u003e connection = storage.get_default_connection()\n\u003e\u003e\u003e bucket = storage.Bucket(name=bucket_name, connection=connection)\n\u003e\u003e\u003e blob = storage.Blob('foo', bucket=bucket)\n\u003e\u003e\u003e blob._reload_properties()\n\u003cBlob: dsmlmsldfsacjnajdnkewee, foo\u003e\n\u003e\u003e\u003e blob.content_type = 'foo/bar'\n\u003e\u003e\u003e\n\u003e\u003e\u003e with Batch() as batch:\n...     blob.patch()\n...\n\u003cBlob: dsmlmsldfsacjnajdnkewee, foo\u003e\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 2, in \u003cmodule\u003e\n  File \"gcloud/storage/batch.py\", line 165, in __exit__\n    self.finish()\n  File \"gcloud/storage/batch.py\", line 130, in finish\n    raise ValueError(\"No deferred requests\")\nValueError: No deferred requests\n```\n\nOn the other hand, if we do the setup correctly, it puts the `blob` in an undefined state (I [referenced](https://github.com/GoogleCloudPlatform/gcloud-python/pull/683#issuecomment-76275986) this some time ago):\n\n``` python\n\u003e\u003e\u003e from gcloud import storage\n\u003e\u003e\u003e from gcloud.storage.batch import Batch\n\u003e\u003e\u003e storage._PROJECT_ENV_VAR_NAME = 'GCLOUD_TESTS_PROJECT_ID'\n\u003e\u003e\u003e storage.set_defaults()\n\u003e\u003e\u003e\n\u003e\u003e\u003e with Batch() as batch:\n...     bucket_name = 'dsmlmsldfsacjnajdnkewee'\n...     bucket = storage.Bucket(name=bucket_name, connection=batch)\n...     blob = storage.Blob('foo', bucket=bucket)\n...     blob.content_type = 'foo/bar'\n...     blob.patch()\n...\n\u003cBlob: dsmlmsldfsacjnajdnkewee, foo\u003e\n\u003e\u003e\u003e blob._properties\n''\n\u003e\u003e\u003e blob.content_type\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"gcloud/storage/_helpers.py\", line 163, in _getter\n    return self.properties[fieldname]\n  File \"gcloud/storage/_helpers.py\", line 64, in properties\n    return self._properties.copy()\nAttributeError: 'str' object has no attribute 'copy'\n```\n","author":{"url":"https://github.com/dhermes","@type":"Person","name":"dhermes"},"datePublished":"2015-03-14T21:23:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/736/google-cloud-python/issues/736"}