Title: Remove datastore.Dataset class · Issue #477 · googleapis/google-cloud-python · GitHub
Open Graph Title: Remove datastore.Dataset class · Issue #477 · googleapis/google-cloud-python
X Title: Remove datastore.Dataset class · Issue #477 · googleapis/google-cloud-python
Description: The replacement will be handled by a string when dataset ID is explicitly needed (which will only be for power users). Some functionality will be moved to key.Key and the rest to the connection module as free functions. In order to make ...
Open Graph Description: The replacement will be handled by a string when dataset ID is explicitly needed (which will only be for power users). Some functionality will be moved to key.Key and the rest to the connection mod...
X Description: The replacement will be handled by a string when dataset ID is explicitly needed (which will only be for power users). Some functionality will be moved to key.Key and the rest to the connection mod...
Opengraph URL: https://github.com/googleapis/google-cloud-python/issues/477
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove datastore.Dataset class","articleBody":"The replacement will be handled by a string when dataset ID is explicitly needed (which will only be for power users). Some functionality will be moved to `key.Key` and the rest to the `connection` module as free functions. In order to make use easier, they will also have versions in `__init__` which can use a default / implicit connection.\n\nSteps to complete:\n- [x] Make `set_default_connection` similar to [`set_default_dataset`](https://github.com/GoogleCloudPlatform/gcloud-python/blob/b79d8624950b3b205de20f527488dde7aa8c8cd8/gcloud/datastore/__init__.py#L61) (#478)\n- [x] Remove ~~`query()`,~~ `entity()`, and `transaction()` methods from `Dataset`, replace their use elsewhere. (#479)\n- [x] Move `Dataset.get_entity` to `Key` (will impact elsewhere, e.g. `Entity.reload`) (#480)\n- [x] Move ~~`save()` and `delete()` methods~~ `delete()` method from `Entity` to `Key` (#481)\n- [x] Move `allocate_ids()` method from `Dataset` to ~~`connection`~~ `__init__` module as free function (#482)\n- [x] Move `get_entities()` method from `Dataset` to ~~`connection`~~ `__init__` module as free function (#483)\n- [x] Fix ~~#484, #485, #486~~ - Lots to do to re-make `Entity`, `Query`, and `Transaction` to not depend on `Dataset`\n- [x] Remove all remnants of `Dataset` (e.g. `set_default_dataset`, `Entity._must_dataset`, and `_implicit_environ._DatastoreBase`)\n- [x] Update stale documentation\n\n**NOTE**: Don't close until `cyclic-import` in #480 is resolved.\n\nSee https://docs.google.com/document/d/1xKw8Tz6lfN5uOcv0my4uUgFSeDoRzwCLho2UGlBpqDU/edit for more.\n","author":{"url":"https://github.com/dhermes","@type":"Person","name":"dhermes"},"datePublished":"2015-01-02T19:26:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/477/google-cloud-python/issues/477"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4b3e142d-0f69-a730-5bad-c66dcb47287e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 86DA:3FF092:57ADDF:77853D:6A4DAA75 |
| html-safe-nonce | b4a4edf548c5d19f45f8ea48a05a9efb452f78e1afeea3ea3f913d76717049d6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkRBOjNGRjA5Mjo1N0FEREY6Nzc4NTNEOjZBNERBQTc1IiwidmlzaXRvcl9pZCI6IjY1MDM2MTcxOTQyNDg0ODEzOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b05a5a11078c7bfa14b031490c6ef563d112ede81222a3b501515539cc7edb89 |
| hovercard-subject-tag | issue:53271989 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/google-cloud-python/477/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e68c477b863df4fd028cfe783df293032fa6f19caabce7268b01b114e6601810/googleapis/google-cloud-python/issues/477 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e68c477b863df4fd028cfe783df293032fa6f19caabce7268b01b114e6601810/googleapis/google-cloud-python/issues/477 |
| og:image:alt | The replacement will be handled by a string when dataset ID is explicitly needed (which will only be for power users). Some functionality will be moved to key.Key and the rest to the connection mod... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dhermes |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 16316451 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16316451 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 47723578ce6819210724ef064c858fce6d3115a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width