René's URL Explorer Experiment


Title: Key id / name should fail if set to 0 / '' · Issue #443 · googleapis/google-cloud-python · GitHub

Open Graph Title: Key id / name should fail if set to 0 / '' · Issue #443 · googleapis/google-cloud-python

X Title: Key id / name should fail if set to 0 / '' · Issue #443 · googleapis/google-cloud-python

Description: In Key.id(), the check def id(self, id_to_set=None): ... if id_to_set: clone = self._clone() also ignores False-y objects other than None. This means it ignores the integer 0, which would seem to be a valid ID. However, the backend actua...

Open Graph Description: In Key.id(), the check def id(self, id_to_set=None): ... if id_to_set: clone = self._clone() also ignores False-y objects other than None. This means it ignores the integer 0, which would seem to b...

X Description: In Key.id(), the check def id(self, id_to_set=None): ... if id_to_set: clone = self._clone() also ignores False-y objects other than None. This means it ignores the integer 0, which would seem to b...

Opengraph URL: https://github.com/googleapis/google-cloud-python/issues/443

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Key id / name should fail if set to 0 / ''","articleBody":"In [`Key.id()`](https://github.com/GoogleCloudPlatform/gcloud-python/blob/8a6feffb5381a7d738c8ecfd0e4d85efd4564dfe/gcloud/datastore/key.py#L188), the check\n\n``` python\n    def id(self, id_to_set=None):\n        ...\n        if id_to_set:\n            clone = self._clone()\n```\n\nalso ignores `False`-y objects other than `None`.\n\nThis means it ignores the integer `0`, which would seem to be a valid ID. However, the backend actually rejects this, so maybe this bug only requires fixing the docstring?\n\n``` python\n\u003e\u003e\u003e from gcloud import datastore\n\u003e\u003e\u003e cnxn = datastore.get_connection()\n\u003e\u003e\u003e import os\n\u003e\u003e\u003e dataset = cnxn.dataset(os.getenv('GCLOUD_TESTS_DATASET_ID'))\n\u003e\u003e\u003e entity = dataset.entity('foo')\n\u003e\u003e\u003e entity.key()._path\n[{'kind': 'foo'}]\n\u003e\u003e\u003e entity.key()._path[0]['id'] = 0\n\u003e\u003e\u003e entity\n\u003cEntity[{'kind': 'foo', 'id': 0}] {}\u003e\n\u003e\u003e\u003e entity['bar'] = u'baz'\n\u003e\u003e\u003e entity.save()\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"gcloud/datastore/entity.py\", line 246, in save\n    exclude_from_indexes=self.exclude_from_indexes())\n  File \"gcloud/datastore/connection.py\", line 477, in save_entity\n    result = self.commit(dataset_id, mutation)\n  File \"gcloud/datastore/connection.py\", line 377, in commit\n    datastore_pb.CommitResponse)\n  File \"gcloud/datastore/connection.py\", line 95, in _rpc\n    data=request_pb.SerializeToString())\n  File \"gcloud/datastore/connection.py\", line 73, in _request\n    raise Exception('Request failed. Error was: %s' % content)\nException: Request failed. Error was: Key path id is invalid. Must not be zero.\n```\n\n/cc @pcostell \n","author":{"url":"https://github.com/dhermes","@type":"Person","name":"dhermes"},"datePublished":"2014-12-18T22:29:36.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/443/google-cloud-python/issues/443"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:af303cfa-8e56-4796-77e6-1dfb80b77446
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8E0A:135B7:17826E7:2068C30:6A4DF68D
html-safe-nonce0a4d224ca6e9eb881020a0963a63839ac3dfb9f9465573128ba1003d3ee71c04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTBBOjEzNUI3OjE3ODI2RTc6MjA2OEMzMDo2QTRERjY4RCIsInZpc2l0b3JfaWQiOiI2ODE3NDUyMTcyNTU0MTM5Mjc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac280e4c4cc77436b4ed519e16c9f9944aeadffdeeeb43d71942425fc30975bf5f
hovercard-subject-tagissue:52424778
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/google-cloud-python/443/issue_layout
twitter:imagehttps://opengraph.githubassets.com/96df5cde6346d1834b4ee9fbd9ba6a7bb89ae22b60e2f3933b5dae85edde14e4/googleapis/google-cloud-python/issues/443
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/96df5cde6346d1834b4ee9fbd9ba6a7bb89ae22b60e2f3933b5dae85edde14e4/googleapis/google-cloud-python/issues/443
og:image:altIn Key.id(), the check def id(self, id_to_set=None): ... if id_to_set: clone = self._clone() also ignores False-y objects other than None. This means it ignores the integer 0, which would seem to b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedhermes
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-preview
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef4bb89367ca678f057d79b1abc45d6675b1bd5b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/issues/443#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2F443
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2F443
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/issues/443
Reloadhttps://github.com/googleapis/google-cloud-python/issues/443
Reloadhttps://github.com/googleapis/google-cloud-python/issues/443
Please reload this pagehttps://github.com/googleapis/google-cloud-python/issues/443
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 439 https://github.com/googleapis/google-cloud-python/issues
Pull requests 132 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Key id / name should fail if set to 0 / ''https://github.com/googleapis/google-cloud-python/issues/443#top
https://github.com/dhermes
🚨This issue needs some love.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22%3Arotating_light%3A%22
api: datastoreIssues related to the Datastore API.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20datastore%22
triage meI really want to be triaged.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22triage%20me%22
https://github.com/dhermes
dhermeshttps://github.com/dhermes
on Dec 18, 2014https://github.com/googleapis/google-cloud-python/issues/443#issue-52424778
Key.id()https://github.com/GoogleCloudPlatform/gcloud-python/blob/8a6feffb5381a7d738c8ecfd0e4d85efd4564dfe/gcloud/datastore/key.py#L188
@pcostellhttps://github.com/pcostell
dhermeshttps://github.com/dhermes
🚨This issue needs some love.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22%3Arotating_light%3A%22
api: datastoreIssues related to the Datastore API.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20datastore%22
triage meI really want to be triaged.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22triage%20me%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.