René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Datastore: unexpected keyword arg in DS client","articleBody":"Commit 9246de7a7138fabb3f25dceb50715de445684323 introduced following bug:\r\n```\r\n  File \"/usr/local/lib/python2.7/dist-packages/google/cloud/datastore/client.py\", line 321, in get\r\n    eventual=eventual)\r\n  File \"/usr/local/lib/python2.7/dist-packages/google/cloud/datastore/client.py\", line 376, in get_multi\r\n    transaction_id=transaction and transaction.id,\r\n  File \"/usr/local/lib/python2.7/dist-packages/google/cloud/datastore/client.py\", line 138, in _extended_lookup\r\n    keys=key_pbs,\r\nTypeError: lookup() got an unexpected keyword argument 'project_id'\r\n```\r\n\r\nPatch\r\n```diff\r\nFrom 7470329ecf13d9f85bfe8af71ee533856ff9ec4c Mon Sep 17 00:00:00 2001\r\nFrom: mathewcohle \u003cmathewcohle@gmail.com\u003e\r\nDate: Mon, 13 Nov 2017 11:41:01 +0100\r\nSubject: [PATCH] Fix wrong keyword argument name introduced in #4348\r\n\r\n---\r\n datastore/google/cloud/datastore/client.py | 2 +-\r\n 1 file changed, 1 insertion(+), 1 deletion(-)\r\n\r\ndiff --git a/datastore/google/cloud/datastore/client.py b/datastore/google/cloud/datastore/client.py\r\nindex a3d1f9d43..c42c75e32 100644\r\n--- a/datastore/google/cloud/datastore/client.py\r\n+++ b/datastore/google/cloud/datastore/client.py\r\n@@ -133,7 +133,7 @@ def _extended_lookup(datastore_api, project, key_pbs,\r\n     while loop_num \u003c _MAX_LOOPS:  # loop against possible deferred.\r\n         loop_num += 1\r\n         lookup_response = datastore_api.lookup(\r\n-            project_id=project,\r\n+            project=project,\r\n             read_options=read_options,\r\n             keys=key_pbs,\r\n         )\r\n-- \r\n2.15.0\r\n```\r\n\r\nInfo (datastore installed from current master via `pip install git+https://github.com/GoogleCloudPlatform/google-cloud-python.git#subdirectory=datastore`)\r\n```\r\n$ pip freeze | grep google\r\n\r\ngapic-google-cloud-error-reporting-v1beta1==0.15.3\r\ngapic-google-cloud-logging-v2==0.91.3\r\ngax-google-logging-v2==0.8.3\r\ngax-google-pubsub-v1==0.8.3\r\ngoogle-api-core==0.1.1\r\ngoogle-api-python-client==1.6.4\r\ngoogle-auth==1.2.0\r\ngoogle-cloud==0.30.1.dev1\r\ngoogle-cloud-bigquery==0.28.0\r\ngoogle-cloud-bigtable==0.28.1\r\ngoogle-cloud-core==0.28.0\r\ngoogle-cloud-datastore==1.4.1.dev1\r\ngoogle-cloud-dns==0.28.0\r\ngoogle-cloud-error-reporting==0.28.0\r\ngoogle-cloud-firestore==0.28.0\r\ngoogle-cloud-language==1.0.0\r\ngoogle-cloud-logging==1.4.0\r\ngoogle-cloud-monitoring==0.28.0\r\ngoogle-cloud-pubsub==0.29.0\r\ngoogle-cloud-resource-manager==0.28.0\r\ngoogle-cloud-runtimeconfig==0.28.0\r\ngoogle-cloud-spanner==0.29.0\r\ngoogle-cloud-speech==0.30.0\r\ngoogle-cloud-storage==1.6.0\r\ngoogle-cloud-trace==0.16.0\r\ngoogle-cloud-translate==1.3.0\r\ngoogle-cloud-videointelligence==0.28.0\r\ngoogle-cloud-vision==0.28.0\r\ngoogle-gax==0.12.5\r\ngoogle-resumable-media==0.3.1\r\ngoogleapis-common-protos==1.5.3\r\ngrpc-google-iam-v1==0.11.4\r\ngrpc-google-logging-v2==0.8.1\r\ngrpc-google-pubsub-v1==0.8.1\r\nproto-google-cloud-error-reporting-v1beta1==0.15.3\r\nproto-google-cloud-logging-v2==0.91.3\r\n```","author":{"url":"https://github.com/mathewcohle","@type":"Person","name":"mathewcohle"},"datePublished":"2017-11-13T12:39:58.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/4387/google-cloud-python/issues/4387"}