René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Cloud Spanner client incorrectly handles NOT_FOUND error returned by create database","articleBody":"While creating a database, is the backend returns NOT_FOUND error, the client assumes it to indicate that instance is not found and thus returns \"Instance not found\" error message:\r\nhttps://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/spanner/google/cloud/spanner_v1/database.py#L213\r\n\r\nThis is not always the case as cloud spanner can return NOT_FOUND in other scenarios. For eg in the \"CREATE INDEX ... \" ddl statement that table that the index is being created on does not exist it would return a NOT_FOUND.  I think the fix would be to just pass the error message returned by the rpc to the user.\r\n\r\nThis can be reproduced using:\r\n```python\r\nfrom google.cloud import spanner\r\n\r\n\"\"\"Creates a database and tables for pattern 1 sample data.\"\"\"\r\n\r\nspanner_client = spanner.Client()\r\n\r\ninstance = spanner_client.instance(\"test-instance\")\r\n\r\n\r\n\r\ndatabase = instance.database(\"bitemporal_pattern1\", ddl_statements=[\r\n\r\n    \"\"\"CREATE TABLE MyTable (\r\n\r\n        Id        String(36) NOT NULL,\r\n\r\n        Field1  STRING(36) NOT NULL\r\n\r\n) PRIMARY KEY (Id)\"\"\"\r\n\r\n,\r\n\r\n\"\"\"CREATE INDEX IDX ON yTable (Field1)\"\"\"\r\n\r\n])\r\n\r\n\r\n\r\noperation = database.create()\r\n\r\n\r\n\r\nprint('Waiting for operation to complete...')\r\n\r\noperation.result()\r\n```","author":{"url":"https://github.com/vkedia","@type":"Person","name":"vkedia"},"datePublished":"2017-09-27T00:34:40.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/4071/google-cloud-python/issues/4071"}