Title: get_target_packages has dependencies in the wrong direction · Issue #3466 · googleapis/google-cloud-python · GitHub
Open Graph Title: get_target_packages has dependencies in the wrong direction · Issue #3466 · googleapis/google-cloud-python
X Title: get_target_packages has dependencies in the wrong direction · Issue #3466 · googleapis/google-cloud-python
Description: We are adding dependencies during changes: answer = answer.union(PKG_DEPENDENCIES.get(package, set())) but this makes a build with logging only changes trigger BigQuery, Pub / Sub and Storage: $ #!/bin/bash -eo pipefail python3.6 test_ut...
Open Graph Description: We are adding dependencies during changes: answer = answer.union(PKG_DEPENDENCIES.get(package, set())) but this makes a build with logging only changes trigger BigQuery, Pub / Sub and Storage: $ #!...
X Description: We are adding dependencies during changes: answer = answer.union(PKG_DEPENDENCIES.get(package, set())) but this makes a build with logging only changes trigger BigQuery, Pub / Sub and Storage: $ #!...
Opengraph URL: https://github.com/googleapis/google-cloud-python/issues/3466
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"get_target_packages has dependencies in the wrong direction","articleBody":"We are [adding dependencies][1] during changes:\r\n\r\n```python\r\nanswer = answer.union(PKG_DEPENDENCIES.get(package, set()))\r\n```\r\n\r\nbut this makes a [build][3] with `logging` only changes [trigger][2] BigQuery, Pub / Sub and Storage:\r\n\r\n```\r\n$ #!/bin/bash -eo pipefail\r\n python3.6 test_utils/scripts/get_target_packages.py \u003e ~/target_packages\r\n cat ~/target_packages\r\n\r\nbigquery\r\nlogging\r\npubsub\r\nstorage\r\n```\r\n\r\n- `logging` **depends** on `bigquery`, `pubsub`, `storage`\r\n- `error_reporting` **depends** on `logging`\r\n\r\nSo the real output should be a reverse of the dependency map:\r\n\r\n```python\r\n{'logging', 'error_reporting'}\r\n```\r\n[1]: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/85fd45a9558f9347dd87abb40a4ce1872b730aec/test_utils/scripts/get_target_packages.py#L150\r\n[2]: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/85fd45a9558f9347dd87abb40a4ce1872b730aec/test_utils/scripts/get_target_packages.py#L43\r\n[3]: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2063","author":{"url":"https://github.com/dhermes","@type":"Person","name":"dhermes"},"datePublished":"2017-06-02T19:58:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/3466/google-cloud-python/issues/3466"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:075e7b4f-2950-39a6-3509-69eebfccfc78 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8AC6:3678A:B5DA6:F88E3:6A4D274D |
| html-safe-nonce | cfc942cc21dc1016449f5ca371ed7e60c883545246b262f27511cb22d19409f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUM2OjM2NzhBOkI1REE2OkY4OEUzOjZBNEQyNzREIiwidmlzaXRvcl9pZCI6IjY1Mjk1NDUxNTE2MDUxODg0MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0f9d0ce1c00d44e2b7c643b5d42af8a7ead8948fdeac5ad4212e168094593305 |
| hovercard-subject-tag | issue:233283572 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/google-cloud-python/3466/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ed47bbe805afc2e977a32d5280d256da8da95217fd2ccc4ffdad107452ff1612/googleapis/google-cloud-python/issues/3466 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ed47bbe805afc2e977a32d5280d256da8da95217fd2ccc4ffdad107452ff1612/googleapis/google-cloud-python/issues/3466 |
| og:image:alt | We are adding dependencies during changes: answer = answer.union(PKG_DEPENDENCIES.get(package, set())) but this makes a build with logging only changes trigger BigQuery, Pub / Sub and Storage: $ #!... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dhermes |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 16316451 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16316451 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 93f17a978ee60bc4668e1d7b90e6bd2d622261fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width