René's URL Explorer Experiment


Title: DISCUSSION: Are setter methods which clone and return object type confusing to end-users? · Issue #188 · googleapis/google-cloud-python · GitHub

Open Graph Title: DISCUSSION: Are setter methods which clone and return object type confusing to end-users? · Issue #188 · googleapis/google-cloud-python

X Title: DISCUSSION: Are setter methods which clone and return object type confusing to end-users? · Issue #188 · googleapis/google-cloud-python

Description: Methods like datastore.key.Key.dataset act as both setters and getters and return a different type of object depending on whether they set or get. In this case key.dataset(dataset=NEW_DATASET) returns a new clone Key object (to keep the ...

Open Graph Description: Methods like datastore.key.Key.dataset act as both setters and getters and return a different type of object depending on whether they set or get. In this case key.dataset(dataset=NEW_DATASET) retu...

X Description: Methods like datastore.key.Key.dataset act as both setters and getters and return a different type of object depending on whether they set or get. In this case key.dataset(dataset=NEW_DATASET) retu...

Opengraph URL: https://github.com/googleapis/google-cloud-python/issues/188

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"DISCUSSION: Are setter methods which clone and return object type confusing to end-users?","articleBody":"Methods like [`datastore.key.Key.dataset`](https://github.com/GoogleCloudPlatform/gcloud-python/blob/b97ce739519c69dc98c2fcab4d52783defa43c62/gcloud/datastore/key.py#L97) act as both setters and getters and return a different type of object depending on whether they set or get.\n\nIn this case `key.dataset(dataset=NEW_DATASET)` returns a new clone `Key` object (to keep the instances immutable, as @tseaver pointed out was discussed in #3) where `key.dataset()` simply returns a `datastore.dataset.Dataset` object.\n\nFor me (@dhermes) it's really a method which is somewhat overloaded in it's scope (though I'll acknowledge the code is typically short).\n\nI'd be much more in favor of two separate methods for getting and setting, i.e.\n`update_dataset` as a method and `dataset` decorated with `@property` as a getter only.\n\n``` python\ncurr_dataset = key.dataset  # Actually a getter.\nnew_key = key.update_dataset(dataset=NEW_DATASET)\n```\n","author":{"url":"https://github.com/dhermes","@type":"Person","name":"dhermes"},"datePublished":"2014-09-25T18:29:40.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/188/google-cloud-python/issues/188"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:27e880f1-345d-f206-bc4a-7d9e978cd2dc
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB81E:3CB688:3769F3:4B5494:6A4D9F3F
html-safe-noncefd17691201384fe6f6177df72c72ffba200bd604fa47b86c774512b8f3fdff50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODFFOjNDQjY4ODozNzY5RjM6NEI1NDk0OjZBNEQ5RjNGIiwidmlzaXRvcl9pZCI6Ijc1Nzk4MDAzMTYzMTQyMzA1OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca53f89cf1974f684779f4e3f258d383cbe17cae5d8698ec59a2f303161ff49e8
hovercard-subject-tagissue:43951063
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/google-cloud-python/188/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8c6a62ec6a5368db89d337435e1b4339fcccf9c28f3b608f472f76be487ba281/googleapis/google-cloud-python/issues/188
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c6a62ec6a5368db89d337435e1b4339fcccf9c28f3b608f472f76be487ba281/googleapis/google-cloud-python/issues/188
og:image:altMethods like datastore.key.Key.dataset act as both setters and getters and return a different type of object depending on whether they set or get. In this case key.dataset(dataset=NEW_DATASET) retu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedhermes
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7f13faa65cccc9b729d674da83335d5dcfdfd193
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/issues/188#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2F188
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2F188
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/issues/188
Reloadhttps://github.com/googleapis/google-cloud-python/issues/188
Reloadhttps://github.com/googleapis/google-cloud-python/issues/188
Please reload this pagehttps://github.com/googleapis/google-cloud-python/issues/188
googleapis https://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Fork 1.7k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Star 5.3k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-python
Code https://github.com/googleapis/google-cloud-python
Issues 439 https://github.com/googleapis/google-cloud-python/issues
Pull requests 129 https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality 0 https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
Code https://github.com/googleapis/google-cloud-python
Issues https://github.com/googleapis/google-cloud-python/issues
Pull requests https://github.com/googleapis/google-cloud-python/pulls
Discussions https://github.com/googleapis/google-cloud-python/discussions
Actions https://github.com/googleapis/google-cloud-python/actions
Projects https://github.com/googleapis/google-cloud-python/projects
Security and quality https://github.com/googleapis/google-cloud-python/security
Insights https://github.com/googleapis/google-cloud-python/pulse
DISCUSSION: Are setter methods which clone and return object type confusing to end-users?https://github.com/googleapis/google-cloud-python/issues/188#top
https://github.com/dhermes
type: questionRequest for information or clarification. Not an issue.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22type%3A%20question%22
https://github.com/dhermes
dhermeshttps://github.com/dhermes
on Sep 25, 2014https://github.com/googleapis/google-cloud-python/issues/188#issue-43951063
datastore.key.Key.datasethttps://github.com/GoogleCloudPlatform/gcloud-python/blob/b97ce739519c69dc98c2fcab4d52783defa43c62/gcloud/datastore/key.py#L97
@tseaverhttps://github.com/tseaver
#3https://github.com/googleapis/google-cloud-python/issues/3
@dhermeshttps://github.com/dhermes
dhermeshttps://github.com/dhermes
type: questionRequest for information or clarification. Not an issue.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22type%3A%20question%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.