Title: DISCUSSION: Are setter methods which clone and return object type confusing to end-users? · Issue #188 · googleapis/google-cloud-python · GitHub
Open Graph Title: DISCUSSION: Are setter methods which clone and return object type confusing to end-users? · Issue #188 · googleapis/google-cloud-python
X Title: DISCUSSION: Are setter methods which clone and return object type confusing to end-users? · Issue #188 · googleapis/google-cloud-python
Description: Methods like datastore.key.Key.dataset act as both setters and getters and return a different type of object depending on whether they set or get. In this case key.dataset(dataset=NEW_DATASET) returns a new clone Key object (to keep the ...
Open Graph Description: Methods like datastore.key.Key.dataset act as both setters and getters and return a different type of object depending on whether they set or get. In this case key.dataset(dataset=NEW_DATASET) retu...
X Description: Methods like datastore.key.Key.dataset act as both setters and getters and return a different type of object depending on whether they set or get. In this case key.dataset(dataset=NEW_DATASET) retu...
Opengraph URL: https://github.com/googleapis/google-cloud-python/issues/188
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"DISCUSSION: Are setter methods which clone and return object type confusing to end-users?","articleBody":"Methods like [`datastore.key.Key.dataset`](https://github.com/GoogleCloudPlatform/gcloud-python/blob/b97ce739519c69dc98c2fcab4d52783defa43c62/gcloud/datastore/key.py#L97) act as both setters and getters and return a different type of object depending on whether they set or get.\n\nIn this case `key.dataset(dataset=NEW_DATASET)` returns a new clone `Key` object (to keep the instances immutable, as @tseaver pointed out was discussed in #3) where `key.dataset()` simply returns a `datastore.dataset.Dataset` object.\n\nFor me (@dhermes) it's really a method which is somewhat overloaded in it's scope (though I'll acknowledge the code is typically short).\n\nI'd be much more in favor of two separate methods for getting and setting, i.e.\n`update_dataset` as a method and `dataset` decorated with `@property` as a getter only.\n\n``` python\ncurr_dataset = key.dataset # Actually a getter.\nnew_key = key.update_dataset(dataset=NEW_DATASET)\n```\n","author":{"url":"https://github.com/dhermes","@type":"Person","name":"dhermes"},"datePublished":"2014-09-25T18:29:40.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/188/google-cloud-python/issues/188"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:27e880f1-345d-f206-bc4a-7d9e978cd2dc |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B81E:3CB688:3769F3:4B5494:6A4D9F3F |
| html-safe-nonce | fd17691201384fe6f6177df72c72ffba200bd604fa47b86c774512b8f3fdff50 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODFFOjNDQjY4ODozNzY5RjM6NEI1NDk0OjZBNEQ5RjNGIiwidmlzaXRvcl9pZCI6Ijc1Nzk4MDAzMTYzMTQyMzA1OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a53f89cf1974f684779f4e3f258d383cbe17cae5d8698ec59a2f303161ff49e8 |
| hovercard-subject-tag | issue:43951063 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/google-cloud-python/188/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8c6a62ec6a5368db89d337435e1b4339fcccf9c28f3b608f472f76be487ba281/googleapis/google-cloud-python/issues/188 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8c6a62ec6a5368db89d337435e1b4339fcccf9c28f3b608f472f76be487ba281/googleapis/google-cloud-python/issues/188 |
| og:image:alt | Methods like datastore.key.Key.dataset act as both setters and getters and return a different type of object depending on whether they set or get. In this case key.dataset(dataset=NEW_DATASET) retu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dhermes |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 16316451 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16316451 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7f13faa65cccc9b729d674da83335d5dcfdfd193 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width