René's URL Explorer Experiment


Title: Record streaming attempt and front-end metrics when PartialResultSet.last=True is observed · Issue #18656 · googleapis/google-cloud-python · GitHub

Open Graph Title: Record streaming attempt and front-end metrics when PartialResultSet.last=True is observed · Issue #18656 · googleapis/google-cloud-python

X Title: Record streaming attempt and front-end metrics when PartialResultSet.last=True is observed · Issue #18656 · googleapis/google-cloud-python

Description: Description In google-cloud-spanner, streaming queries that receive PartialResultSet.last = True hand off the underlying response iterator to _GLOBAL_STREAM_DRAINER to drain trailing metadata to EOF asynchronously on a background worker ...

Open Graph Description: Description In google-cloud-spanner, streaming queries that receive PartialResultSet.last = True hand off the underlying response iterator to _GLOBAL_STREAM_DRAINER to drain trailing metadata to EO...

X Description: Description In google-cloud-spanner, streaming queries that receive PartialResultSet.last = True hand off the underlying response iterator to _GLOBAL_STREAM_DRAINER to drain trailing metadata to EO...

Opengraph URL: https://github.com/googleapis/google-cloud-python/issues/18656

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Record streaming attempt and front-end metrics when PartialResultSet.last=True is observed","articleBody":"### Description\n\nIn `google-cloud-spanner`, streaming queries that receive `PartialResultSet.last = True` hand off the underlying response iterator to `_GLOBAL_STREAM_DRAINER` to drain trailing metadata to EOF asynchronously on a background worker thread (in `snapshot.py`).\n\nHowever, `_StreamingResponseWrapper` in `metrics_interceptor.py` currently defers recording attempt completion (`attempt_latencies`) and front-end timing metrics (`gfe_latencies`, `afe_latencies`) until `StopIteration` is raised:\nhttps://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-spanner/google/cloud/spanner_v1/metrics/metrics_interceptor.py\n\nThis causes two issues:\n1. **Metric Timing Inaccuracy**: Attempt latency should measure when the operation actually completes from an outside observer's perspective (i.e. when `PartialResultSet.last = True` is received by the caller), rather than including time spent waiting in the background drainer queue or consuming trailing stream metadata.\n2. **Race Condition with Metrics Readers**: Callers that complete a query and immediately collect or inspect metrics observe missing `attempt_latencies`, `gfe_latencies`, and `afe_latencies` because the background drainer thread has not yet reached EOF.\n\n### Proposed Solution\n\nThe client should measure attempt completion and record front-end metrics as soon as `PartialResultSet.last == True` is observed on the stream, rather than waiting for `StopIteration` during background stream draining.","author":{"url":"https://github.com/olavloite","@type":"Person","name":"olavloite"},"datePublished":"2026-10-13T09:55:49Z","url":"https://github.com/googleapis/google-cloud-python/issues/18656"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4ce6d5e6-82aa-9fb7-f3c8-d35e8f3566b6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8840:66EFA:9E092:D5531:6AFE1F66
html-safe-nonce17f24eae6a28edc9a9c32af66c70da741eba1668b99cb8e1c8174c25c8c5cbb9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODQwOjY2RUZBOjlFMDkyOkQ1NTMxOjZBRkUxRjY2IiwidmlzaXRvcl9pZCI6IjYwMzI2NjM4OTQxMzA4MjcxMTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5c0f06210e79cb46c4dd30b4e6a408db5c68dc3e2ca41e192a5af55c5bd6b200
hovercard-subject-tagissue:5828263985
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/google-cloud-python/18656/issue_layout
twitter:imagehttps://opengraph.githubassets.com/db63351c97d9dec13dc48ad54227a9c63d3a098cb5a8300ed91e2b637440e18d/googleapis/google-cloud-python/issues/18656
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/db63351c97d9dec13dc48ad54227a9c63d3a098cb5a8300ed91e2b637440e18d/googleapis/google-cloud-python/issues/18656
og:image:altDescription In google-cloud-spanner, streaming queries that receive PartialResultSet.last = True hand off the underlying response iterator to _GLOBAL_STREAM_DRAINER to drain trailing metadata to EO...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameolavloite
hostnamegithub.com
expected-hostnamegithub.com
Noned0525ab1464526bf4532a5551aa348cf100dff75ef808a96fc67a08b1d946aa9
turbo-cache-controlno-preview
go-importgithub.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id16316451
octolytics-dimension-repository_nwogoogleapis/google-cloud-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16316451
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefef3993a71fa20f7be8e167132fbf9619bc66e12
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-python/issues/18656#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2F18656
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-python%2Fissues%2F18656
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-python
Reloadhttps://github.com/googleapis/google-cloud-python/issues/18656
Reloadhttps://github.com/googleapis/google-cloud-python/issues/18656
Reloadhttps://github.com/googleapis/google-cloud-python/issues/18656
googleapishttps://github.com/googleapis
google-cloud-pythonhttps://github.com/googleapis/google-cloud-python
Codehttps://github.com/googleapis/google-cloud-python
Issues449 (449)https://github.com/googleapis/google-cloud-python/issues
Pull requests199 (199)https://github.com/googleapis/google-cloud-python/pulls
Discussionshttps://github.com/googleapis/google-cloud-python/discussions
Actionshttps://github.com/googleapis/google-cloud-python/actions
Projectshttps://github.com/googleapis/google-cloud-python/projects
Security and qualityhttps://github.com/googleapis/google-cloud-python/security
Insightshttps://github.com/googleapis/google-cloud-python/insights
https://github.com/googleapis/google-cloud-python
New issuehttps://github.com/login?return_to=https://github.com/googleapis/google-cloud-python/issues/18656
New issuehttps://github.com/login?return_to=https://github.com/googleapis/google-cloud-python/issues/18656
Record streaming attempt and front-end metrics when PartialResultSet.last=True is observedhttps://github.com/googleapis/google-cloud-python/issues/18656#top
https://github.com/olavloite
api: spannerIssues related to the Spanner API.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20spanner%22
https://github.com/olavloite
olavloitehttps://github.com/olavloite
on Oct 13, 2026https://github.com/googleapis/google-cloud-python/issues/18656#issue-5828263985
https://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-spanner/google/cloud/spanner_v1/metrics/metrics_interceptor.pyhttps://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-spanner/google/cloud/spanner_v1/metrics/metrics_interceptor.py
olavloitehttps://github.com/olavloite
on Oct 13, 2026https://github.com/googleapis/google-cloud-python/issues/18656#event-33121331152
olavloitehttps://github.com/olavloite
api: spannerIssues related to the Spanner API.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20spanner%22
on Oct 13, 2026https://github.com/googleapis/google-cloud-python/issues/18656#event-33121332750
sinhasubhamhttps://github.com/sinhasubham
on Oct 16, 2026https://github.com/googleapis/google-cloud-python/issues/18656#event-33476314541
fix(google-cloud-spanner): record streaming operation latency and att…https://github.com/googleapis/google-cloud-python/commit/1b8a9256c02b3475d66b2aca385392a8e7906297
https://docs.github.com/articles/closing-issues-via-commit-messages
1b8a925https://github.com/googleapis/google-cloud-python/commit/1b8a9256c02b3475d66b2aca385392a8e7906297
sinhasubhamhttps://github.com/sinhasubham
on Oct 27, 2026https://github.com/googleapis/google-cloud-python/issues/18656#event-34338099433
fix(google-cloud-spanner): record streaming operation latency and att…https://github.com/googleapis/google-cloud-python/commit/31b7a081754bf966be6ae9797bf919bcc0e3e0a4
https://docs.github.com/articles/closing-issues-via-commit-messages
31b7a08https://github.com/googleapis/google-cloud-python/commit/31b7a081754bf966be6ae9797bf919bcc0e3e0a4
fix(google-cloud-spanner): record streaming operation latency and att…https://github.com/googleapis/google-cloud-python/commit/e37b72815befc15bfc038722a912bea6d16ab369
https://docs.github.com/articles/closing-issues-via-commit-messages
e37b728https://github.com/googleapis/google-cloud-python/commit/e37b72815befc15bfc038722a912bea6d16ab369
sinhasubhamhttps://github.com/sinhasubham
on Nov 11, 2026https://github.com/googleapis/google-cloud-python/issues/18656#event-35833320444
fix(google-cloud-spanner): record streaming operation latency and att…https://github.com/googleapis/google-cloud-python/commit/6e5cf8c750458dd37c996a1cd465243eaaa83df5
https://docs.github.com/articles/closing-issues-via-commit-messages
6e5cf8chttps://github.com/googleapis/google-cloud-python/commit/6e5cf8c750458dd37c996a1cd465243eaaa83df5
fix(google-cloud-spanner): record streaming operation latency and att…https://github.com/googleapis/google-cloud-python/commit/c945b9f1e76b1f5cc4409f9fc75c6bcb7394af63
https://docs.github.com/articles/closing-issues-via-commit-messages
c945b9fhttps://github.com/googleapis/google-cloud-python/commit/c945b9f1e76b1f5cc4409f9fc75c6bcb7394af63
Sign up for freehttps://github.com/signup?return_to=https://github.com/googleapis/google-cloud-python/issues/18656
Sign in to commenthttps://github.com/login?return_to=https://github.com/googleapis/google-cloud-python/issues/18656
olavloitehttps://github.com/olavloite
api: spannerIssues related to the Spanner API.https://github.com/googleapis/google-cloud-python/issues?q=state%3Aopen%20label%3A%22api%3A%20spanner%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.