Title: Do we need to run py27 **AND** cover on Travis · Issue #1109 · googleapis/google-cloud-python · GitHub
Open Graph Title: Do we need to run py27 **AND** cover on Travis · Issue #1109 · googleapis/google-cloud-python
X Title: Do we need to run py27 **AND** cover on Travis · Issue #1109 · googleapis/google-cloud-python
Description: tox -e cover already runs all the tests in tox -e py27 (it has to so that it can generate the coverage report) To make sure cover fails even if there is 100% coverage but failing tests, I added diff --git a/gcloud/datastore/test_client.p...
Open Graph Description: tox -e cover already runs all the tests in tox -e py27 (it has to so that it can generate the coverage report) To make sure cover fails even if there is 100% coverage but failing tests, I added dif...
X Description: tox -e cover already runs all the tests in tox -e py27 (it has to so that it can generate the coverage report) To make sure cover fails even if there is 100% coverage but failing tests, I added dif...
Opengraph URL: https://github.com/googleapis/google-cloud-python/issues/1109
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Do we need to run py27 **AND** cover on Travis","articleBody":"`tox -e cover` already runs all the tests in `tox -e py27` (it has to so that it can generate the coverage report)\n\nTo make sure cover fails even if there is 100% coverage but failing tests, I added\n\n``` diff\ndiff --git a/gcloud/datastore/test_client.py b/gcloud/datastore/test_client.py\nindex 4fed6d9..a8d482f 100644\n--- a/gcloud/datastore/test_client.py\n+++ b/gcloud/datastore/test_client.py\n@@ -925,6 +925,9 @@ class TestClient(unittest2.TestCase):\n }\n self.assertEqual(query.kwargs, expected_kwargs)\n\n+ def test_nope_dan(self):\n+ self.assertTrue(False)\n+\n\n class _Dummy(object):\n\n```\n\nand then `tox -e cover` fails even with 100% coverage\n\n``` python\n$ tox -e cover\nGLOB sdist-make: /path/to/gcloud-python/setup.py\ncover inst-nodeps: /path/to/gcloud-python/.tox/dist/gcloud-0.7.1.zip\ncover installed: coverage==3.7.1,-e git+git@github.com:dhermes/gcloud-python.git@0dfe5ebc936c141e8f3ca13733b69f68155fe76f#egg=gcloud-master,google-apitools==0.4.8,httplib2==0.9.1,linecache2==1.0.0,nose==1.\n3.7,nosexcover==1.0.10,oauth2client==1.4.12,protobuf==3.0.0a1,protorpc==0.10.0,pyasn1==0.1.8,pyasn1-modules==0.0.7,pycrypto==2.6.1,rsa==3.2,six==1.9.0,traceback2==1.4.0,unittest2==1.1.0,wheel==0.24.0\ncover runtests: PYTHONHASHSEED='2394164928'\ncover runtests: commands[0] | /path/to/gcloud-python/scripts/cover.sh --cover-min-percentage=100\n\nnosetests --ignore-files=run_system_test\\.py \\\n--with-xunit --with-xcoverage --cover-package=gcloud \\\n--nocapture --cover-erase --cover-tests --cover-branches ${@}\n......................................................................................................................................................................................F......................\n.............................................................................................................................................................................................................\n.............................................................................................................................................................................................................\n.............................................................................................................................................................................................................\n.........................................................................\n======================================================================\nFAIL: test_nope_dan (gcloud.datastore.test_client.TestClient)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n File \"/path/to/gcloud-python/gcloud/datastore/test_client.py\", line 929, in test_nope_dan\n self.assertTrue(False)\nAssertionError: False is not true\n\nName Stmts Miss Branch BrMiss Cover Missing\n-------------------------------------------------------------------------------------\ngcloud 3 0 0 0 100%\ngcloud._helpers 89 0 16 0 100%\n\n...\n\ngcloud.test_iterator 145 0 2 0 100%\n-------------------------------------------------------------------------------------\nTOTAL 14844 0 1125 0 100%\n----------------------------------------------------------------------\nRan 893 tests in 0.907s\n\nFAILED (failures=1)\nERROR: InvocationError: '/path/to/gcloud-python/scripts/cover.sh --cover-min-percentage=100'\n__________________________________________________________________________________________________ summary __________________________________________________________________________________________________\nERROR: cover: commands failed\n```\n","author":{"url":"https://github.com/dhermes","@type":"Person","name":"dhermes"},"datePublished":"2015-08-27T17:32:16.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/1109/google-cloud-python/issues/1109"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3654fdcf-cbba-875e-7973-7b1e45a98339 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 80CC:9E28B:91B9DB:C39EBF:6A4D6F7C |
| html-safe-nonce | 28c6647e53f7ef4cc2ac158a0acb36f7e7434d400d6da6e535434b76062ddb3a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MENDOjlFMjhCOjkxQjlEQjpDMzlFQkY6NkE0RDZGN0MiLCJ2aXNpdG9yX2lkIjoiMjk5NzMyNDAzMTE2NDUxMDA3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4e6811d8681facd3150b742fe24e094bd6fb309a84085ea7be061e565056f4c0 |
| hovercard-subject-tag | issue:103557786 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/google-cloud-python/1109/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e814f50f6e0842bfb8c29d60336db49e455eb4de9db1699eaf87a3e21f81f3be/googleapis/google-cloud-python/issues/1109 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e814f50f6e0842bfb8c29d60336db49e455eb4de9db1699eaf87a3e21f81f3be/googleapis/google-cloud-python/issues/1109 |
| og:image:alt | tox -e cover already runs all the tests in tox -e py27 (it has to so that it can generate the coverage report) To make sure cover fails even if there is 100% coverage but failing tests, I added dif... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dhermes |
| hostname | github.com |
| expected-hostname | github.com |
| None | c78260c7b3f4ac4b0356c8208537f05406a3a2d46a9ec3f735b372dcc519c39e |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 16316451 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16316451 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 399fff412f48461d435721c009efc17ea44be72f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width