René's URL Explorer Experiment


Title: Fix performance regression on Cloud Pub/Sub publish by kamalaboulhosn · Pull Request #6076 · googleapis/google-cloud-java · GitHub

Open Graph Title: Fix performance regression on Cloud Pub/Sub publish by kamalaboulhosn · Pull Request #6076 · googleapis/google-cloud-java

X Title: Fix performance regression on Cloud Pub/Sub publish by kamalaboulhosn · Pull Request #6076 · googleapis/google-cloud-java

Description: Google Cloud Client Library for Java. Contribute to googleapis/google-cloud-java development by creating an account on GitHub.

Open Graph Description: With the refactor to support ordering keys, we moved away from publishing on an executor in the unordered case. This causes too many threads to build up and we end up with a lot of timeouts for pub...

X Description: With the refactor to support ordering keys, we moved away from publishing on an executor in the unordered case. This causes too many threads to build up and we end up with a lot of timeouts for pub...

Opengraph URL: https://github.com/googleapis/google-cloud-java/pull/6076

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:36ba0518-f8c4-47d6-18a9-241a5aa45d1c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA156:C3948:348BA96:487CDB5:6A4F337D
html-safe-nonce878bb06c9190c66d8f12f057d982ffda031849937dc94f1730617abb77064818
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTU2OkMzOTQ4OjM0OEJBOTY6NDg3Q0RCNTo2QTRGMzM3RCIsInZpc2l0b3JfaWQiOiIyNTcwMjE1Mjk5MDg2MjM0NDkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4befe81fd0c123907662edc9abf4d4f86a7334d1d97a67cc72f43f8fc812a4cd
hovercard-subject-tagpull_request:307406259
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-java/6076/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c36aa6645fdcc7bb7deaacf70b1b51c90cdc1e94150ad9dff3b7cae78736fe81/googleapis/google-cloud-java/pull/6076
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c36aa6645fdcc7bb7deaacf70b1b51c90cdc1e94150ad9dff3b7cae78736fe81/googleapis/google-cloud-java/pull/6076
og:image:altWith the refactor to support ordering keys, we moved away from publishing on an executor in the unordered case. This causes too many threads to build up and we end up with a lot of timeouts for pub...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekamalaboulhosn
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-java git https://github.com/googleapis/google-cloud-java.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id26181278
octolytics-dimension-repository_nwogoogleapis/google-cloud-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26181278
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-java/pull/6076#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F6076
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F6076
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-java
Reloadhttps://github.com/googleapis/google-cloud-java/pull/6076
Reloadhttps://github.com/googleapis/google-cloud-java/pull/6076
Reloadhttps://github.com/googleapis/google-cloud-java/pull/6076
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/6076
googleapis https://github.com/googleapis
google-cloud-javahttps://github.com/googleapis/google-cloud-java
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Fork 1.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Star 2.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Code https://github.com/googleapis/google-cloud-java
Issues 655 https://github.com/googleapis/google-cloud-java/issues
Pull requests 110 https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality 0 https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
Code https://github.com/googleapis/google-cloud-java
Issues https://github.com/googleapis/google-cloud-java/issues
Pull requests https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
kamalaboulhosnhttps://github.com/kamalaboulhosn
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
Conversationhttps://github.com/googleapis/google-cloud-java/pull/6076
Commits3 (3)https://github.com/googleapis/google-cloud-java/pull/6076/commits
Checkshttps://github.com/googleapis/google-cloud-java/pull/6076/checks
Files changedhttps://github.com/googleapis/google-cloud-java/pull/6076/files
Fix performance regression on Cloud Pub/Sub publishhttps://github.com/googleapis/google-cloud-java/pull/6076#top
kamalaboulhosnhttps://github.com/kamalaboulhosn
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
https://github.com/kamalaboulhosn
kamalaboulhosnhttps://github.com/kamalaboulhosn
Aug 14, 2019https://github.com/googleapis/google-cloud-java/pull/6076#issue-480774992
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/6076
kamalaboulhosnhttps://github.com/kamalaboulhosn
July 16, 2019 12:20https://github.com/googleapis/google-cloud-java/pull/6076#commits-pushed-a0fc98f
https://github.com/kamalaboulhosn
Mark ordering keys APIs publichttps://github.com/googleapis/google-cloud-java/pull/6076/commits/a0fc98ff772c377b6c43698edd9767a4628803f3
a0fc98fhttps://github.com/googleapis/google-cloud-java/pull/6076/commits/a0fc98ff772c377b6c43698edd9767a4628803f3
https://github.com/kamalaboulhosn
Merge branch 'master' ofhttps://github.com/googleapis/google-cloud-java/pull/6076/commits/3e174d391beea3722b74d54f54ea0e65b08443de
https://github.com/kamalaboulhosn/google-clo…https://github.com/kamalaboulhosn/google-cloud-java
3e174d3https://github.com/googleapis/google-cloud-java/pull/6076/commits/3e174d391beea3722b74d54f54ea0e65b08443de
…ud-javahttps://github.com/kamalaboulhosn/google-cloud-java
https://github.com/kamalaboulhosn
Go back to calling publish on the exectuor, which is what we did befo…https://github.com/googleapis/google-cloud-java/pull/6076/commits/173adc5918ea63e574f65a05251bd17726e0c87b
173adc5https://github.com/googleapis/google-cloud-java/pull/6076/commits/173adc5918ea63e574f65a05251bd17726e0c87b
https://github.com/kamalaboulhosn
kamalaboulhosnhttps://github.com/kamalaboulhosn
hannahrogers-googlehttps://github.com/hannahrogers-google
August 14, 2019 16:29https://github.com/googleapis/google-cloud-java/pull/6076#event-2557193324
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 14, 2019https://github.com/googleapis/google-cloud-java/pull/6076#event-2557193649
https://github.com/hannahrogers-google
hannahrogers-googlehttps://github.com/hannahrogers-google
Aug 14, 2019 https://github.com/googleapis/google-cloud-java/pull/6076#pullrequestreview-275013923
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/6076/files/173adc5918ea63e574f65a05251bd17726e0c87b
hannahrogers-googlehttps://github.com/hannahrogers-google
https://github.com/googleapis/google-cloud-java/pull/6076#pullrequestreview-275013923
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/6076
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 14, 2019https://github.com/googleapis/google-cloud-java/pull/6076#issuecomment-521357715
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/6076
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076?src=pr&el=h1
#6076https://codecov.io/gh/googleapis/google-cloud-java/pull/6076?src=pr&el=desc
masterhttps://codecov.io/gh/googleapis/google-cloud-java/commit/7441cce4338f0c2ff01261876efc035074160d8d?src=pr&el=desc
https://codecov.io/gh/googleapis/google-cloud-java/pull/6076?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076?src=pr&el=tree
...ain/java/com/google/cloud/pubsub/v1/Publisher.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXB1YnN1Yi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvcHVic3ViL3YxL1B1Ymxpc2hlci5qYXZh
...m/google/cloud/bigquery/QueryJobConfiguration.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5L3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC9iaWdxdWVyeS9RdWVyeUpvYkNvbmZpZ3VyYXRpb24uamF2YQ==
...om/google/cloud/bigquery/LoadJobConfiguration.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5L3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC9iaWdxdWVyeS9Mb2FkSm9iQ29uZmlndXJhdGlvbi5qYXZh
...ogle/cloud/bigquery/WriteChannelConfiguration.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5L3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC9iaWdxdWVyeS9Xcml0ZUNoYW5uZWxDb25maWd1cmF0aW9uLmphdmE=
...n/java/com/google/cloud/bigquery/BigQueryImpl.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5L3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC9iaWdxdWVyeS9CaWdRdWVyeUltcGwuamF2YQ==
...java/com/google/cloud/firestore/FirestoreImpl.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWZpcmVzdG9yZS9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvZmlyZXN0b3JlL0ZpcmVzdG9yZUltcGwuamF2YQ==
...main/java/com/google/cloud/storage/BucketInfo.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXN0b3JhZ2Uvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3N0b3JhZ2UvQnVja2V0SW5mby5qYXZh
...ud/spanner/jdbc/AbstractJdbcPreparedStatement.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWNvbnRyaWIvZ29vZ2xlLWNsb3VkLXNwYW5uZXItamRiYy9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvc3Bhbm5lci9qZGJjL0Fic3RyYWN0SmRiY1ByZXBhcmVkU3RhdGVtZW50LmphdmE=
.../com/google/cloud/compute/deprecated/DiskInfo.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL2NvbXB1dGUvZGVwcmVjYXRlZC9EaXNrSW5mby5qYXZh
.../cloud/scheduler/v1beta1/CloudSchedulerClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvc2NoZWR1bGVyL3YxYmV0YTEvQ2xvdWRTY2hlZHVsZXJDbGllbnQuamF2YQ==
139 morehttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076/diff?src=pr&el=tree-more
Continue to review full report at Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/6076?src=pr&el=footer
7441cce...173adc5https://codecov.io/gh/googleapis/google-cloud-java/pull/6076?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/6076
https://github.com/kamalaboulhosn
kamalaboulhosnhttps://github.com/kamalaboulhosn
ab193fahttps://github.com/googleapis/google-cloud-java/commit/ab193fa8e7803a5aaaaaaa3e3b218717a286967b
Aug 14, 2019https://github.com/googleapis/google-cloud-java/pull/6076#event-2557489565
https://github.com/kolea2
kolea2https://github.com/kolea2
Aug 14, 2019 https://github.com/googleapis/google-cloud-java/pull/6076#ref-pullrequest-480822855
Release google-cloud-java v0.105.0 #6077 https://github.com/googleapis/google-cloud-java/pull/6077
meltsufinhttps://github.com/meltsufin
Apr 29, 2026 https://github.com/googleapis/google-cloud-java/pull/6076#ref-commit-a3f68ed
https://github.com/kamalaboulhosn
Fix performance regression on Cloud Pub/Sub publish (https://github.com/googleapis/google-cloud-java/commit/a3f68edeed7694fae698bed59610a6a2114bd053
#6076https://github.com/googleapis/google-cloud-java/pull/6076
)https://github.com/googleapis/google-cloud-java/commit/a3f68edeed7694fae698bed59610a6a2114bd053
a3f68edhttps://github.com/googleapis/google-cloud-java/commit/a3f68edeed7694fae698bed59610a6a2114bd053
meltsufinhttps://github.com/meltsufin
May 1, 2026 https://github.com/googleapis/google-cloud-java/pull/6076#ref-commit-0472156
https://github.com/kamalaboulhosn
Fix performance regression on Cloud Pub/Sub publish (https://github.com/googleapis/google-cloud-java/commit/04721562b39783d5859bbcdc46890305ec0c2722
#6076https://github.com/googleapis/google-cloud-java/pull/6076
)https://github.com/googleapis/google-cloud-java/commit/04721562b39783d5859bbcdc46890305ec0c2722
0472156https://github.com/googleapis/google-cloud-java/commit/04721562b39783d5859bbcdc46890305ec0c2722
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F6076
https://github.com/hannahrogers-google
hannahrogers-google https://github.com/hannahrogers-google
https://github.com/googleapis/google-cloud-java/pull/6076/files/173adc5918ea63e574f65a05251bd17726e0c87b
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/6076
https://github.com/kamalaboulhosn
https://github.com/hannahrogers-google
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.