René's URL Explorer Experiment


Title: Storage-nio: Only com.google.cloud.storage.** should be excluded from shading by olavloite · Pull Request #5789 · googleapis/google-cloud-java · GitHub

Open Graph Title: Storage-nio: Only com.google.cloud.storage.** should be excluded from shading by olavloite · Pull Request #5789 · googleapis/google-cloud-java

X Title: Storage-nio: Only com.google.cloud.storage.** should be excluded from shading by olavloite · Pull Request #5789 · googleapis/google-cloud-java

Description: Google Cloud Client Library for Java. Contribute to googleapis/google-cloud-java development by creating an account on GitHub.

Open Graph Description: There's no automatic test for this, but I did the following manual testing: Before the change: Include the shaded nio library as a dependency along with the google-cloud-spanner library. It is...

X Description: There's no automatic test for this, but I did the following manual testing: Before the change: Include the shaded nio library as a dependency along with the google-cloud-spanner library. I...

Opengraph URL: https://github.com/googleapis/google-cloud-java/pull/5789

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f2b4ce98-4623-93fb-10ff-9058f06f5912
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92D8:CD887:D055CF:123FAE8:6A4E8B8B
html-safe-nonce6670fba33f290167bca684a7b5c1f3a138473f82f3004b17fb7624794cd62c09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkQ4OkNEODg3OkQwNTVDRjoxMjNGQUU4OjZBNEU4QjhCIiwidmlzaXRvcl9pZCI6IjMyODg1OTUyMDU1MDcxNTY4NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaced581f794e9196474367452d28e0dac25db2bf28c314d2d270ec1b9a5ae67574
hovercard-subject-tagpull_request:299389629
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-java/5789/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a3e04dc712344b02630a0cccbcc6447bd9c4b45c8492e914f883712146ec85e2/googleapis/google-cloud-java/pull/5789
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a3e04dc712344b02630a0cccbcc6447bd9c4b45c8492e914f883712146ec85e2/googleapis/google-cloud-java/pull/5789
og:image:altThere's no automatic test for this, but I did the following manual testing: Before the change: Include the shaded nio library as a dependency along with the google-cloud-spanner library. It is...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameolavloite
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-java git https://github.com/googleapis/google-cloud-java.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id26181278
octolytics-dimension-repository_nwogoogleapis/google-cloud-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26181278
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-java/pull/5789#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5789
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5789
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-java
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5789
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5789
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5789
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
googleapis https://github.com/googleapis
google-cloud-javahttps://github.com/googleapis/google-cloud-java
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Fork 1.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Star 2.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Code https://github.com/googleapis/google-cloud-java
Issues 652 https://github.com/googleapis/google-cloud-java/issues
Pull requests 110 https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality 0 https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
Code https://github.com/googleapis/google-cloud-java
Issues https://github.com/googleapis/google-cloud-java/issues
Pull requests https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
JesseLovelacehttps://github.com/JesseLovelace
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
olavloite:storage-nio-shadinghttps://github.com/olavloite/google-cloud-java/tree/storage-nio-shading
Conversationhttps://github.com/googleapis/google-cloud-java/pull/5789
Commits1 (1)https://github.com/googleapis/google-cloud-java/pull/5789/commits
Checkshttps://github.com/googleapis/google-cloud-java/pull/5789/checks
Files changedhttps://github.com/googleapis/google-cloud-java/pull/5789/files
Storage-nio: Only com.google.cloud.storage.** should be excluded from shadinghttps://github.com/googleapis/google-cloud-java/pull/5789#top
JesseLovelacehttps://github.com/JesseLovelace
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
olavloite:storage-nio-shadinghttps://github.com/olavloite/google-cloud-java/tree/storage-nio-shading
https://github.com/olavloite
olavloitehttps://github.com/olavloite
Jul 19, 2019https://github.com/googleapis/google-cloud-java/pull/5789#issue-470397435
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
#5127https://github.com/googleapis/google-cloud-java/issues/5127
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
https://github.com/olavloite
we should only exclude storage from shadinghttps://github.com/googleapis/google-cloud-java/pull/5789/commits/b959f532b93867c1a7b83708319563bd1907555b
b959f53https://github.com/googleapis/google-cloud-java/pull/5789/commits/b959f532b93867c1a7b83708319563bd1907555b
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 19, 2019https://github.com/googleapis/google-cloud-java/pull/5789#event-2496266688
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 19, 2019https://github.com/googleapis/google-cloud-java/pull/5789#issuecomment-513296082
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5789?src=pr&el=h1
#5789https://codecov.io/gh/googleapis/google-cloud-java/pull/5789?src=pr&el=desc
masterhttps://codecov.io/gh/googleapis/google-cloud-java/commit/4a95f17b2c2aac6fe020953a41d01453756ee190?src=pr&el=desc
https://codecov.io/gh/googleapis/google-cloud-java/pull/5789?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/googleapis/google-cloud-java/pull/5789?src=pr&el=tree
...ain/java/com/google/cloud/pubsub/v1/Publisher.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5789/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXB1YnN1Yi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvcHVic3ViL3YxL1B1Ymxpc2hlci5qYXZh
Continue to review full report at Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5789?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5789?src=pr&el=footer
4a95f17...b959f53https://codecov.io/gh/googleapis/google-cloud-java/pull/5789?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
https://github.com/chingor13
chingor13https://github.com/chingor13
Jul 19, 2019https://github.com/googleapis/google-cloud-java/pull/5789#issuecomment-513332892
@jean-philippe-martinhttps://github.com/jean-philippe-martin
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
https://github.com/chingor13
chingor13https://github.com/chingor13
JesseLovelacehttps://github.com/JesseLovelace
Jul 22, 2019https://github.com/googleapis/google-cloud-java/pull/5789#event-2500517145
https://github.com/chingor13
chingor13https://github.com/chingor13
JesseLovelacehttps://github.com/JesseLovelace
July 22, 2019 17:24https://github.com/googleapis/google-cloud-java/pull/5789#event-2500517400
https://github.com/jean-philippe-martin
jean-philippe-martinhttps://github.com/jean-philippe-martin
Jul 22, 2019 https://github.com/googleapis/google-cloud-java/pull/5789#ref-pullrequest-441742032
Add BigQuery dependency, BigQueryUtils, move to unshaded google-cloud-java, and newer Spark/Hadoop/Guava broadinstitute/gatk#5928 https://github.com/broadinstitute/gatk/pull/5928
https://github.com/jean-philippe-martin
jean-philippe-martinhttps://github.com/jean-philippe-martin
Jul 23, 2019https://github.com/googleapis/google-cloud-java/pull/5789#issuecomment-514005738
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
https://github.com/olavloite
olavloitehttps://github.com/olavloite
Jul 24, 2019https://github.com/googleapis/google-cloud-java/pull/5789#issuecomment-514481332
@jean-philippe-martinhttps://github.com/jean-philippe-martin
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
https://github.com/jean-philippe-martin
jean-philippe-martinhttps://github.com/jean-philippe-martin
Jul 29, 2019https://github.com/googleapis/google-cloud-java/pull/5789#issuecomment-516180845
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
https://github.com/olavloite
olavloitehttps://github.com/olavloite
Aug 5, 2019https://github.com/googleapis/google-cloud-java/pull/5789#issuecomment-518116633
@JesseLovelacehttps://github.com/JesseLovelace
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
https://github.com/JesseLovelace
JesseLovelacehttps://github.com/JesseLovelace
Aug 14, 2019 https://github.com/googleapis/google-cloud-java/pull/5789#pullrequestreview-275041268
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5789/files/b959f532b93867c1a7b83708319563bd1907555b
https://github.com/JesseLovelace
JesseLovelacehttps://github.com/JesseLovelace
c3173eahttps://github.com/googleapis/google-cloud-java/commit/c3173ead69fab4a3e899b657e07b6376351fc6ec
Aug 14, 2019https://github.com/googleapis/google-cloud-java/pull/5789#event-2557372072
https://github.com/kolea2
kolea2https://github.com/kolea2
Aug 14, 2019 https://github.com/googleapis/google-cloud-java/pull/5789#ref-pullrequest-480822855
Release google-cloud-java v0.105.0 #6077 https://github.com/googleapis/google-cloud-java/pull/6077
suztomohttps://github.com/suztomo
Mar 30, 2026 https://github.com/googleapis/google-cloud-java/pull/5789#ref-commit-f65344d
https://github.com/olavloite
https://github.com/JesseLovelace
we should only exclude storage from shading (https://github.com/googleapis/google-cloud-java/commit/f65344d72dff26ece75870112433743f32aea439
#5789https://github.com/googleapis/google-cloud-java/pull/5789
)https://github.com/googleapis/google-cloud-java/commit/f65344d72dff26ece75870112433743f32aea439
f65344dhttps://github.com/googleapis/google-cloud-java/commit/f65344d72dff26ece75870112433743f32aea439
lqiu96https://github.com/lqiu96
Apr 1, 2026 https://github.com/googleapis/google-cloud-java/pull/5789#ref-commit-9074c20
https://github.com/olavloite
https://github.com/JesseLovelace
we should only exclude storage from shading (https://github.com/googleapis/google-cloud-java/commit/9074c20a9d72bf48d29083057cafdd2296340715
#5789https://github.com/googleapis/google-cloud-java/pull/5789
)https://github.com/googleapis/google-cloud-java/commit/9074c20a9d72bf48d29083057cafdd2296340715
9074c20https://github.com/googleapis/google-cloud-java/commit/9074c20a9d72bf48d29083057cafdd2296340715
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5789
https://github.com/JesseLovelace
JesseLovelace https://github.com/JesseLovelace
https://github.com/googleapis/google-cloud-java/pull/5789/files/b959f532b93867c1a7b83708319563bd1907555b
https://github.com/JesseLovelace
JesseLovelace https://github.com/JesseLovelace
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Incomplete shading in google-cloud-nio leads to downstream breakage https://github.com/googleapis/google-cloud-java/issues/5127
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5789
https://github.com/olavloite
https://github.com/chingor13
https://github.com/jean-philippe-martin
https://github.com/JesseLovelace
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.