René's URL Explorer Experiment


Title: Spanner: Create new instance if existing Spanner is closed by olavloite · Pull Request #5200 · googleapis/google-cloud-java · GitHub

Open Graph Title: Spanner: Create new instance if existing Spanner is closed by olavloite · Pull Request #5200 · googleapis/google-cloud-java

X Title: Spanner: Create new instance if existing Spanner is closed by olavloite · Pull Request #5200 · googleapis/google-cloud-java

Description: Google Cloud Client Library for Java. Contribute to googleapis/google-cloud-java development by creating an account on GitHub.

Open Graph Description: SpannerOptions caches any Spanner instance that has been created, and hands this cached instance out to all subsequent calls to SpannerOptions.getService(). This also included closed Spanner instan...

X Description: SpannerOptions caches any Spanner instance that has been created, and hands this cached instance out to all subsequent calls to SpannerOptions.getService(). This also included closed Spanner instan...

Opengraph URL: https://github.com/googleapis/google-cloud-java/pull/5200

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0a1c99d8-3818-0955-472f-864ba31b0089
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA188:8A2B5:2842B16:37D1611:6A4F5982
html-safe-nonce22dfe51f12180c1c7cfa8f459db636bdcf280a96d436420fa77d4f7c42067d9c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTg4OjhBMkI1OjI4NDJCMTY6MzdEMTYxMTo2QTRGNTk4MiIsInZpc2l0b3JfaWQiOiI3MTc0MDQ2MTc4ODExNTMzNjk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7381932ce48b01fc80f5db16084a1c32fc863a22442bfae5ae2a18a18f1ec4dd
hovercard-subject-tagpull_request:280098921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-java/5200/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e32801d49214bbb7f1aa5c33317213943f1104c5e59e8351e5c146c846ce53ad/googleapis/google-cloud-java/pull/5200
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e32801d49214bbb7f1aa5c33317213943f1104c5e59e8351e5c146c846ce53ad/googleapis/google-cloud-java/pull/5200
og:image:altSpannerOptions caches any Spanner instance that has been created, and hands this cached instance out to all subsequent calls to SpannerOptions.getService(). This also included closed Spanner instan...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameolavloite
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-java git https://github.com/googleapis/google-cloud-java.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id26181278
octolytics-dimension-repository_nwogoogleapis/google-cloud-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26181278
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-java/pull/5200#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5200
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5200
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-java
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5200
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5200
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5200
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
googleapis https://github.com/googleapis
google-cloud-javahttps://github.com/googleapis/google-cloud-java
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Fork 1.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Star 2.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Code https://github.com/googleapis/google-cloud-java
Issues 655 https://github.com/googleapis/google-cloud-java/issues
Pull requests 110 https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality 0 https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
Code https://github.com/googleapis/google-cloud-java
Issues https://github.com/googleapis/google-cloud-java/issues
Pull requests https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
kolea2https://github.com/kolea2
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
olavloite:spanner-create-new-instance-if-closehttps://github.com/olavloite/google-cloud-java/tree/spanner-create-new-instance-if-close
Conversationhttps://github.com/googleapis/google-cloud-java/pull/5200
Commits11 (11)https://github.com/googleapis/google-cloud-java/pull/5200/commits
Checkshttps://github.com/googleapis/google-cloud-java/pull/5200/checks
Files changedhttps://github.com/googleapis/google-cloud-java/pull/5200/files
Spanner: Create new instance if existing Spanner is closedhttps://github.com/googleapis/google-cloud-java/pull/5200#top
kolea2https://github.com/kolea2
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
olavloite:spanner-create-new-instance-if-closehttps://github.com/olavloite/google-cloud-java/tree/spanner-create-new-instance-if-close
https://github.com/olavloite
olavloitehttps://github.com/olavloite
May 18, 2019https://github.com/googleapis/google-cloud-java/pull/5200#issue-445712031
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
https://github.com/olavloite
olavloitehttps://github.com/olavloite
May 18, 2019 12:39https://github.com/googleapis/google-cloud-java/pull/5200#event-2350953685
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 18, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2350953712
https://github.com/olavloite
olavloitehttps://github.com/olavloite
kolea2https://github.com/kolea2
snehashah16https://github.com/snehashah16
May 18, 2019 12:39https://github.com/googleapis/google-cloud-java/pull/5200#event-2350953773
https://github.com/olavloite
olavloitehttps://github.com/olavloite
kokoro:force-run https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
May 21, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2355634305
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:force-run https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
May 21, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2355636247
https://github.com/chingor13
chingor13https://github.com/chingor13
kolea2https://github.com/kolea2
May 22, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2360711174
https://github.com/sduskis
sduskishttps://github.com/sduskis
May 24, 2019 https://github.com/googleapis/google-cloud-java/pull/5200#pullrequestreview-241805204
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5200/files
...loud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.javahttps://github.com/googleapis/google-cloud-java/pull/5200/files#diff-74e505a01476340d6e94d90a079a174ce3afbd1a1b1cc8413bd122c7d2f713fe
sduskishttps://github.com/sduskis
May 24, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r287408713
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
May 24, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r287418486
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
sduskishttps://github.com/sduskis
Jun 13, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r293424915
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
Jun 13, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r293448977
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
sduskishttps://github.com/sduskis
Jun 13, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r293472963
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
Jun 13, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r293479464
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
Jun 14, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r293667883
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
google-cloud-java/google-cloud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.javahttps://github.com/googleapis/google-cloud-java/blob/75d68e7ee646065f0794923520c0332a41d278d9/google-cloud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.java#L89
75d68e7https://github.com/googleapis/google-cloud-java/commit/75d68e7ee646065f0794923520c0332a41d278d9
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
sduskishttps://github.com/sduskis
Jun 14, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r293791012
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
Jun 16, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r294068529
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
https://github.com/ajaaym
ajaaymhttps://github.com/ajaaym
May 24, 2019https://github.com/googleapis/google-cloud-java/pull/5200#issuecomment-495756830
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
https://github.com/olavloite
olavloitehttps://github.com/olavloite
May 27, 2019 https://github.com/googleapis/google-cloud-java/pull/5200#ref-pullrequest-444267921
Spanner: Do not hand out a closed Spanner instance from SpannerOptions.getService() #5187 https://github.com/googleapis/google-cloud-java/pull/5187
https://github.com/yoshi-automation
yoshi-automationhttps://github.com/yoshi-automation
🚨 critical https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22%3Arotating_light%3A%20critical%22
Jun 4, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2388535898
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 14, 2019https://github.com/googleapis/google-cloud-java/pull/5200#issuecomment-501978629
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200?src=pr&el=h1
#5200https://codecov.io/gh/googleapis/google-cloud-java/pull/5200?src=pr&el=desc
masterhttps://codecov.io/gh/googleapis/google-cloud-java/commit/32de0498665ca16e8d3b19b88b5304341ad00e8e?src=pr&el=desc
https://codecov.io/gh/googleapis/google-cloud-java/pull/5200?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200?src=pr&el=tree
...src/main/java/com/google/cloud/ServiceOptions.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWNvcmUvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL1NlcnZpY2VPcHRpb25zLmphdmE=
...ble/data/v2/stub/EnhancedBigtableStubSettings.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWJpZ3RhYmxlL3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC9iaWd0YWJsZS9kYXRhL3YyL3N0dWIvRW5oYW5jZWRCaWd0YWJsZVN0dWJTZXR0aW5ncy5qYXZh
...a/com/google/cloud/dialogflow/v2/AgentsClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWRpYWxvZ2Zsb3cvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL2RpYWxvZ2Zsb3cvdjIvQWdlbnRzQ2xpZW50LmphdmE=
.../google/cloud/dialogflow/v2beta1/AgentsClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWRpYWxvZ2Zsb3cvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL2RpYWxvZ2Zsb3cvdjJiZXRhMS9BZ2VudHNDbGllbnQuamF2YQ==
...om/google/cloud/bigtable/data/v2/models/Query.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWJpZ3RhYmxlL3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC9iaWd0YWJsZS9kYXRhL3YyL21vZGVscy9RdWVyeS5qYXZh
.../v1beta1/stub/DataLabelingServiceStubSettings.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWRhdGFsYWJlbGluZy9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvZGF0YWxhYmVsaW5nL3YxYmV0YTEvc3R1Yi9EYXRhTGFiZWxpbmdTZXJ2aWNlU3R1YlNldHRpbmdzLmphdmE=
.../cloud/dialogflow/v2beta1/stub/GrpcAgentsStub.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWRpYWxvZ2Zsb3cvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL2RpYWxvZ2Zsb3cvdjJiZXRhMS9zdHViL0dycGNBZ2VudHNTdHViLmphdmE=
...oogle/cloud/dialogflow/v2/stub/GrpcAgentsStub.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWRpYWxvZ2Zsb3cvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL2RpYWxvZ2Zsb3cvdjIvc3R1Yi9HcnBjQWdlbnRzU3R1Yi5qYXZh
...com/google/cloud/dialogflow/v2/AgentsSettings.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWRpYWxvZ2Zsb3cvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL2RpYWxvZ2Zsb3cvdjIvQWdlbnRzU2V0dGluZ3MuamF2YQ==
...oogle/cloud/dialogflow/v2beta1/AgentsSettings.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWRpYWxvZ2Zsb3cvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL2RpYWxvZ2Zsb3cvdjJiZXRhMS9BZ2VudHNTZXR0aW5ncy5qYXZh
107 morehttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200/diff?src=pr&el=tree-more
Continue to review full report at Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5200?src=pr&el=footer
32de049...1ca1c92https://codecov.io/gh/googleapis/google-cloud-java/pull/5200?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
June 15, 2019 12:52https://github.com/googleapis/google-cloud-java/pull/5200#commits-pushed-4a89f89
https://github.com/olavloite
do not hand out a closed Spanner instancehttps://github.com/googleapis/google-cloud-java/pull/5200/commits/4a89f892b92b7e5c546325755783dcf80c2a9b94
4a89f89https://github.com/googleapis/google-cloud-java/pull/5200/commits/4a89f892b92b7e5c546325755783dcf80c2a9b94
https://github.com/olavloite
fix small merge errorhttps://github.com/googleapis/google-cloud-java/pull/5200/commits/599535fa7c1719e65846b58f9d9e98f4884486d5
599535fhttps://github.com/googleapis/google-cloud-java/pull/5200/commits/599535fa7c1719e65846b58f9d9e98f4884486d5
https://github.com/olavloite
create a new instance if the service/rpc is closedhttps://github.com/googleapis/google-cloud-java/pull/5200/commits/9bbd0e2c3b7837756776f702af99518969b8aef1
9bbd0e2https://github.com/googleapis/google-cloud-java/pull/5200/commits/9bbd0e2c3b7837756776f702af99518969b8aef1
https://github.com/olavloite
add test case to ensure correct caching behaviorhttps://github.com/googleapis/google-cloud-java/pull/5200/commits/5561b8e284362f983034c7842d10da88db568e77
5561b8ehttps://github.com/googleapis/google-cloud-java/pull/5200/commits/5561b8e284362f983034c7842d10da88db568e77
https://github.com/olavloite
use shouldRefreshService instead of createNewServicehttps://github.com/googleapis/google-cloud-java/pull/5200/commits/d273479077b833f62f983af0daf34db73749220e
d273479https://github.com/googleapis/google-cloud-java/pull/5200/commits/d273479077b833f62f983af0daf34db73749220e
https://github.com/olavloite
fix merge conflictshttps://github.com/googleapis/google-cloud-java/pull/5200/commits/fb2a4db5b97276bbc36b2e7078c6c5fadfc8d558
fb2a4dbhttps://github.com/googleapis/google-cloud-java/pull/5200/commits/fb2a4db5b97276bbc36b2e7078c6c5fadfc8d558
https://github.com/olavloite
olavloitehttps://github.com/olavloite
force-pushedhttps://github.com/googleapis/google-cloud-java/compare/a6515654f46348addc0eb7df7a98c824e75ffe8a..fb2a4db5b97276bbc36b2e7078c6c5fadfc8d558
a651565https://github.com/googleapis/google-cloud-java/commit/a6515654f46348addc0eb7df7a98c824e75ffe8a
fb2a4dbhttps://github.com/googleapis/google-cloud-java/commit/fb2a4db5b97276bbc36b2e7078c6c5fadfc8d558
Compare https://github.com/googleapis/google-cloud-java/compare/a6515654f46348addc0eb7df7a98c824e75ffe8a..fb2a4db5b97276bbc36b2e7078c6c5fadfc8d558
June 15, 2019 11:04https://github.com/googleapis/google-cloud-java/pull/5200#event-2415358985
https://github.com/kolea2
kolea2https://github.com/kolea2
Jun 17, 2019 https://github.com/googleapis/google-cloud-java/pull/5200#pullrequestreview-250523026
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5200/files/fb2a4db5b97276bbc36b2e7078c6c5fadfc8d558
...loud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.javahttps://github.com/googleapis/google-cloud-java/pull/5200/files/fb2a4db5b97276bbc36b2e7078c6c5fadfc8d558#diff-74e505a01476340d6e94d90a079a174ce3afbd1a1b1cc8413bd122c7d2f713fe
kolea2https://github.com/kolea2
Jun 17, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r294319452
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
Jun 17, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r294335667
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
kolea2https://github.com/kolea2
Jun 17, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r294381669
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
Jun 17, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r294398453
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
June 17, 2019 19:04https://github.com/googleapis/google-cloud-java/pull/5200#commits-pushed-5fbb912
https://github.com/olavloite
added documentation to shouldRefresh... methodshttps://github.com/googleapis/google-cloud-java/pull/5200/commits/5fbb9125142147dec7ecca3c266ba96974b1ff46
5fbb912https://github.com/googleapis/google-cloud-java/pull/5200/commits/5fbb9125142147dec7ecca3c266ba96974b1ff46
https://github.com/olavloite
removed overrides only for commentshttps://github.com/googleapis/google-cloud-java/pull/5200/commits/7692138cf255c7f93151c6b0d566bb8e243f99e3
7692138https://github.com/googleapis/google-cloud-java/pull/5200/commits/7692138cf255c7f93151c6b0d566bb8e243f99e3
https://github.com/olavloite
olavloitehttps://github.com/olavloite
kokoro:force-run https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Jun 21, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2430112843
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:force-run https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Jun 21, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2430114690
https://github.com/kolea2
kolea2https://github.com/kolea2
kokoro:force-run https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Jun 24, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2435157369
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:force-run https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Jun 24, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2435161674
https://github.com/kolea2
kolea2https://github.com/kolea2
Jun 25, 2019 https://github.com/googleapis/google-cloud-java/pull/5200#pullrequestreview-254212314
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5200/files/7692138cf255c7f93151c6b0d566bb8e243f99e3
google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.javahttps://github.com/googleapis/google-cloud-java/pull/5200/files/7692138cf255c7f93151c6b0d566bb8e243f99e3#diff-f76357589301dbdc830d2d00d009bec330dad6cc421beaaca470d917378b58f3
kolea2https://github.com/kolea2
Jun 25, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r297348637
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
Jun 26, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r297666976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
https://github.com/kolea2
kolea2https://github.com/kolea2
Jun 25, 2019 https://github.com/googleapis/google-cloud-java/pull/5200#pullrequestreview-254216365
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5200/files/7692138cf255c7f93151c6b0d566bb8e243f99e3
...-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsTest.javahttps://github.com/googleapis/google-cloud-java/pull/5200/files/7692138cf255c7f93151c6b0d566bb8e243f99e3#diff-c468989310954177d1b94677eccca2df8b20c5d9fd4fb842041b3f80ad2b86a9
kolea2https://github.com/kolea2
Jun 25, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r297351789
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
Jun 26, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r297667050
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
https://github.com/kolea2
kolea2https://github.com/kolea2
Jun 25, 2019https://github.com/googleapis/google-cloud-java/pull/5200#issuecomment-505584766
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
June 26, 2019 15:31https://github.com/googleapis/google-cloud-java/pull/5200#commits-pushed-b8bf651
https://github.com/olavloite
fixed naminghttps://github.com/googleapis/google-cloud-java/pull/5200/commits/b8bf65131de0514736c599588d12a45d0f37ec46
b8bf651https://github.com/googleapis/google-cloud-java/pull/5200/commits/b8bf65131de0514736c599588d12a45d0f37ec46
https://github.com/olavloite
added assertions for isClosed()https://github.com/googleapis/google-cloud-java/pull/5200/commits/2cc0635055dc9f32699794dbd53462800a2e127b
2cc0635https://github.com/googleapis/google-cloud-java/pull/5200/commits/2cc0635055dc9f32699794dbd53462800a2e127b
https://github.com/olavloite
fixed formattinghttps://github.com/googleapis/google-cloud-java/pull/5200/commits/1ca1c924bf46236fcac4c759e530d1368957aadb
1ca1c92https://github.com/googleapis/google-cloud-java/pull/5200/commits/1ca1c924bf46236fcac4c759e530d1368957aadb
https://github.com/chingor13
chingor13https://github.com/chingor13
Jun 28, 2019 https://github.com/googleapis/google-cloud-java/pull/5200#pullrequestreview-255887119
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5200/files/1ca1c924bf46236fcac4c759e530d1368957aadb
google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.javahttps://github.com/googleapis/google-cloud-java/pull/5200/files/1ca1c924bf46236fcac4c759e530d1368957aadb#diff-f76357589301dbdc830d2d00d009bec330dad6cc421beaaca470d917378b58f3
chingor13https://github.com/chingor13
Jun 28, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r298682967
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
olavloitehttps://github.com/olavloite
Jun 29, 2019https://github.com/googleapis/google-cloud-java/pull/5200#discussion_r298789297
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
https://github.com/chingor13
chingor13https://github.com/chingor13
Jul 1, 2019 https://github.com/googleapis/google-cloud-java/pull/5200#pullrequestreview-256524314
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5200/files/1ca1c924bf46236fcac4c759e530d1368957aadb
https://github.com/kolea2
kolea2https://github.com/kolea2
Jul 1, 2019 https://github.com/googleapis/google-cloud-java/pull/5200#pullrequestreview-256524551
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5200/files/1ca1c924bf46236fcac4c759e530d1368957aadb
https://github.com/kolea2
kolea2https://github.com/kolea2
17cb858https://github.com/googleapis/google-cloud-java/commit/17cb858a63316afc651a4f03bc4c38f9410eb34a
Jul 1, 2019https://github.com/googleapis/google-cloud-java/pull/5200#event-2452244352
Release google-cloud-java v0.99.0 #5654 https://github.com/googleapis/google-cloud-java/pull/5654
Release google-cloud-java v0.99.0 #5657 https://github.com/googleapis/google-cloud-java/pull/5657
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5200
https://github.com/chingor13
chingor13 https://github.com/chingor13
https://github.com/googleapis/google-cloud-java/pull/5200/files/1ca1c924bf46236fcac4c759e530d1368957aadb
https://github.com/snehashah16
snehashah16 https://github.com/snehashah16
https://github.com/sduskis
sduskis https://github.com/sduskis
https://github.com/googleapis/google-cloud-java/pull/5200/files/75d68e7ee646065f0794923520c0332a41d278d9
https://github.com/kolea2
kolea2 https://github.com/kolea2
https://github.com/googleapis/google-cloud-java/pull/5200/files/1ca1c924bf46236fcac4c759e530d1368957aadb
https://github.com/kolea2
kolea2 https://github.com/kolea2
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
🚨 critical https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22%3Arotating_light%3A%20critical%22
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5200
https://github.com/olavloite
https://github.com/ajaaym
https://github.com/kolea2
https://github.com/chingor13
https://github.com/sduskis
https://github.com/googlebot
https://github.com/yoshi-automation
https://github.com/yoshi-kokoro
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.