René's URL Explorer Experiment


Title: Pub/Sub: more refactoring by sduskis · Pull Request #5044 · googleapis/google-cloud-java · GitHub

Open Graph Title: Pub/Sub: more refactoring by sduskis · Pull Request #5044 · googleapis/google-cloud-java

X Title: Pub/Sub: more refactoring by sduskis · Pull Request #5044 · googleapis/google-cloud-java

Description: Google Cloud Client Library for Java. Contribute to googleapis/google-cloud-java development by creating an account on GitHub.

Open Graph Description: Using Preconditions Adding onSuccess and onFailure to OutstandingPublish

X Description: Using Preconditions Adding onSuccess and onFailure to OutstandingPublish

Opengraph URL: https://github.com/googleapis/google-cloud-java/pull/5044

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f8bdc3c9-6240-d2d6-195d-47da8fa0c5c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id81BA:3E6EAA:39F9841:5089079:6A4F478A
html-safe-nonce8e66c68df042a5c2518a1a2a53dfc07ce5a643b250e6b229868fa854f78edba5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUJBOjNFNkVBQTozOUY5ODQxOjUwODkwNzk6NkE0RjQ3OEEiLCJ2aXNpdG9yX2lkIjoiMTM2MTI3MTE5MDI1ODE0MTA2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdee8cb0d1a374dd2d8df01aa1bfe76e213efc4c3f13fa412984e5023385cc3ab
hovercard-subject-tagpull_request:275042149
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-java/5044/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dd5915d0c7cc0aa9936b709b56802a754334d3607f3c82af613b2bd79d46450b/googleapis/google-cloud-java/pull/5044
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dd5915d0c7cc0aa9936b709b56802a754334d3607f3c82af613b2bd79d46450b/googleapis/google-cloud-java/pull/5044
og:image:altUsing Preconditions Adding onSuccess and onFailure to OutstandingPublish
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesduskis
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-java git https://github.com/googleapis/google-cloud-java.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id26181278
octolytics-dimension-repository_nwogoogleapis/google-cloud-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26181278
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-java/pull/5044#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5044
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5044
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-java
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5044
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5044
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5044
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5044
googleapis https://github.com/googleapis
google-cloud-javahttps://github.com/googleapis/google-cloud-java
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Fork 1.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Star 2.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Code https://github.com/googleapis/google-cloud-java
Issues 655 https://github.com/googleapis/google-cloud-java/issues
Pull requests 110 https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality 0 https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
Code https://github.com/googleapis/google-cloud-java
Issues https://github.com/googleapis/google-cloud-java/issues
Pull requests https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
sduskishttps://github.com/sduskis
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
sduskis:preconditions_pshttps://github.com/sduskis/gcloud-java/tree/preconditions_ps
Conversationhttps://github.com/googleapis/google-cloud-java/pull/5044
Commits3 (3)https://github.com/googleapis/google-cloud-java/pull/5044/commits
Checkshttps://github.com/googleapis/google-cloud-java/pull/5044/checks
Files changedhttps://github.com/googleapis/google-cloud-java/pull/5044/files
Pub/Sub: more refactoringhttps://github.com/googleapis/google-cloud-java/pull/5044#top
sduskishttps://github.com/sduskis
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
sduskis:preconditions_pshttps://github.com/sduskis/gcloud-java/tree/preconditions_ps
https://github.com/sduskis
sduskishttps://github.com/sduskis
May 1, 2019https://github.com/googleapis/google-cloud-java/pull/5044#issue-439179757
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5044
https://github.com/sduskis
Pub/Sub: more refactoringhttps://github.com/googleapis/google-cloud-java/pull/5044/commits/8e9b9bddec55847d247181faf3bc47e679e0398d
8e9b9bdhttps://github.com/googleapis/google-cloud-java/pull/5044/commits/8e9b9bddec55847d247181faf3bc47e679e0398d
https://github.com/sduskis
sduskishttps://github.com/sduskis
May 1, 2019 14:18https://github.com/googleapis/google-cloud-java/pull/5044#event-2311952502
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 1, 2019https://github.com/googleapis/google-cloud-java/pull/5044#event-2311952599
https://github.com/sduskis
Fixing a typohttps://github.com/googleapis/google-cloud-java/pull/5044/commits/b6596531194bb23da04731159da673c263b798bb
b659653https://github.com/googleapis/google-cloud-java/pull/5044/commits/b6596531194bb23da04731159da673c263b798bb
https://github.com/chingor13
chingor13https://github.com/chingor13
May 1, 2019 https://github.com/googleapis/google-cloud-java/pull/5044#pullrequestreview-232612962
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5044/files/b6596531194bb23da04731159da673c263b798bb
https://github.com/chingor13
chingor13https://github.com/chingor13
May 1, 2019https://github.com/googleapis/google-cloud-java/pull/5044#issuecomment-488311263
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5044
https://github.com/sduskis
Fixing formatinghttps://github.com/googleapis/google-cloud-java/pull/5044/commits/ceb2b47be69cd2f5414be861116f1fce86052df8
ceb2b47https://github.com/googleapis/google-cloud-java/pull/5044/commits/ceb2b47be69cd2f5414be861116f1fce86052df8
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 1, 2019https://github.com/googleapis/google-cloud-java/pull/5044#issuecomment-488333549
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044?src=pr&el=h1
#5044https://codecov.io/gh/googleapis/google-cloud-java/pull/5044?src=pr&el=desc
masterhttps://codecov.io/gh/googleapis/google-cloud-java/commit/860fe58a81bfd0290844f5c0438ac78f0b2f8ace?src=pr&el=desc
https://codecov.io/gh/googleapis/google-cloud-java/pull/5044?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044?src=pr&el=tree
...ain/java/com/google/cloud/pubsub/v1/Publisher.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXB1YnN1Yi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvcHVic3ViL3YxL1B1Ymxpc2hlci5qYXZh
...in/java/com/google/cloud/storage/StorageBatch.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXN0b3JhZ2Uvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3N0b3JhZ2UvU3RvcmFnZUJhdGNoLmphdmE=
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXZpc2lvbi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvdmlzaW9uL3YxcDRiZXRhMS9JbWFnZUFubm90YXRvckNsaWVudC5qYXZh
...m/google/cloud/vision/v1/ImageAnnotatorClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXZpc2lvbi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvdmlzaW9uL3YxL0ltYWdlQW5ub3RhdG9yQ2xpZW50LmphdmE=
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXZpc2lvbi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvdmlzaW9uL3YxcDNiZXRhMS9JbWFnZUFubm90YXRvckNsaWVudC5qYXZh
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXZpc2lvbi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvdmlzaW9uL3YxcDJiZXRhMS9JbWFnZUFubm90YXRvckNsaWVudC5qYXZh
.../java/com/google/cloud/speech/v1/SpeechClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXNwZWVjaC9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvc3BlZWNoL3YxL1NwZWVjaENsaWVudC5qYXZh
...om/google/cloud/speech/v1p1beta1/SpeechClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXNwZWVjaC9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvc3BlZWNoL3YxcDFiZXRhMS9TcGVlY2hDbGllbnQuamF2YQ==
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXdlYnJpc2svc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3dlYnJpc2svdjFiZXRhMS9XZWJSaXNrU2VydmljZVYxQmV0YTFDbGllbnQuamF2YQ==
...ogle/cloud/texttospeech/v1/TextToSpeechClient.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXRleHR0b3NwZWVjaC9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvdGV4dHRvc3BlZWNoL3YxL1RleHRUb1NwZWVjaENsaWVudC5qYXZh
543 morehttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044/diff?src=pr&el=tree-more
Continue to review full report at Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5044?src=pr&el=footer
860fe58...ceb2b47https://codecov.io/gh/googleapis/google-cloud-java/pull/5044?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5044
https://github.com/sduskis
sduskishttps://github.com/sduskis
67668c1https://github.com/googleapis/google-cloud-java/commit/67668c1411169338374b050eae50ed650e318c54
May 1, 2019https://github.com/googleapis/google-cloud-java/pull/5044#event-2312352189
https://github.com/sduskis
sduskishttps://github.com/sduskis
May 1, 2019 17:18https://github.com/googleapis/google-cloud-java/pull/5044#event-2312352294
https://github.com/JesseLovelace
JesseLovelacehttps://github.com/JesseLovelace
May 1, 2019 https://github.com/googleapis/google-cloud-java/pull/5044#ref-pullrequest-439348132
Release v0.90.0 #5047 https://github.com/googleapis/google-cloud-java/pull/5047
meltsufinhttps://github.com/meltsufin
Apr 29, 2026 https://github.com/googleapis/google-cloud-java/pull/5044#ref-commit-80f71fa
https://github.com/sduskis
Pub/Sub: more refactoring (https://github.com/googleapis/google-cloud-java/commit/80f71fa6ee09c7bbe5c287c51114f18cd0ad0543
#5044https://github.com/googleapis/google-cloud-java/pull/5044
)https://github.com/googleapis/google-cloud-java/commit/80f71fa6ee09c7bbe5c287c51114f18cd0ad0543
80f71fahttps://github.com/googleapis/google-cloud-java/commit/80f71fa6ee09c7bbe5c287c51114f18cd0ad0543
meltsufinhttps://github.com/meltsufin
May 1, 2026 https://github.com/googleapis/google-cloud-java/pull/5044#ref-commit-68b7abd
https://github.com/sduskis
Pub/Sub: more refactoring (https://github.com/googleapis/google-cloud-java/commit/68b7abd97d09fbc67455a5ff109360751fc90c2b
#5044https://github.com/googleapis/google-cloud-java/pull/5044
)https://github.com/googleapis/google-cloud-java/commit/68b7abd97d09fbc67455a5ff109360751fc90c2b
68b7abdhttps://github.com/googleapis/google-cloud-java/commit/68b7abd97d09fbc67455a5ff109360751fc90c2b
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5044
https://github.com/chingor13
chingor13 https://github.com/chingor13
https://github.com/googleapis/google-cloud-java/pull/5044/files/b6596531194bb23da04731159da673c263b798bb
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5044
https://github.com/sduskis
https://github.com/chingor13
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.