René's URL Explorer Experiment


Title: P/S refactoring Publisher.publish by sduskis · Pull Request #5018 · googleapis/google-cloud-java · GitHub

Open Graph Title: P/S refactoring Publisher.publish by sduskis · Pull Request #5018 · googleapis/google-cloud-java

X Title: P/S refactoring Publisher.publish by sduskis · Pull Request #5018 · googleapis/google-cloud-java

Description: Google Cloud Client Library for Java. Contribute to googleapis/google-cloud-java development by creating an account on GitHub.

Open Graph Description: publish() has a special case where the message is larger the the max byte count. That special case logic can be merged with the general scenario by using a list of batchesToSend rather than having...

X Description: publish() has a special case where the message is larger the the max byte count. That special case logic can be merged with the general scenario by using a list of batchesToSend rather than having...

Opengraph URL: https://github.com/googleapis/google-cloud-java/pull/5018

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:48f1ea3c-06d9-b03e-b9f1-95da2cbe9e6b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83AC:322E35:89017E:B883E7:6A4EC8D2
html-safe-nonce62c23ec59b4684315ebcea07304b04d621cad909eac4bed57c337536a9e1b1e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0FDOjMyMkUzNTo4OTAxN0U6Qjg4M0U3OjZBNEVDOEQyIiwidmlzaXRvcl9pZCI6Ijg4NzUxODg5NjEzMjYwNTc2ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace8c8fc63c04b97a1bcbf1ef489968ebcc0ee4a8827276a12a5e40e52d6b6afee
hovercard-subject-tagpull_request:273586232
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-java/5018/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e155ff6ae56299f519a103c93a030bc02e10736ff6b0c7c73ba12eec45584e9a/googleapis/google-cloud-java/pull/5018
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e155ff6ae56299f519a103c93a030bc02e10736ff6b0c7c73ba12eec45584e9a/googleapis/google-cloud-java/pull/5018
og:image:altpublish() has a special case where the message is larger the the max byte count. That special case logic can be merged with the general scenario by using a list of batchesToSend rather than having...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesduskis
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-java git https://github.com/googleapis/google-cloud-java.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id26181278
octolytics-dimension-repository_nwogoogleapis/google-cloud-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26181278
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-java/pull/5018#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5018
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5018
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-java
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5018
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5018
Reloadhttps://github.com/googleapis/google-cloud-java/pull/5018
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5018
googleapis https://github.com/googleapis
google-cloud-javahttps://github.com/googleapis/google-cloud-java
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Fork 1.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Star 2.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Code https://github.com/googleapis/google-cloud-java
Issues 654 https://github.com/googleapis/google-cloud-java/issues
Pull requests 111 https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality 0 https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
Code https://github.com/googleapis/google-cloud-java
Issues https://github.com/googleapis/google-cloud-java/issues
Pull requests https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
sduskishttps://github.com/sduskis
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
sduskis:refactor_publishhttps://github.com/sduskis/gcloud-java/tree/refactor_publish
Conversationhttps://github.com/googleapis/google-cloud-java/pull/5018
Commits1 (1)https://github.com/googleapis/google-cloud-java/pull/5018/commits
Checkshttps://github.com/googleapis/google-cloud-java/pull/5018/checks
Files changedhttps://github.com/googleapis/google-cloud-java/pull/5018/files
P/S refactoring Publisher.publishhttps://github.com/googleapis/google-cloud-java/pull/5018#top
sduskishttps://github.com/sduskis
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
sduskis:refactor_publishhttps://github.com/sduskis/gcloud-java/tree/refactor_publish
https://github.com/sduskis
sduskishttps://github.com/sduskis
Apr 25, 2019https://github.com/googleapis/google-cloud-java/pull/5018#issue-437276156
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5018
https://github.com/sduskis
P/S refactoring Publisher.publishhttps://github.com/googleapis/google-cloud-java/pull/5018/commits/677f3391307d8c84ad802fe1a52c587ac55a2815
677f339https://github.com/googleapis/google-cloud-java/pull/5018/commits/677f3391307d8c84ad802fe1a52c587ac55a2815
https://github.com/sduskis
sduskishttps://github.com/sduskis
April 25, 2019 15:56https://github.com/googleapis/google-cloud-java/pull/5018#event-2300716682
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 25, 2019https://github.com/googleapis/google-cloud-java/pull/5018#event-2300716821
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Apr 25, 2019https://github.com/googleapis/google-cloud-java/pull/5018#issuecomment-486744780
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5018
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=h1
#5018https://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=desc
masterhttps://codecov.io/gh/googleapis/google-cloud-java/commit/909b0e8ef2d87a5d75da3ebfb595868a94645aae?src=pr&el=desc
https://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=tree
...ain/java/com/google/cloud/pubsub/v1/Publisher.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXB1YnN1Yi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvcHVic3ViL3YxL1B1Ymxpc2hlci5qYXZh
Continue to review full report at Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=footer
909b0e8...677f339https://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5018
https://github.com/kolea2
kolea2https://github.com/kolea2
Apr 25, 2019 https://github.com/googleapis/google-cloud-java/pull/5018#pullrequestreview-230793908
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5018/files/677f3391307d8c84ad802fe1a52c587ac55a2815
...le-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.javahttps://github.com/googleapis/google-cloud-java/pull/5018/files/677f3391307d8c84ad802fe1a52c587ac55a2815#diff-1f75b8a1934a7436a0d7e82fffaadc9ff2a7f0751eda0cdb2032fe7902d83d80
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5018
https://github.com/kolea2
kolea2https://github.com/kolea2
Apr 25, 2019 https://github.com/googleapis/google-cloud-java/pull/5018#pullrequestreview-230845890
View reviewed changes https://github.com/googleapis/google-cloud-java/pull/5018/files/677f3391307d8c84ad802fe1a52c587ac55a2815
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
Apr 25, 2019https://github.com/googleapis/google-cloud-java/pull/5018#issuecomment-486816341
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5018
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=h1
#5018https://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=desc
masterhttps://codecov.io/gh/googleapis/google-cloud-java/commit/909b0e8ef2d87a5d75da3ebfb595868a94645aae?src=pr&el=desc
https://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=tree
...ain/java/com/google/cloud/pubsub/v1/Publisher.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLXB1YnN1Yi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvcHVic3ViL3YxL1B1Ymxpc2hlci5qYXZh
...ud/storage/contrib/nio/testing/FakeStorageRpc.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWNvbnRyaWIvZ29vZ2xlLWNsb3VkLW5pby9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvc3RvcmFnZS9jb250cmliL25pby90ZXN0aW5nL0Zha2VTdG9yYWdlUnBjLmphdmE=
...n/java/com/google/cloud/bigquery/BigQueryImpl.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5L3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC9iaWdxdWVyeS9CaWdRdWVyeUltcGwuamF2YQ==
...ge/contrib/nio/CloudStorageFileSystemProvider.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWNvbnRyaWIvZ29vZ2xlLWNsb3VkLW5pby9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvc3RvcmFnZS9jb250cmliL25pby9DbG91ZFN0b3JhZ2VGaWxlU3lzdGVtUHJvdmlkZXIuamF2YQ==
...le/cloud/storage/contrib/nio/CloudStoragePath.javahttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018/diff?src=pr&el=tree#diff-Z29vZ2xlLWNsb3VkLWNsaWVudHMvZ29vZ2xlLWNsb3VkLWNvbnRyaWIvZ29vZ2xlLWNsb3VkLW5pby9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvc3RvcmFnZS9jb250cmliL25pby9DbG91ZFN0b3JhZ2VQYXRoLmphdmE=
Continue to review full report at Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=footer
909b0e8...677f339https://codecov.io/gh/googleapis/google-cloud-java/pull/5018?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5018
https://github.com/sduskis
sduskishttps://github.com/sduskis
abf92a3https://github.com/googleapis/google-cloud-java/commit/abf92a3ea30a7375790f6447532f6fd45bed5744
Apr 25, 2019https://github.com/googleapis/google-cloud-java/pull/5018#event-2301418295
https://github.com/sduskis
sduskishttps://github.com/sduskis
April 25, 2019 20:39https://github.com/googleapis/google-cloud-java/pull/5018#event-2301418405
https://github.com/JesseLovelace
JesseLovelacehttps://github.com/JesseLovelace
May 1, 2019 https://github.com/googleapis/google-cloud-java/pull/5018#ref-pullrequest-439348132
Release v0.90.0 #5047 https://github.com/googleapis/google-cloud-java/pull/5047
meltsufinhttps://github.com/meltsufin
Apr 29, 2026 https://github.com/googleapis/google-cloud-java/pull/5018#ref-commit-9eed55d
https://github.com/sduskis
P/S refactoring Publisher.publish (https://github.com/googleapis/google-cloud-java/commit/9eed55d4fbf77e520c175e3534d467036c874a72
#5018https://github.com/googleapis/google-cloud-java/pull/5018
)https://github.com/googleapis/google-cloud-java/commit/9eed55d4fbf77e520c175e3534d467036c874a72
9eed55dhttps://github.com/googleapis/google-cloud-java/commit/9eed55d4fbf77e520c175e3534d467036c874a72
meltsufinhttps://github.com/meltsufin
May 1, 2026 https://github.com/googleapis/google-cloud-java/pull/5018#ref-commit-6237fa8
https://github.com/sduskis
P/S refactoring Publisher.publish (https://github.com/googleapis/google-cloud-java/commit/6237fa8c03de16733de032360c0ddd7c32c88592
#5018https://github.com/googleapis/google-cloud-java/pull/5018
)https://github.com/googleapis/google-cloud-java/commit/6237fa8c03de16733de032360c0ddd7c32c88592
6237fa8https://github.com/googleapis/google-cloud-java/commit/6237fa8c03de16733de032360c0ddd7c32c88592
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F5018
https://github.com/kolea2
kolea2 https://github.com/kolea2
https://github.com/googleapis/google-cloud-java/pull/5018/files/677f3391307d8c84ad802fe1a52c587ac55a2815
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/5018
https://github.com/sduskis
https://github.com/codecov-io
https://github.com/kolea2
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.