René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Conditional DELETE from a table with a DATE column fails","articleBody":"Thanks for stopping by to let us know something could be better!\r\n\r\nPlease include as much information as possible:\r\n\r\n#### Environment details\r\n\r\n- OS: N/A\r\n- Java version: 1.8.0_162\r\n- google-cloud-java version(s): google-cloud-spanner 0.57.0-beta\r\n\r\n#### Steps to reproduce\r\n\r\n1. Create table with schema including a DATE column eg. \r\n```\r\nCREATE TABLE geo_views (\r\n\tcity STRING(MAX) NOT NULL,\r\n\tclient_id INT64 NOT NULL,\r\n\tdate DATE NOT NULL,\r\n\tdomain STRING(MAX) NOT NULL,\r\n\turl STRING(MAX) NOT NULL,\r\n\tpageviews INT64 NOT NULL,\r\n) PRIMARY KEY (client_id, domain, date DESC, city, url)\r\n```\r\n2. Add some records.\r\n3. Delete from the table with a `WHERE` clause eg. `DELETE FROM geo_views WHERE client_id \u003e 1000`\r\n\r\n#### Stacktrace\r\n\r\nNote this stacktrace comes from a delete when using the Olaviate Spanner JDBC driver which includes the latest Google Spanner client code as a shaded lib:\r\n\r\n```\r\njava.lang.AssertionError: Illegal key part: class nl.topicus.jdbc.shaded.com.google.cloud.Date\r\n\tat nl.topicus.jdbc.shaded.com.google.cloud.spanner.Key.toProto(Key.java:287)\r\n\tat nl.topicus.jdbc.shaded.com.google.cloud.spanner.KeySet.appendToProto(KeySet.java:204)\r\n\tat nl.topicus.jdbc.shaded.com.google.cloud.spanner.Mutation.toProto(Mutation.java:381)\r\n\tat nl.topicus.jdbc.shaded.com.google.cloud.spanner.SpannerImpl$TransactionContextImpl.commit(SpannerImpl.java:1394)\r\n\tat nl.topicus.jdbc.shaded.com.google.cloud.spanner.SpannerImpl$TransactionRunnerImpl.runInternal(SpannerImpl.java:1299)\r\n\tat nl.topicus.jdbc.shaded.com.google.cloud.spanner.SpannerImpl$TransactionRunnerImpl.run(SpannerImpl.java:1242)\r\n\tat nl.topicus.jdbc.shaded.com.google.cloud.spanner.SessionPool$PooledSession$1.run(SessionPool.java:398)\r\n\tat nl.topicus.jdbc.transaction.TransactionThread.run(TransactionThread.java:115)\r\n```\r\n\r\n#### Code snippet\r\n\r\nI believe this error is caused by lack of support for the `Date` type in the `if` statement here: https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Key.java#L285\r\n\r\n```java\r\n  ListValue toProto() {\r\n    ListValue.Builder builder = ListValue.newBuilder();\r\n    for (Object part : parts) {\r\n      if (part == null) {\r\n        builder.addValues(NULL_PROTO);\r\n      } else if (part instanceof Boolean) {\r\n        builder.addValuesBuilder().setBoolValue((Boolean) part);\r\n      } else if (part instanceof Long) {\r\n        builder.addValuesBuilder().setStringValue(part.toString());\r\n      } else if (part instanceof Double) {\r\n        builder.addValuesBuilder().setNumberValue((Double) part);\r\n      } else if (part instanceof String) {\r\n        builder.addValuesBuilder().setStringValue((String) part);\r\n      } else if (part instanceof ByteArray) {\r\n        builder.addValuesBuilder().setStringValue(((ByteArray) part).toBase64());\r\n      } else if (part instanceof Timestamp) {\r\n        builder.addValuesBuilder().setStringValue(((Timestamp) part).toString());\r\n      } else {\r\n        throw new AssertionError(\"Illegal key part: \" + part.getClass());\r\n      }\r\n    }\r\n    return builder.build();\r\n  }\r\n```\r\n\r\n#### External references such as API reference guides used\r\n\r\nSee also: https://github.com/olavloite/spanner-jdbc/issues/134\r\n\r\n#### Any additional information below\r\n\r\nI looked in the tests for this code but there aren't any because `Key.toProto` is not public and only used by higher level code in the client package.  As best I can tell only an actual delete using a key based condition will trigger its use.\r\n","author":{"url":"https://github.com/O1O1O1O","@type":"Person","name":"O1O1O1O"},"datePublished":"2019-02-07T20:10:46.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/4466/google-cloud-java/issues/4466"}