| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d3ab9e72-bf09-0d3e-553b-8ac7ad47ed89 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA20:2177FC:BA762:FE4FC:6A4D5121 |
| html-safe-nonce | f16d621f24507e26d8fdc25e7b1f3f6f987759925b6efd73e88078245c8b5ee2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTIwOjIxNzdGQzpCQTc2MjpGRTRGQzo2QTRENTEyMSIsInZpc2l0b3JfaWQiOiI1MTUxNTY1MTIzMDA5OTkwOTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 300359f597173dd873daf7ceee913cd6e3eb5ffbd2c3f7a72693f8d62263bb97 |
| hovercard-subject-tag | pull_request:180708959 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-java/3144/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e45be9121d9652ce5b0855b682405d9accd1994cd5419b9fe6a22c1e159eda9b/googleapis/google-cloud-java/pull/3144 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e45be9121d9652ce5b0855b682405d9accd1994cd5419b9fe6a22c1e159eda9b/googleapis/google-cloud-java/pull/3144 |
| og:image:alt | It is hard to do this completely async, but we can use a background
thread so it doesn't block user code.
Fixes #3134.
Fixes #3065.
cc @mdietz94 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pongad |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6 |
| turbo-cache-control | no-cache |
| go-import | github.com/googleapis/google-cloud-java git https://github.com/googleapis/google-cloud-java.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 26181278 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 26181278 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56fc8347865a14e2ec811533d68f929cf4e0ec19 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/googleapis/google-cloud-java/pull/3144#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F3144 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F3144 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-java |
| Reload | https://github.com/googleapis/google-cloud-java/pull/3144 |
| Reload | https://github.com/googleapis/google-cloud-java/pull/3144 |
| Reload | https://github.com/googleapis/google-cloud-java/pull/3144 |
| Please reload this page | https://github.com/googleapis/google-cloud-java/pull/3144 |
|
googleapis
| https://github.com/googleapis |
| google-cloud-java | https://github.com/googleapis/google-cloud-java |
|
Notifications
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java |
|
Fork
1.1k
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java |
|
Star
2.1k
| https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java |
|
Code
| https://github.com/googleapis/google-cloud-java |
|
Issues
651
| https://github.com/googleapis/google-cloud-java/issues |
|
Pull requests
107
| https://github.com/googleapis/google-cloud-java/pulls |
|
Actions
| https://github.com/googleapis/google-cloud-java/actions |
|
Security and quality
0
| https://github.com/googleapis/google-cloud-java/security |
|
Insights
| https://github.com/googleapis/google-cloud-java/pulse |
|
Code
| https://github.com/googleapis/google-cloud-java |
|
Issues
| https://github.com/googleapis/google-cloud-java/issues |
|
Pull requests
| https://github.com/googleapis/google-cloud-java/pulls |
|
Actions
| https://github.com/googleapis/google-cloud-java/actions |
|
Security and quality
| https://github.com/googleapis/google-cloud-java/security |
|
Insights
| https://github.com/googleapis/google-cloud-java/pulse |
| pongad | https://github.com/pongad |
| googleapis:master | https://github.com/googleapis/google-cloud-java/tree/master |
| Conversation | https://github.com/googleapis/google-cloud-java/pull/3144 |
| Commits2 (2) | https://github.com/googleapis/google-cloud-java/pull/3144/commits |
| Checks | https://github.com/googleapis/google-cloud-java/pull/3144/checks |
| Files changed | https://github.com/googleapis/google-cloud-java/pull/3144/files |
| pubsub: stop Subscriber asynchronously | https://github.com/googleapis/google-cloud-java/pull/3144#top |
| pongad | https://github.com/pongad |
| googleapis:master | https://github.com/googleapis/google-cloud-java/tree/master |
|
| https://github.com/pongad |
| pongad | https://github.com/pongad |
| Apr 10, 2018 | https://github.com/googleapis/google-cloud-java/pull/3144#issue-313064955 |
| Please reload this page | https://github.com/googleapis/google-cloud-java/pull/3144 |
| #3134 | https://github.com/googleapis/google-cloud-java/issues/3134 |
| #3065 | https://github.com/googleapis/google-cloud-java/issues/3065 |
| @mdietz94 | https://github.com/mdietz94 |
| Please reload this page | https://github.com/googleapis/google-cloud-java/pull/3144 |
|
| https://github.com/pongad |
| pubsub: stop Subscriber asynchronously | https://github.com/googleapis/google-cloud-java/pull/3144/commits/7cc69c678d92989ec9d8cb4d528b8d05932dbdc1 |
| 7cc69c6 | https://github.com/googleapis/google-cloud-java/pull/3144/commits/7cc69c678d92989ec9d8cb4d528b8d05932dbdc1 |
| #3134 | https://github.com/googleapis/google-cloud-java/issues/3134 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Apr 10, 2018 | https://github.com/googleapis/google-cloud-java/pull/3144#event-1567036508 |
| https://github.com/pongad |
| pongad | https://github.com/pongad |
| jeanbza | https://github.com/jeanbza |
| April 12, 2018 21:04 | https://github.com/googleapis/google-cloud-java/pull/3144#event-1571967233 |
| https://github.com/jeanbza |
| jeanbza | https://github.com/jeanbza |
| Apr 13, 2018 | https://github.com/googleapis/google-cloud-java/pull/3144#issuecomment-380991116 |
| Please reload this page | https://github.com/googleapis/google-cloud-java/pull/3144 |
| https://github.com/jeanbza |
| jeanbza | https://github.com/jeanbza |
|
Apr 13, 2018
| https://github.com/googleapis/google-cloud-java/pull/3144#pullrequestreview-111851700 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-java/pull/3144/files/7cc69c678d92989ec9d8cb4d528b8d05932dbdc1 |
| https://github.com/mdietz94 |
| mdietz94 | https://github.com/mdietz94 |
|
Apr 13, 2018
| https://github.com/googleapis/google-cloud-java/pull/3144#pullrequestreview-112145318 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-java/pull/3144/files/7cc69c678d92989ec9d8cb4d528b8d05932dbdc1 |
| google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java | https://github.com/googleapis/google-cloud-java/pull/3144/files/7cc69c678d92989ec9d8cb4d528b8d05932dbdc1#diff-4fd0fb821e0087d9d1baeed04ae60c2002aaa15cabda1b33a9037a3246e7f96a |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F3144 |
| Please reload this page | https://github.com/googleapis/google-cloud-java/pull/3144 |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F3144 |
| Please reload this page | https://github.com/googleapis/google-cloud-java/pull/3144 |
|
| https://github.com/pongad |
| pr comment | https://github.com/googleapis/google-cloud-java/pull/3144/commits/a1d4890920d355f0b05ee458b5414218933b1889 |
| a1d4890 | https://github.com/googleapis/google-cloud-java/pull/3144/commits/a1d4890920d355f0b05ee458b5414218933b1889 |
| https://github.com/pongad |
| pongad | https://github.com/pongad |
| Apr 16, 2018 | https://github.com/googleapis/google-cloud-java/pull/3144#issuecomment-381673048 |
| @mdietz94 | https://github.com/mdietz94 |
| Please reload this page | https://github.com/googleapis/google-cloud-java/pull/3144 |
| https://github.com/mdietz94 |
| mdietz94 | https://github.com/mdietz94 |
|
Apr 16, 2018
| https://github.com/googleapis/google-cloud-java/pull/3144#pullrequestreview-112502518 |
|
View reviewed changes
| https://github.com/googleapis/google-cloud-java/pull/3144/files/a1d4890920d355f0b05ee458b5414218933b1889 |
| https://github.com/pongad |
| pongad | https://github.com/pongad |
| e5a28f4 | https://github.com/googleapis/google-cloud-java/commit/e5a28f437e27dbb870026508b0ddd53e83c3f4e1 |
| Apr 16, 2018 | https://github.com/googleapis/google-cloud-java/pull/3144#event-1576905642 |
| https://github.com/pongad |
| pongad | https://github.com/pongad |
| April 16, 2018 17:45 | https://github.com/googleapis/google-cloud-java/pull/3144#event-1576905768 |
| https://github.com/j256 |
| j256 | https://github.com/j256 |
|
May 30, 2018
| https://github.com/googleapis/google-cloud-java/pull/3144#ref-issue-306983291 |
|
[pubsub] Subscriber.stopAsync().awaitTerminated() doesn't wait for all acks to be sent
#3065
| https://github.com/googleapis/google-cloud-java/issues/3065 |
| suztomo | https://github.com/suztomo |
|
Mar 9, 2026
| https://github.com/googleapis/google-cloud-java/pull/3144#ref-commit-e1947c1 |
|
| https://github.com/mpeddada1 |
|
| https://github.com/apps/gcf-owl-bot |
| chore: use sdk-platform-java-config to consolidate build configs ( | https://github.com/googleapis/google-cloud-java/commit/e1947c15e081ab69edd1e348217ffdb8d1cea816 |
| #3144 | https://github.com/googleapis/google-cloud-java/pull/3144 |
| ) | https://github.com/googleapis/google-cloud-java/commit/e1947c15e081ab69edd1e348217ffdb8d1cea816 |
| e1947c1 | https://github.com/googleapis/google-cloud-java/commit/e1947c15e081ab69edd1e348217ffdb8d1cea816 |
| https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md | https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md |
| chingor13 | https://github.com/chingor13 |
|
Mar 30, 2026
| https://github.com/googleapis/google-cloud-java/pull/3144#ref-commit-94708e2 |
|
| https://github.com/renovate-bot |
| chore(deps): update dependency com.google.cloud:libraries-bom to v26.… | https://github.com/googleapis/google-cloud-java/commit/94708e267286a04ef59fb3fe9b5ed3ac6efa2e47 |
| 94708e2 | https://github.com/googleapis/google-cloud-java/commit/94708e267286a04ef59fb3fe9b5ed3ac6efa2e47 |
| #3144 | https://github.com/googleapis/google-cloud-java/pull/3144 |
| https://github.co/hiddenchars |
| https://github.com/googleapis/google-cloud-java/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F3144 |
|
| https://github.com/mdietz94 |
|
mdietz94
| https://github.com/mdietz94 |
|
| https://github.com/googleapis/google-cloud-java/pull/3144/files/a1d4890920d355f0b05ee458b5414218933b1889 |
|
| https://github.com/jeanbza |
|
jeanbza
| https://github.com/jeanbza |
|
| https://github.com/googleapis/google-cloud-java/pull/3144/files/7cc69c678d92989ec9d8cb4d528b8d05932dbdc1 |
|
cla: yes
| https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/googleapis/google-cloud-java/pull/3144 |
|
| https://github.com/pongad |
|
| https://github.com/jeanbza |
|
| https://github.com/mdietz94 |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |