René's URL Explorer Experiment


Title: Changing the AckReplyConsumer interface by davidtorres · Pull Request #1758 · googleapis/google-cloud-java · GitHub

Open Graph Title: Changing the AckReplyConsumer interface by davidtorres · Pull Request #1758 · googleapis/google-cloud-java

X Title: Changing the AckReplyConsumer interface by davidtorres · Pull Request #1758 · googleapis/google-cloud-java

Description: Google Cloud Client Library for Java. Contribute to googleapis/google-cloud-java development by creating an account on GitHub.

Open Graph Description: @garrettjonesgoogle @pongad I'm changing the interface of AckReplyConsumer because it really does not buy us anything to be able to accept an exception along with the ackreply. It actually mak...

X Description: @garrettjonesgoogle @pongad I'm changing the interface of AckReplyConsumer because it really does not buy us anything to be able to accept an exception along with the ackreply. It actually...

Opengraph URL: https://github.com/googleapis/google-cloud-java/pull/1758

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9510bb3b-2921-4b24-bbca-89d8561db268
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2F0:A4BE6:1A745:22ECE:6A4D7832
html-safe-nonce1758ca8ec1c7c500bebcdd64f90ef3964fef16bdf3552be845c4f91de1661973
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkYwOkE0QkU2OjFBNzQ1OjIyRUNFOjZBNEQ3ODMyIiwidmlzaXRvcl9pZCI6IjI5NzQ2MTczNzY1ODkxODMwMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc8141350954ea309493962de432c9ac93a08f60872b31ae3086b7e523f56facd
hovercard-subject-tagpull_request:110941134
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-java/1758/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/733be456b6b1191e961cdd729aeb37b718405c5a52e4a142bc33817d3aaeff4f/googleapis/google-cloud-java/pull/1758
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/733be456b6b1191e961cdd729aeb37b718405c5a52e4a142bc33817d3aaeff4f/googleapis/google-cloud-java/pull/1758
og:image:alt@garrettjonesgoogle @pongad I'm changing the interface of AckReplyConsumer because it really does not buy us anything to be able to accept an exception along with the ackreply. It actually mak...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedavidtorres
hostnamegithub.com
expected-hostnamegithub.com
None7f8e15305e2ab58890ca84b830615e375f5df303cf471cafcba0c08272981be3
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-java git https://github.com/googleapis/google-cloud-java.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id26181278
octolytics-dimension-repository_nwogoogleapis/google-cloud-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26181278
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8608b0750fc35e283e5ec5b094bff942d7a0e197
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-java/pull/1758#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F1758
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F1758
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-java
Reloadhttps://github.com/googleapis/google-cloud-java/pull/1758
Reloadhttps://github.com/googleapis/google-cloud-java/pull/1758
Reloadhttps://github.com/googleapis/google-cloud-java/pull/1758
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/1758
googleapis https://github.com/googleapis
google-cloud-javahttps://github.com/googleapis/google-cloud-java
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Fork 1.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Star 2.1k https://github.com/login?return_to=%2Fgoogleapis%2Fgoogle-cloud-java
Code https://github.com/googleapis/google-cloud-java
Issues 653 https://github.com/googleapis/google-cloud-java/issues
Pull requests 105 https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality 0 https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
Code https://github.com/googleapis/google-cloud-java
Issues https://github.com/googleapis/google-cloud-java/issues
Pull requests https://github.com/googleapis/google-cloud-java/pulls
Actions https://github.com/googleapis/google-cloud-java/actions
Security and quality https://github.com/googleapis/google-cloud-java/security
Insights https://github.com/googleapis/google-cloud-java/pulse
pongadhttps://github.com/pongad
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
davidtorres:masterhttps://github.com/davidtorres/google-cloud-java/tree/master
Conversationhttps://github.com/googleapis/google-cloud-java/pull/1758
Commits7 (7)https://github.com/googleapis/google-cloud-java/pull/1758/commits
Checkshttps://github.com/googleapis/google-cloud-java/pull/1758/checks
Files changedhttps://github.com/googleapis/google-cloud-java/pull/1758/files
Changing the AckReplyConsumer interfacehttps://github.com/googleapis/google-cloud-java/pull/1758#top
pongadhttps://github.com/pongad
googleapis:masterhttps://github.com/googleapis/google-cloud-java/tree/master
davidtorres:masterhttps://github.com/davidtorres/google-cloud-java/tree/master
https://github.com/davidtorres
davidtorreshttps://github.com/davidtorres
Mar 15, 2017https://github.com/googleapis/google-cloud-java/pull/1758#issue-214523852
@garrettjonesgooglehttps://github.com/garrettjonesgoogle
@pongadhttps://github.com/pongad
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/1758
davidtorreshttps://github.com/davidtorres
February 22, 2017 15:39https://github.com/googleapis/google-cloud-java/pull/1758#commits-pushed-c4c6174
https://github.com/davidtorres
Enabling client-side compression in the library, with an option tohttps://github.com/googleapis/google-cloud-java/pull/1758/commits/c4c6174498f54e65ca78437c6477307d498579fc
c4c6174https://github.com/googleapis/google-cloud-java/pull/1758/commits/c4c6174498f54e65ca78437c6477307d498579fc
googleapis#1639https://github.com/googleapis/google-cloud-java/issues/1639
https://github.com/davidtorres
Merge remote-tracking branch 'upstream/master'https://github.com/googleapis/google-cloud-java/pull/1758/commits/27338a4aa03921780d483cc114b9b6a02a8bd23a
27338a4https://github.com/googleapis/google-cloud-java/pull/1758/commits/27338a4aa03921780d483cc114b9b6a02a8bd23a
https://github.com/davidtorres
Revert "Enabling client-side compression in the library, with an opti…https://github.com/googleapis/google-cloud-java/pull/1758/commits/d6a1043953ef5a801e7e9ccc65b436bda8a0e862
d6a1043https://github.com/googleapis/google-cloud-java/pull/1758/commits/d6a1043953ef5a801e7e9ccc65b436bda8a0e862
googleapis#1645https://github.com/googleapis/google-cloud-java/pull/1645
a599972https://github.com/davidtorres/google-cloud-java/commit/a5999728f55f3657482a9b6fa671d432be56989f
https://github.com/davidtorres
Merge remote-tracking branch 'upstream/master'https://github.com/googleapis/google-cloud-java/pull/1758/commits/823ad09fdea5c5dab508709b612f955015630061
823ad09https://github.com/googleapis/google-cloud-java/pull/1758/commits/823ad09fdea5c5dab508709b612f955015630061
https://github.com/davidtorres
Changing the AckReplyConsumer interface to comply to just the Java 8 …https://github.com/googleapis/google-cloud-java/pull/1758/commits/ec14abeebf1202e8d681aa37b309145a0b82ed7f
ec14abehttps://github.com/googleapis/google-cloud-java/pull/1758/commits/ec14abeebf1202e8d681aa37b309145a0b82ed7f
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 15, 2017https://github.com/googleapis/google-cloud-java/pull/1758#event-1001679746
https://github.com/pongad
pongadhttps://github.com/pongad
Mar 15, 2017https://github.com/googleapis/google-cloud-java/pull/1758#issuecomment-286886373
@garrettjonesgooglehttps://github.com/garrettjonesgoogle
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/1758
https://github.com/garrettjonesgoogle
garrettjonesgooglehttps://github.com/garrettjonesgoogle
Mar 17, 2017https://github.com/googleapis/google-cloud-java/pull/1758#issuecomment-287499218
@davidtorreshttps://github.com/davidtorres
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/1758
davidtorreshttps://github.com/davidtorres
March 20, 2017 13:51https://github.com/googleapis/google-cloud-java/pull/1758#commits-pushed-652894a
https://github.com/davidtorres
Merge remote-tracking branch 'upstream/master'https://github.com/googleapis/google-cloud-java/pull/1758/commits/652894a9418ee9a8e08d370902dba0f5519f5555
652894ahttps://github.com/googleapis/google-cloud-java/pull/1758/commits/652894a9418ee9a8e08d370902dba0f5519f5555
https://github.com/davidtorres
Example fixes to comply with changes to the AckReplyConsumer interface.https://github.com/googleapis/google-cloud-java/pull/1758/commits/3e906e698e9b82f787c23307976b7153c56c2a6a
3e906e6https://github.com/googleapis/google-cloud-java/pull/1758/commits/3e906e698e9b82f787c23307976b7153c56c2a6a
https://github.com/coveralls
coverallshttps://github.com/coveralls
Mar 20, 2017https://github.com/googleapis/google-cloud-java/pull/1758#issuecomment-287868594
https://coveralls.io/builds/10685318
3e906e6https://github.com/googleapis/google-cloud-java/commit/3e906e698e9b82f787c23307976b7153c56c2a6a
e9c05a5https://github.com/googleapis/google-cloud-java/commit/e9c05a5a9aed5103076e2e2d6d24f59f48a90ef3
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/1758
https://github.com/davidtorres
davidtorreshttps://github.com/davidtorres
Mar 20, 2017https://github.com/googleapis/google-cloud-java/pull/1758#issuecomment-287872480
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/1758
https://github.com/pongad
pongadhttps://github.com/pongad
Mar 21, 2017https://github.com/googleapis/google-cloud-java/pull/1758#issuecomment-287937221
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/1758
https://github.com/pongad
pongadhttps://github.com/pongad
a2ca992https://github.com/googleapis/google-cloud-java/commit/a2ca9924be8fd0372b5a1c430e05b942fbacebda
Mar 21, 2017https://github.com/googleapis/google-cloud-java/pull/1758#event-1007725673
meltsufinhttps://github.com/meltsufin
Dec 22, 2025 https://github.com/googleapis/google-cloud-java/pull/1758#ref-commit-0d24991
https://github.com/renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-logging …https://github.com/googleapis/google-cloud-java/commit/0d24991115b9886564f766face6756d27df8d7a7
0d24991https://github.com/googleapis/google-cloud-java/commit/0d24991115b9886564f766face6756d27df8d7a7
#1758https://github.com/googleapis/google-cloud-java/pull/1758
chingor13https://github.com/chingor13
Jan 22, 2026 https://github.com/googleapis/google-cloud-java/pull/1758#ref-commit-da5d9e5
https://github.com/apps/release-please
chore(main): release 2.26.3 (https://github.com/googleapis/google-cloud-java/commit/da5d9e5e4f0a87356d5a0bb02a53787321ec45af
#1758https://github.com/googleapis/google-cloud-java/pull/1758
)https://github.com/googleapis/google-cloud-java/commit/da5d9e5e4f0a87356d5a0bb02a53787321ec45af
da5d9e5https://github.com/googleapis/google-cloud-java/commit/da5d9e5e4f0a87356d5a0bb02a53787321ec45af
https://togithub.com/googleapis/java-datastore/compare/v2.26.2...v2.26.3https://togithub.com/googleapis/java-datastore/compare/v2.26.2...v2.26.3
#1747https://github.com/googleapis/google-cloud-java/pull/1747
https://togithub.com/googleapis/java-datastore/issues/1747https://togithub.com/googleapis/java-datastore/issues/1747
592072bhttps://github.com/googleapis/google-cloud-java/commit/592072b194706e63a7fd4a6f6230377e8f4b729d
https://togithub.com/googleapis/java-datastore/commit/592072b194706e63a7fd4a6f6230377e8f4b729dhttps://togithub.com/googleapis/java-datastore/commit/592072b194706e63a7fd4a6f6230377e8f4b729d
https://togithub.com/googleapis/release-pleasehttps://togithub.com/googleapis/release-please
https://togithub.com/googleapis/release-please#release-pleasehttps://togithub.com/googleapis/release-please#release-please
suztomohttps://github.com/suztomo
Mar 11, 2026 https://github.com/googleapis/google-cloud-java/pull/1758#ref-commit-5eea444
https://github.com/renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-logging …https://github.com/suztomo/google-cloud-java/commit/5eea444e953adcaaa3494db19af60aa7cdb26a8e
5eea444https://github.com/suztomo/google-cloud-java/commit/5eea444e953adcaaa3494db19af60aa7cdb26a8e
googleapis#1758https://github.com/googleapis/google-cloud-java/pull/1758
lqiu96https://github.com/lqiu96
Mar 20, 2026 https://github.com/googleapis/google-cloud-java/pull/1758#ref-commit-2904171
https://github.com/apps/release-please
chore(main): release 2.26.3 (https://github.com/googleapis/google-cloud-java/commit/2904171b976ded436697c6ae7190fcec4e26b191
#1758https://github.com/googleapis/google-cloud-java/pull/1758
)https://github.com/googleapis/google-cloud-java/commit/2904171b976ded436697c6ae7190fcec4e26b191
2904171https://github.com/googleapis/google-cloud-java/commit/2904171b976ded436697c6ae7190fcec4e26b191
https://togithub.com/googleapis/java-datastore/compare/v2.26.2...v2.26.3https://togithub.com/googleapis/java-datastore/compare/v2.26.2...v2.26.3
#1747https://github.com/googleapis/google-cloud-java/pull/1747
https://togithub.com/googleapis/java-datastore/issues/1747https://togithub.com/googleapis/java-datastore/issues/1747
c63d4echttps://github.com/googleapis/google-cloud-java/commit/c63d4ec089dbde8feadf9288dd3f942f9821f017
https://togithub.com/googleapis/java-datastore/commit/c63d4ec089dbde8feadf9288dd3f942f9821f017https://togithub.com/googleapis/java-datastore/commit/c63d4ec089dbde8feadf9288dd3f942f9821f017
https://togithub.com/googleapis/release-pleasehttps://togithub.com/googleapis/release-please
https://togithub.com/googleapis/release-please#release-pleasehttps://togithub.com/googleapis/release-please#release-please
suztomohttps://github.com/suztomo
Mar 23, 2026 https://github.com/googleapis/google-cloud-java/pull/1758#ref-commit-b8eb155
https://github.com/apps/release-please
chore(main): release 2.22.1 (https://github.com/suztomo/google-cloud-java/commit/b8eb1559342a25162eed81813a39de451efb8e26
googleapis#1758https://github.com/googleapis/google-cloud-java/pull/1758
)https://github.com/suztomo/google-cloud-java/commit/b8eb1559342a25162eed81813a39de451efb8e26
b8eb155https://github.com/suztomo/google-cloud-java/commit/b8eb1559342a25162eed81813a39de451efb8e26
meltsufinhttps://github.com/meltsufin
May 2, 2026 https://github.com/googleapis/google-cloud-java/pull/1758#ref-commit-3b9ccec
https://github.com/apps/release-please
chore(main): release 3.24.2-SNAPSHOT (https://github.com/googleapis/google-cloud-java/commit/3b9ccecd7f4be564a925caaaaa6cd49fc7193f8e
#1758https://github.com/googleapis/google-cloud-java/pull/1758
)https://github.com/googleapis/google-cloud-java/commit/3b9ccecd7f4be564a925caaaaa6cd49fc7193f8e
3b9ccechttps://github.com/googleapis/google-cloud-java/commit/3b9ccecd7f4be564a925caaaaa6cd49fc7193f8e
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-java%2Fpull%2F1758
cla: yes https://github.com/googleapis/google-cloud-java/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/googleapis/google-cloud-java/pull/1758
https://github.com/davidtorres
https://github.com/pongad
https://github.com/garrettjonesgoogle
https://github.com/coveralls
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.