René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Spanner: TransactionRunner.run() sometimes doesn't retry on ABORTED","articleBody":"Hello, we've noticed that sometimes running executeUpdate throws an AbortedException (directly from inside executeUpdate). This happens, for example, when running queries like `DELETE FROM Table WHERE true`. When this happens inside TransactionRunner.run(), the transaction is not automatically retried, but the AbortedException is immediately rethrown to the caller. Note that the AbortedException appears to be thrown from `executeUpdate`, not transaction.commit().\r\n\r\nThe message in the exception says something like:\r\n\r\n```\r\ncom.google.cloud.spanner.AbortedException: ABORTED: com.google.api.gax.rpc.AbortedException: io.grpc.StatusRuntimeException: ABORTED: Transaction aborted. Database schema probably changed during transaction, retry may succeed.\r\n```\r\n\r\nWe've found that if we wrap this in a retry loop, it does in fact succeed as suggested. We're wondering whether this is a case that should be handled by TransactionRunner's retry logic, or whether there's something we should be doing differently in our code. Thanks!\r\n\r\n#### Environment details\r\n\r\n2. OS type and version: OSX High Sierra.\r\n3. Java version: 1.8.0\r\n4. google-cloud-java version(s): google-cloud-spanner v0.70.0\r\n\r\n#### Code example\r\n\r\n```java\r\n// we are primarily seeing this while using RemoteSpannerHelper\r\nfinal RemoteSpannerHelper remoteSpannerHelper = RemoteSpannerHelper.create();\r\nfinal Database db = remoteSpannerHelper.createTestDatabase(DDL);\r\nfinal DatabaseClient dbClient = remoteSpannerHelper.getDatabaseClient(db);\r\n\r\nwhile (true) {\r\n  dbClient.readWriteTransaction().run(tx -\u003e {\r\n    // this sometimes throws AbortedException\r\n    tx.executeUpdate(Statement.of(\"DELETE FROM Table WHERE true\"));\r\n  });\r\n}\r\n```\r\n\r\n#### Stack trace\r\n```\r\ncom.google.cloud.spanner.AbortedException: ABORTED: com.google.api.gax.rpc.AbortedException: io.grpc.StatusRuntimeException: ABORTED: Transaction aborted. Database schema probably changed during transaction, retry may succeed.\r\nretry_delay {\r\n  nanos: 10997310\r\n}\r\n\r\n\tat com.google.cloud.spanner.SpannerExceptionFactory.newSpannerExceptionPreformatted(SpannerExceptionFactory.java:117)\r\n\tat com.google.cloud.spanner.SpannerExceptionFactory.newSpannerException(SpannerExceptionFactory.java:43)\r\n\tat com.google.cloud.spanner.SpannerExceptionFactory.newSpannerException(SpannerExceptionFactory.java:80)\r\n\tat com.google.cloud.spanner.spi.v1.GapicSpannerRpc.get(GapicSpannerRpc.java:526)\r\n\tat com.google.cloud.spanner.spi.v1.GapicSpannerRpc.executeQuery(GapicSpannerRpc.java:456)\r\n\tat com.google.cloud.spanner.SpannerImpl$TransactionContextImpl$2.call(SpannerImpl.java:1643)\r\n\tat com.google.cloud.spanner.SpannerImpl$TransactionContextImpl$2.call(SpannerImpl.java:1640)\r\n\tat com.google.cloud.spanner.SpannerImpl.runWithRetries(SpannerImpl.java:246)\r\n\tat com.google.cloud.spanner.SpannerImpl$TransactionContextImpl.executeUpdate(SpannerImpl.java:1639)\r\n\t(one line from our closure, that calls executeUpdate)\r\n\tat com.google.cloud.spanner.SpannerImpl$TransactionRunnerImpl.runInternal(SpannerImpl.java:1312)\r\n\tat com.google.cloud.spanner.SpannerImpl$TransactionRunnerImpl.run(SpannerImpl.java:1280)\r\n\tat com.google.cloud.spanner.SessionPool$PooledSession$1.run(SessionPool.java:410)\r\n```","author":{"url":"https://github.com/fyhuang-rideos","@type":"Person","name":"fyhuang-rideos"},"datePublished":"2019-04-11T18:53:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/4939/google-cloud-java/issues/4939"}