Title: Don't bundle tests in jars · Issue #3728 · googleapis/google-cloud-java · GitHub
Open Graph Title: Don't bundle tests in jars · Issue #3728 · googleapis/google-cloud-java
X Title: Don't bundle tests in jars · Issue #3728 · googleapis/google-cloud-java
Description: I downloaded and unzipped google-cloud-dns-0.63.0-alpha-tests.jar. Here's what I found inside it. We're definitely bundling the actual tests into these jars. We either shouldn't do this (just include mocks and the like) or otherwise not ...
Open Graph Description: I downloaded and unzipped google-cloud-dns-0.63.0-alpha-tests.jar. Here's what I found inside it. We're definitely bundling the actual tests into these jars. We either shouldn't do this (just inclu...
X Description: I downloaded and unzipped google-cloud-dns-0.63.0-alpha-tests.jar. Here's what I found inside it. We're definitely bundling the actual tests into these jars. We either shouldn't do this...
Opengraph URL: https://github.com/googleapis/google-cloud-java/issues/3728
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Don't bundle tests in jars","articleBody":"I downloaded and unzipped google-cloud-dns-0.63.0-alpha-tests.jar. Here's what I found inside it. We're definitely bundling the actual tests into these jars. We either shouldn't do this (just include mocks and the like) or otherwise not put these in the BOM.\r\n\r\n```\r\n$ jar tvf google-cloud-dns-0.63.0-alpha-tests.jar\r\n 0 Thu Sep 20 16:47:10 EDT 2018 META-INF/\r\n 617 Thu Sep 20 16:47:10 EDT 2018 META-INF/MANIFEST.MF\r\n 0 Thu Sep 20 16:47:10 EDT 2018 com/\r\n 0 Thu Sep 20 16:47:10 EDT 2018 com/google/\r\n 0 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/\r\n 0 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/\r\n 0 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/it/\r\n 19805 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsImplTest.class\r\n 4099 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ProjectInfoTest.class\r\n 46519 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/it/ITDnsTest.class\r\n 8991 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/SerializationTest.class\r\n 4908 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/RecordSetTest.class\r\n 3820 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsExceptionTest.class\r\n 7528 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ChangeRequestInfoTest.class\r\n 2639 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest.class\r\n 879 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$5.class\r\n 3088 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsBatchResultTest.class\r\n 5755 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ZoneInfoTest.class\r\n 28870 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsBatchTest.class\r\n 672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$3.class\r\n 605 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsImplTest$1.class\r\n 672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$1.class\r\n 879 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$6.class\r\n 672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$4.class\r\n 15648 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ZoneTest.class\r\n 8405 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ChangeRequestTest.class\r\n 1207 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsOptionsTest.class\r\n 6212 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsTest.class\r\n 672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$2.class\r\n 0 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/\r\n 0 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/com.google.cloud/\r\n 0 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/com.google.cloud/google-cloud-dns/\r\n 2486 Thu Sep 20 13:30:42 EDT 2018 META-INF/maven/com.google.cloud/google-cloud-dns/pom.xml\r\n 131 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/com.google.cloud/google-cloud-dns/pom.properties\r\n 246 Thu Sep 20 16:47:10 EDT 2018 META-INF/INDEX.LIST\r\n```","author":{"url":"https://github.com/elharo","@type":"Person","name":"elharo"},"datePublished":"2018-09-25T20:31:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/3728/google-cloud-java/issues/3728"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:53690ca6-4de5-48f8-5c34-084ac6ededee |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C682:1F00:21689B:33AEF5:6A4CFD0A |
| html-safe-nonce | a4330c04d90cf6772094b84014d9e7812453908c34ccf552831570ea3ca97664 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjgyOjFGMDA6MjE2ODlCOjMzQUVGNTo2QTRDRkQwQSIsInZpc2l0b3JfaWQiOiI0MTUzNzE1MzkyNjA1MTI1ODk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 232799173d0162f168b54151aa9d1b374cea710cbd85e59744ff1ce15ab7084e |
| hovercard-subject-tag | issue:363754036 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/google-cloud-java/3728/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c7a3d9a32aa835c19251902aa2cc27277e7fcd29409f7748f153936a9fd9a628/googleapis/google-cloud-java/issues/3728 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c7a3d9a32aa835c19251902aa2cc27277e7fcd29409f7748f153936a9fd9a628/googleapis/google-cloud-java/issues/3728 |
| og:image:alt | I downloaded and unzipped google-cloud-dns-0.63.0-alpha-tests.jar. Here's what I found inside it. We're definitely bundling the actual tests into these jars. We either shouldn't do this (just inclu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | elharo |
| hostname | github.com |
| expected-hostname | github.com |
| None | 31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/google-cloud-java git https://github.com/googleapis/google-cloud-java.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 26181278 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 26181278 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fb70bd3c4b2bec429781b65419e912c66e2d5581 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width