René's URL Explorer Experiment


Title: fix(pubsub/v2): avoid Receive hang on context cancellation by landcelita · Pull Request #13114 · googleapis/google-cloud-go · GitHub

Open Graph Title: fix(pubsub/v2): avoid Receive hang on context cancellation by landcelita · Pull Request #13114 · googleapis/google-cloud-go

X Title: fix(pubsub/v2): avoid Receive hang on context cancellation by landcelita · Pull Request #13114 · googleapis/google-cloud-go

Description: Google Cloud Client Libraries for Go. Contribute to googleapis/google-cloud-go development by creating an account on GitHub.

Open Graph Description: Related to #13113 Cause of the Issue In v2.0, when the context was canceled, all messages were Nacked. However, starting from v2.1, when the context is canceled, even if a message has already been ...

X Description: Related to #13113 Cause of the Issue In v2.0, when the context was canceled, all messages were Nacked. However, starting from v2.1, when the context is canceled, even if a message has already been ...

Opengraph URL: https://github.com/googleapis/google-cloud-go/pull/13114

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d0af8c21-17fa-4b73-79d5-93624f5e4b68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E18:C9A7:9AD96:C9C7E:6AEBDF15
html-safe-nonced2be9fb2cc22e3aec5a2af3f3a454eae4fdf7bf5dce6efacb225c49a4920d347
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTE4OkM5QTc6OUFEOTY6QzlDN0U6NkFFQkRGMTUiLCJ2aXNpdG9yX2lkIjoiMTM0MzcwMzkxOTMyOTI3MTU3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8782619b3b3c71c0c54b538c360ac87afe608fa47368be61e50223021e6810df
hovercard-subject-tagpull_request:2910830630
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-go/13114/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/96d7d97a7431d0f22e6093d6e9cafc361af7c79274750715df608839dcace44a/googleapis/google-cloud-go/pull/13114
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/96d7d97a7431d0f22e6093d6e9cafc361af7c79274750715df608839dcace44a/googleapis/google-cloud-go/pull/13114
og:image:altRelated to #13113 Cause of the Issue In v2.0, when the context was canceled, all messages were Nacked. However, starting from v2.1, when the context is canceled, even if a message has already been ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelandcelita
hostnamegithub.com
expected-hostnamegithub.com
None701f7e3aecc56e7594e73fa7b7e1483af74322a67f7038be453d0feb05e86e77
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-go git https://github.com/googleapis/google-cloud-go.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id19608522
octolytics-dimension-repository_nwogoogleapis/google-cloud-go
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id19608522
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-go
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release12d1048a3491dd63e4193b2937cf72f1c24a2a52
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-go/issues/13114#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-go%2Fpull%2F13114
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-go%2Fpull%2F13114
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-go
Reloadhttps://github.com/googleapis/google-cloud-go/issues/13114
Reloadhttps://github.com/googleapis/google-cloud-go/issues/13114
Reloadhttps://github.com/googleapis/google-cloud-go/issues/13114
googleapishttps://github.com/googleapis
google-cloud-gohttps://github.com/googleapis/google-cloud-go
Codehttps://github.com/googleapis/google-cloud-go
Issues221 (221)https://github.com/googleapis/google-cloud-go/issues
Pull requests198 (198)https://github.com/googleapis/google-cloud-go/pulls
Actionshttps://github.com/googleapis/google-cloud-go/actions
Wikihttps://github.com/googleapis/google-cloud-go/wiki
Security and qualityhttps://github.com/googleapis/google-cloud-go/security
Insightshttps://github.com/googleapis/google-cloud-go/pulse
https://github.com/googleapis/google-cloud-go
hongalexhttps://github.com/hongalex
googleapis:mainhttps://github.com/googleapis/google-cloud-go/tree/main
landcelita:fix-pubsub-hang-on-context-cancelhttps://github.com/landcelita/google-cloud-go/tree/fix-pubsub-hang-on-context-cancel
Conversationhttps://github.com/googleapis/google-cloud-go/pull/13114
Commits2 (2)https://github.com/googleapis/google-cloud-go/pull/13114/commits
Checkshttps://github.com/googleapis/google-cloud-go/pull/13114/checks
Files changedhttps://github.com/googleapis/google-cloud-go/pull/13114/files
fix(pubsub/v2): avoid Receive hang on context cancellationhttps://github.com/googleapis/google-cloud-go/issues/13114#top
hongalexhttps://github.com/hongalex
googleapis:mainhttps://github.com/googleapis/google-cloud-go/tree/main
landcelita:fix-pubsub-hang-on-context-cancelhttps://github.com/landcelita/google-cloud-go/tree/fix-pubsub-hang-on-context-cancel
https://github.com/landcelita
landcelitahttps://github.com/landcelita
Oct 13, 2025https://github.com/googleapis/google-cloud-go/issues/13114#issue-3510722515
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13114
#13113https://github.com/googleapis/google-cloud-go/issues/13113
all messages were Nackedhttps://github.com/googleapis/google-cloud-go/blob/494c545e468b5e1b2aa371811c07b4208ab4a87f/pubsub/v2/subscriber.go#L305-L312
iter.receive()https://github.com/landcelita/google-cloud-go/blob/0135d9305581444e1ddcdd8f4fe63e4c588b575f/pubsub/v2/subscriber.go#L323
returns without calling Nack()https://github.com/landcelita/google-cloud-go/blob/0135d9305581444e1ddcdd8f4fe63e4c588b575f/pubsub/v2/subscriber.go#L340
iterator.done()https://github.com/landcelita/google-cloud-go/blob/14c3887819c7bfdf3de661ec807fa82b6bb3183e/pubsub/v2/iterator.go#L219
len(it.keepAliveDeadlines) == 0https://github.com/landcelita/google-cloud-go/blob/14c3887819c7bfdf3de661ec807fa82b6bb3183e/pubsub/v2/iterator.go#L201
it.wg.Wait()https://github.com/landcelita/google-cloud-go/blob/14c3887819c7bfdf3de661ec807fa82b6bb3183e/pubsub/v2/iterator.go#L183
Receive’s group.Wait()https://github.com/landcelita/google-cloud-go/blob/76ddb3498f2c986b156abaeaf7efeab1c9490725/pubsub/subscription.go#L1533
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13114
https://github.com/landcelita
fix(pubsub): avoid Receive hang on context cancellationhttps://github.com/googleapis/google-cloud-go/pull/13114/commits/b6b494c88c4507e9be43230913fc1f829831ed84
b6b494chttps://github.com/googleapis/google-cloud-go/pull/13114/commits/b6b494c88c4507e9be43230913fc1f829831ed84
https://github.com/landcelita
landcelitahttps://github.com/landcelita
October 13, 2025 16:41https://github.com/googleapis/google-cloud-go/issues/13114#event-20251499547
https://github.com/apps/product-auto-label
product-auto-labelhttps://github.com/apps/product-auto-label
api: pubsub https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
Oct 13, 2025https://github.com/googleapis/google-cloud-go/issues/13114#event-20251500828
https://github.com/hongalex
hongalexhttps://github.com/hongalex
kokoro:run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Arun
Oct 13, 2025https://github.com/googleapis/google-cloud-go/issues/13114#event-20253509205
https://github.com/kokoro-team
kokoro-teamhttps://github.com/kokoro-team
kokoro:run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Arun
Oct 13, 2025https://github.com/googleapis/google-cloud-go/issues/13114#event-20253513533
https://github.com/hongalex
hongalexhttps://github.com/hongalex
Oct 13, 2025 https://github.com/googleapis/google-cloud-go/issues/13114#pullrequestreview-3333035037
View reviewed changes https://github.com/googleapis/google-cloud-go/pull/13114/files/b6b494c88c4507e9be43230913fc1f829831ed84
hongalexhttps://github.com/hongalex
https://github.com/googleapis/google-cloud-go/issues/13114#pullrequestreview-3333035037
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13114
https://github.com/hongalex
hongalexhttps://github.com/hongalex
Oct 13, 2025https://github.com/googleapis/google-cloud-go/issues/13114#event-20256808812
https://github.com/hongalex
hongalexhttps://github.com/hongalex
October 13, 2025 22:55https://github.com/googleapis/google-cloud-go/issues/13114#event-20256810996
https://github.com/hongalex
hongalexhttps://github.com/hongalex
Oct 13, 2025 https://github.com/googleapis/google-cloud-go/issues/13114#pullrequestreview-3333359774
View reviewed changes https://github.com/googleapis/google-cloud-go/pull/13114/files/b6b494c88c4507e9be43230913fc1f829831ed84
pubsub/v2/subscriber.gohttps://github.com/googleapis/google-cloud-go/pull/13114/files/b6b494c88c4507e9be43230913fc1f829831ed84#diff-1e9b3986c37445321241408810f4541ee3c50494ed55258eb24c902c4fedf320
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13114
https://github.com/landcelita
https://github.com/hongalex
Update pubsub/v2/subscriber.gohttps://github.com/googleapis/google-cloud-go/pull/13114/commits/899f1d6316f57228b14a40c89fae5d88b0982c2e
899f1d6https://github.com/googleapis/google-cloud-go/pull/13114/commits/899f1d6316f57228b14a40c89fae5d88b0982c2e
https://github.com/landcelita
landcelitahttps://github.com/landcelita
hongalexhttps://github.com/hongalex
stale reviewhttps://github.com/googleapis/google-cloud-go/issues/13114#pullrequestreview-3333035037
899f1d6https://github.com/googleapis/google-cloud-go/commit/899f1d6316f57228b14a40c89fae5d88b0982c2e
October 13, 2025 23:37https://github.com/googleapis/google-cloud-go/issues/13114#event-20257191355
https://github.com/hongalex
hongalexhttps://github.com/hongalex
Oct 14, 2025 https://github.com/googleapis/google-cloud-go/issues/13114#pullrequestreview-3336614375
View reviewed changes https://github.com/googleapis/google-cloud-go/pull/13114/files/899f1d6316f57228b14a40c89fae5d88b0982c2e
https://github.com/bhshkh
bhshkhhttps://github.com/bhshkh
Oct 14, 2025 https://github.com/googleapis/google-cloud-go/issues/13114#pullrequestreview-3336988294
View reviewed changes https://github.com/googleapis/google-cloud-go/pull/13114/files/899f1d6316f57228b14a40c89fae5d88b0982c2e
https://github.com/hongalex
hongalexhttps://github.com/hongalex
kokoro:force-run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Oct 14, 2025https://github.com/googleapis/google-cloud-go/issues/13114#event-20277073635
https://github.com/kokoro-team
kokoro-teamhttps://github.com/kokoro-team
kokoro:force-run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Oct 14, 2025https://github.com/googleapis/google-cloud-go/issues/13114#event-20277084775
https://github.com/hongalex
hongalexhttps://github.com/hongalex
kokoro:run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Arun
Oct 14, 2025https://github.com/googleapis/google-cloud-go/issues/13114#event-20280163334
https://github.com/hongalex
hongalexhttps://github.com/hongalex
e7e169dhttps://github.com/googleapis/google-cloud-go/commit/e7e169d1c1e48ad0fb78bcfe23d73f2de76d1f01
Oct 14, 2025https://github.com/googleapis/google-cloud-go/pull/13114#event-20280164699
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13114
https://github.com/apps/release-please
release-pleasehttps://github.com/apps/release-please
Oct 14, 2025 https://github.com/googleapis/google-cloud-go/issues/13114#ref-pullrequest-3511372333
chore(main): release pubsub/v2 2.2.1 #13119 https://github.com/googleapis/google-cloud-go/pull/13119
hongalexhttps://github.com/hongalex
Oct 14, 2025 https://github.com/googleapis/google-cloud-go/issues/13114#ref-commit-100c0ff
https://github.com/apps/release-please
chore(main): release pubsub/v2 2.2.1 (https://github.com/googleapis/google-cloud-go/commit/100c0ffe4588b2045be8bf359bb648c7df888698
#13119https://github.com/googleapis/google-cloud-go/pull/13119
)https://github.com/googleapis/google-cloud-go/commit/100c0ffe4588b2045be8bf359bb648c7df888698
100c0ffhttps://github.com/googleapis/google-cloud-go/commit/100c0ffe4588b2045be8bf359bb648c7df888698
pubsub/v2/v2.2.0...pubsub/v2/v2.2.1https://github.com/googleapis/google-cloud-go/compare/pubsub/v2/v2.2.0...pubsub/v2/v2.2.1
#13114https://github.com/googleapis/google-cloud-go/pull/13114
#13114https://github.com/googleapis/google-cloud-go/pull/13114
e7e169dhttps://github.com/googleapis/google-cloud-go/commit/e7e169d1c1e48ad0fb78bcfe23d73f2de76d1f01
e7e169dhttps://github.com/googleapis/google-cloud-go/commit/e7e169d1c1e48ad0fb78bcfe23d73f2de76d1f01
8fffca2https://github.com/googleapis/google-cloud-go/commit/8fffca2819fa3dc858c213aa0c503e0df331b084
8fffca2https://github.com/googleapis/google-cloud-go/commit/8fffca2819fa3dc858c213aa0c503e0df331b084
https://github.com/googleapis/release-pleasehttps://github.com/googleapis/release-please
https://github.com/googleapis/release-please#release-pleasehttps://github.com/googleapis/release-please#release-please
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-go/issues/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-go%2Fpull%2F13114
https://github.com/hongalex
hongalex https://github.com/hongalex
https://github.com/googleapis/google-cloud-go/pull/13114/files/899f1d6316f57228b14a40c89fae5d88b0982c2e
https://github.com/bhshkh
bhshkh https://github.com/bhshkh
https://github.com/googleapis/google-cloud-go/pull/13114/files/899f1d6316f57228b14a40c89fae5d88b0982c2e
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13114
api: pubsub https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
kokoro:run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Arun
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13114
https://github.com/landcelita
https://github.com/hongalex
https://github.com/bhshkh
https://github.com/kokoro-team
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.