René's URL Explorer Experiment


Title: fix(pubsub/v2): respect ShutdownBehavior when handling timeout by kurochan · Pull Request #13021 · googleapis/google-cloud-go · GitHub

Open Graph Title: fix(pubsub/v2): respect ShutdownBehavior when handling timeout by kurochan · Pull Request #13021 · googleapis/google-cloud-go

X Title: fix(pubsub/v2): respect ShutdownBehavior when handling timeout by kurochan · Pull Request #13021 · googleapis/google-cloud-go

Description: Google Cloud Client Libraries for Go. Contribute to googleapis/google-cloud-go development by creating an account on GitHub.

Open Graph Description: Previously, ShutdownOptions.Behavior was never respected — when a positive Timeout was set, messages were always nacked. This PR fixes the shutdown logic so that messages are only nacked if Behavio...

X Description: Previously, ShutdownOptions.Behavior was never respected — when a positive Timeout was set, messages were always nacked. This PR fixes the shutdown logic so that messages are only nacked if Behavio...

Opengraph URL: https://github.com/googleapis/google-cloud-go/pull/13021

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d6da5843-e74a-ddd8-856b-8448c00d189d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id843C:2813B3:B66CD:EEA04:6AEBDF66
html-safe-nonce194ff5a1027468e804f04433c5e50f40618fa58571e077a6b8282e67fe031a73
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDNDOjI4MTNCMzpCNjZDRDpFRUEwNDo2QUVCREY2NiIsInZpc2l0b3JfaWQiOiIzOTQwMjE0MDY3Mjc0OTY0ODM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdfd1240efae2664a9b5019647441ed5cc1911318b2db250f6b9b3c28fb4a7732
hovercard-subject-tagpull_request:2880457996
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-cloud-go/13021/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2d6d29cb99db41570012bf42d1e098346cd011c65cdb40ac00aa56fff1cee4b9/googleapis/google-cloud-go/pull/13021
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d6d29cb99db41570012bf42d1e098346cd011c65cdb40ac00aa56fff1cee4b9/googleapis/google-cloud-go/pull/13021
og:image:altPreviously, ShutdownOptions.Behavior was never respected — when a positive Timeout was set, messages were always nacked. This PR fixes the shutdown logic so that messages are only nacked if Behavio...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekurochan
hostnamegithub.com
expected-hostnamegithub.com
None701f7e3aecc56e7594e73fa7b7e1483af74322a67f7038be453d0feb05e86e77
turbo-cache-controlno-cache
go-importgithub.com/googleapis/google-cloud-go git https://github.com/googleapis/google-cloud-go.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id19608522
octolytics-dimension-repository_nwogoogleapis/google-cloud-go
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id19608522
octolytics-dimension-repository_network_root_nwogoogleapis/google-cloud-go
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release12d1048a3491dd63e4193b2937cf72f1c24a2a52
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/googleapis/google-cloud-go/issues/13021#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-go%2Fpull%2F13021
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-go%2Fpull%2F13021
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-cloud-go
Reloadhttps://github.com/googleapis/google-cloud-go/issues/13021
Reloadhttps://github.com/googleapis/google-cloud-go/issues/13021
Reloadhttps://github.com/googleapis/google-cloud-go/issues/13021
googleapishttps://github.com/googleapis
google-cloud-gohttps://github.com/googleapis/google-cloud-go
Codehttps://github.com/googleapis/google-cloud-go
Issues221 (221)https://github.com/googleapis/google-cloud-go/issues
Pull requests198 (198)https://github.com/googleapis/google-cloud-go/pulls
Actionshttps://github.com/googleapis/google-cloud-go/actions
Wikihttps://github.com/googleapis/google-cloud-go/wiki
Security and qualityhttps://github.com/googleapis/google-cloud-go/security
Insightshttps://github.com/googleapis/google-cloud-go/pulse
https://github.com/googleapis/google-cloud-go
hongalexhttps://github.com/hongalex
googleapis:mainhttps://github.com/googleapis/google-cloud-go/tree/main
kurochan:pubsubv2-shutdown-behaviorhttps://github.com/kurochan/google-cloud-go/tree/pubsubv2-shutdown-behavior
Conversationhttps://github.com/googleapis/google-cloud-go/pull/13021
Commits1 (1)https://github.com/googleapis/google-cloud-go/pull/13021/commits
Checkshttps://github.com/googleapis/google-cloud-go/pull/13021/checks
Files changedhttps://github.com/googleapis/google-cloud-go/pull/13021/files
fix(pubsub/v2): respect ShutdownBehavior when handling timeouthttps://github.com/googleapis/google-cloud-go/issues/13021#top
hongalexhttps://github.com/hongalex
googleapis:mainhttps://github.com/googleapis/google-cloud-go/tree/main
kurochan:pubsubv2-shutdown-behaviorhttps://github.com/kurochan/google-cloud-go/tree/pubsubv2-shutdown-behavior
https://github.com/kurochan
kurochanhttps://github.com/kurochan
Oct 2, 2025https://github.com/googleapis/google-cloud-go/issues/13021#issue-3476043980
#12829https://github.com/googleapis/google-cloud-go/pull/12829
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13021
https://github.com/kurochan
kurochanhttps://github.com/kurochan
shollymanhttps://github.com/shollyman
code ownerhttps://github.com/googleapis/google-cloud-go/blob/e47c260de57e8c97cc688693f0600caaa96195e4/.github/CODEOWNERS#L13
October 2, 2025 05:08https://github.com/googleapis/google-cloud-go/issues/13021#event-20050156841
https://github.com/kurochan
kurochanhttps://github.com/kurochan
October 2, 2025 05:08https://github.com/googleapis/google-cloud-go/issues/13021#event-20050156865
https://github.com/apps/product-auto-label
product-auto-labelhttps://github.com/apps/product-auto-label
api: pubsub https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
Oct 2, 2025https://github.com/googleapis/google-cloud-go/issues/13021#event-20050159336
https://github.com/hongalex
hongalexhttps://github.com/hongalex
Oct 2, 2025https://github.com/googleapis/google-cloud-go/issues/13021#issuecomment-3362378266
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13021
https://github.com/hongalex
hongalexhttps://github.com/hongalex
Oct 2, 2025 https://github.com/googleapis/google-cloud-go/issues/13021#pullrequestreview-3295781607
View reviewed changes https://github.com/googleapis/google-cloud-go/pull/13021/files/741bdf580f9bafc54a6340855fc1189085c8fbad
https://github.com/feywind
feywindhttps://github.com/feywind
Oct 2, 2025 https://github.com/googleapis/google-cloud-go/issues/13021#pullrequestreview-3295791640
View reviewed changes https://github.com/googleapis/google-cloud-go/pull/13021/files/741bdf580f9bafc54a6340855fc1189085c8fbad
https://github.com/hongalex
hongalexhttps://github.com/hongalex
kokoro:run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Arun
Oct 2, 2025https://github.com/googleapis/google-cloud-go/issues/13021#event-20065681527
https://github.com/kokoro-team
kokoro-teamhttps://github.com/kokoro-team
kokoro:run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Arun
Oct 2, 2025https://github.com/googleapis/google-cloud-go/issues/13021#event-20065684863
https://github.com/kurochan
fix(pubsub/v2): respect ShutdownBehavior when handling timeouthttps://github.com/googleapis/google-cloud-go/pull/13021/commits/741bdf580f9bafc54a6340855fc1189085c8fbad
741bdf5https://github.com/googleapis/google-cloud-go/pull/13021/commits/741bdf580f9bafc54a6340855fc1189085c8fbad
https://github.com/kurochan
kurochanhttps://github.com/kurochan
force-pushedhttps://github.com/googleapis/google-cloud-go/compare/3f8ebbde411c36ae21c6b383164376740040a3db..741bdf580f9bafc54a6340855fc1189085c8fbad
3f8ebbdhttps://github.com/googleapis/google-cloud-go/commit/3f8ebbde411c36ae21c6b383164376740040a3db
741bdf5https://github.com/googleapis/google-cloud-go/commit/741bdf580f9bafc54a6340855fc1189085c8fbad
Compare https://github.com/googleapis/google-cloud-go/compare/3f8ebbde411c36ae21c6b383164376740040a3db..741bdf580f9bafc54a6340855fc1189085c8fbad
October 3, 2025 01:44https://github.com/googleapis/google-cloud-go/issues/13021#event-20071935055
https://github.com/kurochan
kurochanhttps://github.com/kurochan
October 3, 2025 01:44https://github.com/googleapis/google-cloud-go/issues/13021#event-20071935065
https://github.com/hongalex
hongalexhttps://github.com/hongalex
kokoro:force-run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Oct 3, 2025https://github.com/googleapis/google-cloud-go/issues/13021#event-20086671911
https://github.com/hongalex
hongalexhttps://github.com/hongalex
October 3, 2025 17:30https://github.com/googleapis/google-cloud-go/issues/13021#event-20086676916
https://github.com/kokoro-team
kokoro-teamhttps://github.com/kokoro-team
kokoro:force-run https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Oct 3, 2025https://github.com/googleapis/google-cloud-go/issues/13021#event-20086677105
https://github.com/hongalex
hongalexhttps://github.com/hongalex
0135d93https://github.com/googleapis/google-cloud-go/commit/0135d9305581444e1ddcdd8f4fe63e4c588b575f
Oct 3, 2025https://github.com/googleapis/google-cloud-go/pull/13021#event-20086885034
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13021
https://github.com/apps/release-please
release-pleasehttps://github.com/apps/release-please
Oct 3, 2025 https://github.com/googleapis/google-cloud-go/issues/13021#ref-pullrequest-3466895691
chore(main): release pubsub/v2 2.2.0 #12988 https://github.com/googleapis/google-cloud-go/pull/12988
hongalexhttps://github.com/hongalex
Oct 3, 2025 https://github.com/googleapis/google-cloud-go/issues/13021#ref-commit-4750d78
https://github.com/apps/release-please
chore(main): release pubsub/v2 2.2.0 (https://github.com/googleapis/google-cloud-go/commit/4750d78c8df993aff090e4aeb6c1e40452880d90
#12988https://github.com/googleapis/google-cloud-go/pull/12988
)https://github.com/googleapis/google-cloud-go/commit/4750d78c8df993aff090e4aeb6c1e40452880d90
4750d78https://github.com/googleapis/google-cloud-go/commit/4750d78c8df993aff090e4aeb6c1e40452880d90
pubsub/v2/v2.1.0...pubsub/v2/v2.2.0https://github.com/googleapis/google-cloud-go/compare/pubsub/v2/v2.1.0...pubsub/v2/v2.2.0
#12985https://github.com/googleapis/google-cloud-go/pull/12985
#12985https://github.com/googleapis/google-cloud-go/pull/12985
4e8c9d5https://github.com/googleapis/google-cloud-go/commit/4e8c9d50a07d209417d4a5807ab1990160a4fd0b
4e8c9d5https://github.com/googleapis/google-cloud-go/commit/4e8c9d50a07d209417d4a5807ab1990160a4fd0b
#13021https://github.com/googleapis/google-cloud-go/pull/13021
#13021https://github.com/googleapis/google-cloud-go/pull/13021
0135d93https://github.com/googleapis/google-cloud-go/commit/0135d9305581444e1ddcdd8f4fe63e4c588b575f
0135d93https://github.com/googleapis/google-cloud-go/commit/0135d9305581444e1ddcdd8f4fe63e4c588b575f
https://github.com/googleapis/release-pleasehttps://github.com/googleapis/release-please
https://github.com/googleapis/release-please#release-pleasehttps://github.com/googleapis/release-please#release-please
https://github.co/hiddenchars
https://github.com/googleapis/google-cloud-go/issues/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-cloud-go%2Fpull%2F13021
https://github.com/hongalex
hongalex https://github.com/hongalex
https://github.com/googleapis/google-cloud-go/pull/13021/files/741bdf580f9bafc54a6340855fc1189085c8fbad
https://github.com/feywind
feywind https://github.com/feywind
https://github.com/googleapis/google-cloud-go/pull/13021/files/741bdf580f9bafc54a6340855fc1189085c8fbad
https://github.com/shollyman
shollyman https://github.com/shollyman
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13021
api: pubsub https://github.com/googleapis/google-cloud-go/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
Please reload this pagehttps://github.com/googleapis/google-cloud-go/issues/13021
https://github.com/kurochan
https://github.com/hongalex
https://github.com/feywind
https://github.com/kokoro-team
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.