| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7ea258b7-f884-4c24-38e9-1f9b7c481331 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B916:200C95:1FF175:2AC267:6B0084AA |
| html-safe-nonce | 7ebb68190e13637ae68a1515cc9824d95b28f605859acab7a617669e2cd8db4c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTE2OjIwMEM5NToxRkYxNzU6MkFDMjY3OjZCMDA4NEFBIiwidmlzaXRvcl9pZCI6Ijc5MTI0MzIyNDA0NzczNzM2MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3b49449ca744e682dd7a0e7b6d6f65996fadc4e5ea5121e5ed007f43e31bde56 |
| hovercard-subject-tag | pull_request:5060507371 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/google-api-python-client/2848/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2a12ac3f8a3a499699280aeacf73a9c76de3378c2d427bc7ab22d5ac3dc7412a/googleapis/google-api-python-client/pull/2848 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2a12ac3f8a3a499699280aeacf73a9c76de3378c2d427bc7ab22d5ac3dc7412a/googleapis/google-api-python-client/pull/2848 |
| og:image:alt | Fixes #2757
Description
In \ ests/test_discovery.py, \class Discovery(unittest.TestCase)\ was defined twice:
Line 498: containing an incomplete/shadowed test \ est_discovery_http_is_closed\
Line 1... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | reginaldalfret |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61 |
| turbo-cache-control | no-cache |
| go-import | github.com/googleapis/google-api-python-client git https://github.com/googleapis/google-api-python-client.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 15749269 |
| octolytics-dimension-repository_nwo | googleapis/google-api-python-client |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 15749269 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-api-python-client |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | db758f8e02b8257935fb03edf81a3e76eb3abd11 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/googleapis/google-api-python-client/pull/2848#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-api-python-client%2Fpull%2F2848 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-api-python-client%2Fpull%2F2848 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fgoogle-api-python-client |
| Reload | https://github.com/googleapis/google-api-python-client/pull/2848 |
| Reload | https://github.com/googleapis/google-api-python-client/pull/2848 |
| Reload | https://github.com/googleapis/google-api-python-client/pull/2848 |
| googleapis | https://github.com/googleapis |
| google-api-python-client | https://github.com/googleapis/google-api-python-client |
| Code | https://github.com/googleapis/google-api-python-client |
| Issues18 (18) | https://github.com/googleapis/google-api-python-client/issues |
| Pull requests39 (39) | https://github.com/googleapis/google-api-python-client/pulls |
| Discussions | https://github.com/googleapis/google-api-python-client/discussions |
| Actions | https://github.com/googleapis/google-api-python-client/actions |
| Projects | https://github.com/googleapis/google-api-python-client/projects |
| Security and quality | https://github.com/googleapis/google-api-python-client/security |
| Insights | https://github.com/googleapis/google-api-python-client/insights |
| https://github.com/googleapis/google-api-python-client |
| reginaldalfret | https://github.com/reginaldalfret |
| googleapis:main | https://github.com/googleapis/google-api-python-client/tree/main |
| reginaldalfret:fix/discovery-close-test | https://github.com/reginaldalfret/google-api-python-client/tree/fix/discovery-close-test |
| Conversation | https://github.com/googleapis/google-api-python-client/pull/2848 |
| Commits1 (1) | https://github.com/googleapis/google-api-python-client/pull/2848/commits |
| Checks | https://github.com/googleapis/google-api-python-client/pull/2848/checks |
| Files changed | https://github.com/googleapis/google-api-python-client/pull/2848/files |
| test: restore shadowed discovery http close test | https://github.com/googleapis/google-api-python-client/pull/2848#top |
| reginaldalfret | https://github.com/reginaldalfret |
| googleapis:main | https://github.com/googleapis/google-api-python-client/tree/main |
| reginaldalfret:fix/discovery-close-test | https://github.com/reginaldalfret/google-api-python-client/tree/fix/discovery-close-test |
|
| https://github.com/reginaldalfret |
| reginaldalfret | https://github.com/reginaldalfret |
| Oct 29, 2026 | https://github.com/googleapis/google-api-python-client/pull/2848#issue-6090818211 |
| #2757 | https://github.com/googleapis/google-api-python-client/issues/2757 |
| Please reload this page | https://github.com/googleapis/google-api-python-client/pull/2848 |
|
| https://github.com/reginaldalfret |
| test: restore shadowed discovery http close test | https://github.com/googleapis/google-api-python-client/pull/2848/commits/c8649ec7b5679282ed516ee4484c8a9b27c6a6db |
| c8649ec | https://github.com/googleapis/google-api-python-client/pull/2848/commits/c8649ec7b5679282ed516ee4484c8a9b27c6a6db |
| googleapis#2757 | https://github.com/googleapis/google-api-python-client/issues/2757 |
| https://github.com/reginaldalfret |
| reginaldalfret | https://github.com/reginaldalfret |
| code owner | https://github.com/googleapis/google-api-python-client/blob/c1bdb24533614d6fcffeb7b9a93b2fc836c4e4e0/.github/CODEOWNERS#L8 |
| October 29, 2026 01:31 | https://github.com/googleapis/google-api-python-client/pull/2848#event-34538044608 |
| https://github.com/apps/product-auto-label |
| product-auto-label | https://github.com/apps/product-auto-label |
|
size: s
| https://github.com/googleapis/google-api-python-client/issues?q=state%3Aopen%20label%3A%22size%3A%20s%22 |
| Oct 29, 2026 | https://github.com/googleapis/google-api-python-client/pull/2848#event-34538046791 |
| https://github.com/apps/gemini-code-assist |
| gemini-code-assist | https://github.com/apps/gemini-code-assist |
|
Oct 29, 2026
| https://github.com/googleapis/google-api-python-client/pull/2848#pullrequestreview-5691810272 |
|
View reviewed changes
| https://github.com/googleapis/google-api-python-client/pull/2848/files/c8649ec7b5679282ed516ee4484c8a9b27c6a6db |
| gemini-code-assist | https://github.com/apps/gemini-code-assist |
| https://github.com/googleapis/google-api-python-client/pull/2848#pullrequestreview-5691810272 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/google-api-python-client/pull/2848 |
| tests/test_discovery.py | https://github.com/googleapis/google-api-python-client/pull/2848/files/c8649ec7b5679282ed516ee4484c8a9b27c6a6db#diff-497a7484da3a04385e7414af583a0b33f9ec8dc4875df7f9cc98e37fb360dc0e |
| gemini-code-assist | https://github.com/apps/gemini-code-assist |
| Oct 29, 2026 | https://github.com/googleapis/google-api-python-client/pull/2848#discussion_r4407829984 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://camo.githubusercontent.com/508ba0af8fcc5b69c2f7fd05896fc39957428ba34e1b99c6508db43cf217da8d/68747470733a2f2f7777772e677374617469632e636f6d2f636f64657265766965776167656e742f6d656469756d2d7072696f726974792e737667 |
| Please reload this page | https://github.com/googleapis/google-api-python-client/pull/2848 |
| https://github.co/hiddenchars |
| https://github.com/googleapis/google-api-python-client/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-api-python-client%2Fpull%2F2848 |
|
| https://github.com/apps/gemini-code-assist |
|
gemini-code-assist[bot]
| https://github.com/apps/gemini-code-assist |
|
| https://github.com/googleapis/google-api-python-client/pull/2848/files/c8649ec7b5679282ed516ee4484c8a9b27c6a6db |
| Please reload this page | https://github.com/googleapis/google-api-python-client/pull/2848 |
|
size: s
| https://github.com/googleapis/google-api-python-client/issues?q=state%3Aopen%20label%3A%22size%3A%20s%22 |
|
test: connection leak test test_discovery_http_is_closed is shadowed and syntactically invalid
| https://github.com/googleapis/google-api-python-client/issues/2757 |
| Please reload this page | https://github.com/googleapis/google-api-python-client/pull/2848 |
|
| https://github.com/reginaldalfret |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |