René's URL Explorer Experiment

Title: Fix HasCustomStr to recognise custom __repr__ as a meaningful str (fixes #595) by shivamtiwari3 · Pull Request #653 · google/python-fire · GitHub

Open Graph Title: Fix HasCustomStr to recognise custom __repr__ as a meaningful str (fixes #595) by shivamtiwari3 · Pull Request #653 · google/python-fire

X Title: Fix HasCustomStr to recognise custom __repr__ as a meaningful str (fixes #595) by shivamtiwari3 · Pull Request #653 · google/python-fire

Description: Summary Fixes #595. Objects that override __repr__ but not __str__ (e.g. datasets.Dataset from HuggingFace) were shown as a help screen instead of being printed, because HasCustomStr only checked for a custom __str__. Problem Python's object.__str__ delegates to __repr__, so a class that defines a custom __repr__ already produces a meaningful custom string via str(obj) — even without defining __str__. However, HasCustomStr in value_types.py only inspected __str__: str_attr = class_attrs.get('__str__') if str_attr and str_attr.defining_class is not object: return True # __repr__-only classes fall through → False → help screen shown This caused fire.Fire(main) to show the datasets.Dataset help screen rather than the dataset's repr string. Solution After the existing __str__ check, also look for a custom __repr__ — but only on user-defined (non-stdlib) types, so that Python built-in containers (dict, list, OrderedDict, …) continue to be treated as navigable groups rather than values. The guard uses sys.stdlib_module_names (Python ≥ 3.10) and falls back to a minimal sentinel set for older interpreters: _STDLIB_MODULE_NAMES = frozenset( getattr(sys, 'stdlib_module_names', {'builtins', 'collections', 'abc'}) ) If the __repr__-defining class's top-level module is not in that set, the object is treated as a value. Testing Added to test_components.py: ClassWithCustomRepr — overrides __repr__ only ClassWithCustomStr — overrides __str__ only (existing behaviour) fn_returning_custom_repr / fn_returning_custom_str — functions returning those objects Added to core_test.py: testPrintObjectWithCustomStr — existing __str__ path still works testPrintObjectWithCustomRepr — new __repr__ path: output is ClassWithCustomRepr(), not a help screen Run command: python3 -m pytest fire/ --ignore=fire/docstrings_fuzz_test.py --ignore=fire/parser_fuzz_test.py 262 tests pass, 0 failures. Checklist Fixes the reported issue Existing behaviour unchanged (no regressions — dict/list/OrderedDict still show help screens) Tests added All 262 tests pass Code style matches project conventions

Open Graph Description: Summary Fixes #595. Objects that override __repr__ but not __str__ (e.g. datasets.Dataset from HuggingFace) were shown as a help screen instead of being printed, because HasCustomStr only checked f...

X Description: Summary Fixes #595. Objects that override __repr__ but not __str__ (e.g. datasets.Dataset from HuggingFace) were shown as a help screen instead of being printed, because HasCustomStr only checked f...

Opengraph URL: https://github.com/google/python-fire/pull/653

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width