René's URL Explorer Experiment


Title: Support 3.8 with tests fix by uburuntu · Pull Request #263 · google/python-fire · GitHub

Open Graph Title: Support 3.8 with tests fix by uburuntu · Pull Request #263 · google/python-fire

X Title: Support 3.8 with tests fix by uburuntu · Pull Request #263 · google/python-fire

Description: Hi! I want to use Fire in project with Python 3.8, so I think library should be officially supported for 3.8. I added travis run for 3.8 and one test testInitRequiresFlagSyntaxSubclassNamedTuple got failed: link. Investigation showed that now namedtuple attributes of type collections._tuplegetter since 3.8, not property: link, commit: So I added backward compatibility check in MemberVisible function. One not solved trouble: pytype does not support 3.8 (google/pytype#587) -- https://travis-ci.org/github/uburuntu/python-fire, but I can add check in travis.yml to skip it currently.

Open Graph Description: Hi! I want to use Fire in project with Python 3.8, so I think library should be officially supported for 3.8. I added travis run for 3.8 and one test testInitRequiresFlagSyntaxSubclassNamedTuple go...

X Description: Hi! I want to use Fire in project with Python 3.8, so I think library should be officially supported for 3.8. I added travis run for 3.8 and one test testInitRequiresFlagSyntaxSubclassNamedTuple go...

Opengraph URL: https://github.com/google/python-fire/pull/263

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0cf4001d-0c26-1ac0-3aa4-ed4834e1e236
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEA8:1FBEEF:D58737:11424B5:6AFFE7C2
html-safe-noncef12348f62dc69f3bc18dead58bc3ba32d6231d12da437cec6065f8d6b66b2a14
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUE4OjFGQkVFRjpENTg3Mzc6MTE0MjRCNTo2QUZGRTdDMiIsInZpc2l0b3JfaWQiOiI0NTc1MDA5MDEzODU0MzY1NjM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac13a1c3a385063075d7b336f727e1052988cbd81984d94654f85aaf6fa2149d50
hovercard-subject-tagpull_request:423219282
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/google/python-fire/pull/263/files
twitter:imagehttps://avatars.githubusercontent.com/u/6163085?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6163085?s=400&v=4
og:image:altHi! I want to use Fire in project with Python 3.8, so I think library should be officially supported for 3.8. I added travis run for 3.8 and one test testInitRequiresFlagSyntaxSubclassNamedTuple go...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/google/python-fire git https://github.com/google/python-fire.git
octolytics-dimension-user_id1342004
octolytics-dimension-user_logingoogle
octolytics-dimension-repository_id82729529
octolytics-dimension-repository_nwogoogle/python-fire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id82729529
octolytics-dimension-repository_network_root_nwogoogle/python-fire
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/google/python-fire/pull/263/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fpython-fire%2Fpull%2F263%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fpython-fire%2Fpull%2F263%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=google%2Fpython-fire
Reloadhttps://github.com/google/python-fire/pull/263/files
Reloadhttps://github.com/google/python-fire/pull/263/files
Reloadhttps://github.com/google/python-fire/pull/263/files
googlehttps://github.com/google
python-firehttps://github.com/google/python-fire
Codehttps://github.com/google/python-fire
Issues146 (146)https://github.com/google/python-fire/issues
Pull requests85 (85)https://github.com/google/python-fire/pulls
Actionshttps://github.com/google/python-fire/actions
Projectshttps://github.com/google/python-fire/projects
Security and qualityhttps://github.com/google/python-fire/security
Insightshttps://github.com/google/python-fire/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgoogle%2Fpython-fire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgoogle%2Fpython-fire%2Fissues%2Fnew%2Fchoose
uburuntuhttps://github.com/uburuntu
google:masterhttps://github.com/google/python-fire/tree/master
uburuntu:masterhttps://github.com/uburuntu/python-fire/tree/master
Conversation 6 https://github.com/google/python-fire/pull/263
Commits 12 https://github.com/google/python-fire/pull/263/commits
Checks 0 https://github.com/google/python-fire/pull/263/checks
Files changed https://github.com/google/python-fire/pull/263/files
Please reload this pagehttps://github.com/google/python-fire/pull/263/files
Support 3.8 with tests fix https://github.com/google/python-fire/pull/263/files#top
Show all changes 12 commits https://github.com/google/python-fire/pull/263/files
36b6d2e enh: remove outdated travis workaround for 3.7 uburuntu May 25, 2020 https://github.com/google/python-fire/pull/263/commits/36b6d2edafdc9faedb51e3c69e072cea2d26e6bb
910a92a new: add python 3.8 to travis.yml uburuntu May 25, 2020 https://github.com/google/python-fire/pull/263/commits/910a92ae1e006150f3008300e0e25dedd00ecfe8
72fdf8e new: add python 3.8 to setup.py uburuntu May 25, 2020 https://github.com/google/python-fire/pull/263/commits/72fdf8e693c7a0ee3354a615b75d9a1830737187
18856f1 new: add travis builds badge uburuntu May 26, 2020 https://github.com/google/python-fire/pull/263/commits/18856f1cde0cc7369473886739dfbfd7550f916d
6e22bf9 fix: backward compatibility for namedtuples uburuntu May 26, 2020 https://github.com/google/python-fire/pull/263/commits/6e22bf9ab00837561fd8a15225787af41e7f794b
7919d59 fix: change condition for passing pytype uburuntu May 26, 2020 https://github.com/google/python-fire/pull/263/commits/7919d592a6eabc20a7f7be3843ade9f12b1563e7
8f8b25b fix: delete wrong type() uburuntu May 26, 2020 https://github.com/google/python-fire/pull/263/commits/8f8b25bf32dd80f8964a01e6df4d2fd6c87a3006
8915c46 fix: try to bypass pylint `isinstance-second-argument-not-valid-type` uburuntu May 26, 2020 https://github.com/google/python-fire/pull/263/commits/8915c460c5953bec6dcadab99555bd5b289542de
352f558 fix: finally enhance code style uburuntu May 26, 2020 https://github.com/google/python-fire/pull/263/commits/352f55889f3da291e3be5d98fe97c72bf961208e
ef2d7a9 fix: skip pytype for 3.8 uburuntu May 26, 2020 https://github.com/google/python-fire/pull/263/commits/ef2d7a93c4d71e4f32dd8d82d580b0cc2d5f2f2a
9e93d6c new: travis with pytype on 3.8 uburuntu Jun 4, 2020 https://github.com/google/python-fire/pull/263/commits/9e93d6cc80a7e474842c8adf04f33808f373c253
efaf65f del: remove outdated comment uburuntu Jun 4, 2020 https://github.com/google/python-fire/pull/263/commits/efaf65fe5b0986121f0e1b76a949a07169dd354f
Clear filters https://github.com/google/python-fire/pull/263/files
Please reload this pagehttps://github.com/google/python-fire/pull/263/files
Please reload this pagehttps://github.com/google/python-fire/pull/263/files
.travis.yml https://github.com/google/python-fire/pull/263/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
README.md https://github.com/google/python-fire/pull/263/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
completion.py https://github.com/google/python-fire/pull/263/files#diff-8396e29f81b1db73268b7723f968e8fbef21207aa3b05626ba2d33c2f3723d54
setup.py https://github.com/google/python-fire/pull/263/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
.travis.ymlhttps://github.com/google/python-fire/pull/263/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
View file https://github.com/uburuntu/python-fire/blob/efaf65fe5b0986121f0e1b76a949a07169dd354f/.travis.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/google/python-fire/pull/263/{{ revealButtonHref }}
https://github.com/google/python-fire/pull/263/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485
README.mdhttps://github.com/google/python-fire/pull/263/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
View file https://github.com/uburuntu/python-fire/blob/efaf65fe5b0986121f0e1b76a949a07169dd354f/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/google/python-fire/pull/263/{{ revealButtonHref }}
https://github.com/google/python-fire/pull/263/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
fire/completion.pyhttps://github.com/google/python-fire/pull/263/files#diff-8396e29f81b1db73268b7723f968e8fbef21207aa3b05626ba2d33c2f3723d54
View file https://github.com/uburuntu/python-fire/blob/efaf65fe5b0986121f0e1b76a949a07169dd354f/fire/completion.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/google/python-fire/pull/263/{{ revealButtonHref }}
https://github.com/google/python-fire/pull/263/files#diff-8396e29f81b1db73268b7723f968e8fbef21207aa3b05626ba2d33c2f3723d54
https://github.com/google/python-fire/pull/263/files#diff-8396e29f81b1db73268b7723f968e8fbef21207aa3b05626ba2d33c2f3723d54
setup.pyhttps://github.com/google/python-fire/pull/263/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
View file https://github.com/uburuntu/python-fire/blob/efaf65fe5b0986121f0e1b76a949a07169dd354f/setup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/google/python-fire/pull/263/{{ revealButtonHref }}
https://github.com/google/python-fire/pull/263/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://github.com/google/python-fire/pull/263/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.