Title: Crash on annotated array type · Issue #374 · google/google-java-format · GitHub
Open Graph Title: Crash on annotated array type · Issue #374 · google/google-java-format
X Title: Crash on annotated array type · Issue #374 · google/google-java-format
Description: Here are three files, all of which compile with javac: import java.lang.annotation.ElementType; import java.lang.annotation.Target; @Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER}) @interface MyTypeAnno {} public class GjfFail...
Open Graph Description: Here are three files, all of which compile with javac: import java.lang.annotation.ElementType; import java.lang.annotation.Target; @Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER}) @inte...
X Description: Here are three files, all of which compile with javac: import java.lang.annotation.ElementType; import java.lang.annotation.Target; @Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER}) @inte...
Opengraph URL: https://github.com/google/google-java-format/issues/374
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Crash on annotated array type","articleBody":"Here are three files, all of which compile with javac:\r\n\r\n```\r\nimport java.lang.annotation.ElementType;\r\nimport java.lang.annotation.Target;\r\n\r\n@Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER})\r\n@interface MyTypeAnno {}\r\n\r\npublic class GjfFailure {\r\n void m(int a @MyTypeAnno []) {}\r\n}\r\n```\r\n\r\n```\r\nimport java.lang.annotation.ElementType;\r\nimport java.lang.annotation.Target;\r\n\r\n@Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER})\r\n@interface MyTypeAnno {}\r\n\r\npublic class GjfSuccess {\r\n void m(int @MyTypeAnno [] a) {}\r\n}\r\n```\r\n\r\n```\r\nimport java.lang.annotation.ElementType;\r\nimport java.lang.annotation.Target;\r\n\r\n@Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER})\r\n@interface MyTypeAnno {}\r\n\r\npublic class GjfSuccess2 {\r\n void m(int a[]) {}\r\n}\r\n```\r\n\r\nRunning google-java-format (version 1.7) on the first file yields this stack trace:\r\n\r\n```\r\nGjfFailure.java:8:11: error: com.google.common.base.VerifyException\r\n\tat com.google.common.base.Verify.verify(Verify.java:100)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitAnnotatedArrayType(JavaInputAstVisitor.java:580)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitAnnotatedType(JavaInputAstVisitor.java:1322)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitAnnotatedType(JavaInputAstVisitor.java:156)\r\n\tat org.openjdk.tools.javac.tree.JCTree$JCAnnotatedType.accept(JCTree.java:2637)\r\n\tat org.openjdk.source.util.TreePathScanner.scan(TreePathScanner.java:82)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.scan(JavaInputAstVisitor.java:328)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.declareOne(JavaInputAstVisitor.java:3253)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitToDeclare(JavaInputAstVisitor.java:2536)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitFormals(JavaInputAstVisitor.java:2361)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitMethod(JavaInputAstVisitor.java:1419)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitMethod(JavaInputAstVisitor.java:156)\r\n\tat org.openjdk.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:898)\r\n\tat org.openjdk.source.util.TreePathScanner.scan(TreePathScanner.java:82)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.scan(JavaInputAstVisitor.java:328)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.addBodyDeclarations(JavaInputAstVisitor.java:3464)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitClassDeclaration(JavaInputAstVisitor.java:1962)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitClass(JavaInputAstVisitor.java:400)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitClass(JavaInputAstVisitor.java:156)\r\n\tat org.openjdk.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)\r\n\tat org.openjdk.source.util.TreePathScanner.scan(TreePathScanner.java:82)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.scan(JavaInputAstVisitor.java:328)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitCompilationUnit(JavaInputAstVisitor.java:372)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitCompilationUnit(JavaInputAstVisitor.java:156)\r\n\tat org.openjdk.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:591)\r\n\tat org.openjdk.source.util.TreePathScanner.scan(TreePathScanner.java:82)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.scan(JavaInputAstVisitor.java:328)\r\n\tat com.google.googlejavaformat.java.Formatter.format(Formatter.java:155)\r\n\tat com.google.googlejavaformat.java.Formatter.getFormatReplacements(Formatter.java:258)\r\n\tat com.google.googlejavaformat.java.Formatter.formatSource(Formatter.java:234)\r\n\tat com.google.googlejavaformat.java.FormatFileCallable.call(FormatFileCallable.java:45)\r\n\tat com.google.googlejavaformat.java.FormatFileCallable.call(FormatFileCallable.java:26)\r\n\tat java.util.concurrent.FutureTask.run(FutureTask.java:266)\r\n\tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)\r\n\tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)\r\n\tat java.lang.Thread.run(Thread.java:748)\r\n```\r\n\r\nThe code is in bad style as it uses a deprecated placement of array brackets in a variable declaration. However, it's legal code and google-java-format probably shouldn't crash.","author":{"url":"https://github.com/mernst","@type":"Person","name":"mernst"},"datePublished":"2019-05-18T15:14:34Z","url":"https://github.com/google/google-java-format/issues/374"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0531e1c8-d5d5-a164-19d5-22cf4ab7a387 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C2C2:59F6:4A2B:63E1:6AFBD767 |
| html-safe-nonce | 3f8cdbf8b08d353e88904d96e4902c982e85a733e253684b55bf2a0d800f9c39 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkMyOjU5RjY6NEEyQjo2M0UxOjZBRkJENzY3IiwidmlzaXRvcl9pZCI6Ijg2NTk2ODM1MDk3NjcyMzEzMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fb4544cd5c57535e64112102a9732d68dbf472c0d290e169c4376490e9039112 |
| hovercard-subject-tag | issue:445725115 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/google/google-java-format/374/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5978c50265e9f47e8911f0bc774ca6d2a9656af96f105ac9506a4e327ebe0a0f/google/google-java-format/issues/374 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5978c50265e9f47e8911f0bc774ca6d2a9656af96f105ac9506a4e327ebe0a0f/google/google-java-format/issues/374 |
| og:image:alt | Here are three files, all of which compile with javac: import java.lang.annotation.ElementType; import java.lang.annotation.Target; @Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER}) @inte... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mernst |
| hostname | github.com |
| expected-hostname | github.com |
| None | 18742cb872ec73544356e60359266b67aafece70c4ce008042e06227924cdd07 |
| turbo-cache-control | no-preview |
| go-import | github.com/google/google-java-format git https://github.com/google/google-java-format.git |
| octolytics-dimension-user_id | 1342004 |
| octolytics-dimension-user_login | |
| octolytics-dimension-repository_id | 35448780 |
| octolytics-dimension-repository_nwo | google/google-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 35448780 |
| octolytics-dimension-repository_network_root_nwo | google/google-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 820be804f18e1ef3940bd74a00d41d73d02e2b91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width