René's URL Explorer Experiment


Title: Crash on annotated array type · Issue #374 · google/google-java-format · GitHub

Open Graph Title: Crash on annotated array type · Issue #374 · google/google-java-format

X Title: Crash on annotated array type · Issue #374 · google/google-java-format

Description: Here are three files, all of which compile with javac: import java.lang.annotation.ElementType; import java.lang.annotation.Target; @Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER}) @interface MyTypeAnno {} public class GjfFail...

Open Graph Description: Here are three files, all of which compile with javac: import java.lang.annotation.ElementType; import java.lang.annotation.Target; @Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER}) @inte...

X Description: Here are three files, all of which compile with javac: import java.lang.annotation.ElementType; import java.lang.annotation.Target; @Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER}) @inte...

Opengraph URL: https://github.com/google/google-java-format/issues/374

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Crash on annotated array type","articleBody":"Here are three files, all of which compile with javac:\r\n\r\n```\r\nimport java.lang.annotation.ElementType;\r\nimport java.lang.annotation.Target;\r\n\r\n@Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER})\r\n@interface MyTypeAnno {}\r\n\r\npublic class GjfFailure {\r\n  void m(int a @MyTypeAnno []) {}\r\n}\r\n```\r\n\r\n```\r\nimport java.lang.annotation.ElementType;\r\nimport java.lang.annotation.Target;\r\n\r\n@Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER})\r\n@interface MyTypeAnno {}\r\n\r\npublic class GjfSuccess {\r\n  void m(int @MyTypeAnno [] a) {}\r\n}\r\n```\r\n\r\n```\r\nimport java.lang.annotation.ElementType;\r\nimport java.lang.annotation.Target;\r\n\r\n@Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER})\r\n@interface MyTypeAnno {}\r\n\r\npublic class GjfSuccess2 {\r\n  void m(int a[]) {}\r\n}\r\n```\r\n\r\nRunning google-java-format (version 1.7) on the first file yields this stack trace:\r\n\r\n```\r\nGjfFailure.java:8:11: error: com.google.common.base.VerifyException\r\n\tat com.google.common.base.Verify.verify(Verify.java:100)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitAnnotatedArrayType(JavaInputAstVisitor.java:580)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitAnnotatedType(JavaInputAstVisitor.java:1322)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitAnnotatedType(JavaInputAstVisitor.java:156)\r\n\tat org.openjdk.tools.javac.tree.JCTree$JCAnnotatedType.accept(JCTree.java:2637)\r\n\tat org.openjdk.source.util.TreePathScanner.scan(TreePathScanner.java:82)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.scan(JavaInputAstVisitor.java:328)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.declareOne(JavaInputAstVisitor.java:3253)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitToDeclare(JavaInputAstVisitor.java:2536)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitFormals(JavaInputAstVisitor.java:2361)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitMethod(JavaInputAstVisitor.java:1419)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitMethod(JavaInputAstVisitor.java:156)\r\n\tat org.openjdk.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:898)\r\n\tat org.openjdk.source.util.TreePathScanner.scan(TreePathScanner.java:82)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.scan(JavaInputAstVisitor.java:328)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.addBodyDeclarations(JavaInputAstVisitor.java:3464)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitClassDeclaration(JavaInputAstVisitor.java:1962)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitClass(JavaInputAstVisitor.java:400)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitClass(JavaInputAstVisitor.java:156)\r\n\tat org.openjdk.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)\r\n\tat org.openjdk.source.util.TreePathScanner.scan(TreePathScanner.java:82)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.scan(JavaInputAstVisitor.java:328)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitCompilationUnit(JavaInputAstVisitor.java:372)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.visitCompilationUnit(JavaInputAstVisitor.java:156)\r\n\tat org.openjdk.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:591)\r\n\tat org.openjdk.source.util.TreePathScanner.scan(TreePathScanner.java:82)\r\n\tat com.google.googlejavaformat.java.JavaInputAstVisitor.scan(JavaInputAstVisitor.java:328)\r\n\tat com.google.googlejavaformat.java.Formatter.format(Formatter.java:155)\r\n\tat com.google.googlejavaformat.java.Formatter.getFormatReplacements(Formatter.java:258)\r\n\tat com.google.googlejavaformat.java.Formatter.formatSource(Formatter.java:234)\r\n\tat com.google.googlejavaformat.java.FormatFileCallable.call(FormatFileCallable.java:45)\r\n\tat com.google.googlejavaformat.java.FormatFileCallable.call(FormatFileCallable.java:26)\r\n\tat java.util.concurrent.FutureTask.run(FutureTask.java:266)\r\n\tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)\r\n\tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)\r\n\tat java.lang.Thread.run(Thread.java:748)\r\n```\r\n\r\nThe code is in bad style as it uses a deprecated placement of array brackets in a variable declaration.  However, it's legal code and google-java-format probably shouldn't crash.","author":{"url":"https://github.com/mernst","@type":"Person","name":"mernst"},"datePublished":"2019-05-18T15:14:34Z","url":"https://github.com/google/google-java-format/issues/374"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0531e1c8-d5d5-a164-19d5-22cf4ab7a387
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC2C2:59F6:4A2B:63E1:6AFBD767
html-safe-nonce3f8cdbf8b08d353e88904d96e4902c982e85a733e253684b55bf2a0d800f9c39
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkMyOjU5RjY6NEEyQjo2M0UxOjZBRkJENzY3IiwidmlzaXRvcl9pZCI6Ijg2NTk2ODM1MDk3NjcyMzEzMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfb4544cd5c57535e64112102a9732d68dbf472c0d290e169c4376490e9039112
hovercard-subject-tagissue:445725115
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/google/google-java-format/374/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5978c50265e9f47e8911f0bc774ca6d2a9656af96f105ac9506a4e327ebe0a0f/google/google-java-format/issues/374
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5978c50265e9f47e8911f0bc774ca6d2a9656af96f105ac9506a4e327ebe0a0f/google/google-java-format/issues/374
og:image:altHere are three files, all of which compile with javac: import java.lang.annotation.ElementType; import java.lang.annotation.Target; @Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER}) @inte...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemernst
hostnamegithub.com
expected-hostnamegithub.com
None18742cb872ec73544356e60359266b67aafece70c4ce008042e06227924cdd07
turbo-cache-controlno-preview
go-importgithub.com/google/google-java-format git https://github.com/google/google-java-format.git
octolytics-dimension-user_id1342004
octolytics-dimension-user_logingoogle
octolytics-dimension-repository_id35448780
octolytics-dimension-repository_nwogoogle/google-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id35448780
octolytics-dimension-repository_network_root_nwogoogle/google-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release820be804f18e1ef3940bd74a00d41d73d02e2b91
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/google/google-java-format/issues/374#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fgoogle-java-format%2Fissues%2F374
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fgoogle-java-format%2Fissues%2F374
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=google%2Fgoogle-java-format
Reloadhttps://github.com/google/google-java-format/issues/374
Reloadhttps://github.com/google/google-java-format/issues/374
Reloadhttps://github.com/google/google-java-format/issues/374
googlehttps://github.com/google
google-java-formathttps://github.com/google/google-java-format
Codehttps://github.com/google/google-java-format
Issues84 (84)https://github.com/google/google-java-format/issues
Pull requests35 (35)https://github.com/google/google-java-format/pulls
Actionshttps://github.com/google/google-java-format/actions
Projectshttps://github.com/google/google-java-format/projects
Wikihttps://github.com/google/google-java-format/wiki
Security and qualityhttps://github.com/google/google-java-format/security
Insightshttps://github.com/google/google-java-format/pulse
https://github.com/google/google-java-format
New issuehttps://github.com/login?return_to=https://github.com/google/google-java-format/issues/374
New issuehttps://github.com/login?return_to=https://github.com/google/google-java-format/issues/374
#427https://github.com/google/google-java-format/pull/427
Crash on annotated array typehttps://github.com/google/google-java-format/issues/374#top
#427https://github.com/google/google-java-format/pull/427
https://github.com/cushon
https://github.com/mernst
mernsthttps://github.com/mernst
on May 18, 2019https://github.com/google/google-java-format/issues/374#issue-445725115
https://github.com/cushon
cushonhttps://github.com/cushon
on Dec 19, 2019https://github.com/google/google-java-format/issues/374#issuecomment-567522733
cushonhttps://github.com/cushon
on Dec 19, 2019https://github.com/google/google-java-format/issues/374#event-2897523035
klueverhttps://github.com/kluever
on Dec 20, 2019https://github.com/google/google-java-format/issues/374#event-2900974036
Fix a crash on c-style arrays in parametershttps://github.com/google/google-java-format/commit/acfe9c5c34e7be0ce46fb79aea4d6f4597ff6767
acfe9c5https://github.com/google/google-java-format/commit/acfe9c5c34e7be0ce46fb79aea4d6f4597ff6767
klueverhttps://github.com/kluever
completedhttps://github.com/google/google-java-format/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#427https://github.com/google/google-java-format/pull/427
on Dec 20, 2019https://github.com/google/google-java-format/issues/374#event-2901177257
klueverhttps://github.com/kluever
on Dec 20, 2019https://github.com/google/google-java-format/issues/374#event-2901177348
Fix a crash on c-style arrays in parametershttps://github.com/google/google-java-format/commit/ed40e472878b9daa215787e6d27164bf2ec6f8ea
ed40e47https://github.com/google/google-java-format/commit/ed40e472878b9daa215787e6d27164bf2ec6f8ea
https://github.com/mernst
mernsthttps://github.com/mernst
on Dec 20, 2019https://github.com/google/google-java-format/issues/374#issuecomment-568114740
@cushonhttps://github.com/cushon
robfighttps://github.com/robfig
on Dec 17, 2020https://github.com/google/google-java-format/issues/374#event-4126199957
Sync upstream changes. (#3)https://github.com/yext-eng/yext-java-format/commit/1b384317e0f4f62a35b8247a14283912994394b0
#3https://github.com/yext-eng/yext-java-format/pull/3
1b38431https://github.com/yext-eng/yext-java-format/commit/1b384317e0f4f62a35b8247a14283912994394b0
Sign up for freehttps://github.com/signup?return_to=https://github.com/google/google-java-format/issues/374
Sign in to commenthttps://github.com/login?return_to=https://github.com/google/google-java-format/issues/374
cushonhttps://github.com/cushon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.