Title: Annotation location when mixed with modifiers · Issue #1152 · google/google-java-format · GitHub
Open Graph Title: Annotation location when mixed with modifiers · Issue #1152 · google/google-java-format
X Title: Annotation location when mixed with modifiers · Issue #1152 · google/google-java-format
Description: When annotations are mixed with modifiers, formatter formats the code in following way: $ cat TestingModifiers.java /** some javadoc. */ public abstract class TestingModifiers { abstract @MyAnnotation2 public void fooMet1(); final strict...
Open Graph Description: When annotations are mixed with modifiers, formatter formats the code in following way: $ cat TestingModifiers.java /** some javadoc. */ public abstract class TestingModifiers { abstract @MyAnnotat...
X Description: When annotations are mixed with modifiers, formatter formats the code in following way: $ cat TestingModifiers.java /** some javadoc. */ public abstract class TestingModifiers { abstract @MyAnnotat...
Opengraph URL: https://github.com/google/google-java-format/issues/1152
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Annotation location when mixed with modifiers","articleBody":"When annotations are mixed with modifiers, formatter formats the code in following way:\r\n\r\n```\r\n$ cat TestingModifiers.java\r\n/** some javadoc. */\r\npublic abstract class TestingModifiers {\r\n abstract @MyAnnotation2 public void fooMet1();\r\n\r\n final strictfp synchronized protected @MyAnnotation2 void fooMethod7() {}\r\n\r\n synchronized final strictfp @MyAnnotation2 public void fooMethod5() {}\r\n\r\n @MyAnnotation2 public static @MyAnnotation4 strictfp void someMethod5() {}\r\n\r\n strictfp protected final @MyAnnotation2 static synchronized void fooMethod1() {}\r\n\r\n native synchronized protected static @MyAnnotation2 void fooMethod3();\r\n}\r\n\r\n$ java -jar google-java-format-1.23.0-all-deps.jar TestingModifiers.java > TestingModifiersUpdated.java \r\n\r\n$ cat TestingModifiersUpdated.java \r\n/** some javadoc. */\r\npublic abstract class TestingModifiers {\r\n abstract @MyAnnotation2 public void fooMet1();\r\n\r\n protected final synchronized strictfp @MyAnnotation2 void fooMethod7() {}\r\n\r\n final synchronized strictfp @MyAnnotation2 public void fooMethod5() {}\r\n\r\n @MyAnnotation2\r\n public static @MyAnnotation4 strictfp void someMethod5() {}\r\n\r\n protected final strictfp @MyAnnotation2 static synchronized void fooMethod1() {}\r\n\r\n protected static synchronized native @MyAnnotation2 void fooMethod3();\r\n}\r\n\r\n$ diff -u TestingModifiers.java TestingModifiersUpdated.java \r\n--- TestingModifiers.java 2024-08-28 11:00:02.129632600 +0530\r\n+++ TestingModifiersUpdated.java 2024-08-28 11:01:40.748988100 +0530\r\n@@ -2,13 +2,14 @@\r\n public abstract class TestingModifiers {\r\n abstract @MyAnnotation2 public void fooMet1();\r\n\r\n- final strictfp synchronized protected @MyAnnotation2 void fooMethod7() {}\r\n+ protected final synchronized strictfp @MyAnnotation2 void fooMethod7() {}\r\n\r\n- synchronized final strictfp @MyAnnotation2 public void fooMethod5() {}\r\n+ final synchronized strictfp @MyAnnotation2 public void fooMethod5() {}\r\n\r\n- @MyAnnotation2 public static @MyAnnotation4 strictfp void someMethod5() {}\r\n+ @MyAnnotation2\r\n+ public static @MyAnnotation4 strictfp void someMethod5() {}\r\n\r\n- strictfp protected final @MyAnnotation2 static synchronized void fooMethod1() {}\r\n+ protected final strictfp @MyAnnotation2 static synchronized void fooMethod1() {}\r\n\r\n- native synchronized protected static @MyAnnotation2 void fooMethod3();\r\n+ protected static synchronized native @MyAnnotation2 void fooMethod3();\r\n}\r\n```\r\n\r\nFrom [4.8.7 Modifiers](https://google.github.io/styleguide/javaguide.html#s4.8.7-modifiers)\r\n\r\n> Class and member modifiers, when present, appear in the order recommended by the Java Language Specification:\r\n>\r\n> `public protected private abstract default static final transient volatile synchronized native strictfp`\r\n\r\nThere's not explicitly mentioned anything about position of annotations when mixed with modifiers or annotations should not be mixed with modifiers or something similar to that in above rule.\r\n\r\nAlso, in [4.8.5 Annotations](https://google.github.io/styleguide/javaguide.html#s4.8.5-annotations), there's not explicitly mentioned that how annotations should be positioned when used with modifiers. But all sub-sections mostly refers to:\r\n```\r\nAnnotations applying to a class appear immediately after the documentation block, and each annotation is listed on a line of its own (that is, one annotation per line).\r\n```\r\n\r\nAttention to:\r\n\r\n```\r\nimmediately after the documentation block\r\n```\r\n\r\nThis kind of implies that annotations should be placed before any modifiers. But formatter does not places annotations before modifiers as shown in above example. So if annotations should not be mixed with modifiers and placed at the beginning or in a separate line then formatter should be updated and format the code according to this.","author":{"url":"https://github.com/Zopsss","@type":"Person","name":"Zopsss"},"datePublished":"2024-08-28T05:37:06Z","url":"https://github.com/google/google-java-format/issues/1152"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e2b784e3-8f4b-9cde-c44c-fc92b0b4417a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D62E:10A7CF:B5CFA:F1A62:6AFBAD9C |
| html-safe-nonce | 705f0449f24c44d89154a36bdf135e1aa1827c7b793833e3b4135b4e03386409 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjJFOjEwQTdDRjpCNUNGQTpGMUE2Mjo2QUZCQUQ5QyIsInZpc2l0b3JfaWQiOiI4MzQ0NzUyNjAxODM2NTMxMTAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0f2fcc22007efb96fff11c19068ca4ae5ca92d24c85fada9251d5f4e27269861 |
| hovercard-subject-tag | issue:2491098884 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/google/google-java-format/1152/issue_layout |
| twitter:image | https://opengraph.githubassets.com/43d7b098785c363dbdd683a630518989fddc82e560b3e466078a33f5b183a5b5/google/google-java-format/issues/1152 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/43d7b098785c363dbdd683a630518989fddc82e560b3e466078a33f5b183a5b5/google/google-java-format/issues/1152 |
| og:image:alt | When annotations are mixed with modifiers, formatter formats the code in following way: $ cat TestingModifiers.java /** some javadoc. */ public abstract class TestingModifiers { abstract @MyAnnotat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Zopsss |
| hostname | github.com |
| expected-hostname | github.com |
| None | e25fbd830d3e6ad0e8935c105cf4fdc70c593dffcd27bb45b790ae4fece5ea55 |
| turbo-cache-control | no-preview |
| go-import | github.com/google/google-java-format git https://github.com/google/google-java-format.git |
| octolytics-dimension-user_id | 1342004 |
| octolytics-dimension-user_login | |
| octolytics-dimension-repository_id | 35448780 |
| octolytics-dimension-repository_nwo | google/google-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 35448780 |
| octolytics-dimension-repository_network_root_nwo | google/google-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 08c8f17f9d27054a108b8b6254e405de0151f660 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width