René's URL Explorer Experiment


Title: Intellij Plugin breaks method inlining and variable extraction from inside if condition · Issue #1101 · google/google-java-format · GitHub

Open Graph Title: Intellij Plugin breaks method inlining and variable extraction from inside if condition · Issue #1101 · google/google-java-format

X Title: Intellij Plugin breaks method inlining and variable extraction from inside if condition · Issue #1101 · google/google-java-format

Description: Consider the following code and try inlining isEmpty2: import java.util.Collection; import java.util.List; public class InliningWithJavaFormat { static boolean isEmpty(Collection c) { return c == null || c.isEmpty(); } static boolean ...

Open Graph Description: Consider the following code and try inlining isEmpty2: import java.util.Collection; import java.util.List; public class InliningWithJavaFormat { static boolean isEmpty(Collection c) { return c =...

X Description: Consider the following code and try inlining isEmpty2: import java.util.Collection; import java.util.List; public class InliningWithJavaFormat { static boolean isEmpty(Collection<?> c) { retu...

Opengraph URL: https://github.com/google/google-java-format/issues/1101

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Intellij Plugin breaks method inlining and variable extraction from inside if condition","articleBody":"Consider the following code and try inlining `isEmpty2`:\r\n```java\r\nimport java.util.Collection;\r\nimport java.util.List;\r\n\r\npublic class InliningWithJavaFormat {\r\n  static boolean isEmpty(Collection\u003c?> c) {\r\n    return c == null || c.isEmpty();\r\n  }\r\n\r\n  static boolean isEmpty2(Collection\u003c?> c) {\r\n    return isEmpty(c);\r\n  }\r\n\r\n  public static void main(String[] args){\r\n    var pojo = new MyPojo();\r\n    if (pojo != null && !isEmpty2(pojo.getCollection())) {\r\n      System.out.println(\"empty\");\r\n    }\r\n  }\r\n\r\n  static class MyPojo {\r\n    Collection\u003cString> getCollection() {\r\n      return List.of();\r\n    }\r\n  }\r\n}\r\n```\r\nNot only does it fail (without reporting it), but it adds an additional `if (true)`:\r\n```java\r\n  public static void main(String[] args){\r\n    var pojo = new MyPojo();\r\n    if (pojo != null && !isEmpty2(pojo.getCollection())) {\r\n      if (true) {\r\n        System.out.println(\"empty\");\r\n      }\r\n    }\r\n  }\r\n```\r\nwith the plugin disabled, it works:\r\n```java\r\n  public static void main(String[] args){\r\n    var pojo = new MyPojo();\r\n    if (pojo != null) {\r\n      Collection\u003c?> c = pojo.getCollection();\r\n      if (!isEmpty(c)) {\r\n        System.out.println(\"empty\");\r\n      }\r\n    }\r\n  }\r\n```\r\n(not the ideal result but at least it does not fail)\r\n\r\nIn addition, when I do that on my actual project I get an error notification from the plugin and the formatting gets broken:\r\n![error notification](https://github.com/google/google-java-format/assets/6871742/0831ae81-6bd5-4fb7-a3d2-d9537eaa589e)\r\n(I did not try to reproduce this with an MRE, I guess it is a side effect of the first issue)","author":{"url":"https://github.com/DidierLoiseau","@type":"Person","name":"DidierLoiseau"},"datePublished":"2024-05-23T09:54:25Z","url":"https://github.com/google/google-java-format/issues/1101"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:cbf815fc-ed53-2266-f9d1-5646d65a50e5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8D92:27AA32:1F459A:2A3CBB:6AFBAD09
html-safe-noncee865d035212ccae85f0e44b38d7bde68d8ddf73ab8c0019e405303b97f584b3b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDkyOjI3QUEzMjoxRjQ1OUE6MkEzQ0JCOjZBRkJBRDA5IiwidmlzaXRvcl9pZCI6IjMxNzAxNzcxOTMzMjE2NzE5NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfb71ccd9ede7aa354a57d6780b13ec3de6b9f936056ea82268d24d6a8462d4ea
hovercard-subject-tagissue:2312473707
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/google/google-java-format/1101/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e7eed0f6f12b4cc615d64c724473d800c12519f771bd8508617266f97db63a21/google/google-java-format/issues/1101
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e7eed0f6f12b4cc615d64c724473d800c12519f771bd8508617266f97db63a21/google/google-java-format/issues/1101
og:image:altConsider the following code and try inlining isEmpty2: import java.util.Collection; import java.util.List; public class InliningWithJavaFormat { static boolean isEmpty(Collection c) { return c =...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDidierLoiseau
hostnamegithub.com
expected-hostnamegithub.com
Nonee25fbd830d3e6ad0e8935c105cf4fdc70c593dffcd27bb45b790ae4fece5ea55
turbo-cache-controlno-preview
go-importgithub.com/google/google-java-format git https://github.com/google/google-java-format.git
octolytics-dimension-user_id1342004
octolytics-dimension-user_logingoogle
octolytics-dimension-repository_id35448780
octolytics-dimension-repository_nwogoogle/google-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id35448780
octolytics-dimension-repository_network_root_nwogoogle/google-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08c8f17f9d27054a108b8b6254e405de0151f660
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/google/google-java-format/issues/1101#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fgoogle-java-format%2Fissues%2F1101
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2Fgoogle-java-format%2Fissues%2F1101
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=google%2Fgoogle-java-format
Reloadhttps://github.com/google/google-java-format/issues/1101
Reloadhttps://github.com/google/google-java-format/issues/1101
Reloadhttps://github.com/google/google-java-format/issues/1101
googlehttps://github.com/google
google-java-formathttps://github.com/google/google-java-format
Codehttps://github.com/google/google-java-format
Issues84 (84)https://github.com/google/google-java-format/issues
Pull requests35 (35)https://github.com/google/google-java-format/pulls
Actionshttps://github.com/google/google-java-format/actions
Projectshttps://github.com/google/google-java-format/projects
Wikihttps://github.com/google/google-java-format/wiki
Security and qualityhttps://github.com/google/google-java-format/security
Insightshttps://github.com/google/google-java-format/pulse
https://github.com/google/google-java-format
New issuehttps://github.com/login?return_to=https://github.com/google/google-java-format/issues/1101
New issuehttps://github.com/login?return_to=https://github.com/google/google-java-format/issues/1101
Intellij Plugin breaks method inlining and variable extraction from inside if conditionhttps://github.com/google/google-java-format/issues/1101#top
IntelliJhttps://github.com/google/google-java-format/issues?q=state%3Aopen%20label%3A%22IntelliJ%22
https://github.com/DidierLoiseau
DidierLoiseauhttps://github.com/DidierLoiseau
on May 23, 2024https://github.com/google/google-java-format/issues/1101#issue-2312473707
https://private-user-images.githubusercontent.com/6871742/333133851-0831ae81-6bd5-4fb7-a3d2-d9537eaa589e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTQ4NzkwMjksIm5iZiI6MTc5NDg3ODcyOSwicGF0aCI6Ii82ODcxNzQyLzMzMzEzMzg1MS0wODMxYWU4MS02YmQ1LTRmYjctYTNkMi1kOTUzN2VhYTU4OWUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MTExNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjExMTdUMDEyNTI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTgzMjNjZTZiYWFhMzI5ODNiZDg0ZTdiMDVjYjA3ZjMzYjI0NjIxZTlhODM2ZjM5NjhjYjQzMzQ1OWY1ZmQ0ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.uF-3zqcc2-p3N5OZc-mHvYoAEEH7rd7nXTZxYScEJjY
cushonhttps://github.com/cushon
IntelliJhttps://github.com/google/google-java-format/issues?q=state%3Aopen%20label%3A%22IntelliJ%22
on May 24, 2024https://github.com/google/google-java-format/issues/1101#event-12929173820
https://github.com/DidierLoiseau
DidierLoiseauhttps://github.com/DidierLoiseau
on May 30, 2024https://github.com/google/google-java-format/issues/1101#issuecomment-2140150983
DidierLoiseauhttps://github.com/DidierLoiseau
on May 30, 2024https://github.com/google/google-java-format/issues/1101#event-12988732568
https://github.com/nrayburn-tech
nrayburn-techhttps://github.com/nrayburn-tech
on Aug 23, 2024https://github.com/google/google-java-format/issues/1101#issuecomment-2306359316
https://github.com/JetBrains/intellij-community/blob/cd9bfbd98a7dca730fbc469156ce1ed30364afba/java/java-analysis-impl/src/com/siyeh/ig/psiutils/CodeBlockSurrounder.java#L884https://github.com/JetBrains/intellij-community/blob/cd9bfbd98a7dca730fbc469156ce1ed30364afba/java/java-analysis-impl/src/com/siyeh/ig/psiutils/CodeBlockSurrounder.java#L884
https://github.com/amaembo
amaembohttps://github.com/amaembo
on Oct 17, 2024https://github.com/google/google-java-format/issues/1101#issuecomment-2418975964
IDEA-340109https://youtrack.jetbrains.com/issue/IDEA-340109
Sign up for freehttps://github.com/signup?return_to=https://github.com/google/google-java-format/issues/1101
Sign in to commenthttps://github.com/login?return_to=https://github.com/google/google-java-format/issues/1101
IntelliJhttps://github.com/google/google-java-format/issues?q=state%3Aopen%20label%3A%22IntelliJ%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.